From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9142EC77B7E for ; Tue, 18 Apr 2023 21:41:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07235900004; Tue, 18 Apr 2023 17:41:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 021368E0001; Tue, 18 Apr 2023 17:41:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDD3A900004; Tue, 18 Apr 2023 17:41:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C8F998E0001 for ; Tue, 18 Apr 2023 17:41:22 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 860B21A0427 for ; Tue, 18 Apr 2023 21:41:22 +0000 (UTC) X-FDA: 80695833204.21.600A0BA Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf14.hostedemail.com (Postfix) with ESMTP id B97A1100009 for ; Tue, 18 Apr 2023 21:41:20 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Pv9SA57W; spf=pass (imf14.hostedemail.com: domain of hughd@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681854080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/l5NmV5LTOy+MuZF5xVusIDHhnwmLcYQzsGvy/o6FI4=; b=vwAkzZ9qRExxF3D/yS/P2+J78urIZUm9w8CKXBes4TMkQKJhzkShOIqlOOc3i+Ey3vScJi 28ZVswqPYYRAd0L+sAqqt6LNN4i7/c1BBE3WOt6/05UXaYOlhMP7frpUtF9a+fazdpFaTR eOtPTKPGyrIIymMfKOhOu6g+eSa6lSk= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Pv9SA57W; spf=pass (imf14.hostedemail.com: domain of hughd@google.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681854080; a=rsa-sha256; cv=none; b=CCzkf8N3iVqKW3UkmHmJf74N/2bnXjDwEsTc9qdgzwdYI5h+UC8nTrJjJWJqx0rCUzOyKS x6I7fn2nu55dwQSVExKrqWR1yLDSGZgkLzALP7HNaTWHJdyWGietF3LtsXMLEoSz0TnfLu eIwW1yBI0GVSx/wBG2MRR5xQbUJgOZ8= Received: by mail-yb1-f178.google.com with SMTP id t16so17601564ybi.13 for ; Tue, 18 Apr 2023 14:41:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1681854080; x=1684446080; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=/l5NmV5LTOy+MuZF5xVusIDHhnwmLcYQzsGvy/o6FI4=; b=Pv9SA57WCaI0h5O+syMJxPCGe7ngSa+KNB/ytcvTS2xA0ArUjcFUFcGZ16ZtypomcT JMoa1uPFNnUQAuyhcGMpaYZMDqfSNfSfPLc7TI4Np1hhUYBZigm96fLmxniMpEMpp76Y hn8IYYMozPjcmJwXO+ddLqdEA/5U7hZ9BJajITz9rrVswELd9Na6053tL9Irhs/OwYAT Ity6LtA0N24HWrG8dBKNKMPboyxGPFV30ynashqnpYqjrv8jTl1VmvAN6C1xA2otuP62 frtHWLg1vo7n7rSRpqrtmkuPufvrZwPa+bOlRMF3uAPrCw0mZOLVIe1ybIEWmTXzMkuG 6J7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681854080; x=1684446080; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/l5NmV5LTOy+MuZF5xVusIDHhnwmLcYQzsGvy/o6FI4=; b=KTTGKIj4RsYS32GjFwRSdm6mFmR9+ggWoCoq4ShwGkPAT+kTKnLbBU4yNqVj6PrOLg yrsK67dECE0dpLrJkFrvzYdblSIWiOrnysJcESQzzFbIy9hXDsdiaqqhn9H6ok0hQzpS taa+gd/HDpTSZkoXdE94uxoJkuB22Jf+WkwJCtypYhBjAzkTMk88TufDoZCL3G7XlTl/ saD//1gB8UD1wM54nuBjWInyMt6UHxF3EYJ5LD5XJBiw1yMkSgp8Th4GXiha+zMkzrck gsvYUgruzu15AmLTPh220NhP/PbSeQE70mLSkafNcF9yIQKBr0J/jwyj5SBfHMcSIyFj pWhA== X-Gm-Message-State: AAQBX9coQSZad3wCxpHUADu2MvPXUojRr8cNGcB2coWa2MCkNYQdnkJk 9KYN8Uz4QIr4hAKFJpcavE5rtQ== X-Google-Smtp-Source: AKy350bBpV4DRJsoJMtUOdmmSo5lT/qQl5OOsDX8dIyNKzyq26sIVASCEbgl7SRgoGKjXd8OYcGPzg== X-Received: by 2002:a25:2fd0:0:b0:b8f:4182:2cc9 with SMTP id v199-20020a252fd0000000b00b8f41822cc9mr17849382ybv.6.1681854079745; Tue, 18 Apr 2023 14:41:19 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id k134-20020a25248c000000b00b958a4c8847sm573011ybk.11.2023.04.18.14.41.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 14:41:19 -0700 (PDT) Date: Tue, 18 Apr 2023 14:41:07 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Luis Chamberlain cc: Hugh Dickins , akpm@linux-foundation.org, willy@infradead.org, brauner@kernel.org, linux-mm@kvack.org, p.raghav@samsung.com, da.gomez@samsung.com, a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, David Hildenbrand Subject: Re: [PATCH v2 5/6] shmem: update documentation In-Reply-To: Message-ID: <6064b468-33fb-3693-54e-6f1f8d316f64@google.com> References: <20230309230545.2930737-1-mcgrof@kernel.org> <20230309230545.2930737-6-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: B97A1100009 X-Stat-Signature: asi4ea1gsie94n975q4h94731q4tkx8z X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1681854080-162789 X-HE-Meta: U2FsdGVkX1/Prs3QlVaqxAXEohlvayjBZErfZFQt45iO0TK4juncdkHa8PomXM2wNjQsJEfaAd7TnrZTFFBF4+QGYsBsnJWhw1XRvzL+UXIkSHr3E80odi0IThKIlv0b1CV7kxWXi2NEuKM4d7Vr19BkqhHMC45eaI38O8U3IDPV+zJ0qT6kXt730ivwkYSYMol7lN17hycsMNIb4NfhzK/wtmUv6CvAD+wBsciyiyNdVjZQHnThQmIXwLe5VBzBKd1sXciB2v7aPHM1Mj0NJ2f4Uj4Bnvxf+R7ttue1IWmSrybumghOq8ypeVxNQHKT225nnTL6+3ZTpYe2vE2V3vgpJvmsoNYvZQtEzqh65znk31L5Q0hfP39Zk2MlxXbWvGwv0Kgwja6crC2QIjiJ1iqayMAFxVKOhoRXylpaqhsp5Zos8O2LyizLqa5RVdpTwAD/2W9LRoO4NhlZlZseXYzdxawzs281zSDfrT9NMRwix/zhIqLD1m/cfFqxc45cIsTX3JB8VshNjo8tAy1I8hjc9SkYPwmLOn+uIx1ZXLQoqOB9R332jCN1cpnj4zq/Y4Th+MFM/VMm3ORGJZt7ltgj8tlnqDnG/3lcTAdimJOQfrZ5EO2+nGzESVSQTbeUpOOFpJCfG62RbsCNnw5i0mSCenEG7dGIfPy7R9jA62pQa78GVaHJaxA0PUkqIO4ixQ7sR4o6ed/myuPQ8W7KJ8/NOwYo9AA9HVkABXM3cwZIAmZqLlXAYMvO2yICm7xJ0rpikWrngMEM+qC18BMyug/uugIR9s7McDJVcBHQCl1ogE4vdXvwTaPCgsJLJzuGzsbEbrSZZ/GbcHx8qSJvCKL0Df6i5HI7y8WDiOTa1uXHilALx6VtpLm1ejUnoWxC5xWrKYf2VTompo7BWk1+5PjAOrqjstfcR2jmsTvyuFa2U+HQio1ldRsuQAKjeiQfmNjBw4o4/Dsg2acQHGI DO2ipQI1 6rjiUltnb9QPd5SN0akLP50sRyrbBkDqkTuePoF6ioDv/AZVGuKlPlPWto+OGpwmcAFdsfyq+oWCKHbJnasBTa0BmdH7//DcqIb7clCnxKkl1cEKuim2VsRbyTTz2YLoyODyy/9xCLfe3ZpFyiJTaJffDfBNpKb/0xp8OvwH1oFZTndqbHDFXBjx9e+o4nP/s0HXRi8TPIAu8+lX8V+snbA51ugUx7IG0v6HZ9bhxeS73qDTnJ6SCYINPeJtsWPZrkKj3JUcnw2BA8HQyqNFUxf1HG+lULKCVFra7jwvk1vGKpNuAT1XiRYxYSt4qyLLG6r495fK8MeInsoUVbevk2dOUoY+RcV7X9YE8MAw3R4468TQPdHMpVH1kEaYewvvu7xXg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 18 Apr 2023, Luis Chamberlain wrote: > On Mon, Apr 17, 2023 at 10:29:59PM -0700, Hugh Dickins wrote: > > On Thu, 9 Mar 2023, Luis Chamberlain wrote: > > > > > Update the docs to reflect a bit better why some folks prefer tmpfs > > > over ramfs and clarify a bit more about the difference between brd > > > ramdisks. > > > > > > While at it, add THP docs for tmpfs, both the mount options and the > > > sysfs file. > > > > Okay: the original canonical reference for THP options on tmpfs has > > been Documentation/admin-guide/mm/transhuge.rst. You're right that > > they would be helpful here too: IIRC (but I might well be confusing > > with our Google tree) we used to have them documented in both places, > > but grew tired of keeping the two in synch. You're volunteering to > > do so! so please check now that they tell the same story. > > Hehe. Sure, we should just make one point to the other. Which one should > be the authoritive source? Documentation/admin-guide/mm/transhuge.rst has been the authoritative source up until this patch, so I suggest it remain so; but good if you point to it from this Doc - unless in reading it you find that actually its account is wrong. (Haha, it refers to fadvise too, never mind that.) But the man page is more important than either, so it would be good to point to that too. Mention the "huge=" option in this document, but point to elsewhere for the detail of its values. > > > But nowadays, "man 5 tmpfs" is much more important (and that might > > give you a hint for what needs to be done after this series goes into > > 6.4-rc - and I wonder if there are tmpfs manpage updates needed from > > Christian for idmapped too? or already taken care of?). > > Sure, what's the man page git tree to use? I can do that once these > documents are settled as well. I'll send fixes. Thanks. I'll look up a mail to lkml from Alejandro and forward that to you, it has the details. Hugh