From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0EDEC71159 for ; Mon, 16 Jun 2025 22:54:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4201F6B009A; Mon, 16 Jun 2025 18:54:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A61A6B009C; Mon, 16 Jun 2025 18:54:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 246EC6B0099; Mon, 16 Jun 2025 18:54:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0C9E46B009A for ; Mon, 16 Jun 2025 18:54:14 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B27281A112B for ; Mon, 16 Jun 2025 22:54:13 +0000 (UTC) X-FDA: 83562768786.10.B9841EE Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf19.hostedemail.com (Postfix) with ESMTP id 8C2521A000A; Mon, 16 Jun 2025 22:54:11 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p9LuBOmF; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of dlemoal@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=dlemoal@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750114451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/MQsD6la/BSX1QuayTipEXhf37o+C5JvtM3N1DgVBC8=; b=WSKA5OqrH8UCPTf3X0fkDZnqIfA9MY9fTPzP1G7mE81kXQzw5olF10XT1R3D57dqXf1z5S 5v/hG359PUaMVvF1/GijJr9EiaLA8SQtcOJxeFNkVMghwd+INWb+wFT00fDT+Q2zTuqYJy /sjyelMayPIx62OK8wDz9G59/DELtDs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750114451; a=rsa-sha256; cv=none; b=j5TjrmY8T/2hPfrmBgPvR021cOXix6yuXtJKLiy8spn8mki2ZmeGkZDuXCbu5ol7pWGe16 dFLT3kzIeFO5xdpdXXmmiF54R+++7mDe4PfSWi3xRYphUg79X17iu5QDoSPGXqK/N/WNfx Cbzv6qo2XwrAoiFp/iRKT+x/13un3lw= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p9LuBOmF; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of dlemoal@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=dlemoal@kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 88E3A629DC; Mon, 16 Jun 2025 22:54:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1F658C4CEEA; Mon, 16 Jun 2025 22:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750114450; bh=2rQ4MWMNuiiZXr3ruKby+3pF9PtUetUIutSjWGs52xQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=p9LuBOmFGkwzRdPq0c3k3DFo+Gg7PbA5ztEVsDN9YZvn/BtbR0RubCEEUAupc/0QN UyKsXWg+3Xgr8jYaXCDMYIX9AMo3NmXmNJWlhYEhfQb2Sm0ZC+2euqRHnrYZxtOuoI /XOGCT4NNqf3QLkRtC5atg5JemfK28tCQYDxQ+vvt7VJIHaxKtebm4/Pva1Y9ypu3C 0i5AHJz8+318CUMsMSF8zAEbryPRnLo/KnKQMO3Ip+RltAyo1TepCJSxqJg7VUGaup 0RxiaVHPlYYqHNPaSdRNrmN5q1z0dDh0yP0RcMExF7vaS/owYzg4U/4qGi5HRJ5JK3 4Jr+e8uabprHQ== Message-ID: <60615f31-7a58-4336-adaa-129408c90000@kernel.org> Date: Tue, 17 Jun 2025 07:51:56 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/10] fs: replace mmap hook with .mmap_prepare for simple mappings To: Lorenzo Stoakes , Andrew Morton Cc: "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Ryusuke Konishi , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Naohiro Aota , Johannes Thumshirn , Dan Williams , Matthew Wilcox , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev References: From: Damien Le Moal Content-Language: en-US Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 1x4bsdawmm9i9yrnhmb7qarba1z68rht X-Rspamd-Queue-Id: 8C2521A000A X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1750114451-681229 X-HE-Meta: U2FsdGVkX19WqpzP7ULNxwYPqryMUxeb++bM9QkT+J5PXm9uovGUrBsrC7Oaz+dqMRLRap0G5powTrTGDM9vD0jCH3Eu1of81zYx5JPDcR8MxGxTMLzMHEbg0y/tLA71K+8rYby1Y/Zd7YdqbzUksLDhKkldwBw+QcPTEPWjpCEmoB6uuVYUNfFq0Vub3QjwJpnVTqNaCCrkqRsIg9Ca9ie6boWn4gqYO7XURwC5bxPDJunPynHcF+71IVFzs+ViI6Ae5GJlcliZ6SuVKhybuGaxJVMp8J9T/WOQUlTgJ+bthlOM9XwB5AWIh54Os89xdFd9YtQL996jGHmOMJyHvC0gvYvnX3/hgg+gBPxpcK8Vvce+1NnWpgPTZaRr9u48MsmtuZGFlbPKzwnGcWaHqaZqxq4b9Reg72vUa98ISA81tuW0JP0DidFPOIGIQ2pyaMBNjjrBFLiYHBHoleP0w+X96syw4fMd6sIfa3SvOk/L6pdFshNTugFGV0Wi2Co2MJr1zrX4+MlXI55Uu1sFKoZoR9a38RCzDxjh99/Qglz+brZUpR3lnd2z8BB75E+9AjZvxFNCyezmbvfHSeYL/yoNKO/vOsLMOQAOKnqLGpSFyNWr1xDcSTsoHjNoiIqGpvEeOoMtY2n1F+wiTrweNKbd0J8sjCsk5c01smy6l4sY0bU3xykfhnDw7E8ALQHsf/Pa+uK9fZSJ2BKDpXBUDjuW4sfHz2g80wgSFCvXLARPqDcyPnI0/CFzigPbPQvOF6K/ZyNmrKonsdswR4TQcoYvHJOzdYsG/+3Av+cYQJtPfpOWF0qDzU83mv7/ts6YVPsxZB2/Y9828H7ZK6fc54OTmtsg/ONFPMQUFYGoBCtmG9/TmK84LCHqXytmEFAuBppmEDMrhm/tOqh4dXz+jcxzex6mEvJo6Qv4Gz/ESyh102uuNQwfjtrHtWPGt3sjtFrzQwcftzG1P/i0+pE 95zPscXA bgZ2w7FBp9y8jzgjtqgTJSR/+iEdcBJb6/Ae6FQfS9ascG1pMu24TbINb70wdAPlPKPFaEjIQjcls23YD5AzlwyMJj20TWQUFF3gVq47yHuDVWXyZ0lhHX+ZIv4v1D0UXefXocqAxdOVD3ue4dNzkMcO1vXeb+CuA5TghT/zEwFUv0Un0Ew1rmIvX1zSoiDiqn1zTF3LU6qoi4+Biir2qE+CRoUvwETo4UHcS8q87N3q+ITeqswpW1nliVECNUMf/oGcuxbjhLZ2J1jT4myhvXk8PKIDE+HJ5+6sSSnaH46tciLajRpbjMC5XCFssyXXGWAeqHbWTfMRh22UNHXnyD4jGxJE3Zgv4WBlR2UOVSkBL4BZe4OLAEekW9yp8mcchc981cGo9PdnRW6k++p18GYZ+JYqLyJ3IFLUx0Mm9yoEbKCWMTFM0Bu/ZvEx4WVZUP2mXQ0cN+lqQBK8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/17/25 4:33 AM, Lorenzo Stoakes wrote: > Since commit c84bf6dd2b83 ("mm: introduce new .mmap_prepare() file > callback"), the f_op->mmap() hook has been deprecated in favour of > f_op->mmap_prepare(). > > This callback is invoked in the mmap() logic far earlier, so error handling > can be performed more safely without complicated and bug-prone state > unwinding required should an error arise. > > This hook also avoids passing a pointer to a not-yet-correctly-established > VMA avoiding any issues with referencing this data structure. > > It rather provides a pointer to the new struct vm_area_desc descriptor type > which contains all required state and allows easy setting of required > parameters without any consideration needing to be paid to locking or > reference counts. > > Note that nested filesystems like overlayfs are compatible with an > .mmap_prepare() callback since commit bb666b7c2707 ("mm: add mmap_prepare() > compatibility layer for nested file systems"). > > In this patch we apply this change to file systems with relatively simple > mmap() hook logic - exfat, ceph, f2fs, bcachefs, zonefs, btrfs, ocfs2, > orangefs, nilfs2, romfs, ramfs and aio. > > Signed-off-by: Lorenzo Stoakes For zonefs, Acked-by: Damien Le Moal -- Damien Le Moal Western Digital Research