From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33084E7717F for ; Tue, 17 Dec 2024 10:05:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6BA16B00BE; Tue, 17 Dec 2024 05:05:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF38D6B00C4; Tue, 17 Dec 2024 05:05:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94AA96B00C5; Tue, 17 Dec 2024 05:05:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6FB5B6B00BE for ; Tue, 17 Dec 2024 05:05:51 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 11659C05ED for ; Tue, 17 Dec 2024 10:05:51 +0000 (UTC) X-FDA: 82904019324.02.E056540 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf27.hostedemail.com (Postfix) with ESMTP id 0427B4000B for ; Tue, 17 Dec 2024 10:05:14 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vhqtP1oE; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=AcM1u5LR; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vhqtP1oE; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=AcM1u5LR; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf27.hostedemail.com: domain of hare@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=hare@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734429935; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8/6NS1ssR6spHYiu3y0Y1SnfsByi/sQPG7A7syHmwAI=; b=iEdekTAOVcc80mhGXjxk92Vousah04J9oFwMss8h5MOUyAxFlbJxvpRbshufS+cbU3wonO o4y1G55rHLZuHs1/OGvT+lszNHiwyI8KSjxl3alAw8hRdGia7L1ueIO3hnOPKLBquKd814 cgbMGyInUoN1CGl5t5rmImRJ+ezHnD8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734429935; a=rsa-sha256; cv=none; b=YZEUqhNP9bw8wwqCFI/F7zNCzQHtbyzgC+QPNlXajxFWf4LSzseyzuswRixxM2YUfJpkFy LyIWmsKONjrtlIajpzUeQ+SXa79N5OiNGMSNmxOjzpr46Kn3P3bpOfFHUxdJLCwSEMWUJ9 TFAeHEUKpDIrB+kynQcs2RAg+ggVby0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vhqtP1oE; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=AcM1u5LR; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=vhqtP1oE; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=AcM1u5LR; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf27.hostedemail.com: domain of hare@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=hare@suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 19EDC1F392; Tue, 17 Dec 2024 10:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1734429947; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8/6NS1ssR6spHYiu3y0Y1SnfsByi/sQPG7A7syHmwAI=; b=vhqtP1oENdHaVHJtPBNZOLB8F8gGPgoX6XF9TP4fGrJSkvYFHxT4m3jSQnPqPHuFa6aswP TgwEc4Ud4n+LPpF0h/vKRRESZW/Nuf89W/6fLQsIVBeEweAH6gtukXwlmJMMLvYagK4j3a /ZhmSaz9uERbLrH2ULnxlK1YnoJec+Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1734429947; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8/6NS1ssR6spHYiu3y0Y1SnfsByi/sQPG7A7syHmwAI=; b=AcM1u5LRYaa5tmevPECZZnduWTT4DHNLGNBXbF1r5Jp/ppnxucuDYYY/z8SRUdedowohd5 lUwJsq790dU+RADg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1734429947; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8/6NS1ssR6spHYiu3y0Y1SnfsByi/sQPG7A7syHmwAI=; b=vhqtP1oENdHaVHJtPBNZOLB8F8gGPgoX6XF9TP4fGrJSkvYFHxT4m3jSQnPqPHuFa6aswP TgwEc4Ud4n+LPpF0h/vKRRESZW/Nuf89W/6fLQsIVBeEweAH6gtukXwlmJMMLvYagK4j3a /ZhmSaz9uERbLrH2ULnxlK1YnoJec+Y= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1734429947; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8/6NS1ssR6spHYiu3y0Y1SnfsByi/sQPG7A7syHmwAI=; b=AcM1u5LRYaa5tmevPECZZnduWTT4DHNLGNBXbF1r5Jp/ppnxucuDYYY/z8SRUdedowohd5 lUwJsq790dU+RADg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6BD6A13A3C; Tue, 17 Dec 2024 10:05:46 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id CdKzGPpMYWe0OwAAD6G6ig (envelope-from ); Tue, 17 Dec 2024 10:05:46 +0000 Message-ID: <6053c010-a623-485d-89b7-de34f05a5c8a@suse.de> Date: Tue, 17 Dec 2024 11:05:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 09/11] block/bdev: lift block size restrictions and use common definition To: Luis Chamberlain , willy@infradead.org, hch@lst.de, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org Cc: john.g.garry@oracle.com, ritesh.list@gmail.com, kbusch@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com References: <20241214031050.1337920-1-mcgrof@kernel.org> <20241214031050.1337920-10-mcgrof@kernel.org> Content-Language: en-US From: Hannes Reinecke In-Reply-To: <20241214031050.1337920-10-mcgrof@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Stat-Signature: 8qnmw85wj67qjy94jsfzbcb1znimbf13 X-Rspamd-Queue-Id: 0427B4000B X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1734429914-167196 X-HE-Meta: U2FsdGVkX1+sDP4j44rJbUVHj0UwKyIBSGQOZaCXkSPsixkav4JgdWeNSOJCRwGUvo42xLaj/7EBNc5eheWITrsbxOSQnD1QhtJ4lt3uXBoOQl5tXZ2SXihH1N/r1ELJcpGkXjdL2sMsssJDWSx6yHDjknnQghPLs5Yuz9+WXciCc3hnUAbjNKZEY0CJb+X/MiDXVuxzBu+SKcrH4EX86KpeUX3f2lChERSqRa1P9e+mwqv/x+39WksXu9dC/mMdzG4r94a3Pwx+XypF+TjcnGDcpk6p/b1l80MfpII/sgqLEAVLx1f3A2guvzo/YP19M63RnI7FyZzB89r3O4Kt8Aac7hmzbV/uN805Nq962kwi12bRZYg7b9wp6Ry/QganaAe7n+OmGdy1oVTUGjckdAotLtMdZ4I2pdho5tQIYUlL1rVrcO0++xAVNepbyPO2Y3up3w4a/kngM8hpoxiPNolXD60pxE4wNyteO9Sye2xFyXw0EA/EfKGKbEf8hdAa5YEuhewdOk4rpD16RqDN0WeuWhK1+JTJeZYdSoPdg/D8Dxn3G1Gp5DAYlugWfV5T3+MMs8QCGkgcxN6WH7mfJrCGVOUVNKgSKa5wEcqaSx01+PAVud6e2sHr6ebiWQBez+t73vg55S9R9Ly3TAfbAlDXV4AAXtc6x9t/Ex7l2DmwZ2bSk/Xa35/hhN6Djx0wayjI6LjIDGH2NQKKnkA3etmbg2b2Ggus0QfP37WrAA09cB1HvXRTIjkW0deEkpXUeOXUGjqm+FBWF8BoBv2TTMiO4Sza+CGaosm3xQJcWEhmD6VtNBtjONXyjpWr5aYUmenTtrABqE3UZqKoQg27G9y/TUgrLe5cjmfBMT//TZpzhCR15dU3n+MuN0X9wx0h1U3SJVwHGDJZGaYvJl8ty5Ye7dTFUpO/eYHtocJKjRh3xK9qIVnwxvFDas8OLqvoMsqdOFKBA2tCV7rCQOm k11qYo8p im7FLIQ7cHx6iHb9zdOCFS2qkOkMW9QTstK9zjcKRJzzlk6JgACf5ROMBhipNF4G7cEyiWI0RuYkkYBn4Ky6AEsU3jRhviddz9mwm8UaMP+ilXqh+qjlJdVT3bvCGe4E6pCwfZGA9lg9TvDz/O99ajiq2X7lQfwviwIGAUlJf/sGQY1/ZRmHr5GoFsmkVsEwyjZluyUl1k1FRK4AvrfFDL7Hz79rw8A+rls4xsfLCU0Yq4YQuym3zAlxiWkZGqoKgvEdOj2CHDD7dJPEfxzMKAQt0mayje7L0HohDKOvNXf6mkQ6a3fyZPkr8bHxTrtyznsUkjoWvvknVYTZ8VYOkbkVQH8MKTG7VL9u8PGfL0p3bX9cLcqevFtodUfb3l0RPVMqZD5KrST/qMMiw3t97ODYoi0GAxPLgWaYeMDnlGdRo01nrZq85UMLvFA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/14/24 04:10, Luis Chamberlain wrote: > We now can support blocksizes larger than PAGE_SIZE, so lift > the restriction up to the max supported page cache order and > just bake this into a common helper used by the block layer. > > We bound ourselves to 64k as a sensible limit. The hard limit, > however is 1 << (PAGE_SHIFT + MAX_PAGECACHE_ORDER). > > Signed-off-by: Luis Chamberlain > --- > block/bdev.c | 5 ++--- > include/linux/blkdev.h | 11 ++++++++++- > 2 files changed, 12 insertions(+), 4 deletions(-) > > diff --git a/block/bdev.c b/block/bdev.c > index 167d82b46781..b57dc4bff81b 100644 > --- a/block/bdev.c > +++ b/block/bdev.c > @@ -157,8 +157,7 @@ int set_blocksize(struct file *file, int size) > struct inode *inode = file->f_mapping->host; > struct block_device *bdev = I_BDEV(inode); > > - /* Size must be a power of two, and between 512 and PAGE_SIZE */ > - if (size > PAGE_SIZE || size < 512 || !is_power_of_2(size)) > + if (blk_validate_block_size(size)) > return -EINVAL; > > /* Size cannot be smaller than the size supported by the device */ > @@ -185,7 +184,7 @@ int sb_set_blocksize(struct super_block *sb, int size) > if (set_blocksize(sb->s_bdev_file, size)) > return 0; > /* If we get here, we know size is power of two > - * and it's value is between 512 and PAGE_SIZE */ > + * and its value is larger than 512 */ > sb->s_blocksize = size; > sb->s_blocksize_bits = blksize_bits(size); > return sb->s_blocksize; > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 08a727b40816..a7303a55ed2a 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -269,10 +269,19 @@ static inline dev_t disk_devt(struct gendisk *disk) > return MKDEV(disk->major, disk->first_minor); > } > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > +/* > + * The hard limit is (1 << (PAGE_SHIFT + MAX_PAGECACHE_ORDER). As this is the hard limit, one wonders why we don't use it ... So please add a comment why we restrict it to 64k. > + */ > +#define BLK_MAX_BLOCK_SIZE (SZ_64K) > +#else > +#define BLK_MAX_BLOCK_SIZE (PAGE_SIZE) > +#endif > + > /* blk_validate_limits() validates bsize, so drivers don't usually need to */ > static inline int blk_validate_block_size(unsigned long bsize) > { > - if (bsize < 512 || bsize > PAGE_SIZE || !is_power_of_2(bsize)) > + if (bsize < 512 || bsize > BLK_MAX_BLOCK_SIZE || !is_power_of_2(bsize)) > return -EINVAL; > > return 0; Otherwise: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich