From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E7FFC678D4 for ; Thu, 2 Mar 2023 10:05:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC6B76B0074; Thu, 2 Mar 2023 05:05:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A51966B0075; Thu, 2 Mar 2023 05:05:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CA2B6B0078; Thu, 2 Mar 2023 05:05:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 78D646B0074 for ; Thu, 2 Mar 2023 05:05:00 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4BAD41C6A05 for ; Thu, 2 Mar 2023 10:05:00 +0000 (UTC) X-FDA: 80523524760.30.5B566AA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 9EEE2100009 for ; Thu, 2 Mar 2023 10:04:57 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KWH+w6K3; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677751498; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/uoGk2wxEZGUXHA+zZCIpKdEvxnO7q7FQa1CWjqGNMM=; b=Y3t1tu4Fb6FpLvKNN6yZYEP166BXAK2ODnd/7x1WAolWa9zUZpxLd/ODhQ+fBS69L8yzyr nKGwpkNTq0cAgWzq5go2g6WAZfOvEA6wAhukax6AgfzYXlOakaIGrBEXuuh9y6cCwjx8H4 x49os5uFo5ZqKhRx/80d4ohwy/wAA9w= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KWH+w6K3; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677751498; a=rsa-sha256; cv=none; b=wyrRnvkjC+9kV9PqfGkkF8dadba9Jp4Fx1DiVdaUSoojDN9KMjn21TceLcy4O8/RzGkjpR brEm5uV8VNpmYyeel1+ry9CKb3noan94mHyZXcgjNEbfMh0EtxgOpJOtvwqLJ+DpiNv3C7 Xg9tTI4etweMEs2pLNLLNpzhblGZOlY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677751496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/uoGk2wxEZGUXHA+zZCIpKdEvxnO7q7FQa1CWjqGNMM=; b=KWH+w6K3Wo5//jDDNcHp016tAhmXY7JsS2ILvqz0+6AuZ7XZwoW9kfCbB/1gxqYEX7XTY2 4GoSfKupqsw7TPZm5bIvyvH/nk/stcMJpQUNaH4mgkSrUQQ/6tW9PirmjrOFlLCGqUkpip h0aTf+olYa3Wb7MNqazr34TdNzDVRSg= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-475-UxuWlOuePx-tY9tF3uUkOg-1; Thu, 02 Mar 2023 05:04:50 -0500 X-MC-Unique: UxuWlOuePx-tY9tF3uUkOg-1 Received: by mail-wr1-f71.google.com with SMTP id t19-20020a0560001a5300b002ce013276b8so84284wry.1 for ; Thu, 02 Mar 2023 02:04:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/uoGk2wxEZGUXHA+zZCIpKdEvxnO7q7FQa1CWjqGNMM=; b=eCegtrrPE8Ti4hapmIpb6lloYI1+rLQ1t/iedI/EyTxuICQH79IXWSX4XZSHFrZc/S dxYvryVn9edzsNiNaRjSZXhGBs4oTz2MyPBOCTdS6rYJcSnOUkL4oE5ep21vBJeuah06 cGK5V/ROSzTh/C84Qw/QSCjciNzGws6Y9xQamxC/1NXggixQwDunnEqcUeyY4IAwQqER xTSwOhAOdKs9aiu+unafInjJJJI6IIAm7qXdiJhgRuS2OHtY3CcXbJlcV6NFi6wV1kRt fp0Vcegp/7Qzp8h6bgMGgbGmhlTqox8A4pnO4ZoyePAgy46KoNXWFvEYAX8oGWNI5vpi 75ew== X-Gm-Message-State: AO0yUKUNHxAcV4NhM0jrpPdyrmsiVUlM70fyNQOvof5oubCn1yYtPiuF R6um8uWPR3Hn+D0o8Z8FD8qm5mcSpdh0w++vT+kGZcKJyFzpEjtNIltbdmUTHeE7Kba8VzeE4ux wKjf+vf2RhEs= X-Received: by 2002:a05:600c:3544:b0:3eb:3fea:a2ac with SMTP id i4-20020a05600c354400b003eb3feaa2acmr7478557wmq.22.1677751489205; Thu, 02 Mar 2023 02:04:49 -0800 (PST) X-Google-Smtp-Source: AK7set87BA5fbiB0uEGz1fxSOsLC8LTZ1LQyHD28rrDLcIsrrW//CvOXpe8Otlkj+UDBo6NnOPRdaA== X-Received: by 2002:a05:600c:3544:b0:3eb:3fea:a2ac with SMTP id i4-20020a05600c354400b003eb3feaa2acmr7478536wmq.22.1677751488867; Thu, 02 Mar 2023 02:04:48 -0800 (PST) Received: from ?IPV6:2003:cb:c70e:4f00:87ba:e9e9:3821:677b? (p200300cbc70e4f0087bae9e93821677b.dip0.t-ipconnect.de. [2003:cb:c70e:4f00:87ba:e9e9:3821:677b]) by smtp.gmail.com with ESMTPSA id v12-20020adfedcc000000b002c5a1bd527dsm14827604wro.96.2023.03.02.02.04.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Mar 2023 02:04:48 -0800 (PST) Message-ID: <604c372c-e474-14a7-dd80-c5197f12564d@redhat.com> Date: Thu, 2 Mar 2023 11:04:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2 0/5] batched remove rmap in try_to_unmap_one() To: "Yin, Fengwei" , "akpm@linux-foundation.org" Cc: "linux-mm@kvack.org" , "willy@infradead.org" , "mike.kravetz@oracle.com" , "sidhartha.kumar@oracle.com" , "naoya.horiguchi@nec.com" , "chu, jane" References: <20230228122308.2972219-1-fengwei.yin@intel.com> <20230228122823.eba4f0fa5f7f436a2f8b3a3b@linux-foundation.org> <19263da54b9818332620345bbed69e8ded241e00.camel@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <19263da54b9818332620345bbed69e8ded241e00.camel@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 9EEE2100009 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: j36sp31gmsyggsfj1apsr4f5zqoumreb X-HE-Tag: 1677751497-208405 X-HE-Meta: U2FsdGVkX1/IXvpZVh9JG/9p5H5e9tRgA8WHSYc7KhFYRg/RKTNvuS0bVec7NBFN+ohUWgdTdB2J7nLf+nCKw352bQ7FmjYWtR0fYta13r93Sfz5UdXzCKs+myNv5miq9md1uq8pyY9Mjx1Rubf++fVGCb+sxbA8YvcjFYu9UZGy3kizhG+YCbV+fyFHFpiBTx4iT3FMe1mGbM6CeEqKeQ9gjnuux37mqGjkO2WpmUPaB2FujAoUwI9uwqt3nlrKJbSopYRkCo9ijGRVWwCyp0wTFi4aey28o6yomIB/KXWIHxuVlbY/mX0qElpisK3pddUG/f1drkV/BjVxzG0lcPyEqj8I5fyx+Sz90K162EzvxvslQK63Rdwv57Mid0C00TxK269GwOoFY7Z1z7k9+5AxCtdQIJTr5WG7Z0uQe43dHHqYmrbgM//Bf3/gn+KOszzjdNXabURXbj43B6xLjkfmb+mlYinKQBMYrei2hv2+MbGA0EJbJjN288Ebst3qQjlA6iP3qVgyLfpQBNqiif4+6rS6uHEvnV5m1IVjZUo9eU6v2cgswihKeJqmqauP5D73Ne5IOkUt4EapHXsm03BLL7Gie7aQqTE9fwEPu4fEO7Oczv+ZNAtdJU9srr4v44yuWASesmd1/CTDIdqF59p6TQIB8f0r+Hu+EqlOn8gRTgRsQq2J9sy6o0/i1PVX/jga4XFcrg2907TtSfGcSs2UWQBhDiy768WC5tklBf8H+gaG8gUm7Hlkuo3L291FCNHyzvsd9GB1xV6khe9nFXi16dCb0zVHKPOkah/p4P+JHubb+FoOTWvGRHuFphI2UrDpT5evQc1IzS3JBAHicbAyYyGkxC9F/r4hLaE5622Sjx2NX98+0NcTjEYDywcTF2/14NNHQS76U+uhb8xBGjg+RXaih13FU0ZRhEuwG/VDQ+MJcxWKKtjgakTx6o52zDSZCzArPhI+EAr15oi 406xSTax wcdSyoVW7/txnJBbsn94QqasE/I+kSQ/BQXt1irbM1tjU1lNjOl8wYjBBTpD8UVlp8JwV4arBLpEWN4U/53beXBgxgXwy96sV7emxKwKRUmbBtV6T31U4/xqTgjLq4VXVpK/rDXtaBNviSbz1SEfCng3hCuSSGlHxvfnGJ7RKWF4M9nEZLSV95nwusXirT71i5982/1DAdn7UuJFRIVc97575fKjLbAG+S79eLo5jjxFex3okHJXE9knCEy/jYAcjTcPCFqDFMW1CYOWDYLO0cCNajleEAcqal2ofJij2ZDHn1l0hw2LFI6MA9WMYMJtoKVfCWS8sBqf9ck2yIR40Z9chbe2xkVWFOcB1u85ZMtcWoaSz9xQKcIYwkpOfCD3Xa3HbjK9WPBmurciVCKHN8W3zCO0REJwzLeIP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.03.23 02:44, Yin, Fengwei wrote: > On Tue, 2023-02-28 at 12:28 -0800, Andrew Morton wrote: >> On Tue, 28 Feb 2023 20:23:03 +0800 Yin Fengwei >> wrote: >> >>> Testing done with the V2 patchset in a qemu guest >>> with 4G mem + 512M zram: >>>   - kernel mm selftest to trigger vmscan() and final hit >>>     try_to_unmap_one(). >>>   - Inject hwpoison to hugetlb page to trigger try_to_unmap_one() >>>     call against hugetlb. >>>   - 8 hours stress testing: Firefox + kernel mm selftest + kernel >>>     build. >> >> Was any performance testing done with these changes? > I tried to collect the performance data. But found out that it's > not easy to trigger try_to_unmap_one() path (the only one I noticed > is to trigger page cache reclaim). And I am not aware of a workload > can show it. Do you have some workloads suggsted to run? Thanks. If it happens barely, why care about performance and have a "398 insertions(+), 260 deletions(-)" ? -- Thanks, David / dhildenb