From: David Hildenbrand <david@redhat.com>
To: "Yin, Fengwei" <fengwei.yin@intel.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"willy@infradead.org" <willy@infradead.org>,
"mike.kravetz@oracle.com" <mike.kravetz@oracle.com>,
"sidhartha.kumar@oracle.com" <sidhartha.kumar@oracle.com>,
"naoya.horiguchi@nec.com" <naoya.horiguchi@nec.com>,
"chu, jane" <jane.chu@oracle.com>
Subject: Re: [PATCH v2 0/5] batched remove rmap in try_to_unmap_one()
Date: Thu, 2 Mar 2023 11:04:47 +0100 [thread overview]
Message-ID: <604c372c-e474-14a7-dd80-c5197f12564d@redhat.com> (raw)
In-Reply-To: <19263da54b9818332620345bbed69e8ded241e00.camel@intel.com>
On 01.03.23 02:44, Yin, Fengwei wrote:
> On Tue, 2023-02-28 at 12:28 -0800, Andrew Morton wrote:
>> On Tue, 28 Feb 2023 20:23:03 +0800 Yin Fengwei
>> <fengwei.yin@intel.com> wrote:
>>
>>> Testing done with the V2 patchset in a qemu guest
>>> with 4G mem + 512M zram:
>>> - kernel mm selftest to trigger vmscan() and final hit
>>> try_to_unmap_one().
>>> - Inject hwpoison to hugetlb page to trigger try_to_unmap_one()
>>> call against hugetlb.
>>> - 8 hours stress testing: Firefox + kernel mm selftest + kernel
>>> build.
>>
>> Was any performance testing done with these changes?
> I tried to collect the performance data. But found out that it's
> not easy to trigger try_to_unmap_one() path (the only one I noticed
> is to trigger page cache reclaim). And I am not aware of a workload
> can show it. Do you have some workloads suggsted to run? Thanks.
If it happens barely, why care about performance and have a "398
insertions(+), 260 deletions(-)" ?
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2023-03-02 10:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 12:23 Yin Fengwei
2023-02-28 12:23 ` [PATCH v2 1/5] rmap: move hugetlb try_to_unmap to dedicated function Yin Fengwei
2023-02-28 12:23 ` [PATCH v2 2/5] rmap: move page unmap operation " Yin Fengwei
2023-02-28 12:23 ` [PATCH v2 3/5] rmap: cleanup exit path of try_to_unmap_one_page() Yin Fengwei
2023-02-28 12:23 ` [PATCH v2 4/5] rmap:addd folio_remove_rmap_range() Yin Fengwei
2023-02-28 12:23 ` [PATCH v2 5/5] try_to_unmap_one: batched remove rmap, update folio refcount Yin Fengwei
2023-02-28 20:28 ` [PATCH v2 0/5] batched remove rmap in try_to_unmap_one() Andrew Morton
2023-03-01 1:44 ` Yin, Fengwei
2023-03-02 10:04 ` David Hildenbrand [this message]
2023-03-02 13:32 ` Yin, Fengwei
2023-03-02 14:23 ` David Hildenbrand
2023-03-02 14:33 ` Matthew Wilcox
2023-03-02 14:55 ` David Hildenbrand
2023-03-03 2:44 ` Yin, Fengwei
2023-03-03 2:26 ` Yin, Fengwei
2023-03-06 9:11 ` Yin Fengwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=604c372c-e474-14a7-dd80-c5197f12564d@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=fengwei.yin@intel.com \
--cc=jane.chu@oracle.com \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=naoya.horiguchi@nec.com \
--cc=sidhartha.kumar@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox