From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46851E77180 for ; Mon, 9 Dec 2024 12:56:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 80EDA8D0055; Mon, 9 Dec 2024 07:56:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7BEB78D004C; Mon, 9 Dec 2024 07:56:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65ED48D0055; Mon, 9 Dec 2024 07:56:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 41F3A8D004C for ; Mon, 9 Dec 2024 07:56:55 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EE946ACD7B for ; Mon, 9 Dec 2024 12:56:54 +0000 (UTC) X-FDA: 82875419970.11.1008560 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf01.hostedemail.com (Postfix) with ESMTP id 4221040014 for ; Mon, 9 Dec 2024 12:56:36 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XDYmxEqZ; spf=pass (imf01.hostedemail.com: domain of klarasmodin@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=klarasmodin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733748991; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PWVCxbrTVnf61GHy50t1nIO1WdXwoF1UvHG9EnxG6sQ=; b=C2WNwAxSeFsP02E1Lbvj+7NtL65T4OV5DW5AoSxZWeISJkyN2oLxFgoZyOz9Galyf28N/B MFfh0LRHiiyiz2gED61ULZAwH82F+UNtym1bnDwOgXqyoh4/JFgtsdet97DZPsXk1gLFdZ t7sLNJLYhHLPC6bLhYmuq3aaeC1VKlQ= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XDYmxEqZ; spf=pass (imf01.hostedemail.com: domain of klarasmodin@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=klarasmodin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733748991; a=rsa-sha256; cv=none; b=ujqcKx6sotEVG9N34jV9iCAVhz99pwaj3eMrdIHpRhUK0OZA1RuyK6WfzEPrytchXcQ9Mw HYGvyV+0n48hf/lYLu5XH5plGirg0kMXOz6VxyjhxjJfXIbMu5JJ5FKvaLODQAKzy9pfXe 1sbgEAoeIc8+Kuev35QeRAyJc/l2WhI= Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-53e3778bffdso2906379e87.0 for ; Mon, 09 Dec 2024 04:56:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733749011; x=1734353811; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=PWVCxbrTVnf61GHy50t1nIO1WdXwoF1UvHG9EnxG6sQ=; b=XDYmxEqZYi+obvlzzTmbrp2K3QDbQb1pNLXKQEl89xd/QFqgStxmlvXvwBHKPxHxWG 0kiC1NyR7zao0Tso94vlywW7KdbgfAKoVdfXHUIQxCPXRJdgwL+m389bmk1S3gLl1bfr 7lKiWbr3NmOie1RRZa/Fi2u7CegNyWxq+QfEMPabUmzd1+8Beb7/WXBoM1syTgofEMaJ Sz3LVmvUuwkWZOgaS0HyPzE8cKe/bX3JiJIQ0IeVXvIqqK7SlWYm84uxnvE58OAVQ5uo VYfKAfG/YOqlTO+8c8a+MIDYSKi4D90oL7MdiwHXo1Mm4rFlUdk/l/nUgXCEpKi+zpOo Qv5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733749011; x=1734353811; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PWVCxbrTVnf61GHy50t1nIO1WdXwoF1UvHG9EnxG6sQ=; b=VgiICOCqktSVBKJZ46ANi0SJYeQIUeM27x8E1aXHdQTzevY/weDc10Eh0I9kWZh8a0 LKzd8uPcdWRGPZf00wF+8tSq9kHkZkckr2dkE6IkJkiIxhx2rh0Ik8dHggOysm2rWLpE 7UYNx0DyB5+VXOmxj4OSyHwUXvyVBnJfXRjasA+GZ+VpazN8FUUf94OLLqkmAsD/Zk8K vtkJr56vEfge5tNGpt9zor0TNlGFPPUIReqehRtXK8Zd13Uc1vpxJUFlI9mbr86/QSbo jBNyqFldAk2U0FGeQOIyX7QGEoq7HOxLp5fih4Ccp7M6TN7AGYpgIrX4rMjHGOqKdvzr rFww== X-Forwarded-Encrypted: i=1; AJvYcCVfEAgqa6LM6/B9wv1tAiF6JoOrKvk5AjryfiWxhyps1Pv1jggbMiy3tzl3CBUf/79zH+JQc92ktw==@kvack.org X-Gm-Message-State: AOJu0YzoxRERCv7Jz2q4+ABu5EBXHZg59PvHK0ez+Ta8AGe5DXLMjwE2 D3P2852ZPEOg1dzfdZcfo15/Pj3kfUTtJyBHV1/Et3CTKOZlrwLe X-Gm-Gg: ASbGnctW+0gOOLvp8dsUYRFZ0Ju4hBLRjlOBnTnjEC8vjxUgrwYOJvoAF2Kx1fGodZW Sc5f/NhTHVxMoLhrpnuTJlUqg87coS0bd65SNOfR6SM3O7A2fxIb/zf8Xj+wRv3XuqQwvWom7d0 YUGfocZj/sXFBWC2I9tp3YKpubBw9CMB2/SSB1rnHXyCvCe4q5FC4mjH36kKzz5s0cQ8q3HQ42d pBqiqcGO7i5S1J+YXwjgG0XKWHjisi6JG0d2vsnl8vduIjZdaUvumhlAOUF9bWAtYmbNcsR1duL J9oQ+02x2/V3lT/0 X-Google-Smtp-Source: AGHT+IGJP+qDi++rMu9YDBxju5NqTXgzk9eSdqcEvXa9AgotuNX4C1hJ3WINefmjNBbADlez0VnW4A== X-Received: by 2002:a05:6512:3b0d:b0:53e:335b:4348 with SMTP id 2adb3069b0e04-54024113004mr128559e87.40.1733749010712; Mon, 09 Dec 2024 04:56:50 -0800 (PST) Received: from ?IPV6:2001:6b0:1:1041:f9b4:5409:8dcc:9750? ([2001:6b0:1:1041:f9b4:5409:8dcc:9750]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53e6b4c051esm732384e87.70.2024.12.09.04.56.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Dec 2024 04:56:49 -0800 (PST) Message-ID: <604c3501-f134-4a6e-ad41-ace84c2fd902@gmail.com> Date: Mon, 9 Dec 2024 13:56:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 16/19] fsnotify: generate pre-content permission event on page fault To: Jan Kara Cc: Josef Bacik , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, amir73il@gmail.com, brauner@kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, sraithal@amd.com References: <5d0cd660-251c-423a-8828-5b836a5130f9@gmail.com> <20241209123137.o6bzwr35kumi2ksv@quack3> Content-Language: en-US, sv-SE From: Klara Modin In-Reply-To: <20241209123137.o6bzwr35kumi2ksv@quack3> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4221040014 X-Rspam-User: X-Stat-Signature: u4skujuskaaxc5zd57yaqprs69y8kpyz X-HE-Tag: 1733748996-550997 X-HE-Meta: U2FsdGVkX19k+jSN8x2hCNi9/9qUGgN5CcrsGdfA30Hqz84vbhz0myp+j5UbHrYOQ61lDlG3PPa/zUc0QmwA/oIV2S8ByVk+Zz/DBxRlzblKkBCZsaREZrQtBb5L7NDhFAASSalgdtzLcUWTqNvK0CPLaUKdn/NYWzwoPZ8Fcv2ver+50ie1dXPpC3hH/256KX2n7y54N+QFeRJQF3+vCtFsyiLDCGBaAAjGesFMZeukC/9Xb7atpHr5zHQqBnrCZSX5PrxgjN3YibozD+rGgvbG5WTRC0yk/p/7Vq1Q6DA1CdBgz63Wvc/nY1VfxOb6UK4M8h8akKBPzlgXqSqlm7n1r2uduJZfAGNFZM8WZj3D2azhB80R/bixrPTmnFO7bVPM4UwcPqHNayD6I1WgZrIu92KfFTmdzphYFQKhGRTN8QSBYbL1Gw9IMaKTZJ6KZT8EuO/1YxfFhyjMi1AS6bv3R70zRtplvCHa+Wr//RTaJ5fn3MRONd6QmdRK0zqyZMVi03xBqIHUTC/tNISfYR5aCpbU3Y/8t4YqP6ZcZxw9n1jkk/Hjh2G5d10JRoI4PIVzH081ZgGcb2HDjFI+czv2NNbD/NnsB6jU26wDVfOaVjwjWSaM1z2obddxIxC7B6/8L/Okn0IfWurnMKn4hiiG2Q7gZXkc6tQ2LpPjcTB62qg70+0dHpkSLJ4sK0juBU7pji6vqCGF8MeEQ0w8ThOLix3LsL3vT6LcF2EeYZxjSA891WaD1EM7vNpwYnI2crmKDKr+yG2Nm8hPca3Mi2feB4RxQxf/MqZfjxMI1tY+8E1YQZi44HY5IDRGqr1SeuxdfD1d4FzxBIq/NEuDRwivfKOwdTKKahC4HJ10o8DVtxuktCST8VyrAxqI8C4CzJIZvTHcX1FQRXgfwP7YZRwVQsRhpsrNKuKxDPJ8QHv7YQTznBfKiEV+G7PTCkh81vxINWt1EE5WL+FH/Vl 3ZA2cFXu xn7IJOiVOp0B/W7oBU29MMioFH4w6xWa+zgNHwiG+8zvQPjoLxMPvRZHY9Pmsa+gm6zqm1F3oWHAbHbLnvHJXru3rrPSSBFC3XzBfyCRoUyrKnn9JtoWD612dygUIyG699EuB7rP6obxeSjN0khU5KXtQq43XpXX2Iq8fDF6u6gkGG+zmO/IKs/Le0NeIqk56fLbCHWYsRk5DxplftrF1ucf67vns/Di2b+qPqrKIjraZ40fYF2dVQ3fu8RgwA7N4QRh8K/01LcAvMu+xcy6iB7oHESJd0Ad3y4n2YCKF3yGxoxwcWwk16A6NXZTdPOxlKHBoAHfjP5BqD6Ck2K8lOKOJfRNX+xJ6u32VLejZeg8aBzjRu7GOhMEH/G084xDoAl7094f0YHcUJsRM7cJA/O9HNx4eQIOdI69A88awuY9h3fFWwBqOJAzkJLioTMrvg54k X-Bogosity: Ham, tests=bogofilter, spamicity=0.368863, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On 2024-12-09 13:31, Jan Kara wrote: > Hello! > > On Sun 08-12-24 17:58:42, Klara Modin wrote: >> On 2024-11-15 16:30, Josef Bacik wrote: >>> FS_PRE_ACCESS or FS_PRE_MODIFY will be generated on page fault depending >>> on the faulting method. >>> >>> This pre-content event is meant to be used by hierarchical storage >>> managers that want to fill in the file content on first read access. >>> >>> Export a simple helper that file systems that have their own ->fault() >>> will use, and have a more complicated helper to be do fancy things with >>> in filemap_fault. >>> >> >> This patch (0790303ec869d0fd658a548551972b51ced7390c in next-20241206) >> interacts poorly with some programs which hang and are stuck at 100 % sys >> cpu usage (examples of programs are logrotate and atop with root >> privileges). >> >> I also retested the new version on Jan Kara's for_next branch and it behaves >> the same way. > > Thanks for report! What is your kernel config please? I've just fixed a > bug reported by [1] which manifested in the same way with > CONFIG_FANOTIFY_ACCESS_PERMISSIONS=n. > > Can you perhaps test with my for_next branch I've just pushed out? Thanks! > > Honza My config was attached, but yes, I have CONFIG_FANOTIFY_ACCESS_PERMISSIONS=n. I tried the tip by Srikanth Aithal to enable it and that resolved the issue. Your new for_next branch resolved the CONFIG_FANOTIFY_ACCESS_PERMISSIONS=n case for me. Thanks, Klara Modin