From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45976C0218C for ; Thu, 23 Jan 2025 09:19:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9F416B007B; Thu, 23 Jan 2025 04:19:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C4F776B0082; Thu, 23 Jan 2025 04:19:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC8196B0083; Thu, 23 Jan 2025 04:19:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 90E4F6B007B for ; Thu, 23 Jan 2025 04:19:35 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4BF42120DB4 for ; Thu, 23 Jan 2025 09:19:35 +0000 (UTC) X-FDA: 83038168710.27.B28C109 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id D2CD640008 for ; Thu, 23 Jan 2025 09:19:32 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="CauB7/J3"; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1737623973; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tpk29QNJr/u2raDKjwzZa/ftrpCg2eN5gxWBxwWhmCg=; b=PfpaT+Q30HJ/K9YF9dpi2+SOHYFhhlIN2fR5ANntM8lt2W7jao+vMZtWWFrLVTwtbvoEx+ BEXAEzT4weprv5lTUruiHZU0tCea8uHfy5nLGdhHICNkP7yo7FV8T6pDD92oHwiwxoXc3w IKapzc+SZGr6PsQD1+uDWRtoBiDoL/A= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="CauB7/J3"; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1737623973; a=rsa-sha256; cv=none; b=SCQwa5raiG/inQR6kj6CiBFuEXLH74suuMVByI7J5o0dbhTdDrDVvQklp51H6WFIbY45cu on/Jzg+fwMDOOwQeAQfcbiA/tY7xshcnWeKArsmx4Bm/9rlBzEnkyWAsC+unhDIozlBO+g XfSs1UaSRuWwsZoOdTLG+0pvU+eHmbA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737623972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=tpk29QNJr/u2raDKjwzZa/ftrpCg2eN5gxWBxwWhmCg=; b=CauB7/J3FBDaJxv8cZyvvOqfcHYMkyr/niSaeNAiri299EejY3JuHGNFER3GDBXMQ9GRJd DKcb6jwm8LvYudkt4iZSBYM3cMpAvJfDhdqBLhWLV8+So7Vks4+9iyDWHmbsjndGEdRsAq yTc6wJPlcdYzoeI/JrUMuobJTFhAPxw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561-SgM9FGHePsqw2ACQS_MIYA-1; Thu, 23 Jan 2025 04:19:31 -0500 X-MC-Unique: SgM9FGHePsqw2ACQS_MIYA-1 X-Mimecast-MFC-AGG-ID: SgM9FGHePsqw2ACQS_MIYA Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43628594d34so3639185e9.2 for ; Thu, 23 Jan 2025 01:19:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737623970; x=1738228770; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=tpk29QNJr/u2raDKjwzZa/ftrpCg2eN5gxWBxwWhmCg=; b=GkV2xRPmxY3H7pcpkP+MuuF8/v8I50+eSItmMGJe0Mi1OSQ6UGFP08uTEhAcb77mXc TXtxIvuPf/xVwBhniifzhljm0Dbw8nWx2UETCOud4PYBEQlrgOFaHprzWz06Rd3wftV0 EOl/mY+rJV3KybDVZCjWdsSVP47eMY2+asEYY3Ngb90ZiuRSBnnfgnXStUVOzoZS/4HP 0iCmPFNPVoSqjDpLfjubWbkRmJW9TZPEBUOHq8s5thx29dAerHQi4ZZUB87cLA7i6kDv HVjFZaWnzMU3DpfKMY0FQd4xm5YLzIMM0sgQBMJk+5crTJtio/Sqi5CQyOUUUYJW9r7G m2DA== X-Gm-Message-State: AOJu0Ywk7qJ4TpOqRA3BYh0UMfmz+RPWjZXWFn1b0/oTTVPBdQ2ZXowI OUFgro2NXpcBCV0UZFdNia0xk72jxKKbcWVDzvFYcKY5G/IU22sQy+tRc0i7rkuQYt71THLudsJ yzB3P9x3CSE5N1zutWt3g06Y9T/8qcLQoCx45Ubz4QIJotqSg/gFApIJK4Hk= X-Gm-Gg: ASbGncvWSOkq5IqaMoFcwNVsvjXQR3kRvcbqkZdLmweONccJqFLVjYW6H6pYd5ZQ0C3 cGp4gFKV3mn22Q4hu6mbErPYcHebqYwDhIeeEygY7p+Jl5r0udnicaGev2xpdkLR32UYOgwrNpR kRe2mepOaWI5AXpoPd322lXZ+VdUr8DG5dDeHUUtPYYBEpIzHXRCezkc2ydpX5w/J26kPZlf3J/ RduFuHM0BVNEYCO3K1HRuDyxdWrgftiTh/ARvZ2SISKFhjI4jkIQkL7cutWrn85ofOXZXDyaGT7 TfSIg6eP97e47OOwfZUcO3QW4Bo1JjjsmpoQz4rnGgd9lmlaEUNJJFYxYMPPx6RSWC29mYdc+LI As6yO7mfwZoF+TQF+3BuCsA== X-Received: by 2002:a05:6000:1565:b0:386:41bd:53a3 with SMTP id ffacd0b85a97d-38bf57c0716mr20592560f8f.50.1737623969873; Thu, 23 Jan 2025 01:19:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IELJvr120PccGhiPk+J8vS7HCzJfKTXcv+kUl4068w0UecLnu7MAo371oosFvaHdmBOdCHv5w== X-Received: by 2002:a05:6000:1565:b0:386:41bd:53a3 with SMTP id ffacd0b85a97d-38bf57c0716mr20592522f8f.50.1737623969485; Thu, 23 Jan 2025 01:19:29 -0800 (PST) Received: from ?IPV6:2003:cb:c70b:b400:e20a:6d03:7ac8:f97d? (p200300cbc70bb400e20a6d037ac8f97d.dip0.t-ipconnect.de. [2003:cb:c70b:b400:e20a:6d03:7ac8:f97d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38bf2fc5caasm18686671f8f.0.2025.01.23.01.19.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2025 01:19:28 -0800 (PST) Message-ID: <604bbcbb-e728-4aef-b95b-13d50f8c4cc8@redhat.com> Date: Thu, 23 Jan 2025 10:19:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/compaction: fix UBSAN shift-out-of-bounds warning To: Liu Shixin , Andrew Morton , Kefeng Wang , Kemeng Shi , Baolin Wang , Mel Gorman , Matthew Wilcox , Nanyong Sun Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250123021029.2826736-1-liushixin2@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250123021029.2826736-1-liushixin2@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: nPSRTBAdZo5Qqxzrgec5uAA24DX4-j9o2RXov1AG_h4_1737623970 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: D2CD640008 X-Stat-Signature: peeb9c334hstt9o9rg7pkrs6csnrxr4p X-HE-Tag: 1737623972-806865 X-HE-Meta: U2FsdGVkX18gnN0X2QWKG3dsS6RicOjfGIY4zdtuQmZnQKf0DxDzY73QqwN6ZQE/lKlgKqpqvvE/JWjqoOzxEIX1FF3XHLegdevYtdFdMRc4ZS34JO74BlhUVe5o+ZorYz5QrArHHjCEKg3sbLrqS0mWZ4otn6/ra7f9pjrKhpHBHlgXr7dUilGgBsC5xcmjWzcUUnlChbAivYmQ3x/XU3PEXI/l7jOkQ0hBf5NYm0QY/eUoOOPVPAW8Ox2+94jGcOWDHI76+wJ592cEjhiYcnY3sb2xOx4yYQJrExrpvfBcS84UhvsG4ppLQydrbCkweTRpL1pPT5WhpefLUg6C/fPWSFuEdw5hHKezd1K5va1nMySm5CBDIFvg4AzPDQ3RneErrC1KlOkP0bn1ND1ctVwCPw8pdRs9Xf7A4Q7ZgkQEmZAUd3TyUSlLUJrK+ndaqvPY4I+U1ClBPiUunPH8s92yVb4lOZ8Yu2pBQy8a/QcgyINbcuPAJy69vWY7MgXYxlNYHAzS8MfxQgZLgQ+FYlIG9pinW2VnNdJreDWb16TKHJgR97tOjWO5P4WZIPjs6EW8IP7qyUI5m4ptVNOaFD+KBf5L1+sf8nz9P5Ekxcx5hEBd/TTOvdEuARPIoXfgV7dYsJ60MqOSZ/KPlZw7dfOTGLe5Sr7gCmLXUD/JhyySQH9Z2tNxneivQ91ShwQqidGnxxZtvNeI645XgoSNHHpyg2CWUvwE+357pZdE+b3W1oixHM/+EK6b/Oj3/oPqiq9qqHwU7PqVzDToViCR415RY5twjH/iUqVbLgcOYDC/824mMCOygM8JCVVVwkYDTGG46/AxYoMi/a/s/hPj/H4OATSXrTH1LUoVvCRZeMdfEFWzPpa3AZYvyg4LSXMl98S52h76du9NSNpcxVKChUhgCsweX30KasBZ0bU4ZqtaGt9M0rf1SsN+LYURkE1HAg3dEUai7UK1uFFa06y KflFqMOc x4z+DQJBdoIOKwVCEQD8zwm+eQKtv3ub107Z9Cljy5iRPAvFCnox1mZ0o3870LsjWCQvAyXq/2urF5o4oX9AgqcBeAdjm1lNZ6+PZABStKMQDD+KDj85s30X4lpsAOv2AsB3zMfHF9FCZDLv8BsgDxWn2S3GhhW711X1MccTal7pHN47vfuKZ/bb3B+it0zA1Z4ffvNoCCcGBsZv7jqCFcjwg1iiVOtcbmyBQkpqUy1n40rp9nxrXzQODLXUPU7ktzvdhr4DPK1hUlj/HY2qbew/lqKyjMf08gelve3iPgGRHrRnvhzk8C7ybYwbgdsCvdMdkZu5OFMModW3lBPVbwh0XoDhDlflb5GbznvUwhBUBVQNCS8/Y4xhIZXaXX6gkOczF0ORaGD/96sOeSw2vzMI99KyXBBuonYf01xHIyuxo0ssQlvFs4OY2sPqg9zGrBPFP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 23.01.25 03:10, Liu Shixin wrote: > syzkaller reported a UBSAN shift-out-of-bounds warning of (1UL << order) > in isolate_freepages_block(). The bogus compound_order can be any value > because it is union with flags. Add back the MAX_PAGE_ORDER check to fix > the warning. > > Fixes: 3da0272a4c7d ("mm/compaction: correctly return failure with bogus compound_order in strict mode") > Signed-off-by: Liu Shixin > --- > mm/compaction.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index a2b16b08cbbff..384e4672998e5 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -630,7 +630,8 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, > if (PageCompound(page)) { > const unsigned int order = compound_order(page); > > - if (blockpfn + (1UL << order) <= end_pfn) { > + if ((order <= MAX_PAGE_ORDER) && hugetlb can exceed MAX_PAGE_ORDER, but end_pfn cannot. So I think what you have here will not change the exiting handling. Acked-by: David Hildenbrand Note: the whole "-1" with stride != 1 looks odd ... -- Cheers, David / dhildenb