From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 897FDEB64DA for ; Sat, 1 Jul 2023 02:57:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54C718E0061; Fri, 30 Jun 2023 22:57:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FC938E0059; Fri, 30 Jun 2023 22:57:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 412068E0061; Fri, 30 Jun 2023 22:57:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 33C1F8E0059 for ; Fri, 30 Jun 2023 22:57:52 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E2B13140457 for ; Sat, 1 Jul 2023 02:57:51 +0000 (UTC) X-FDA: 80961533142.30.21B4F3B Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf12.hostedemail.com (Postfix) with ESMTP id 7F51B40004 for ; Sat, 1 Jul 2023 02:57:47 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf12.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688180270; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fDEzdV62/bIp179YqyaMKtKJj7n0iCCMe6bFmAfXbgY=; b=SPIaKXvlIaq7OIFzJ8/Lpa1DqqO2OvQWMaSWE4Ew1S3m2uaj2+/8OehEd0uXVuSO4Uw3Mb tjyghyEwI7ocWpJ9+lcQ1z4JOSNmuPUL2qjTHHUSDz+UF9NUZkvLwBKpK3QQ1tGW7jqMD2 3tYctFA+ejUIfHYytyi7vD/343z5Y9M= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf12.hostedemail.com: domain of zhangpeng362@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=zhangpeng362@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688180270; a=rsa-sha256; cv=none; b=2IYsOaLp9JM86dayZdVycWMdXhT5H9492HAV0vawp5/3OFQg1lIolPEguj/iJPpj2zvS0I TM4J/0w+rOJNDtZbc6w+8ENOC9L3k/7YPLr7bW97B53R/U0lzgarOP+NwJRpQEsVwk5aoN 1GLgAZZ+ySqb1IAfWQ+F6Sw3c+FCrzA= Received: from kwepemm600020.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QtGxn4WbPztQTd; Sat, 1 Jul 2023 10:54:53 +0800 (CST) Received: from [10.174.179.160] (10.174.179.160) by kwepemm600020.china.huawei.com (7.193.23.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sat, 1 Jul 2023 10:57:40 +0800 Message-ID: <604775f0-fa72-0ec4-d911-5c113fef7de1@huawei.com> Date: Sat, 1 Jul 2023 10:57:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 0/2] mm: remove page_rmapping() Content-Language: en-US To: Matthew Wilcox CC: , , , , , References: <20230630121310.165700-1-zhangpeng362@huawei.com> From: "zhangpeng (AS)" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.160] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600020.china.huawei.com (7.193.23.147) X-CFilter-Loop: Reflected X-Rspam-User: X-Stat-Signature: uwmkjxtqyon8ysgjk9g66skqq15wzanj X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7F51B40004 X-HE-Tag: 1688180267-602492 X-HE-Meta: U2FsdGVkX1+hh6JJFpB5phQLTdbGRSQyNASJxsxuUkvhr7gTIrzILylqlp9G7PREpa63icGimtYukEW6eZIMMzbSBdemtIMCtxMFUrWEcR31KJRGrnC3WbS9VA2WJsSlJxPxveELwv+SM7lhgrroEx0AelXqKEoMiVA2sRWK7icRa6n/ERHucj3yWgs+QhPPlLQFRQCXWvMAwXzQvKtchzk6DFprDI3fsm8MVtXPRta50i0o1DzFpdvErjsFUx7IPI+AO8DUNZISYk6oozAM6A7XUOvEeFLi3sTyMUUVkDp338OzjD4TYpjBHgtnfR304JsqCLRIXlxDVzC3UvQH6DoOTyKBa1hYownxwkO36Q1bwe2WrlvmLnD9XcY1iot/AcygecsT3n6gkBGQQ26t65KJEO0fEhHJe44sqcaOBrzTyddM0RcQ+N4xQ4m+pjsZz0JsdJjo16mtZTcf+xnRo/Pl4JOFio+6ruZy1C5zyxXVNS/Xt4FomwwqpvtTaEWQMY80T9d7Kp5QgIukN3352ub77Ch3OaYibbZcM2yd3B1NgcxWwS/YmavG88dkAU5TgdZHDdebet/Cd/RUny68K3JlighYSwbJ7rN1HU0GruX4DQUP6yBQqxG7gW45WbXV6JzxuWQqAlFaW/V+f7gjTazwhALViBj0Sg96hDuj5Fb/tv8GtovLpnm+wIXJ2OAMaxHA3A9TE/9NDpZm4wU77uRQV5+7PXIU7xM639ehmXkEAbpPqO/XbEd0pBdRSz0bTrFKLY97/yK1oZILy4RGHYg5F1ZifDJ5vGXRuWn5Kvzmtj+u4iuV1UxvAOHHZLBGHocylyrOVBVmF2d+qpBYneSFDjg8wu0MsqQMjbCufApiM6p/qvI2EWbCRpdav/scRaPjIrEXNdU1x4TkIHVcytb0KbaxAOq6v7kGectOXcE8SqMfIcy2EM1eAoQFVoBWET5ZHN3W26rAhfI3PNO Ugco9pDO Y/vur9MeMaz1RUngqmpBIRjh6qe/jfxwxAl6TC5LSFvRydLM1B+eprzrsJxvOiksZ/kkfNhu693EM+RidXUNRHaExT9AvTkOJmYeA1ARac1oajKoUoZhyrPG+HxPCESyD7b16DcnN1YgaSmQznjX61AoddRBuk/+x4x30+HOwKKWOGvBduGK5X1hU2XbsO5GDXKyhjYDpMXnDLC8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/1 5:39, Matthew Wilcox wrote: > On Fri, Jun 30, 2023 at 08:13:08PM +0800, Peng Zhang wrote: >> From: ZhangPeng >> >> This minor patch series remove page_rmapping() and convert the last user >> fault_dirty_shared_page() to use a folio. > This patch series works better if you do it in the other order. > First convert the user, then remove the now-unused page_rmapping(). > > It's almost always a mistake to start with "I want to remove all the > users of API x". You should be thinking "Here is function y that still > uses pages; I shall convert it to use folios". Thanks for your feedback. I'll reverse the order of the two patches. Convert user first, then remove the now-unused page_rmapping(). Best Regards, Peng