From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD4D6C433EF for ; Wed, 8 Jun 2022 07:16:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1968B6B0071; Wed, 8 Jun 2022 03:16:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1465E6B0072; Wed, 8 Jun 2022 03:16:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F286F6B0073; Wed, 8 Jun 2022 03:16:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DF8756B0071 for ; Wed, 8 Jun 2022 03:16:58 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 98A503452B for ; Wed, 8 Jun 2022 07:16:58 +0000 (UTC) X-FDA: 79554211716.18.94B4C09 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf03.hostedemail.com (Postfix) with ESMTP id AAC2120003 for ; Wed, 8 Jun 2022 07:16:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654672617; x=1686208617; h=message-id:subject:from:to:cc:date:in-reply-to: references:mime-version:content-transfer-encoding; bh=KlqO8nPRQRaOPy3EhxLg2Le/QPz9uVGA3SU1z+o5YCI=; b=dO2OsmVrHdhhWclfP9ebTAtd0qDCQxSZRRZMnDnzC3N5VsGhH6M6HAqx C556gWKzn0xVCxR3n7ZKyXphtB/Eh+zDWNXl1HhEG0BmOvhru5CzUeFKw MCfS/np5042DpRz/UmqeBZQPEZ2MiUPrXCpwRy/+4H4T3wAd2XxVq5vJY 18f6AgrzQAXseJ0Cd9yY6a8xoOk6i0OSVVGG4DQx7Jo50rha9OR7OpbIZ Y3jnkqYQxJrIHqShWSumSqFnlsNaSsN5o1rP0MWYhygpw0/w6goh0qQYi zatLyLxtYYF1N4T3OU2j+BjT4NTX8vJSDm/cLUgFtvobIhXfjygFnWOld w==; X-IronPort-AV: E=McAfee;i="6400,9594,10371"; a="363139016" X-IronPort-AV: E=Sophos;i="5.91,285,1647327600"; d="scan'208";a="363139016" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2022 00:16:54 -0700 X-IronPort-AV: E=Sophos;i="5.91,285,1647327600"; d="scan'208";a="636631905" Received: from xding11-mobl.ccr.corp.intel.com ([10.254.214.239]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2022 00:16:48 -0700 Message-ID: <604403db000ced33f997688ce82eaa43ed6c8bbe.camel@intel.com> Subject: Re: [RFC PATCH v4 1/7] mm/demotion: Add support for explicit memory tiers From: Ying Huang To: "Aneesh Kumar K.V" , linux-mm@kvack.org, akpm@linux-foundation.org Cc: Greg Thelen , Yang Shi , Davidlohr Bueso , Tim C Chen , Brice Goglin , Michal Hocko , Linux Kernel Mailing List , Hesham Almatary , Dave Hansen , Jonathan Cameron , Alistair Popple , Dan Williams , Feng Tang , Jagdish Gediya , Baolin Wang , David Rientjes Date: Wed, 08 Jun 2022 15:16:46 +0800 In-Reply-To: <20220527122528.129445-2-aneesh.kumar@linux.ibm.com> References: <20220527122528.129445-1-aneesh.kumar@linux.ibm.com> <20220527122528.129445-2-aneesh.kumar@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspam-User: Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=dO2OsmVr; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf03.hostedemail.com: domain of ying.huang@intel.com has no SPF policy when checking 192.55.52.43) smtp.mailfrom=ying.huang@intel.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: AAC2120003 X-Stat-Signature: 1i6rmaoyyuzzoq1ay46midtdk3zdsak9 X-HE-Tag: 1654672617-193332 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2022-05-27 at 17:55 +0530, Aneesh Kumar K.V wrote: [snip] > > +static int __init memory_tier_init(void) > +{ > + int ret; > + > + ret = subsys_system_register(&memory_tier_subsys, memory_tier_attr_groups); > + if (ret) > + panic("%s() failed to register subsystem: %d\n", __func__, ret); I don't think we should go panic for failing to register subsys and device for memory tiers. Just pr_err() should be enough. Best Regards, Huang, Ying > + > + /* > + * Register only default memory tier to hide all empty > + * memory tier from sysfs. > + */ > + ret = register_memory_tier(DEFAULT_MEMORY_TIER); > + if (ret) > + panic("%s() failed to register memory tier: %d\n", __func__, ret); > + > + /* > + * CPU only nodes are not part of memoty tiers. > + */ > + memory_tiers[DEFAULT_MEMORY_TIER]->nodelist = node_states[N_MEMORY]; > + > + return 0; > +} > +subsys_initcall(memory_tier_init); > + > +#endif /* CONFIG_TIERED_MEMORY */