From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A84EEB64DD for ; Thu, 29 Jun 2023 21:33:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B64A78D0002; Thu, 29 Jun 2023 17:33:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B15478D0001; Thu, 29 Jun 2023 17:33:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DC2D8D0002; Thu, 29 Jun 2023 17:33:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8DAC28D0001 for ; Thu, 29 Jun 2023 17:33:14 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4EEE71405EF for ; Thu, 29 Jun 2023 21:33:14 +0000 (UTC) X-FDA: 80957086308.25.0EEE286 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by imf05.hostedemail.com (Postfix) with ESMTP id 5F4E4100009 for ; Thu, 29 Jun 2023 21:33:12 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of sagigrim@gmail.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=sagigrim@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688074392; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5sXNz3T27fieAIRTR48zTnONuZ1yBFOaZf/CPHZQ27c=; b=a+L8TNyRJoW4PJUzUknqAN4lWkQQ0Vq+qjt4OPW5XnDU8pllddo3W5cbS7cn10ofqa4dBJ nDyVIhhwLcqFv3uLd8bMztXc2j3INsEQfFJiT/lEdfdslbvoxt7okPEF1iCdj1qykkuLAq ROli/pmwqTpdrekHNlzHzR9qB8IRDYA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of sagigrim@gmail.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=sagigrim@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688074392; a=rsa-sha256; cv=none; b=BI3c85Mlq5q+iF3efob78Z4ncqQDMwRvGkXdqfFUHUab/Biqeaen+obcN2WcexZ45gEMN/ ZQBMRufGqL/8j2CzVYplwpxLSXaioaRBmMF5w6ikRz0tHE7Y5+jDiw6EA3Mzt3kztr78L8 Digp8CXnAbOJhZcarrNOYJPuBeU4SFU= Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-313f0ca48c7so367164f8f.0 for ; Thu, 29 Jun 2023 14:33:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688074391; x=1690666391; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5sXNz3T27fieAIRTR48zTnONuZ1yBFOaZf/CPHZQ27c=; b=TryNe4x8SNBSIbCK9L+xBgAjmqiysNDJ6HNRo5k2YdEdQ1rNaXFbMuM7QDoT51RkFP OdtDf9AugzAVIZOcRRaR2WohERAHVc07dOLRsFlMnQD6BnLSvrbJVhI3SNmjhwhRYZYL Ek+ssRJFceQfXaUaPuwc9auHsYYkQcyfBrK2nB3ZXzuxRD8FbLC2S6igSC6ptKGvxuUt oW+sU1Qf0C9G6PiEMLRpPE930DV7SUViTj/Kp5Z5mw+9HDxlqY4b1RI7a7WjJ/Eufgk4 b6IS2wXWrRG0zM6+HJf7tUaajeaBrKdRSr888wv6nHYP17cIqwqzxGefOHZbM6Pke/mm Pykw== X-Gm-Message-State: ABy/qLYpSxT75pE7nLngj4vYuLUIEgv+YuvcpKGBkNwngIbjgw3arI+R MfvpvHGocKkbGwYx+65toj8= X-Google-Smtp-Source: APBJJlHhxv+5GV3Rjo7juNC1oow8yS4xjV2IiwQgUGk5HHlOOrfmZLq+H5OaYbuw+s8Py7L4F8UYoQ== X-Received: by 2002:adf:e5c1:0:b0:314:1e8:40ca with SMTP id a1-20020adfe5c1000000b0031401e840camr598464wrn.3.1688074390598; Thu, 29 Jun 2023 14:33:10 -0700 (PDT) Received: from [10.100.102.14] (46-116-229-137.bb.netvision.net.il. [46.116.229.137]) by smtp.gmail.com with ESMTPSA id b3-20020a05600010c300b00313f9367844sm9301920wrx.88.2023.06.29.14.33.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jun 2023 14:33:09 -0700 (PDT) Message-ID: <6021d82d-ac0f-cc03-d9b2-19dcf20e48ee@grimberg.me> Date: Fri, 30 Jun 2023 00:33:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH net-next v3 10/18] nvme/host: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage Content-Language: en-US To: David Howells Cc: Aurelien Aptel , netdev@vger.kernel.org, Alexander Duyck , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Willem de Bruijn , Keith Busch , Jens Axboe , Christoph Hellwig , Chaitanya Kulkarni , linux-nvme@lists.infradead.org References: <20230620145338.1300897-1-dhowells@redhat.com> <20230620145338.1300897-11-dhowells@redhat.com> <253mt0il43o.fsf@mtr-vdi-124.i-did-not-set--mail-host-address--so-tickle-me> <55023.1688073781@warthog.procyon.org.uk> From: Sagi Grimberg In-Reply-To: <55023.1688073781@warthog.procyon.org.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5F4E4100009 X-Rspam-User: X-Stat-Signature: 3pq4q5khx1gypbfree8c9bnkrm65fiqj X-Rspamd-Server: rspam01 X-HE-Tag: 1688074392-801224 X-HE-Meta: U2FsdGVkX1/TUVRr/X/RjZrwTr68i85Z2niTuQ+PBK1AMpLvAfKpXq+ARnq7OA0G5sLuP22mpQRgI0gVF8RSsWtiaQFx5JCEtWENEeq13IxXe/GjLlDzdSA5l18HVe/+aIgbf8+pMPHm0ifHQM6g2nXdTr2o7EX0LS+rLsGQCfDQbr+lZfJpK9sMlMNSNCmm4OVLrklFFjfOtd7MBh8aw+CdC2LyP4qywB4+nZcWIPMox17/mau9PSkCqbmrl+bbgSBq+eOl/iGV7+kyW1lBLw8d2Ry2M+ksZteoPuDZjZk7B0y4YdIoeEvUyfOck8c0bnnGLbCGJ6bE80I43YNrdb1rfMkOA56Hd5KCAng8Z3qYUwvcTf6oHi/MQ1FAfQSL23G+Y5Kll8Pnci+AYVXOfj23A1lI1kruBNBgsD03nvz9LajQcQYRN0ZyFgMCyE0puknOEdf+bMSN1w/NKwtjQyw9NQigpapD+jCqPdPdUoNe2YCKAIwfNSxF71H8eoWyisUhoEQGwt4EPMJsIPXGXdmzoIQY6DfiyAcDEU/h3yT7iih4odWH9VyGshf9tcH+71eG0BXzfSRsBrQdymbxbFFZ1l2vptc3DIUNSmwt/F8xp2pcgYYqRPRdvRnGM5XaH5I4v9l9xKs/kdk16v57OT7ZzKcRcxKrGB12pndvODIIINjpDA3/YYX/SV79gpf0u41jeEeyknnzHGkyDv5EFmVNiRjjyJtRjk5NoSXkeTJFePdYi/mGj4LU1sLA18Im7xgg0ZLYwYys1iUTaEDvGyFuvYqEA1WkFuVBLhSMP/7a6UjYZ8gRstDm83GFfl3L2eJ6gMna6ntJ9QtfR5S+psznzdU6dYrGcDGIfSM6h5brAi6NHh0sfZ77Re5+vZ9vxPuVU5xo8UZTpYefvhKWOyo1TAhrGHFVsv2Y0OXhjk8Czz+gVdNmNCKU/O1TbCqQ6mlgmde/7120sjkbukz KJdAaCYa 5UQMbmrl2TAjBwEI29gZSMZsMaFxrPSxmM6HJN/7Jq5Hy8wsWdBTjmWDGOWE3JdRGDA6ZpDEEPY9DH3orQh7l3zC9k9ZZnlbiDtJb9gPdfXpyPUwOZSuVLTt/IHUiyWlZLSZQmBf3R+Y/I83+HLBxY+bnp2vibvVOKEmEgXMo0NIitX5E48EA+e2hBX7amoIrWZuIWYEP9v5cFUzAsg0khUvBdtvAnBweykMM0KUnKmsCXeZOGx2YvXaPyACnLnMpzQRjXkOzCIfCEQAFwV58+rjZZNHMYOfbG2RB9YmrHQu8UDQ+LZpUB9gBZ09F8cU10kTSXTqvond7gh3YHJ72ExyeYIwuP/9opLNfTGZVQmHxXVi1LdNJX6rh8mehOO5TLa8PZVvFkQ19hZ3XK1JAfF4Qjzgz/RDshmSV+9rspyb1jF4SFSFx7KDZ2BgYpQkiw1/hZ/sR5CzAxQx2DBgyWuPp8f9MTRgsaicw7MshJljpO2gOS3nkyylzdd7cmv20V8gqC2r46JpQJcfkPvUOnWda+k1i8qYSPNqELWgmwdfANkIV/zZDwBf2TDd+AI90fFRD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Sagi Grimberg wrote: > >> simple way to check is to run: >> nvme_trtype=tcp ./check nvme > > It says a lot of: > > nvme/002 (create many subsystems and test discovery) [not run] > nvme is not available > nvme_trtype=tcp is not supported in this test > nvme/003 (test if we're sending keep-alives to a discovery controller) [not run] > nvme is not available > nvme/004 (test nvme and nvmet UUID NS descriptors) [not run] > nvme is not available > nvme/005 (reset local loopback target) [not run] > nvme is not available > ... > > I have the following NVMe config: > > # NVME Support > CONFIG_NVME_COMMON=y > CONFIG_NVME_CORE=y > CONFIG_BLK_DEV_NVME=y > CONFIG_NVME_MULTIPATH=y > # CONFIG_NVME_VERBOSE_ERRORS is not set > # CONFIG_NVME_HWMON is not set > CONFIG_NVME_FABRICS=y > # CONFIG_NVME_RDMA is not set > # CONFIG_NVME_FC is not set > CONFIG_NVME_TCP=y > CONFIG_NVME_AUTH=y > CONFIG_NVME_TARGET=y > CONFIG_NVME_TARGET_PASSTHRU=y > CONFIG_NVME_TARGET_LOOP=y > # CONFIG_NVME_TARGET_RDMA is not set > # CONFIG_NVME_TARGET_FC is not set > CONFIG_NVME_TARGET_TCP=y > CONFIG_NVME_TARGET_AUTH=y > # end of NVME Support > CONFIG_RTC_NVMEM=y > CONFIG_NVMEM=y > # CONFIG_NVMEM_SYSFS is not set > # CONFIG_NVMEM_LAYOUT_SL28_VPD is not set > # CONFIG_NVMEM_LAYOUT_ONIE_TLV is not set > # CONFIG_NVMEM_RMEM is not set > > Can you tell me what I'm missing? install nvme-cli. nvme/010 is enough to reproduce I think: nvme_trtype=tcp ./check nvme/010