From: David Hildenbrand <david@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: David Hildenbrand <david@redhat.com>,
David Rientjes <rientjes@google.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
virtualization@lists.linux-foundation.org,
Jason Wang <jasowang@redhat.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Tyler Sanderson <tysand@google.com>,
Wei Wang <wei.w.wang@intel.com>,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Nadav Amit <namit@vmware.com>, Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3] virtio-balloon: Switch back to OOM handler for VIRTIO_BALLOON_F_DEFLATE_ON_OOM
Date: Tue, 10 Mar 2020 23:02:58 +0100 [thread overview]
Message-ID: <6021D755-F883-4524-B3D1-07C03C7DF11B@redhat.com> (raw)
In-Reply-To: <20200310172114-mutt-send-email-mst@kernel.org>
> Am 10.03.2020 um 22:25 schrieb Michael S. Tsirkin <mst@redhat.com>:
>
> On Tue, Mar 10, 2020 at 08:13:19PM +0100, David Hildenbrand wrote:
>>> Should this have:
>>>
>>> Cc: stable@vger.kernel.org # 4.19+
>>
>> I guess as nothing will actually "crash" it's not worth stable.
>
>
> No - it's a regression, it would be a stable candidate from that POV.
AFAIK
„ It must fix a problem that causes a build error (but not for things marked CONFIG_BROKEN), an oops, a hang, data corruption, a real security issue, or some “oh, that’s not good” issue. In short, something critical.“
If this regression is that critical is debatable. But it doesn‘t matter as you correctly say, it‘s too big :)
next prev parent reply other threads:[~2020-03-10 22:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 11:38 David Hildenbrand
2020-03-10 16:15 ` Tyler Sanderson
2020-03-10 19:05 ` David Rientjes
2020-03-10 19:13 ` David Hildenbrand
2020-03-10 21:25 ` Michael S. Tsirkin
2020-03-10 22:02 ` David Hildenbrand [this message]
2020-03-11 11:12 ` Michael S. Tsirkin
2020-03-11 11:21 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6021D755-F883-4524-B3D1-07C03C7DF11B@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=namit@vmware.com \
--cc=rientjes@google.com \
--cc=sfr@canb.auug.org.au \
--cc=tysand@google.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox