From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 098A5C4CEC5 for ; Thu, 12 Sep 2019 15:52:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BC5F620644 for ; Thu, 12 Sep 2019 15:52:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="Xve/r2+a" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC5F620644 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 52A1E6B000A; Thu, 12 Sep 2019 11:52:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B3EC6B000C; Thu, 12 Sep 2019 11:52:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 32D406B000D; Thu, 12 Sep 2019 11:52:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0226.hostedemail.com [216.40.44.226]) by kanga.kvack.org (Postfix) with ESMTP id 0BEC46B000A for ; Thu, 12 Sep 2019 11:52:34 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 859BF1A4D4 for ; Thu, 12 Sep 2019 15:52:33 +0000 (UTC) X-FDA: 75926710986.13.coast32_507203d54af17 X-HE-Tag: coast32_507203d54af17 X-Filterd-Recvd-Size: 8056 Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) by imf03.hostedemail.com (Postfix) with ESMTP for ; Thu, 12 Sep 2019 15:52:32 +0000 (UTC) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 46Tjvd4mf5z9v01v; Thu, 12 Sep 2019 17:52:29 +0200 (CEST) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=Xve/r2+a; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id A0Kfupm1sMQP; Thu, 12 Sep 2019 17:52:29 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 46Tjvd3M1wzB09bN; Thu, 12 Sep 2019 17:52:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1568303549; bh=8yNeYzD4hyXGy/cp3pkfdaOEeCFKo8dkfUfa1uQQNdw=; h=Subject:From:To:Cc:References:Date:In-Reply-To:From; b=Xve/r2+abfDHfuK0WIskaBB17UKxFk/oCvwXkkUF5Yo4BLlxGU81bDiG5ke88fbye BE8P5FDH9S654EK1eo6Y8b6n1X7xstmolnKTrzECKOGoc5E7ZdJ0fsFaCrbfijNknG 8RziH8EmMIWjiObqTYaXwtz8qoLghxzrvqE5L7qA= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 6ED6B8B945; Thu, 12 Sep 2019 17:52:30 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id pajkW6Q7ywER; Thu, 12 Sep 2019 17:52:30 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 812188B941; Thu, 12 Sep 2019 17:52:22 +0200 (CEST) Subject: Re: [PATCH V2 2/2] mm/pgtable/debug: Add test validating architecture page table helpers From: Christophe Leroy To: Anshuman Khandual , linux-mm@kvack.org Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Heiko Carstens , Michal Hocko , Dave Hansen , Paul Mackerras , sparclinux@vger.kernel.org, Dan Williams , linux-s390@vger.kernel.org, Jason Gunthorpe , x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Tetsuo Handa , Vlastimil Babka , linux-snps-arc@lists.infradead.org, Kees Cook , Mark Brown , "Kirill A . Shutemov" , Thomas Gleixner , Gerald Schaefer , linux-arm-kernel@lists.infradead.org, Sri Krishna chowdary , Masahiro Yamada , Greg Kroah-Hartman , Ard Biesheuvel , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" References: <1568268173-31302-1-git-send-email-anshuman.khandual@arm.com> <1568268173-31302-3-git-send-email-anshuman.khandual@arm.com> <4cf31ca9-39e4-87e4-7eef-a6f3f0ea7576@c-s.fr> <31aa6043-3b11-a936-bf35-6ed84bff9304@c-s.fr> Message-ID: <600a7c62-eea9-e26f-f7cf-f2103b7c228c@c-s.fr> Date: Thu, 12 Sep 2019 17:52:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <31aa6043-3b11-a936-bf35-6ed84bff9304@c-s.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 12/09/2019 =C3=A0 17:36, Christophe Leroy a =C3=A9crit=C2=A0: >=20 >=20 > Le 12/09/2019 =C3=A0 17:00, Christophe Leroy a =C3=A9crit=C2=A0: >> >> >> On 09/12/2019 06:02 AM, Anshuman Khandual wrote: >>> This adds a test module which will validate architecture page table=20 >>> helpers >>> and accessors regarding compliance with generic MM semantics=20 >>> expectations. >>> This will help various architectures in validating changes to the=20 >>> existing >>> page table helpers or addition of new ones. >>> >>> Test page table and memory pages creating it's entries at various=20 >>> level are >>> all allocated from system memory with required alignments. If memory=20 >>> pages >>> with required size and alignment could not be allocated, then all=20 >>> depending >>> individual tests are skipped. >> >> Build failure on powerpc book3s/32. This is because asm/highmem.h is=20 >> missing. It can't be included from asm/book3s/32/pgtable.h because it=20 >> creates circular dependency. So it has to be included from=20 >> mm/arch_pgtable_test.c >=20 > In fact it is that needs to be added, adding=20 > directly provokes build failure at link time. >=20 I get the following failure, [ 0.704685] ------------[ cut here ]------------ [ 0.709239] initcall arch_pgtable_tests_init+0x0/0x228 returned with=20 preemption imbalance [ 0.717539] WARNING: CPU: 0 PID: 1 at init/main.c:952=20 do_one_initcall+0x18c/0x1d4 [ 0.724922] CPU: 0 PID: 1 Comm: swapper Not tainted=20 5.3.0-rc7-s3k-dev-00880-g28fd02a838e5-dirty #2307 [ 0.734070] NIP: c070e674 LR: c070e674 CTR: c001292c [ 0.739084] REGS: df4a5dd0 TRAP: 0700 Not tainted=20 (5.3.0-rc7-s3k-dev-00880-g28fd02a838e5-dirty) [ 0.747975] MSR: 00029032 CR: 28000222 XER: 000000= 00 [ 0.754628] [ 0.754628] GPR00: c070e674 df4a5e88 df4a0000 0000004e 0000000a=20 00000000 000000ca 38207265 [ 0.754628] GPR08: 00001032 00000800 00000000 00000000 22000422=20 00000000 c0004a7c 00000000 [ 0.754628] GPR16: 00000000 00000000 00000000 00000000 00000000=20 c0810000 c0800000 c0816f30 [ 0.754628] GPR24: c070dc20 c074702c 00000006 0000009c 00000000=20 c0724494 c074e140 00000000 [ 0.789339] NIP [c070e674] do_one_initcall+0x18c/0x1d4 [ 0.794435] LR [c070e674] do_one_initcall+0x18c/0x1d4 [ 0.799437] Call Trace: [ 0.801867] [df4a5e88] [c070e674] do_one_initcall+0x18c/0x1d4=20 (unreliable) [ 0.808694] [df4a5ee8] [c070e8c0] kernel_init_freeable+0x204/0x2dc [ 0.814830] [df4a5f28] [c0004a94] kernel_init+0x18/0x110 [ 0.820107] [df4a5f38] [c00122ac] ret_from_kernel_thread+0x14/0x1c [ 0.826220] Instruction dump: [ 0.829161] 4beb1069 7d2000a6 61298000 7d200124 89210008 2f890000=20 41be0048 3c60c06a [ 0.836849] 38a10008 7fa4eb78 3863cacc 4b915115 <0fe00000> 4800002c=20 81220070 712a0004 [ 0.844723] ---[ end trace 969d686308d40b33 ]--- Then starting init fails: [ 3.894074] Run /init as init process [ 3.898403] Failed to execute /init (error -14) [ 3.903009] Run /sbin/init as init process [ 3.907172] Run /etc/init as init process [ 3.911251] Run /bin/init as init process [ 3.915513] Run /bin/sh as init process [ 3.919471] Starting init: /bin/sh exists but couldn't execute it=20 (error -14) [ 3.926732] Kernel panic - not syncing: No working init found. Try=20 passing init=3D option to kernel. See Linux=20 Documentation/admin-guide/init.rst for guidance. [ 3.940864] CPU: 0 PID: 1 Comm: init Tainted: G W=20 5.3.0-rc7-s3k-dev-00880-g28fd02a838e5-dirty #2307 [ 3.951165] Call Trace: [ 3.953617] [df4a5ec8] [c002392c] panic+0x12c/0x320 (unreliable) [ 3.959621] [df4a5f28] [c0004b8c] rootfs_mount+0x0/0x2c [ 3.964849] [df4a5f38] [c00122ac] ret_from_kernel_thread+0x14/0x1c Christophe