From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8282DC76195 for ; Tue, 21 Mar 2023 20:46:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97B186B0078; Tue, 21 Mar 2023 16:46:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 903066B007B; Tue, 21 Mar 2023 16:46:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 77C536B007D; Tue, 21 Mar 2023 16:46:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 650E06B0078 for ; Tue, 21 Mar 2023 16:46:25 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2E4C01A01BB for ; Tue, 21 Mar 2023 20:46:25 +0000 (UTC) X-FDA: 80594088330.29.2292073 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by imf16.hostedemail.com (Postfix) with ESMTP id 4DF4318001D for ; Tue, 21 Mar 2023 20:46:23 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FNfoY1JZ; spf=pass (imf16.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679431583; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rtTyPgAyyTCsuj6xg05jXpazWd4/Ojg4wA/2tNBdu1s=; b=n9AmvC/vYfSYYc5M9rFoE5bPeRiLiOtsVatum8Y4EqZ1Dm5PfJHChC8Sh2rI5wiQDPgKl6 TPUxRNPVkE8RJ4QVut/zQpX0aXLzu478v04/imee94XVidqbbfJpsPu+Kk37P9YqfaZgWw XhAe9X1kBCcBLkzwT6aWHf46e1GtvQY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=FNfoY1JZ; spf=pass (imf16.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679431583; a=rsa-sha256; cv=none; b=icuiblEoe1l90zWyP+ISKuk4IIDCwGXx/YaWuJ3XNvyEEopS4NwNrcg/1/THTFFyrF1Sp4 HQboyAhKQHKxiiFvsBdWnG5ZPzFCZNmBOOKQWmeisTMYznuW/cFDqNd/2etc2s9sh/wG45 CpMUDDUt4f3BLWjXLRd/DUUIUdV6EkA= Received: by mail-wr1-f49.google.com with SMTP id l27so6715592wrb.2 for ; Tue, 21 Mar 2023 13:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679431581; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rtTyPgAyyTCsuj6xg05jXpazWd4/Ojg4wA/2tNBdu1s=; b=FNfoY1JZqKacVO45/DDOogtTW4PW0fxKgBlLXtoiWkvTUfS6IQ/FQnbJJ1CFoPs0b5 /1h8esRSWXRteL8326UpIcdEO/vAxUnsB2isAMecO/hT8OeEfGvKMWOJEuP8g0X75MGE zxz0EHrS/YMqvpJ5j+Vt9TNN+z2FWaady0aFglC5LJB3F2JeohyRkNpOf7t3jeBsJptx eQXpN1UQY8fja8NW4R6y0uTgYuN58Cw2fGTVXz/zYzDc5FfMd7xFVLzkQktNvY257Lp5 A7PUORfPoYfC1KBNoGCr4oDKeV/9AqZt1oGH5A6SfKMOpGg+Qx5yGymyuwcPoEapxVrQ lQWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679431581; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rtTyPgAyyTCsuj6xg05jXpazWd4/Ojg4wA/2tNBdu1s=; b=VdTheFf2jB/M9v7gkZC2acKrvQz6/PsCj8XlE/kYNZdr34TsRGYmd1vtnKn92qX/dq vUbsyJ7ZNfWN6Gc7u/bDYX35M0vYuKKTdV55qHG7WeDlg5foBrPDsed0ZGn/YkmV+jw6 Zj4XAEH9Po/N/HMhAjMl9YDcpd0482YGsBEoZptJaiGkL6ixc9YZkcb+cjZGEIAXcNpT 1OCzsz/qndVXRY82bj8QoYQWYM4Dy4oUv2hnRLP39PbjePjGkFT6yZXZAJhE//lunG4x +GXpbzHgI4B+nk+cWG0egXxwyajag7EijpLQdZFS0RCtLN42f2CeBmNCbQM8p3N1fZwb UfTA== X-Gm-Message-State: AO0yUKW3Lqx/m1X9xx9IQdgdPX1fZivSPSrDMV4NykcahbpTQGjEThLY dqk/kUZyNyWN8XsqXpTbCgfo/TsxjiI= X-Google-Smtp-Source: AK7set9BnZ4bM/xxg7ypwfZc8P2cRwJfe18HibEQw4HhoYPbGmd/BqiU8iQBnCtCF4L78CAscq6zRQ== X-Received: by 2002:a05:6000:136d:b0:2ce:a828:b248 with SMTP id q13-20020a056000136d00b002cea828b248mr3169695wrz.71.1679431581454; Tue, 21 Mar 2023 13:46:21 -0700 (PDT) Received: from lucifer.home (host86-146-209-214.range86-146.btcentralplus.com. [86.146.209.214]) by smtp.googlemail.com with ESMTPSA id a4-20020adffb84000000b002d322b9a7f5sm12142491wrr.88.2023.03.21.13.46.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 13:46:20 -0700 (PDT) From: Lorenzo Stoakes To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: David Hildenbrand , Matthew Wilcox , Vlastimil Babka , "Liam R . Howlett" , maple-tree@lists.infradead.org, Vernon Yang , Lorenzo Stoakes Subject: [PATCH v2 1/4] mm/mmap/vma_merge: further improve prev/next VMA naming Date: Tue, 21 Mar 2023 20:45:55 +0000 Message-Id: <6001e08fa7e119470cbb1d2b6275ad8d742ff9a7.1679431180.git.lstoakes@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4DF4318001D X-Rspam-User: X-Stat-Signature: mcbe6wzfwc9qibqmu46jfqf6ihtq1jm6 X-HE-Tag: 1679431583-524058 X-HE-Meta: U2FsdGVkX1/ZRp2N+FLEeQtuPVA9YZsZW+x73Hvbu5OJF25s7Ys26sTu8pP4mf8b+IW4bmfeN+Rl3jw9mGgKitGtJiWIT1e7JUBmfIYeicgnFHqRPvxPZneuof+Mfv+a/W6Oe3vF9KwlqmIwkgBzpRPzSZNunbjtkFnteM5izuBrEVo8sZZtdE2mIMctEROxajGGcGCc67ANGG7kk6lfC5fmR3qVZEHLW+a2BDdHMFnNE9bGw8yTLXZ+rCC2Acm3yP+zYPeWNesN0Xcl9px5EO7knWplCopT3ddieZqtc0IX0Dp29yvrwUn0hvX6HdV8BQwMCohQCUyURPRf0Po7CzmgtHI7YAQW3IES/qEvEsZffR/BaUQzBomniZm7AdNRCFMFyjxH07V2W4psOoepuO7qIeSyBwaBsWD0hznralpCl83KJZkmfIEBZI2oKhvc6lztZNTBygGGrEZiwBV05yYIWcKu9KAtLG1mEsWiLCBixTyJAUFe3PdoBKERZ431RUI45Jluakb70cdIb8csuBwDtoL7e2p0FHO2/mODA/iX7oMYyNtC++E86lUXzxvr0tSsD2n7Wo6JTQSmvkqEXA3xYV0WozowqgcLC3LuqwukVw6g0xLs3IMYlLF5IIvEZKpx8M7h1nNeGXt49YSmbcC0CSKybL7IUHd0c6ziuKhUuZupiCIb11RaaPctZHeN/EFAifEWZtKO1f2JUuLErr5cVDqkE8+lALNxOlYK+n8JatlnufkDOSY15KlzppJK29LEfx89Q3ncANtbu1xOtwfPcUnLLctgJ3yvIbYrwsIi5FjtnoVRByrJSbBoXGiTtRiSOJ1c0gpSsy6Ut345UhYqbGHJCfAZLJvg5s81NGdYfdZ8ycxLwO7moASC685TnnDee/GgmPxXBOvC5K+SZ61O1OZSDzMUGW8lR6yjMpN2L9ltICDs21Q7c1PuNzqTcSSOUjXAfELivqVIpxk uj05xLX5 m6Q+xmpuqWgjIrmjJe5u5O11KNB7PBLe74P0s+nXMhx5o+a8mpUrESIy0IeGA/J85lvpNnzuyQqtOxITH0GyIbYELN0+xbHh0sRj54Tnv65h01tdQ4tH12OfSy/Ju6SG6nrCec6cDa6EHjczxKFT9XbDUGdhEyZY+TiDH/jU4yutHk3u8dM0bDVsdKy5KeA/kBQra8IM3Jh9IPoV54S61hnNpj+shnn0kA7LB94yTbkAMY+J7Ob9h6Yav4IMASM7Rya/gha1+yNbO6L0CiKKoLglUVdmscasdVz9NBeLyc/QYtncRok1aV/vLO1N3E3nzfGOsHitxHEhgOqtEc0o66iP3KcOSnw0n0I+dgLoPzJo9Kd+pmrHy1D/IeBbm06O4HozZu39QlVdHRYHmTkpbptRADf7FJrBLY+LTaF47s8Rx5HCNM+3rmqxs/m2Vg0n2CZmhMHzWOCaiZlGLntn04EDqlZfSe343MylQVIy4NNgWc845HpMwxKBOI/aKC8GTg2Tw X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Previously the ASCII diagram above vma_merge() and the accompanying variable naming was rather confusing, however recent efforts by Liam Howlett and Vlastimil Babka have significantly improved matters. This patch goes a little further - replacing 'X' with 'N' which feels a lot more natural and replacing what was 'N' with 'C' which stands for 'concurrent' VMA. No word quite describes a VMA that has coincident start as the input span, concurrent, abbreviated to 'curr' (and which can be thought of also as 'current') however fits intuitions well alongside prev and next. This has no functional impact. Signed-off-by: Lorenzo Stoakes --- mm/mmap.c | 86 +++++++++++++++++++++++++++---------------------------- 1 file changed, 43 insertions(+), 43 deletions(-) diff --git a/mm/mmap.c b/mm/mmap.c index 042d22e63528..c9834364ac98 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -861,44 +861,44 @@ can_vma_merge_after(struct vm_area_struct *vma, unsigned long vm_flags, * this area are about to be changed to vm_flags - and the no-change * case has already been eliminated. * - * The following mprotect cases have to be considered, where AAAA is + * The following mprotect cases have to be considered, where **** is * the area passed down from mprotect_fixup, never extending beyond one - * vma, PPPP is the previous vma, NNNN is a vma that starts at the same - * address as AAAA and is of the same or larger span, and XXXX the next - * vma after AAAA: + * vma, PPPP is the previous vma, CCCC is a concurrent vma that starts + * at the same address as **** and is of the same or larger span, and + * NNNN the next vma after ****: * - * AAAA AAAA AAAA - * PPPPPPXXXXXX PPPPPPXXXXXX PPPPPPNNNNNN + * **** **** **** + * PPPPPPNNNNNN PPPPPPNNNNNN PPPPPPCCCCCC * cannot merge might become might become - * PPXXXXXXXXXX PPPPPPPPPPNN + * PPNNNNNNNNNN PPPPPPPPPPCC * mmap, brk or case 4 below case 5 below * mremap move: - * AAAA AAAA - * PPPP XXXX PPPPNNNNXXXX + * **** **** + * PPPP NNNN PPPPCCCCNNNN * might become might become * PPPPPPPPPPPP 1 or PPPPPPPPPPPP 6 or - * PPPPPPPPXXXX 2 or PPPPPPPPXXXX 7 or - * PPPPXXXXXXXX 3 PPPPXXXXXXXX 8 + * PPPPPPPPNNNN 2 or PPPPPPPPNNNN 7 or + * PPPPNNNNNNNN 3 PPPPNNNNNNNN 8 * - * It is important for case 8 that the vma NNNN overlapping the - * region AAAA is never going to extended over XXXX. Instead XXXX must - * be extended in region AAAA and NNNN must be removed. This way in + * It is important for case 8 that the vma CCCC overlapping the + * region **** is never going to extended over NNNN. Instead NNNN must + * be extended in region **** and CCCC must be removed. This way in * all cases where vma_merge succeeds, the moment vma_merge drops the * rmap_locks, the properties of the merged vma will be already * correct for the whole merged range. Some of those properties like * vm_page_prot/vm_flags may be accessed by rmap_walks and they must * be correct for the whole merged range immediately after the - * rmap_locks are released. Otherwise if XXXX would be removed and - * NNNN would be extended over the XXXX range, remove_migration_ptes + * rmap_locks are released. Otherwise if NNNN would be removed and + * CCCC would be extended over the NNNN range, remove_migration_ptes * or other rmap walkers (if working on addresses beyond the "end" - * parameter) may establish ptes with the wrong permissions of NNNN - * instead of the right permissions of XXXX. + * parameter) may establish ptes with the wrong permissions of CCCC + * instead of the right permissions of NNNN. * * In the code below: * PPPP is represented by *prev - * NNNN is represented by *mid or not represented at all (NULL) - * XXXX is represented by *next or not represented at all (NULL) - * AAAA is not represented - it will be merged and the vma containing the + * CCCC is represented by *curr or not represented at all (NULL) + * NNNN is represented by *next or not represented at all (NULL) + * **** is not represented - it will be merged and the vma containing the * area is returned, or the function will return NULL */ struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm, @@ -911,7 +911,7 @@ struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm, { pgoff_t pglen = (end - addr) >> PAGE_SHIFT; pgoff_t vma_pgoff; - struct vm_area_struct *mid, *next, *res = NULL; + struct vm_area_struct *curr, *next, *res = NULL; struct vm_area_struct *vma, *adjust, *remove, *remove2; int err = -1; bool merge_prev = false; @@ -930,19 +930,19 @@ struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm, if (vm_flags & VM_SPECIAL) return NULL; - mid = find_vma(mm, prev ? prev->vm_end : 0); - if (mid && mid->vm_end == end) /* cases 6, 7, 8 */ - next = find_vma(mm, mid->vm_end); + curr = find_vma(mm, prev ? prev->vm_end : 0); + if (curr && curr->vm_end == end) /* cases 6, 7, 8 */ + next = find_vma(mm, curr->vm_end); else - next = mid; + next = curr; - /* In cases 1 - 4 there's no NNNN vma */ - if (mid && end <= mid->vm_start) - mid = NULL; + /* In cases 1 - 4 there's no CCCC vma */ + if (curr && end <= curr->vm_start) + curr = NULL; /* verify some invariant that must be enforced by the caller */ VM_WARN_ON(prev && addr <= prev->vm_start); - VM_WARN_ON(mid && end > mid->vm_end); + VM_WARN_ON(curr && end > curr->vm_end); VM_WARN_ON(addr >= end); if (prev) { @@ -974,21 +974,21 @@ struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm, remove = next; /* case 1 */ vma_end = next->vm_end; err = dup_anon_vma(prev, next); - if (mid) { /* case 6 */ - remove = mid; + if (curr) { /* case 6 */ + remove = curr; remove2 = next; if (!next->anon_vma) - err = dup_anon_vma(prev, mid); + err = dup_anon_vma(prev, curr); } } else if (merge_prev) { err = 0; /* case 2 */ - if (mid) { - err = dup_anon_vma(prev, mid); - if (end == mid->vm_end) { /* case 7 */ - remove = mid; + if (curr) { + err = dup_anon_vma(prev, curr); + if (end == curr->vm_end) { /* case 7 */ + remove = curr; } else { /* case 5 */ - adjust = mid; - adj_start = (end - mid->vm_start); + adjust = curr; + adj_start = (end - curr->vm_start); } } } else if (merge_next) { @@ -1004,10 +1004,10 @@ struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm, vma_end = next->vm_end; vma_pgoff = next->vm_pgoff; err = 0; - if (mid) { /* case 8 */ - vma_pgoff = mid->vm_pgoff; - remove = mid; - err = dup_anon_vma(next, mid); + if (curr) { /* case 8 */ + vma_pgoff = curr->vm_pgoff; + remove = curr; + err = dup_anon_vma(next, curr); } } } -- 2.39.2