From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DF67EE49A4 for ; Tue, 22 Aug 2023 16:35:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8B0594001B; Tue, 22 Aug 2023 12:35:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1339280048; Tue, 22 Aug 2023 12:35:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8E1994002D; Tue, 22 Aug 2023 12:35:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 99FD094001B for ; Tue, 22 Aug 2023 12:35:07 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 702F61A03F9 for ; Tue, 22 Aug 2023 16:35:07 +0000 (UTC) X-FDA: 81152290254.04.1931DED Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf23.hostedemail.com (Postfix) with ESMTP id 9CA88140016 for ; Tue, 22 Aug 2023 16:35:04 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Pax4caF2; spf=pass (imf23.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692722104; a=rsa-sha256; cv=none; b=qHMFT8UEfvo25s35HNzHzFZ7TcW5qAM32DWvHNJmd0XSPEWi8CiD6RVCSRvDkCd86U5pnw PzPtSfBPnFaU5z4j51VqPLmSkLjq312E9iYgvARZ7OwM0Zrb8wipd2DMD0IavMwKQj6Xds r+UIFX+82cvv6IIwbwx+LIIdkQ9Ny9I= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=Pax4caF2; spf=pass (imf23.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692722104; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qt0ZLoOqT9+wpCm2Ny+8HuPkuahGjnCugCYXd8XlMx4=; b=CZhWbA6UdLviniOMXtA2xDk6/WTiNLe/eShnR/o8sBRk7pAqN2TcT4MtWj7vkGT/JQe2F7 gYo10MYRytsFzBAISb9srJ0HGMk+m22sysWUBj30R79Khnv2XwQenYHm+xnB2jXBelQA9S Xj+JTjv6qNBrU00NnpTZNNKMYd9Xack= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C1636200EB; Tue, 22 Aug 2023 16:35:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1692722101; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Qt0ZLoOqT9+wpCm2Ny+8HuPkuahGjnCugCYXd8XlMx4=; b=Pax4caF2Ef7NBtayR04STCzFqckSNupMb66tw35QjhgWvF9+wKzVgjJBg9YlG0KcbLsLZ2 oCi24HsoJGkFuND2JYvuNfi4s3gIN/HH/BaylrFafuhYEdWG+9nZ1ta4ax3RchF+ksp0vy C1CLitUshYgpH557xXomFZYOIxXdAA8= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7A2CD13919; Tue, 22 Aug 2023 16:35:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9zIEHbXj5GRMXgAAMHmgww (envelope-from ); Tue, 22 Aug 2023 16:35:01 +0000 Date: Tue, 22 Aug 2023 18:35:00 +0200 From: Michal =?utf-8?Q?Koutn=C3=BD?= To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Ivan Babrou , Tejun Heo , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] mm: memcg: add a helper for non-unified stats flushing Message-ID: <5y3e32ek6owren3q5e3gzonzxzdhs53ihywj3mtbhz56hnizfy@fctafygsnfaq> References: <20230821205458.1764662-1-yosryahmed@google.com> <20230821205458.1764662-3-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7f63xjlvpzzrd5op" Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 9CA88140016 X-Stat-Signature: 8rso8476brdgkxaxi66dcijer19s9a39 X-Rspam-User: X-HE-Tag: 1692722104-971486 X-HE-Meta: U2FsdGVkX18x7rQQkw6yQd585vSSOL9b8+Pd4Tl7upeH2PX1X7FHtXu/BQtKYEAs66lkpbcytjajgO40LTfeiPhkD2R5x6VkV7mdtCiDyexIns9nKDL6HO3UdFoEiC6SRzXzsoUFqUoTbk0BfxWDzVV3vGbXrdfLzJvOt5nLjcS/NGMEmBFkIkrwtaV1BDw/M+oWDd4SHcLQBjuhy4eS/nAnhEDLYr8vmA+1q8O8s02x8vTrNKpk8updHFviTYr7hvjAKqpL6bddZR3TtcYQhl/5hOGtO/RQiWs9m8nKL9/haU6inrhVR24jccK+NeXev8VMtRTFMGYNoMZ4y0uyqfZ+qMvPNTmvOrqQYwLzFzvdgiT1iDxQ7VN/qhQXZm2g174qPo07fmZcQxJ9jz9/8npxZ+sUutEIVjga29HcJO7mPFzv6f4Szb1TcICOEjpltbl4tDoDI/uvBlfzAVOkDotqIHkkPQ0dLvhq+ZkfzwDDhPt0PxUfvk2N25iAf8ev52wM89+VqdiH1oQcLJx/PjiKOfAglEYDWNXR4hzv8KsudIkJbCeVA05Y569SJDWxuArfGCr6jCBf9/UmJo4TzLzvGPzn9B6oijehpxCdKeysHAXH+jDzbVhA8OEzqMJ6kbold1uyefEB4ahkiXx62AUCf/o+eMjYTwZPO/VZazulihOGRtEnEpOKEZNfBqiNR2cyNQtEh4IyFlp1/hRDL+kewAFhV3sFt+Ma/tHCl6peTY1EBtvhrIznTI42hFM4SNNU9x0Qur+fbvZMcr8IOSxGzgv1uVCVVrYPjg8v10HRzz5yNFrsH9X3dwjRLoIuOc4NRjHsZEpNvwqkryOZjMBTArDtv27P6TcrEy6Y6RsIZPSrHmALThulu4qdgyo2nFa006dPV1FebdiU+7wmMwCT3BDc5AakWWAT40WLBDM+9X9wpkfbVqGTaETYyfevx6WjbrbaBpdI6rL1Eam nl5lGXbt 07Ni5MCmJWxOY13oduCYB7KDajUVL9xylGe01/cFnfTViFbKaG7S9L9BQd/ThbhqSLV4fxTdjU6ngbMBUKfuJNFIrY7/tFKRH46+65wcK1TBdwNlgg2E0ove3aJljTJ8Q3WWMirdoMCZHuoRJMroFyE+AwqSMLzF6y+kzWqoNW/AYDbuHb6QimmqZgGyGpnyEK4sUHr/gS6SwwjIs4/c4yw5hNvn+dQoyB7W7c33/YMxQA5sWo2iwXWAqKP+kvcJ8xZqs9F/NWw7hmTzMVsyRSDCvKtbNEfSJioByXY5UdN9FoI9mT6jm7HFDIxkhjJMYP/Pxy34/XOBkl5+yknGGsJQcavBwA4GYpFYNlbkG/2frrb4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --7f63xjlvpzzrd5op Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 22, 2023 at 09:00:06AM -0700, Yosry Ahmed wrote: > We can probably also kick FLUSH_TIME forward as well. True, they guard same work. > Perhaps I can move both into do_stats_flush() then. If I understand > correctly this is what you mean? Yes. > What do you think? The latter is certainly better looking code. I wasn't sure at first about moving stats_flush_threshold reset before actual flush but on second thought it should not be a significant change - readers: may skip flushing, the values that they read should still be below the error threshold, - writers: may be slowed down a bit (because of conditional atomic write optimization in memcg_rstat_updates), presumably not on average though. So the latter should work too. Michal --7f63xjlvpzzrd5op Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQQpEWyjXuwGT2dDBqAGvrMr/1gcjgUCZOTjsgAKCRAGvrMr/1gc jnZMAP9j2epDKDEIrW1B1fJASKjVt5dkRJM2SCYyQNX6oNKqUAEAnUs7Pg88u8E/ lU8WkkS7hOz1ZQ2abpo1AtoV7nqS6QU= =FEfo -----END PGP SIGNATURE----- --7f63xjlvpzzrd5op--