From: "Michal Koutný" <mkoutny@suse.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Shakeel Butt <shakeelb@google.com>,
Muchun Song <muchun.song@linux.dev>,
Ivan Babrou <ivan@cloudflare.com>, Tejun Heo <tj@kernel.org>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] mm: memcg: add a helper for non-unified stats flushing
Date: Tue, 22 Aug 2023 18:35:00 +0200 [thread overview]
Message-ID: <5y3e32ek6owren3q5e3gzonzxzdhs53ihywj3mtbhz56hnizfy@fctafygsnfaq> (raw)
In-Reply-To: <CAJD7tkaVuiMU-ifJiyH5d_W1hi9DnAymYJxzBxEKCVX+tU=OCA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 785 bytes --]
On Tue, Aug 22, 2023 at 09:00:06AM -0700, Yosry Ahmed <yosryahmed@google.com> wrote:
> We can probably also kick FLUSH_TIME forward as well.
True, they guard same work.
> Perhaps I can move both into do_stats_flush() then. If I understand
> correctly this is what you mean?
Yes.
> What do you think?
The latter is certainly better looking code.
I wasn't sure at first about moving stats_flush_threshold reset before
actual flush but on second thought it should not be a significant change
- readers: may skip flushing, the values that they read should still be
below the error threshold,
- writers: may be slowed down a bit (because of conditional atomic write
optimization in memcg_rstat_updates), presumably not on average
though.
So the latter should work too.
Michal
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-08-22 16:35 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 20:54 [PATCH 0/3] memcg: non-unified flushing for userspace stats Yosry Ahmed
2023-08-21 20:54 ` [PATCH 1/3] mm: memcg: properly name and document unified stats flushing Yosry Ahmed
2023-08-21 20:54 ` [PATCH 2/3] mm: memcg: add a helper for non-unified " Yosry Ahmed
2023-08-22 13:01 ` Michal Koutný
2023-08-22 16:00 ` Yosry Ahmed
2023-08-22 16:35 ` Michal Koutný [this message]
2023-08-22 16:48 ` Yosry Ahmed
2023-08-21 20:54 ` [PATCH 3/3] mm: memcg: use non-unified stats flushing for userspace reads Yosry Ahmed
2023-08-22 9:06 ` Michal Hocko
2023-08-22 15:30 ` Yosry Ahmed
2023-08-23 7:33 ` Michal Hocko
2023-08-23 14:55 ` Yosry Ahmed
2023-08-24 7:13 ` Michal Hocko
2023-08-24 18:15 ` Yosry Ahmed
2023-08-24 18:50 ` Yosry Ahmed
2023-08-25 7:05 ` Michal Hocko
2023-08-25 15:14 ` Yosry Ahmed
2023-08-25 18:17 ` Michal Hocko
2023-08-25 18:21 ` Yosry Ahmed
2023-08-25 18:43 ` Michal Hocko
2023-08-25 18:44 ` Michal Hocko
2023-08-28 15:47 ` Michal Hocko
2023-08-28 16:15 ` Yosry Ahmed
2023-08-28 17:00 ` Shakeel Butt
2023-08-28 17:07 ` Yosry Ahmed
2023-08-28 17:27 ` Waiman Long
2023-08-28 17:28 ` Yosry Ahmed
2023-08-28 17:35 ` Waiman Long
2023-08-28 17:43 ` Waiman Long
2023-08-28 18:35 ` Yosry Ahmed
2023-08-29 7:27 ` Michal Hocko
2023-08-29 15:05 ` Waiman Long
2023-08-29 15:17 ` Michal Hocko
2023-08-29 16:04 ` Yosry Ahmed
2023-08-29 18:44 ` Tejun Heo
2023-08-29 19:13 ` Yosry Ahmed
2023-08-29 19:36 ` Tejun Heo
2023-08-29 19:54 ` Yosry Ahmed
2023-08-29 20:12 ` Tejun Heo
2023-08-29 20:20 ` Yosry Ahmed
2023-08-31 9:05 ` Michal Hocko
2023-08-22 13:00 ` [PATCH 0/3] memcg: non-unified flushing for userspace stats Michal Koutný
2023-08-22 15:43 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5y3e32ek6owren3q5e3gzonzxzdhs53ihywj3mtbhz56hnizfy@fctafygsnfaq \
--to=mkoutny@suse.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=ivan@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=tj@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox