From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5520AC54755 for ; Wed, 14 May 2025 18:34:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9A906B000A; Wed, 14 May 2025 14:34:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4A636B0082; Wed, 14 May 2025 14:34:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0FDE6B0083; Wed, 14 May 2025 14:34:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 840236B000A for ; Wed, 14 May 2025 14:34:30 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0F156141066 for ; Wed, 14 May 2025 18:34:32 +0000 (UTC) X-FDA: 83442363984.13.12BB8F2 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf14.hostedemail.com (Postfix) with ESMTP id 6994810001B for ; Wed, 14 May 2025 18:34:30 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=s6iu+8sL; spf=pass (imf14.hostedemail.com: domain of alx@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=alx@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=s6iu+8sL; spf=pass (imf14.hostedemail.com: domain of alx@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=alx@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747247670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VWRHfTV0h+Yo3bob1h+7U5RABVIm3Enb+/MtbT0Z7mo=; b=ganAg2ciG6j7rsDSvrvUwDuqHyiq90sFGuHSeUuB3a50QiHNBPPvDoD031nU85gjX3glZU No/xz36HwLEYe+3RzeXdM3Fo6PVvCo07onvJ5eRSAo42g4ZIOQUCfS6FZ8ypdW/2faUctF yhhxMfar20e5sQrk4Tw65r4O81zCCKM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747247670; a=rsa-sha256; cv=none; b=6Zk6VuJN9TxF9ZwBAR8MYNGXlD25TZtBuWmwJoVZkPBymeA/lRJvWqw5ZtOjWhxf0xevO/ J5TmHgQuydWQE00OnLgQk3A8rf1/Ir7320RleEzbWN3HoOWC1GWFlyezOYbM3z5Hj2gEr3 h1BKw7GS5WnXfCitipjy8JCTgTp6IjA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 6BA0A629DA; Wed, 14 May 2025 18:34:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E432C4CEE3; Wed, 14 May 2025 18:34:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747247669; bh=US4aMCr9h+WIzJSiaRZrpBVDIR14dmQ8/DnZa3W4o7Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s6iu+8sL2/BvGbxTQIOVB8zGB5TvpCCK0h08Ln2eKbgBZXeRgyQS/fiY8VZ6JUJNB 7MfklHG2YVDenP+Q8257867VjrJqTYVol+1cnVKlgx1+qSIRVLG+hslyDd9WKG8YfZ 25Tb2XJfKLemZ8DPZroh24tSFpe6mZVPwhSBmEdJjuAs4dHnS+3XmgbuAgALQh33gS vGcryxCXqQvbCjE1M1wAdjL4W2XJeQ2CJjsfotSgzht32JdS5srZcah+5GBsf1zkm9 rm9SoNd3wYDik0EXcvnuMbQuYUbxwkuktRwLCXqI3fZlQVqEayt1WYC2ihKExdmZr1 XVEscTve40cVg== Date: Wed, 14 May 2025 20:34:22 +0200 From: Alejandro Colomar To: Peter Xu Cc: linux-man@vger.kernel.org, linux-kernel@vger.kernel.org, Andrea Arcangeli , Mike Rapoport , Axel Rasmussen , Kyle Huey , linux-mm@kvack.org, Robert O'Callahan , Suren Baghdasaryan Subject: Re: [PATCH 1/2] UFFDIO_API.2const: Update userfaultfd handshake and feature probe Message-ID: <5ttjhxdolfulke72aqi25tv5gfww7jl2cwtwgp6lu4zp66hl3d@kwowsvdhuju7> References: <20250512171922.356408-1-peterx@redhat.com> <20250512171922.356408-2-peterx@redhat.com> <6eobuzkwm6xhpis4s52dtit55fws37elv5d7zygaf64czcjag6@brz2nrc6qptu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hqfungowftzawdun" Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6994810001B X-Stat-Signature: xhpkj1bh1pwxbibc1zy1aoka58p5pfa3 X-Rspam-User: X-HE-Tag: 1747247670-318007 X-HE-Meta: U2FsdGVkX1/orcqQSfgojS+AYrRDqLYUX74dI+PjMwsGjjMBFifOpgJ10EBe3KOg9/IRAykvysqw/8oXsszx+9HKPC07XtseFBdHNINZNGxq+l/NMcp9Qf0r3M5kLxIwjblkBqgTVmbrv71jzrDoXtFkrnjz1NrIC/q8N6mPvPZ31qMWGDFYenQJFmoGye+neMOoQ71ZiLrxyXJ+YhIB6hqlGusICGxwmWRSWLU4wMYDSNcLVslA2g1jjfkGvGbzOvQiMAJug6wjM7ZaTCP/ZJ0PvMjU21UKuxImrFtAFqfZcLtjzMopk/D35yjTlgR+d40r4CkLbrWuwgIrZuWz0nmgil9PkpEkq2AmCP+7atWdSPiAhf+1Z4Z8ILUKFrt4XMR3nvFKqKbrmzxU5vR5m9cPr75vCFiMfv5TTAdiTKwDOXF6GLebgQxyMFbwvKCvx2M9bYBR1YL2vpmj4f0T5S+y3VNvt+3JH2JioEBmIXPiEm0EZiIhS0hDXipZ+1shngQ7bpetwJsq+DtFSOx+jVVhMuWcLitLNcajFcTiEYJXdjxcV3VjzPTHuF6STwH0MqzV1TtJMW5b0DbjikdC52K59BO2nnI7rfhqji0Fn2aFh/SU1aSavtpPNWFfqLttN4U7lNtIeTSOxMA1HGjftbt2rp8sDBa45SvqY6F3bJwVox+wlsNah8yIYLJpDEY2v/ajfc9v2ubD7J4sEPEbKMj/CmWor7AqbdW8mInRY1VoGurpsZWZ2qvwEU6IwHVo8vdu4y2rVmi0GOuSCz9nZw4n1UcvIgueGxk1tv0VZ9l3LRSTAFq3CtiOjGYM5n8mrPHhllwKjBM6LjRmtom6VM8mg1jWMXgpSXkQLb1QPUnyyonwnYfF9fC7F8fnxlPxYWMwO5+oDNhjmqOU9NFM82QkDiy6ygfQZpIMI4DBsogTQMacVwUH1+vpz+ssXJduz6FU0ExrR9X5flDu/Wu P1KwP30F LnUXde2HtmO2f3XFWoLKxKs1d43CIfRi9Yg0IjMl90Q/tZtyAfFaI+XHkXuXIqRNVFulC+KglgMvuOITmGdfs1PSt6LWH/2D8KqvCGHw+PnEsKjFIleTxaFDB/YPfRFUc66gPh+Y/MMYsrheYQC+yOGAlKdrvDded6NtJ4zRHnpoW1zP479FRLgUFXB56koW2XdjhyOP/zSeEjBJpwcF2XgyfFyS4MyCvLJp/dTq45XdJ+iN+0tgNAIpjdudDM1fAt419Q0ex325fOwXegSte/0pl5pEDwP8o06geW5V4kzEQTKCKN0Nb8Ydw4G4S6Abjsw7CIAV5wxDqkr4uaH9PxNHgA8sgS+dg8eC4d4Du0MaSC5fT2nWjSrIwcTGLp45ff19zbizr0I3a9P0zuhq0p04r6R2l3vh0MeuG56UmZnca8+rQ2M9qlTtWBEmaiGMey2/aUM5Nmoc69Ak= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --hqfungowftzawdun Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable From: Alejandro Colomar To: Peter Xu Cc: linux-man@vger.kernel.org, linux-kernel@vger.kernel.org, Andrea Arcangeli , Mike Rapoport , Axel Rasmussen , Kyle Huey , linux-mm@kvack.org, Robert O'Callahan , Suren Baghdasaryan Subject: Re: [PATCH 1/2] UFFDIO_API.2const: Update userfaultfd handshake and feature probe References: <20250512171922.356408-1-peterx@redhat.com> <20250512171922.356408-2-peterx@redhat.com> <6eobuzkwm6xhpis4s52dtit55fws37elv5d7zygaf64czcjag6@brz2nrc6qptu> MIME-Version: 1.0 In-Reply-To: Hi Peter, On Wed, May 14, 2025 at 01:21:17PM -0400, Peter Xu wrote: > On Wed, May 14, 2025 at 05:59:48PM +0200, Alejandro Colomar wrote: > > > +.P > > > +For historical reasons, > > > +a temporary userfaultfd is needed to probe > > > +what userfaultfd features the kernel supports. > > > +The application needs to create a temporary userfaultfd, > > > +issue an > > > +.B UFFDIO_API > > > +ioctl with > > > +.I features > > > +set to 0. After the > >=20 > > Please use semantic newlines. Break the line after the '.'. >=20 > This one was overlooked indeed, will fix it. Thanks! =20 > >=20 > > $ MANWIDTH=3D72 man man-pages | sed -n '/Use semantic newlines/,/^$/p' > > Use semantic newlines > > In the source of a manual page, new sentences should be started > > on new lines, long sentences should be split into lines at > > clause breaks (commas, semicolons, colons, and so on), and long > > clauses should be split at phrase boundaries. This convention, > > sometimes known as "semantic newlines", makes it easier to see > > the effect of patches, which often operate at the level of indi= =E2=80=90 > > vidual sentences, clauses, or phrases. > >=20 > > Also, please say "zero" instead of "0", as was in the old paragraph. > > That will allow git-diff(1) --color-moved to detect some movement of > > text. >=20 > This was not part of the old text, but sure, will do. I know you've completely rewritten the paragraph, but even then, parts of the old text remain (maybe because however you write it, some parts need to be said). -.I features -field set to zero. This part is kept in the new text, even if just by chance, and it might be interesting to see that in git-diff(1) --color-moved. Have a lovely day! Alex >=20 > Thanks, >=20 > --=20 > Peter Xu >=20 --=20 --hqfungowftzawdun Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEES7Jt9u9GbmlWADAi64mZXMKQwqkFAmgk4igACgkQ64mZXMKQ wqmj4hAAgRxz4rSoq+wezhJH20C+of2dSCloeCFk8LaEAOXal4mFZADa8ndeCKVj tw3RuzzmFvValDlaVVM3R6jI8ujsGSjE+ZVdT5Xye+WDScCh438QryjHPtTZp9b6 Lq21mXgrjg63uC8GhJ/LUNu3O/Uksik5mOOvDV5RBZYVsm2hpUKlrAl9RtwzRXQA 5npMzCZbMlZBH7LxahktaErX7X4YsGwp9KnuUWQqPdQb6P5APN2mNqjA5nJlUYQ0 XovB3N3mVNjZ7YnTF/dbIiGKvWYg2K2W9U5oarVIZ0Gv73K77lGOxiagIEL8y98i kDXkMztKrHbYV0lLLLM+X4enQ+cK0/USpHtKMrdbPtdhGlN7gWyzw+IgXwOr/mUl Jh0nUGmC0PWbP7xSCCsEvk3dr3H/zTw7o/335yrchPv5KwUK24ozReLHqxFVLvpI dqh9Si43Ro1MCFbRpp5hUd7KbsdMY75C+MZYeDCF+ouYF2+WdJAOXGSJkWqEfG6H lhkCuihV6JedgvB+7q19jMhve09CrObIrQ0PdAyqZqi3F/hdsqfR1FwvNtf3GU47 aQQAn/IxXSr5lDEzkhLdYid32++oWbg0053wgf28bej0Ckg6mzJ3jZVUgzvpOwhJ 3139n4woCcVUTfMh8Pwoi6IuWhbgZAfXB6uFOkE9MLHfdnMPwbA= =nCgI -----END PGP SIGNATURE----- --hqfungowftzawdun--