Re: [PATCH 1/2] UFFDIO_API.2const: Update userfaultfd handshake and feature probe

[Alejandro Colomar <alx@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1906 bytes --]

Hi Peter,

On Wed, May 14, 2025 at 01:21:17PM -0400, Peter Xu wrote:
> On Wed, May 14, 2025 at 05:59:48PM +0200, Alejandro Colomar wrote:
> > > +.P
> > > +For historical reasons,
> > > +a temporary userfaultfd is needed to probe
> > > +what userfaultfd features the kernel supports.
> > > +The application needs to create a temporary userfaultfd,
> > > +issue an
> > > +.B UFFDIO_API
> > > +ioctl with
> > > +.I features
> > > +set to 0. After the
> > 
> > Please use semantic newlines.  Break the line after the '.'.
> 
> This one was overlooked indeed, will fix it.

Thanks!
 
> > 
> > $ MANWIDTH=72 man man-pages | sed -n '/Use semantic newlines/,/^$/p'
> >    Use semantic newlines
> >        In the source of a manual page, new sentences should be  started
> >        on  new  lines,  long  sentences  should  be split into lines at
> >        clause breaks (commas, semicolons, colons, and so on), and  long
> >        clauses  should be split at phrase boundaries.  This convention,
> >        sometimes known as "semantic newlines", makes it easier  to  see
> >        the effect of patches, which often operate at the level of indi‐
> >        vidual sentences, clauses, or phrases.
> > 
> > Also, please say "zero" instead of "0", as was in the old paragraph.
> > That will allow git-diff(1) --color-moved to detect some movement of
> > text.
> 
> This was not part of the old text, but sure, will do.

I know you've completely rewritten the paragraph, but even then, parts
of the old text remain (maybe because however you write it, some parts
need to be said).

	-.I features
	-field set to zero.

This part is kept in the new text, even if just by chance, and it might
be interesting to see that in git-diff(1) --color-moved.


Have a lovely day!
Alex

> 
> Thanks,
> 
> -- 
> Peter Xu
> 

-- 
<https://www.alejandro-colomar.es/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]