From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03E02C4828E for ; Fri, 2 Feb 2024 12:44:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 865AC6B0085; Fri, 2 Feb 2024 07:44:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8156C6B0087; Fri, 2 Feb 2024 07:44:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DD1B6B0088; Fri, 2 Feb 2024 07:44:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5D9026B0085 for ; Fri, 2 Feb 2024 07:44:56 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F11931A0FC5 for ; Fri, 2 Feb 2024 12:44:55 +0000 (UTC) X-FDA: 81746833350.13.9BD571F Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) by imf24.hostedemail.com (Postfix) with ESMTP id 3DAD818001B for ; Fri, 2 Feb 2024 12:44:53 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="SlpCS/bd"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706877894; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+4SlfiygKKU71t9L+sMrkvrsvHoKpZtEQA/tb9zLLPM=; b=1Ad3CYH0+aTqems8aV3qog5DMY1kjz7uotbdic2Zg5YcYfOCIgskUet4h93uW8lRG39eiK d78QnAEaGrXO/+DAX8TYVQLZBlPIPeSiuj6sTNbbTnM7Fa/HycWuLXi/ZP4eJPTcl4yb2C yz2b0Rwn/59eba7+v20ZIX+JVDNGmBc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="SlpCS/bd"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf24.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706877894; a=rsa-sha256; cv=none; b=Y/XHiDaFQtm1ceuFtSr4HuRl/yY5nOXWbKnd0IY2zxlmI3ledv2xLNNXzHFUL4GSVZQzVk cFvWkwOkSv9zdkxZGgONSSsLhpkmVbJBrZ0EScplrvJrwao/9FIkv6OFoxwoyeqoqYXvyo /926aVIuU0QkMgOVlkYs1J75ifClS4Y= Date: Fri, 2 Feb 2024 07:44:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1706877891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+4SlfiygKKU71t9L+sMrkvrsvHoKpZtEQA/tb9zLLPM=; b=SlpCS/bdhzDa+bf30mWqy7EztHUGK+oQiaKSEL8XdbHHEhVxax1L9Yfg0nPZph92WHuU+3 ovtfsAt/P0rcm2fDuJudu2fhA9sLWyEE595ZQOCEyhEye8t70SRcuSv447t2m8kccSoW4R vSTkTA5DePn9KJzo3h0SzgjxpkHnIgQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: David Howells Cc: Miklos Szeredi , lsf-pc@lists.linux-foundation.org, Matthew Wilcox , dwmw2@infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [LSF/MM/BPF TOPIC] Replacing TASK_(UN)INTERRUPTIBLE with regions of uninterruptibility Message-ID: <5s7h6lemzjmpsqv57vodupeumkmjqga74sso27nrwgxpg2aq2g@qn72mescc5k3> References: <2701318.1706863882@warthog.procyon.org.uk> <2704767.1706869832@warthog.procyon.org.uk> <2751706.1706872935@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2751706.1706872935@warthog.procyon.org.uk> X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3DAD818001B X-Stat-Signature: 371bo6x3ofgrrihxns5ee4gt5hwqgm49 X-Rspam-User: X-HE-Tag: 1706877893-113846 X-HE-Meta: U2FsdGVkX1/BZtLSYVJw/V/PlD0dMH3Fj7WSZ/qe5P1tvwPf+z3rBI9sg4DaOPhND0iKdE0iL71rd0e4X3SSkGShANvfr1QfFV5MRlT/SdSk/Vou0bLIiZ3jz4cqzKO/w0xzRvSq5R+doW88qOq6QNzlmcV5AkteOMXAGaU8T10dQh9xjmmcU/Y6ctDWKhoN6vDn3sLAa5OYyflroAG7tIsqCqUo3e8IQkLoM/mr90rCodoFkwExD0tx35dsJD2bFGSr2frzlpFMnhahd0801f5y9Sqz4rQuBPVKz4E7mY/O6RNazRTgp3JizF9cjEA18Et256z2059k/ZmYkpzDUBd1lzrY62g/lj8jVyBfw8kKnG/TZDwnkl6m2yUPSQb9E6UYISrGAGeGdgwEsE0A755g5xlc/YvQ8DJrVKvZdm6H7+sP4qXOAo48RMTMIZhfTWu6c9ZOMRElOBXXPJTWwSIe67NzIvvlDk+liS56zLeOe0fUAnWuJOk6nUDfGFfiPAGIxvbJxpan18w6Z1aL/cSUT6HLtLudTGLGjdnDfMBs3W4OyILrnb3jmVVodY2pOK6Wmp9/H131hOcjhokatmYp55EHyBqWvvZPzVEu9fcO7yTZ8FmzV/1FL9dhyw18Ccxdqa3MJepMYLzoLPPRMITw91EqRz/qWUbM7ye6Q/e7OryoEYaczfTmq97YqTWRRLL3BbD7RVo2v5rcmi3gHeBfgIc8Q2Lp1LOdsoi7jLOc5b+vYdbznaAYGvsArJfPaKCx9+Vd0PxV2Atx387jlm2QkVXhjmlM5No2Em/Eq5KadjWcnm9rmkTAMn7V6MZTdcBQoMEmjgiLG22VuTtlERPl4iKxefCs X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 02, 2024 at 11:22:15AM +0000, David Howells wrote: > Miklos Szeredi wrote: > > > Just making inode_lock() interruptible would break everything. > > Why? Obviously, you'd need to check the result of the inode_lock(), which I > didn't put in my very rough example code, but why would taking the lock at the > front of a vfs op like mkdir be a problem? Existing callers don't check for errors, so maybe-interruptible-depending-on-context has to be a new function. > > For overlayfs it doesn't really make sense, but for network fs and > > fuse I guess it could be interesting. > > But overlayfs calls down into other filesystems - and those might be, say, > network filesystems that want to be interruptible. yup, and our interruptible vs. non interruptible stuff has always been a wacky patchwork