From: Kent Overstreet <kent.overstreet@linux.dev>
To: David Howells <dhowells@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
lsf-pc@lists.linux-foundation.org,
Matthew Wilcox <willy@infradead.org>,
dwmw2@infradead.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [LSF/MM/BPF TOPIC] Replacing TASK_(UN)INTERRUPTIBLE with regions of uninterruptibility
Date: Fri, 2 Feb 2024 07:44:47 -0500 [thread overview]
Message-ID: <5s7h6lemzjmpsqv57vodupeumkmjqga74sso27nrwgxpg2aq2g@qn72mescc5k3> (raw)
In-Reply-To: <2751706.1706872935@warthog.procyon.org.uk>
On Fri, Feb 02, 2024 at 11:22:15AM +0000, David Howells wrote:
> Miklos Szeredi <miklos@szeredi.hu> wrote:
>
> > Just making inode_lock() interruptible would break everything.
>
> Why? Obviously, you'd need to check the result of the inode_lock(), which I
> didn't put in my very rough example code, but why would taking the lock at the
> front of a vfs op like mkdir be a problem?
Existing callers don't check for errors, so
maybe-interruptible-depending-on-context has to be a new function.
> > For overlayfs it doesn't really make sense, but for network fs and
> > fuse I guess it could be interesting.
>
> But overlayfs calls down into other filesystems - and those might be, say,
> network filesystems that want to be interruptible.
yup, and our interruptible vs. non interruptible stuff has always been a
wacky patchwork
next prev parent reply other threads:[~2024-02-02 12:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 8:51 David Howells
2024-02-02 9:08 ` Miklos Szeredi
2024-02-02 9:43 ` Kent Overstreet
2024-02-02 10:30 ` David Howells
2024-02-02 10:46 ` Miklos Szeredi
2024-02-02 11:22 ` David Howells
2024-02-02 12:06 ` Miklos Szeredi
2024-02-02 12:44 ` Kent Overstreet [this message]
2024-02-02 16:23 ` Al Viro
2024-02-03 17:27 ` Kent Overstreet
2024-02-02 13:28 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5s7h6lemzjmpsqv57vodupeumkmjqga74sso27nrwgxpg2aq2g@qn72mescc5k3 \
--to=kent.overstreet@linux.dev \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lsf-pc@lists.linux-foundation.org \
--cc=miklos@szeredi.hu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox