From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13AB4C25B75 for ; Sun, 19 May 2024 18:02:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 524866B0085; Sun, 19 May 2024 14:02:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D4BE6B0088; Sun, 19 May 2024 14:02:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39BCD6B0089; Sun, 19 May 2024 14:02:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1D03C6B0085 for ; Sun, 19 May 2024 14:02:49 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 8EC4C160AD2 for ; Sun, 19 May 2024 18:02:48 +0000 (UTC) X-FDA: 82135916016.19.C81412B Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) by imf17.hostedemail.com (Postfix) with ESMTP id 8F8EC40028 for ; Sun, 19 May 2024 18:02:46 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=bSKda03q; spf=pass (imf17.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716141766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QxWT6yFeaOauY+SRIXUcV0VmlDaq8Ucmr4A+eczzPDg=; b=NpYp4kbwntRr3CZnojk7YdEFOdbb9Uq5keMLLv7uIZKAKhcsNbxEd6N6/sIMWOOta01lM+ stIbbNGd6BBNn/ONR68V+SsyL1YA9807Y2SPWe9ENwM4c+UWUtaWSmkJTcZwH8lP0E1GQb FfV4ATCzgjtq4QUFx+qVsaqWncUfvDU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1716141766; a=rsa-sha256; cv=none; b=u7UARKdh1rNxZsy/gr1eLHpPzBvWE0tI1rqQwPlrHGIqAf6YxGclni5M/21k8CemkPgcsX PKKRmRmxK0Sfaht7/3sFcZrtzoiud3/F77uUvVXK5Gz7oiTsHXi8wmsRUfXSs93S1hKgKr A1zn/jDC7i0xkdfhGNaomkZOLxAfVEQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=bSKda03q; spf=pass (imf17.hostedemail.com: domain of kent.overstreet@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=kent.overstreet@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Envelope-To: torvalds@linuxfoundation.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716141764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=QxWT6yFeaOauY+SRIXUcV0VmlDaq8Ucmr4A+eczzPDg=; b=bSKda03qak4LPyrSaarBvNgu2qR0QRx7q9MRbSwN1KXH34CJsWxmxrsM5RozDdhMWkehGl XHkq7D91uA9QZMvOdEmokZbyZg/noDv1jvmKlVvE4UWW5XQy5Y8OJ0IaTrJuGiSteBhTGP 6g+X6WWkr9DcLPVc7pyPSJMYpViBMeE= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: mm-commits@vger.kernel.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Sun, 19 May 2024 14:02:41 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Linus Torvalds Cc: Andrew Morton , linux-mm@kvack.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] MM updates for 6.10-rc1 Message-ID: <5qcafqbnrox7r5m4kghgykahtp2pusmhwfxqzrmhgvavxxsdux@ao2tce7nppey> References: <20240517192239.9285edd85f8ef893bb508a61@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 8F8EC40028 X-Rspam-User: X-Stat-Signature: 3imn6ib9gs8iobq4ugq4hrzk6tfruhfz X-HE-Tag: 1716141766-253459 X-HE-Meta: U2FsdGVkX1/2ke4BxuRKy5NMaWUG8BzzN5juknk/KsFHJoVLiBAjFyfIWA3B239RX4haUIu7tAC2p5DDyapB6OSNhYshTbfX10cci3jQeyEVo5p9pgRKEzHlIB9kxN7WrF47YP/rFV8w+57RLHyuiyGEzBQpSz2rcxD/A4KmhUF39ewh6+r2kWc1CZ/mQeyZmJPNbqPZi2KoCJJF75V59NqJsXyv8hQciAu4Ut92dPzQ4lvzVCb9980sYpSbt3RjBj/QccfeOn4ZGB6Ud8zFEWp4maByUUx7572e7cQC46RF0It5qwWwT0JmXjztG08nikkANIbkaZvc+xPe6GfC1X6fgSc81bi0EA7ZIOER/rbOKdSXeNBTIFJdPr+8gYnyXhm1Y/TbTpuF79Z/esWSUO26NU4CrE4HIZv8nuU398h4miFjo2DKKM9jr57wpV3PXjHegZs/s4JfxFF5EAd4UJT0sY42FcHusAnEm0bI3oV4SSGH5qFZsdOtGMV2iyhzEgHdG+BbFHVxuqTE73R0Gxs6fzKbasOTxistI3GMYdgboaUGc+7bH0fStWx8Vu0iF+6hA0kSwzxexQSDiO/f2lg65YVexYk8d4hbG1PKNtKauoyngNrDF0cs1QeUibGkEAR6yFC/IbxFoFLf3JEWHnV0d2+H5IY2DQSkTSZKO/wKMDPQqKDQzd8KeIRGrATwXxf2C51EWsaJeJNpvDpsKTFcZ0Ns+IRovGHmyvEfCBStKKTlt7xeDp/2BMf7LTNlxwDhAT1yQGQj3fbVSlq+ncTva8W0wY4UZvvfW4poUJI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, May 19, 2024 at 09:48:49AM -0700, Linus Torvalds wrote: > On Sun, 19 May 2024 at 08:32, Linus Torvalds > wrote: > > > > I'm going to take this pull and fix up the cases I find, but I'm not > > happy with this kind of trivial C preprocessor misuse. > > I did some other maco handling cleanup too and tried to regularize > some of this all, and it seems to work for me. But somebody should > double-check, and it's possible these patterns should all be > regularized further with a few helper macros for the whole "add > __GFP_ZERO to argument list" or similar. I just double checked slab.h, gfp.h and percpu.h, and scanned through the diff vs. 6.9 for include/linux/ - looks like you got everything. I think we can slim down the API surface of slab.h some more too, we're now exposing three different ways of saying "trace/track this allocation here": _trace, _track_caller and _noprof vs. normal; I think after a cycle we can see if the old variants are still needed or can be consolidated somehow.