From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAB2CC28B28 for ; Wed, 12 Mar 2025 20:52:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 097C3280003; Wed, 12 Mar 2025 16:52:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04666280001; Wed, 12 Mar 2025 16:52:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA030280003; Wed, 12 Mar 2025 16:52:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CD692280001 for ; Wed, 12 Mar 2025 16:52:26 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 5AED1AA690 for ; Wed, 12 Mar 2025 20:52:28 +0000 (UTC) X-FDA: 83214097176.26.2C64032 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) by imf04.hostedemail.com (Postfix) with ESMTP id 96A914000E for ; Wed, 12 Mar 2025 20:52:26 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=eIkdQi1k; spf=pass (imf04.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741812746; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U0xZZm/MliMhDloN5dyyQOH2WRuwx6QmF4AcEDs+rzY=; b=18fDH6Y+KKwyrXIbY2yKjdjBKlDbAS2dbxUrOozjS7QQuA/VLfW29+VxSLOom0e851BWQ4 8LXYluSiI0ViQnFMfDwm2E0/yd9io+L8NUSyp82yYW0OozfoO2byinCxaAGL4iQKlodPGX WQG5yBhTEYA8o+5Cg3K36QXDhJv1g0U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741812746; a=rsa-sha256; cv=none; b=zZwX5/GUlPP6D8xJT6yFT/Gs7XHZlRT3VfsbAz6fYtD11iu3hxKlmOi0Cj7Hw1PUzhffIX nZqmVVi41RmGmVEEWrs6MDZFzJ9r2STD4BAfm5N0h/f/HKKX4rmStTJnv67mR2E7b7MUVj 9+avchN2770gWE2BYxoex3TT+wMRM6Y= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=eIkdQi1k; spf=pass (imf04.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.173 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Wed, 12 Mar 2025 13:52:18 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741812744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U0xZZm/MliMhDloN5dyyQOH2WRuwx6QmF4AcEDs+rzY=; b=eIkdQi1kwcAGaEi9IHef/FQl3k+1zNdGSvIN0X/haUAVj7yGFrhN+HnstIuuspDmzDHo9C e8nJzDhVfbOy4cJXSmjtb/HL4sMs9XZ4kLCci8aAt5uBmbncpklHHUjQ9WaEAVVwTU2Rzr 73DEzT8r2EX2yUjkYaI79skssXDyhjE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: SeongJae Park Cc: Andrew Morton , "Liam R. Howlett" , David Hildenbrand , Lorenzo Stoakes , Vlastimil Babka , kernel-team@meta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/4] mm/madvise: use is_memory_failure() from madvise_do_behavior() Message-ID: <5mgpezzqrr6xzmp6w27ggmv4f2gydyeuhejwmnxsvcw43mcf5x@rxw2zcnjqfuc> References: <20250312164750.59215-1-sj@kernel.org> <20250312164750.59215-2-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250312164750.59215-2-sj@kernel.org> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 96A914000E X-Stat-Signature: 67wec6zunran15im9g9p98hjbutqcx5z X-HE-Tag: 1741812746-821632 X-HE-Meta: U2FsdGVkX18GWGQdMqTxXHn3OxU81hK0hho6/tStHao02TGVt/Ns7tFjh+/OaQ1W9oC+/aOzIvmV1CuPl/75sJtNpD3xX5UDnQApifaCOf5QoBBdNZvCozdYlB35RPfQHbYtUuSKxH4TMuSK5bKQYdzp0lGtMTbiM4W7aJjNoGLQiDCEnreNj9eP5jGA7M2csQUkY9pzCfriTdOwEwPz5W9SMq0bkRYcXwZvhQGTYvQsEZuVJrP6yaFqV6IdY9r2QeY+/OL5tQP0qzo62BhxzCiAN/M081gHB3/GS0Se828YSTqEYR1vGljbjzhqUHtiYL1ZWP1n4yaBkHmKiiKUQutD655y9TPQBjoFg9n0V/ZcGV1BsACUtbYdUkb3vm7ER6UyidzgBL/JiakSkM2UnKwQqgXQec8kC3J5cDC+VqocQpd2zpEZL1hUXPwn4DZetiP4v+is8fRivwkGEfqRwhg1J9oLvHWdFExP4uspecyxe7vjjK0DDtlWnawp/GsP5wLFO6E20SPG5wOSymD77YSTwuIwc6TF/MWmLDBTPEcGMwNOrl0EROU6YtMIJOQSkhhiNR4LyNZQNR1KG3ei968rmXBAohIg/VoIS4DT6bW/AFoCN31P+cSvcX56jF1BZPR3V33SZmAgwrIdQTpafe3CxKRv4rPHlAjOYlY1OWq1RJgvkLCLMfjIHXm1ej4qUJaPPtGYPuW8Ro6F7ny5qU+8+qS+RMAuW35A5i8jCrCtIooiZFEHa/USD0U9CUHeSoX9l/ity08/hwSIJhHCAgc4EyIB4YnR2BTaqgDK68DlYwglPdu5tifTwFqUjPJZ7Zlbymza5DWN+UmFADGZbNxTScsJZxr4LurJ4DszaH0x5YjJ0W0by37i3pe/u3GsVtnuRwzLa+Q/GMnWQs+To3I1vIC309bnWGvgfdt4yIJBTtik5jkOgRl1IYzAmoaNrcUP9o4AxSj/JlMOPaU G9NYyuN+ 3LU49q//41zWlX0I5dFn/kx0CRn8lVE3zI9dI5TZ15nP3FYAcHwFa//kWmo8L16JFfLqF1ppyEC8j90D6kf3GrVMiEmcc+ZL2YQDIXk1oetC01ADiymKuSYjVV01OiakVQVK6djgt9hzwCVeH3DueHK5nDt6pEg3qjjJQR9d8UAZOGeIsJmLcSzhvGUbPlr+xV6wapljUqg6KS1EnHWM1GuoEapti0po3MbMvZKMeRBYimU7R5bEDxdXlmobslilPm0FdKb6gLXHdz0BTZfz8Lt0o+K7uByscrufLhujRO73Tdv8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 12, 2025 at 09:47:47AM -0700, SeongJae Park wrote: > To reduce redundant open-coded checks of CONFIG_MEMORY_FAILURE and > MADV_{HWPOISON,SOFT_OFFLINE} in madvise_[un]lock(), is_memory_failure() > is introduced. madvise_do_behavior() is still doing the same open-coded > check, though. Use is_memory_failure() instead. > > To avoid build failure on !CONFIG_MEMORY_FAILURE case, implement an > empty madvise_inject_error() under the config. Also move the definition > of is_memory_failure() inside #ifdef CONFIG_MEMORY_FAILURE clause for > madvise_inject_error() definition, to reduce duplicated ifdef clauses. > > Signed-off-by: SeongJae Park > Reviewed-by: Lorenzo Stoakes Reviewed-by: Shakeel Butt