From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11A0CC3ABBC for ; Tue, 6 May 2025 19:00:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E258E6B0083; Tue, 6 May 2025 15:00:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD3D16B0088; Tue, 6 May 2025 15:00:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9CF86B0089; Tue, 6 May 2025 15:00:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AB7416B0083 for ; Tue, 6 May 2025 15:00:21 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 94121C02D5 for ; Tue, 6 May 2025 19:00:22 +0000 (UTC) X-FDA: 83413398684.29.1B61322 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by imf09.hostedemail.com (Postfix) with ESMTP id C35C1140018 for ; Tue, 6 May 2025 19:00:19 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=McYjZms6; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf09.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.14) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746558020; a=rsa-sha256; cv=none; b=bZGKh4EtmSUekYCHVSkp1fg3DjfRj+GfntJjMrF80OW9L+cbKDMPAuCIcmcCdqeMjOFFYE UT0f7HXMBZewUvHkzZPaOP8TiZBaOs9tN6pgw/qt1mWBciJC4LJt7yU9ToSIz0kseoKRMu BNJOdIwLXqCE3thilfcrJKuz7sSyqaI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=McYjZms6; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf09.hostedemail.com: domain of kirill.shutemov@linux.intel.com has no SPF policy when checking 198.175.65.14) smtp.mailfrom=kirill.shutemov@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746558020; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j86TqyvrlUHXsNYIP7qPVbHcnkWIn93DrI/iwpGCcv0=; b=a+Wgp4/lW2WPPbu56dl4kP7vFCc1ruiRu4U9PL8QWePnBqmoCqhQJh9lPIs2eOSyyiQOsz ThcjJfIU6O9wHFX5jgdv+YgCxCpG0qmNnaWDPIGSTO/il9PLyTe7OfX5RLIP0XIJwappKN GZKPAhQ8ZdYp4ysP522DeU4tuozd7oo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1746558020; x=1778094020; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=Z0vBXO/loqohfGa22HfiNkucHedKAaHavqhq7CkMCBY=; b=McYjZms6sOTTuojzeUCSDS3pAjI2h71TgfNQ8KGzv/wJssuj0jwNZaAC P/dubouB5/WrdViCrKTulrdbNDj+nmv5lQxppgtFeo5qtQzo+wsTAVhKV iiZtrlZ2R2bO8fBDq7V6y2zVMsK0Ad/hEkgCV/3ekGUv07fMhZAAXT11L LGxwaTGpxcbRkEyDcnOV8wqpLraTaIsVSG0jLnZEj0AIhPkgMC2c1B8vg BLmzQ1zZdtlRkuyJfI5JF2AWOAOejrQnfhg6ooRDyRMHkJDmQtKq7IOkx Fe1SSpjAsWUagGYfEsbRwPYmf6qt//UhCv3lcHGkxc2QlvFwR9bo267yO g==; X-CSE-ConnectionGUID: NA3hkhWpQkyxNFQYJd3fJA== X-CSE-MsgGUID: MbodpUtlSHWSehj1pIm4lw== X-IronPort-AV: E=McAfee;i="6700,10204,11425"; a="52068991" X-IronPort-AV: E=Sophos;i="6.15,267,1739865600"; d="scan'208";a="52068991" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2025 12:00:19 -0700 X-CSE-ConnectionGUID: lS+c777GTYeKcz2mU8LuKQ== X-CSE-MsgGUID: lpzgMqx7StSWyfHIleru1w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,267,1739865600"; d="scan'208";a="159006784" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa002.fm.intel.com with ESMTP; 06 May 2025 12:00:15 -0700 Received: by black.fi.intel.com (Postfix, from userid 1000) id E6549172; Tue, 06 May 2025 22:00:12 +0300 (EEST) Date: Tue, 6 May 2025 22:00:12 +0300 From: "Kirill A. Shutemov" To: Alexei Starovoitov Cc: Andrew Morton , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Borislav Petkov , Thomas Gleixner , David Hildenbrand , Alexei Starovoitov , linux-mm , linux-coco@lists.linux.dev, LKML Subject: Re: [PATCH 1/2] mm/page_alloc: Ensure try_alloc_pages() plays well with unaccepted memory Message-ID: <5loiv7lfplpruujplz7wmzj25g34rs2aezvrfsl55dsddrh7mo@rnqrlx5zccol> References: <20250506112509.905147-1-kirill.shutemov@linux.intel.com> <20250506112509.905147-2-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: C35C1140018 X-Stat-Signature: 6sbif76cx6ddi3rwtp74k87hk6fta6bu X-Rspam-User: X-HE-Tag: 1746558019-572289 X-HE-Meta: U2FsdGVkX192CB8kgbTdcQRm2L2c0YSqnxO3MR4stdDt2HmGI+Jmi9FFR5BWITOru4pEuOgcH84rrGRZTJ1qp56oGJgF8pgVYpm8PW175f1FMhJLTz1riuTvC7DKdwCfKtT6Ob6Kt70UDdWTzPzGwXG6C9ISKXjVF8P4ZU7hvYejbfDN/+MkZ+tiNnNGgFq6vBgXytx9HHOyhgLrmS20nH3IYll3MAPffz2b30n0aVxBkZPAJ8qIAG7lDe08wi9FGVpgjIKdLaGji4VR/yRTAdOPQ0ZgQE5Y6bwG82XhrjbQdVhK2aLu9qtj/9fg4F+5LbWZyo4gITIbxJDExQDqdamRsEw31+Okf4BCVeRavlDlBbx2yV6cjieNYHkLAJo1+5IZkbqM/HbkTXYhz6409IQ7d82CBnwYEpgsyX3+ZYuqD5gxKIbFisCmYzpRa9WZ4a4ddUSpIxFP+SgPcE51/nwpDyNC6rGAbQl+Fd8CnCpTi9PsRikBJtW2N2Jui//OqvJ471xpEaJC3goepUtr+p78LcnLpuWAIUDdLtZbMmXpK5gCIU2PjGwpZJum90zD+NaEJtBhCF2SpxlUNr9tyGDHHxr4AgY3EoLqDa90qAB11aSNl4/AQUyQ5mxiEZN6B0YySof3DL/AboCZ0nv2Hxj5f5IlpyNhlaCK5B8lKUyBC/EyqCiwUupUpuU1fWEQuDvsEZ3t7hZcqf/Nb30lJ8hmLPKCZjR2QtM5XzxqFo6dpvvgyB7GwqoJmwFsHPc5z9tw9W1xangssPTg2SIKeCZMkJ9609pTUawyCig2BMQxs/mlTB0ILQemMc50A2sP1GVvQHDukxb379fMbGhAI4ofYtHPZyFykxxQNXka2uLaaXSur+TrcIx7gI5HosQpksFJpfQQ62DUIYpr7bJ/hMc6MBIlxjvcwPOK/AZJrUboMi7Rg2LHo1+9l3nsb6IF58BNNgb0/8KE3VExwby ivYB3/OC a9EZ4wDYIEdzvUhTaRypwZt/Ya81KUBM9ediMImQpY5SIyqJVarLWystNB/tCb1Y/NrPlmimSNShJZGpU5oKmyVv34vR4AJxm4Z9e19ozD9oz6hF5uOBjktSHsG8t/Fbf8etmaB16PfnbYt6l40CFx4AImjik0nHG+P9bDOy3HxvQclWvkA3Gkhee618flx5ZMk5bhQ/k9Wlqc/aIKwr1FCjgaRzrYcq1YuZrQjxgxS5pgQA/IF42+eKxYyYeS4RVC5Wwy3/spx26MwEyyLqeJj2x5JV95z10PYBf36oaYfzprwZHIQGD1nQV01f/0LTfKbIosiX8Z7HhnwUEz6isiy5ndpLm9UVVKJTDb12ijyBC8tisz+PgMIR+GA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 06, 2025 at 10:18:21AM -0700, Alexei Starovoitov wrote: > On Tue, May 6, 2025 at 4:25 AM Kirill A. Shutemov > wrote: > > > > try_alloc_pages() will not attempt to allocate memory if the system has > > *any* unaccepted memory. Memory is accepted as needed and can remain in > > the system indefinitely, causing the interface to always fail. > > > > Rather than immediately giving up, attempt to use already accepted > > memory on free lists. > > > > Pass 'alloc_flags' to cond_accept_memory() and do not accept new memory > > for ALLOC_TRYLOCK requests. > > > > Signed-off-by: Kirill A. Shutemov > > Fixes: 97769a53f117 ("mm, bpf: Introduce try_alloc_pages() for opportunistic page allocation") > > Thanks for working on this, but the fixes tag is overkill. > This limitation is not causing any issues in our setups. Have you had chance to test it on any platform with unaccepted memory? So far it is only Intel TDX and AMD SEV guests. > Improving it is certainly better, of course. > Acked-by: Alexei Starovoitov Thanks! -- Kiryl Shutsemau / Kirill A. Shutemov