From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E548CC28B30 for ; Wed, 26 Mar 2025 04:16:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DC7E428005A; Wed, 26 Mar 2025 00:16:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D752C280056; Wed, 26 Mar 2025 00:16:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3F2E28005A; Wed, 26 Mar 2025 00:16:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A4AA9280056 for ; Wed, 26 Mar 2025 00:16:28 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id AA3CCA3EEE for ; Wed, 26 Mar 2025 04:16:28 +0000 (UTC) X-FDA: 83262390456.20.A53204A Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by imf26.hostedemail.com (Postfix) with ESMTP id B8887140004 for ; Wed, 26 Mar 2025 04:16:26 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="UJ/TQ8Df"; spf=pass (imf26.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742962586; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AILLZeGov018ovsXda9kodqh4SjOH5TnCaDx9SjPjrk=; b=oWM4WoGm7OtdJRmwcGjCzS4Dzc3ZCAAmQSfGOpoJTjaGlm1eU9JUAJDGYsovhn9rSLiKmM 93EWMK3LyEHD21kiwsA1jT3fC5kuw6vx+5blR0LlJWmtSkZC5EyuAUZAFMMxrnfk/VD6T1 Jm3wJlQ8kABPlQ79zMc2mZatIwu1cHY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742962586; a=rsa-sha256; cv=none; b=QumWupnUFEktcYqCpmX7Yj9ZELuNRY/PlaJMfYoiWXP1QCa22n3LKolAj16IujEkGfzsME jNy6ubiBw4N8ApG84ljrNfshu8muVPBG8xRd+gLzIJovRrBFhNIM9QHhuyMTFeeMeghX91 viWgjBUB3GKlD9Fv5Hbjb9vCYMDEAUQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="UJ/TQ8Df"; spf=pass (imf26.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.182 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2279915e06eso71308935ad.1 for ; Tue, 25 Mar 2025 21:16:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1742962585; x=1743567385; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AILLZeGov018ovsXda9kodqh4SjOH5TnCaDx9SjPjrk=; b=UJ/TQ8Dfg0EMDtCFfOwywPpLey+sHjRVOy4Q1mSfedRgVv3QYPYh5avX3OhaGnpDfn zih8TNRO6+KWUCxOHRpErR3ORU0vhwK2kyMTR59VyWMaZpDia3ywI0bAQUfwSBtwYW9E aW1KZXyYBY+cFtt4YQcj/xSuSD2cv+0ZbxoSI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742962585; x=1743567385; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AILLZeGov018ovsXda9kodqh4SjOH5TnCaDx9SjPjrk=; b=ZvGacq5RoeZN98Arxax2GEbb7CIIJ3kNabFWIQFkTyNwKcTq6lMJzPK8RDTjedX11S p60Cs6kTP1Oy3R//ATuPnvkWQbKPsjqTNWg8EMtpN3IvBJT3zQ995Mv3ayvP7O/V3XGT EYXWF5PQy3sHX53yB7xk8vRilKl+OEWIqkydp4eKYr0qczwm4c/yU2z5iF9r8M9nsjzL mX/3Fh69B4MwN1AoQ26xBMqx2dTHsnk89ZPDO/+2i/5d7FUK1xUV9v95KBBylSK8alFu WQ9LwLWioXUmWAyoR4eEssGAFF8WbamChdtzihWgWHKDk78nSxSRf8HdROsMSYKWgM23 TwAA== X-Forwarded-Encrypted: i=1; AJvYcCVVp8zlQXpPcz9mAY/lYMCGSl2NkaVZSv7Ky7SLFh2+Iyq/0kf3n8YG5Qo0qXssO5BgKnsB3nA9hw==@kvack.org X-Gm-Message-State: AOJu0Yw6aROuq0eVDVOKRi2OOqUzCB9OQ1vwPqNRIZKYvWXt2Al7E+1T 7XQ28JR9R6pXpQxEqjE3M0Qj2kE2TOy38DwfEQAa4zNR3hLixG+zhHQ3HmMUdQ== X-Gm-Gg: ASbGncvlh9+nYlYBTVEpGufhTgUTO+yY+7pT1ADkksLLNFVdgfzSTwnafaRRUKMiFnr VC2kSi6p4yvpAO0gE8NmitFt000vW+FaJoD+6rXY8IFjTiwiwpXouXWQN0usOTP9q7ve+szeF55 gHJl71EM3NddYcWDycm7fljRQTmA+94Ehay3NmZnk7pkvN7yRVoP3vkg52UphBe3bc2PlSvIDB9 kPgduxTuOFirDzy4s6irnv8TFwXwfSAfdCL2KyNxrD+gegqo/r46DeM2hlSTLUbUa8d3hXvADR3 qNMWEZ9hE+XEap+XkSrbl7okm+Mo6FdjyK8Qrf9i5mR6xlFGZd1nuAqL1Rs= X-Google-Smtp-Source: AGHT+IEYD4I81caHizx4b3QwHmB36Sk1YdKjB4tHwyQyr2ZnnKdYtVGO8dghifNfsTi3mSOEzVl/sw== X-Received: by 2002:a05:6a20:3d89:b0:1f5:535c:82dc with SMTP id adf61e73a8af0-1fe4330dcf3mr32728235637.42.1742962585550; Tue, 25 Mar 2025 21:16:25 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:d343:29c5:4565:9d95]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73905fab633sm11527409b3a.18.2025.03.25.21.16.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Mar 2025 21:16:25 -0700 (PDT) Date: Wed, 26 Mar 2025 13:16:20 +0900 From: Sergey Senozhatsky To: Richard Chang Cc: Minchan Kim , Sergey Senozhatsky , Andrew Morton , Brian Geffon , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] zram: modernize writeback interface Message-ID: <5l4pjqlgu4afndn3ysa7ynecjmvepkfjlh56ycm5jt5e4mioqm@dujakwaomhlk> References: <20250325034210.3337080-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: htek5w5tw6k7e3niwhnsrbebqgmchqpa X-Rspam-User: X-Rspamd-Queue-Id: B8887140004 X-Rspamd-Server: rspam08 X-HE-Tag: 1742962586-210046 X-HE-Meta: U2FsdGVkX188rQXNlboQiwUWMpMywr64D6viA4EtwHtJqeOvBaTjA50/+fvjqT6dfxWUZjH5hAtButLLkjQHcR8AVcFAe3EfGf3mE+RSafUchIXHfj1v+/fyLc8nVu0r27PH5tsh/qJq/uGIf4mrQ2EfknkwF9KusesxQ/3M8J64NRV4Huevlr3ObLvA8Iv/8SXf5yL1SxU/BdmozJmqomW27Z/kL4Q9F2dDcATbv35TSEilSlhjnpLOGoh2NjIFdH1XvI3nzjo0lVQ+9YnGi5a/PV3io7DF7kKMc11jGs9L8Bfvm4qfEgWb1quSuUWy6lKICaNgo8sQ6d+QPz/fPYvoalSTbLg954DxRhZIdaEt7SGCy7OJkCsCLFN4jKqqxBGkRJyRi0tfD35rB67zO/6akNvXBfQOgl9Wc+6WRmVuBUmkr8CFm0/P03kXoccR/L6RY5vVT/HjlAZoWkyj1EhBYy0P6BJ68PxFDOS6wjgbteSjH/vqDR3lmA/dvf5ne/eQ76w5lHbVJftn3a3ovImznsJESpGLapYrPJR4s0YU1EcT/EpycjI5lN5zM2QihNeAE49PhWLedBLKIlkq3wMPXAcRWSkNezn0KjrnKud7nZYNrAXLW7ku+q0H9M9bPIBPETKTXGxzn/3ML6GZttlzkMG1gSW9qPOHfmXErmjy8RzSOHMREzTj0Doklg2Q143MiM0sAItEYyUoY+8Qw1iEgIJE5TGfCID15ZgrhOWJuWae6ugsUUXKU/kK8DRtGAOi1TTDa2wHE1zPxisRbpQuCH7sIZiq/2RUTiKeQNVBTvopnUu0ml2Q5k7ff+7nyCGdV+03JvgYN1UqFGZWNQP7A9rck/TRa6FDr3TVj7+7JPPBs9zJFBxHCRVrAefsjfmg8TDuT08DBQQvM+kR5qbSTf5QlImnwjKAXzrQq6B3P+XxtGQYlK9bbAWmAUCFC/doKRK47NrPfGVFNQw b5O3yO33 p7DOulkEQzYdGLQo45IxY6zoEA2TMXGkova5fCoZSFVDzMvv2c0o1W8AvkG9M2zLAw1zkdGb520/JKy7C07cdcVaSapzGdf0wwsVZVbdCtaGUUWdG9r2/gigZzKt0qnHW3UtVM9mrQZIT6AyrgcQgy83tSvlGoykGc8TjjHD5MYBaOikZRqjUz39N5MuiBlm0AKLQm23+Acv9p/nk3Xdrwm8CAEj1i7COITPc7JnSWMcRgC25W6AO6P5ymCDxaEoQaS2MQ7ovYpthH3NbmiLXhyDzaokDCb+b5CqX4i/0ipqdz7zAy0JQLtu7txi1Jq5o9EqLLC5lKMo0e/rbU1fYw17CPUkLcq01TQ45UF3iNKWSQtE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.021406, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On (25/03/26 12:03), Richard Chang wrote: > Hi Sergey, > Since the input buffer length is only PAGE_SIZE long, can we reduce > the duplicated "page_index_range=" strings? > Eg: > Turn > echo page_index_range=100-200 \ > page_index_range=500-700 > zram0/writeback > To: > echo page_index_range=100-200,500-700 > zram0/writeback Do you expect to ever have so many ranges that PAGE_SIZE buffer would be too small? I didn't want to put a list parser into the kernel, I wanted to keep arguments parsing as simple as possible. But if you really need to writeback that many pages then I guess I can implement it as a list of ranges. Alternatively: We don't necessarily need to use page_index_range key, which is a little long, but can use page_indices=/page_indexes= or just pages=?