From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F636C02198 for ; Thu, 13 Feb 2025 00:57:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1ADCF6B0083; Wed, 12 Feb 2025 19:57:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 15D3B6B0085; Wed, 12 Feb 2025 19:57:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0252F6B0088; Wed, 12 Feb 2025 19:57:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D8F616B0083 for ; Wed, 12 Feb 2025 19:57:56 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8BC884C32D for ; Thu, 13 Feb 2025 00:57:56 +0000 (UTC) X-FDA: 83113109352.23.73371E3 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf03.hostedemail.com (Postfix) with ESMTP id 990FC2000A for ; Thu, 13 Feb 2025 00:57:54 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=OGJv5P90; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.52 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739408274; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gWSDWHDBJk4mPKKvXA7cp+JzSNkoJBuCEwXul/Db3Co=; b=ElUC6kqBdqMdTMCboJtBvj1T3HQ2xEIIDkIBTPNCCKs82VvFBEsG/XKdPJoXKT2bHjnODm SiD6bTyOj0DIIAUFzMkl5xgjCtUvEF8EfUf81CwIy8/vvIyKojysxwDJiUI9usPSjo0cjm pSxZZXWHXbyOoiR6jPabMV+pHj8UVNg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=OGJv5P90; spf=pass (imf03.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.52 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739408274; a=rsa-sha256; cv=none; b=C4DpiMNQylfSIkHCL0X3mCCMkE2mywUUacIh7CcVP1hpFRq0EjVC3yWowg+NW7DU8CUQ4f 02Bs4FL11Qi04uFBkyj8Ky5sDq/Y0saPbs9BAet4vh9VlH6uZv0lD7ml+F8DCjfr1c+1+O VpdN0Jf36VbNQ31p58DoLuUj1fQ8UVI= Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2fa44590eebso767080a91.3 for ; Wed, 12 Feb 2025 16:57:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1739408273; x=1740013073; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gWSDWHDBJk4mPKKvXA7cp+JzSNkoJBuCEwXul/Db3Co=; b=OGJv5P90fyTAUsitcVK0prnu3Em8qOZC59JRrCtyg54/ET5AslRt13dkY2iyVcNeCQ DM/KQ3Z/qIYn7h3d5qI9sdJ4ILhTCioXEuguqIeSbmsQ3XIog4os3ZWgb/v9AUuB5Bsf 7t9jpaX3SI+Pdop9L+lByfIj9cye7UU3S4VHc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739408273; x=1740013073; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gWSDWHDBJk4mPKKvXA7cp+JzSNkoJBuCEwXul/Db3Co=; b=E9X0Mi9s16YbE+qAqke+yPrPOcz/s5Yq7iRtZhFKkHK/QrWSx8UJQzOyi1r139PkGh bc6KF1j3I/Xa5iyY0/0Q8p7eLx4HbSVMzJDGONZon71QI0W3z7mIAJ+N/BUN8oOaA97P 56MYs/Ob0MAG/JVwqEC/I9313gJ+Eh6vQ7rzUqsonh30Dj1KRGOzOGIWONuE2nl8upwW lP2RGSoGcQeYnZpzHPeMOFZdFmu7F+gy9cwsaxoxaNrL6qMVy5B2uXrmOiIUBpi5y1HJ malZ1a9Q17UFFe4v0Mn2rDcFLxKXvrFfUWzus3ALDuF/e/C9YC0WPEI4J0vZj0VwZPwR pjAA== X-Forwarded-Encrypted: i=1; AJvYcCVmiKj3NV5uSIYwKy29qKXnU7xOzha5779s1k496u0UepIqOZ4aqb2Q7N/KtSBSoIRiaKyc6GXVMA==@kvack.org X-Gm-Message-State: AOJu0YzRpl+IacwgY6u/wbJuVEOaREvNYL0A7tyGANRWYkMlykGH+Z24 H77KBMDWdrrflVDPyrncSY9AqLgnNLupi8aBFFDnxW6kaGfXuIWWbrtex5k2ug== X-Gm-Gg: ASbGncufB0h5FNMwZ71B6iUq44mD2q1gXiSrrtT7EzV2EFBs3m/FBjXP/nQDpHjLfLz AfCNZrPSdc9zt5dEinP3hYCUTT2hWdi8K3508GAz4YVVV0+e/Tqpfw2p3jAvqeJSeMhT8GucbHb eP5zRxR4npCYW0ohs+F1BgZgDkVN9fsWzPXPWOe2oL3uJ8C+4au02A3jdqVWkYE1o1KmhXkGdvw u2PCBDIuOwHduBfAYFHs/cQKEPIUHCicOG0YorTzmjR2uppQZmFMQWR6WfqqAXt45JEZMHw8tKC l9xj+vknDj786a+Pr0g= X-Google-Smtp-Source: AGHT+IGB9KqF9IAMhrqzrI/AeAeLYzqAhbuoryuN4qs2PucLIe47WlIuNI4ci/dGDYV+2TqNbfG+/g== X-Received: by 2002:a05:6a00:1404:b0:730:74f8:25c8 with SMTP id d2e1a72fcca58-7323c144064mr1950139b3a.11.1739408273477; Wed, 12 Feb 2025 16:57:53 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:69f5:6852:451e:8142]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73242546efcsm76022b3a.23.2025.02.12.16.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2025 16:57:53 -0800 (PST) Date: Thu, 13 Feb 2025 09:57:48 +0900 From: Sergey Senozhatsky To: Yosry Ahmed Cc: Sergey Senozhatsky , Andrew Morton , Kairui Song , Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 10/18] zsmalloc: factor out pool locking helpers Message-ID: <5htndqx74yv2lq2zr2odozrrbi5cz6zizn3vk4uosobn4ceoji@5zuknjmi26f6> References: <20250212063153.179231-1-senozhatsky@chromium.org> <20250212063153.179231-11-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 990FC2000A X-Stat-Signature: 6d3nbenkdbabt3yerons9okg1rdsrcjd X-HE-Tag: 1739408274-201862 X-HE-Meta: U2FsdGVkX1/+x4cTkJwlshePvRgPgFN63ao/NPFlls+aJrBXISx+SOewNWIiAOj732i1gDag421cAYp2D/a7M9ZpU/mYi42SbO6+lK3qJ+1V7kIGSfK3Ob/CM13SAGg/1vXZmHmewF+Ysfe7HM6JPX3bczHdrMa5Wzp5qYfEDh8+q8MDKPWGRnZBImJ13hfShCIYdQjN3J3ochlZXRJs7hBliWvfFJv09hmm6xseHpGqICknhyE9Ad855Dmln2lQ4LYeBgU/fOVjZLXOf0FY9uDDqGFlycEa31zC9uPTqz2UyTeksLk/1P2YsZ/zl/WEgUSY25TsWOYLknaqZOh3z8jWcQNt98VhkQEXFEOv4n6fGfCggR+pRBAu8VEIppXiSqjwJfx5h2bmEiP/qEmxuJvdzRxI128VQPm9dQDTLpUEslr+UfhNwEGSn5SVVzQkmnt3JT6uwm8qWekE4JfiD+ysFdMcJN0a3QEF5fCwnF+/XmzDw7KtIH3RwvDPlAxNn34+igRRvLL7UIrbLiBtUSfJvNPMz6d2yLA0uW7pjeJrCaTB/00clLJXjLkghQ8clkZ66R4/6GRTyawZIy73yIG6p0JoybRw0ZFp0NMCADMOgl6me1tW5iyuPEgMBCgn5YpO0NzXwgBtat9AmCKrfuJQEYLkKi0rkAcSw5OeDWpS0wWzonzPwk1zov3d8lVRNILBDTJjLyuYvrLXhueLIwoTcpeUrB88/3n3fb1tY0E/7eautZAQJn+027YTzhsKO9sHMA7qjuPBWYk9v/bINenHL98Z/Y0XrybbXxxOi1twiZCrw90eL2B3f3WJkOt8HvlOU9ZY6vzUj8oqGSnRGiQh2SnA6IJqOyofrea7eAT+/Jy30uwtw4CVgSG5LzGMcYutvw7XdK1o5zYf5xYfhj05i7hYfC/ejK7k9taEo3q3dGZHyyjorv+Rq4/JJLmLpjUR+c+C4lrDhEW71X3 u64SdelK 8rNEX1gJu6dZtzYRO0emG31uO9hThcJfbr5ud7RjUe47Tzzg8Eo6qi/zozTuHNWi5HflqTrHEC637ncuR54/r8anu9OfU+SuwKw1KFHuIbTZPKOrPJxgV18w6kiYLIM3LDsHvmdGZlB/3zU8BjuAZfd1jK8gEhCvqJn2G/rC6R59Z5UnD4uglqGMMvtzYyZ9oy/UbaPsR/FtIxFJRRqV0pI6aUP+zeRgh4mKIMOHyHWLoO2bz/DYg+ujgbCpdnlg4kCkaMGW+2tuLOKdUZ6Ac7fIIRRvzAuiyza3GjqrNANEnKlhEp1Y9pXWDmvEwbdwFJjUSZQLtXIeN5TV6tS/ElXiLMrwEYZL/Z3FDKx5hNk2Few0z6KLYiGLdAQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.004820, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (25/02/12 16:18), Yosry Ahmed wrote: > On Wed, Feb 12, 2025 at 03:27:08PM +0900, Sergey Senozhatsky wrote: > > We currently have a mix of migrate_{read,write}_lock() helpers > > that lock zspages, but it's zs_pool that actually has a ->migrate_lock > > access to which is opene-coded. Factor out pool migrate locking > > into helpers, zspage migration locking API will be renamed to > > reduce confusion. > > > > It's worth mentioning that zsmalloc locks sync not only migration, > > but also compaction. > > > > Signed-off-by: Sergey Senozhatsky > > FWIW I don't see a lot of value in the helpers (renaming the lock is > useful tho). I want to hide the details, keep them in one place and at some point *in the future* have the same "locking rules" as for zspage lock. Also *possibly* throwing a couple of lockdep assertions. So I'd prefer to abstract all of these.