From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B10EAC3ABC0 for ; Thu, 8 May 2025 02:08:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF6416B000A; Wed, 7 May 2025 22:08:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA4276B0082; Wed, 7 May 2025 22:08:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B47256B0083; Wed, 7 May 2025 22:08:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 916976B000A for ; Wed, 7 May 2025 22:08:15 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1E2641D15FD for ; Thu, 8 May 2025 02:08:17 +0000 (UTC) X-FDA: 83418105834.09.81F7A03 Received: from out30-100.freemail.mail.aliyun.com (out30-100.freemail.mail.aliyun.com [115.124.30.100]) by imf08.hostedemail.com (Postfix) with ESMTP id BA83D16000A for ; Thu, 8 May 2025 02:08:13 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=W+wrrW9e; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf08.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746670095; a=rsa-sha256; cv=none; b=yepWT3MGD50nK75gIG3fCy+z9Bw30Xf+k5ZH6PF5vMtVKZi2rZp/sab+NTddoH2MgbxbBp MmwgWRmxczZCsWHkOVp55C5V6NwpxajXiEqhUgm7HbBkcyh/X9QCRO4rjQLGOYYrXKFn/S IJkWOsuKZCyT755hPyLSd/urwW9i4wo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=W+wrrW9e; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf08.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.100 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746670095; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XU2tUPMbXFANOISEpeXWUxvB5DcpMsMzlgYdMXpTRzg=; b=gfGjhGu4d2juQpb/c/zwpcUekcPUP0jvGSJCplELMMaO/Q+Y/85YoODndtssRiIMf4h//C RmxKZKJ6UJ8qxm5/42IUUe5LrdmtiHOKwmsK2gZGlyPwyeZzWqTpygOC8ImQXMiEYdzGVW 9QKV9z5WFRcUAul1dKIn4FNu/wSEaqg= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1746670091; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=XU2tUPMbXFANOISEpeXWUxvB5DcpMsMzlgYdMXpTRzg=; b=W+wrrW9e6ag7GxBwGb1wh1lEu9JpBG2zlqz1meWSJ5URnIbS8ByvdJ74O0iE8bs9Qo0+GdXV+1xy/anuH59VvYmzDjiCWGYjgcAeUZBxDBhbvf6ncoSuW+mox3sIMDhKZWmf1sT3TDm4Aydh3csiMGtq3K2WWNf2+ptCjjuRpvE= Received: from 30.74.144.116(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WZyiDYG_1746670088 cluster:ay36) by smtp.aliyun-inc.com; Thu, 08 May 2025 10:08:09 +0800 Message-ID: <5ffc814f-72e9-4173-9a77-5b45f941565c@linux.alibaba.com> Date: Thu, 8 May 2025 10:08:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm: khugepaged: convert set_huge_pmd() to take a folio To: David Hildenbrand , Matthew Wilcox Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, ziy@nvidia.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <8e33c8a65b46170dfd8ba6715d2115856a55b8f6.1746609191.git.baolin.wang@linux.alibaba.com> <70785e68-5152-459f-b241-fa5abc3b88ae@redhat.com> From: Baolin Wang In-Reply-To: <70785e68-5152-459f-b241-fa5abc3b88ae@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BA83D16000A X-Stat-Signature: 35j6mpdej5usyrf5gk6fr81r8bsptgax X-HE-Tag: 1746670093-804287 X-HE-Meta: U2FsdGVkX19LT0KP4lHMShNCY+5f9gf15hT/OcdGCZRPidOrgc4LqY1F69feOsCAjR3d6etg7ZIRPwB89KGb9FdfWOFxi8qt9S+TbVdB7R8GMC6yq2HCnpoQqUfyMrMDJApVKdc93eOAqU8QoHl/bpxS/fqMGLYhsRyIqJ4wxBcL6EmHchzFCRDosIarmcJFodIi9ELQTQ2RzhlE6cwJp66nbQPVvZHqMiV/Wxq8+omEv6jnkF/FgfQtRdNGRzd1Plxlo3ue7+MR0TpXluv5m6ik6jfhd0RefOFFj0XjO3QTp4UELDQ2vq1hcNP2DqklbKchTcpkpsbZFrEfhBnmaapa4f8WCalmePb1yxNkFoR4GiBZBoqFpAOzx/996wP0n1dKo36n7jK4kr67dN76T/lxXLRISuL+0XwgJgAsHxQpYJkE5bDcXSaoIdRkYnOgJHpY7ffDdjZvp1hEb849pwJX98I4/cQZirxH/Y9ZNKYVnbYZOxQXizSwFR29DBmK6LK4cbP9rDWRBhNqxU2DsyXaqNY/faL2V2DqZ3evtj2OxS68TScOgyddKAt/DPVdtjtEuyYnfNO5env14bWXTCugpuoNofUD47ZSN03iaSaw4NZysFel2RbzRgxfNktD8YTkExVhAZpyeLy79YcLE4E+dn5GLxSvHALoXSxfr05tFvUirwbd/2wZG+mVLgCqTonqMPZMzKr+4wPAXA4V5Z5xdryX1iY3KG4CpW+LLXNpbTCHsWYwWS2P9PgHiy4Q7IdCkepaskfqXN7ko9wSeF4lMYWvseelTVF13UUnD+gssoP62r6cZS+8YIb2aiTwX30Vz4B/mefGoBBCRFFNKAPCxyQPy+6acOOXp193qXg4xcYxEb+5A1Tdi0N/xTsYfZx+Tn8+VT2hMgZ8nKwECIHvbZd6POQTW8x7wxl6retE8pL8VKagTUVkHzN7ql2x8uN7ynbzU3Jz71GfL8v 2jups0ar qj+PwOuZJlElhOK1U0O/bwOAqY7oWYHCc/Bx66jRCjuD5ysaAlQ7wmnGYm13FIYKSXbHvP+x5lnvMAeyZ3FLdtVdbDIo8+J0gsWhMnht245IQoPPUIndCWZYNulcAxnoAYCXsUJRtJVAey1bnROpgenXjHBu3r7EIUbzxQOvaSua2jdDLDvby3+yh17hL47kK5fLrHdfE4eoO86DFQ1yEbBYXajllrix/onVUsAVvXYYCggqfXAD61G5NzrJh0//MmLbBhcEc2L24vZVVHxYLCTeydESBHR5lfEdJ1sx7KKq2W3IK4lv4ZElwfAxg5rEnQOZAt//88BrteuOfyHNZ3nG6wsVkXk5xK3GVtSCEbwlXMSE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/5/8 05:19, David Hildenbrand wrote: > On 07.05.25 14:04, Matthew Wilcox wrote: >> On Wed, May 07, 2025 at 05:26:12PM +0800, Baolin Wang wrote: >>> @@ -1476,13 +1476,13 @@ static int set_huge_pmd(struct vm_area_struct >>> *vma, unsigned long addr, >>>           .pmd = pmdp, >>>       }; >>> -    VM_BUG_ON(!PageTransHuge(hpage)); >>> +    VM_BUG_ON(!folio_test_large(folio)); >> >> I don't think this is aterribly useful assertion to keep in a static >> function with one caller, do you? Yes. Will remove this VM_BUG_ON. > I'll not that -- whatever we do here -- we can (finally) get rid of > PageTransHuge. Right. I will remove the PageTransHuge in the next version.