From: Logan Gunthorpe <logang@deltatee.com>
To: Nick Kossifidis <mick@ics.forth.gr>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-sh@vger.kernel.org,
Rob Herring <robh@kernel.org>, Albert Ou <aou@eecs.berkeley.edu>,
Andrew Waterman <andrew@sifive.com>,
Arnd Bergmann <arnd@arndb.de>, Palmer Dabbelt <palmer@sifive.com>,
Stephen Bates <sbates@raithlin.com>, Zong Li <zong@andestech.com>,
Olof Johansson <olof@lixom.net>,
Andrew Morton <akpm@linux-foundation.org>,
Michael Clark <michaeljclark@mac.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 6/6] RISC-V: Implement sparsemem
Date: Mon, 17 Dec 2018 09:50:30 -0700 [thread overview]
Message-ID: <5fd0880c-5896-ffee-4d3c-4fce1649382e@deltatee.com> (raw)
In-Reply-To: <4b591ba933363e29392dba218ef63267@mailhost.ics.forth.gr>
On 2018-12-17 7:59 a.m., Nick Kossifidis wrote:
> Having memory blocks of a minimum size of 1GB doesn't make much sense.
> It makes it harder to implement hotplug on top of this since we'll only
> able to add/remove 1GB at a time. ARM used to do the same and they
> switched to 27bits (https://patchwork.kernel.org/patch/9172845/), ARM64
> still uses 1GB, x86 also uses 27bits and most archs also use something
> below 30. I believe we should go for 27bits as well or even better have
> this as a compile time option.
Thanks, that makes sense. I'll make the change for the next time we submit.
> BTW memblocks_present is on master now (got merged 3 days ago).
Great! We'll send an updated patch set after the merge window.
Logan
next prev parent reply other threads:[~2018-12-17 16:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 17:56 [PATCH v2 0/6] sparsemem support for RISC-V Logan Gunthorpe
2018-10-15 17:56 ` [PATCH v2 1/6] mm: Introduce common STRUCT_PAGE_MAX_SHIFT define Logan Gunthorpe
2018-10-29 17:53 ` Will Deacon
2018-10-15 17:56 ` [PATCH v2 2/6] mm/sparse: add common helper to mark all memblocks present Logan Gunthorpe
2018-10-15 17:56 ` [PATCH v2 3/6] ARM: mm: make use of new memblocks_present() helper Logan Gunthorpe
2018-10-15 17:57 ` [PATCH v2 4/6] arm64: " Logan Gunthorpe
2018-10-15 17:57 ` [PATCH v2 5/6] sh: " Logan Gunthorpe
2018-10-15 17:57 ` [PATCH v2 6/6] RISC-V: Implement sparsemem Logan Gunthorpe
2018-12-17 14:59 ` Nick Kossifidis
2018-12-17 16:50 ` Logan Gunthorpe [this message]
2018-10-16 0:04 ` [PATCH v2 0/6] sparsemem support for RISC-V Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fd0880c-5896-ffee-4d3c-4fce1649382e@deltatee.com \
--to=logang@deltatee.com \
--cc=akpm@linux-foundation.org \
--cc=andrew@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=hch@lst.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sh@vger.kernel.org \
--cc=michaeljclark@mac.com \
--cc=mick@ics.forth.gr \
--cc=olof@lixom.net \
--cc=palmer@sifive.com \
--cc=robh@kernel.org \
--cc=sbates@raithlin.com \
--cc=zong@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox