From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 546C3C04A6A for ; Mon, 7 Aug 2023 15:19:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E834A6B007B; Mon, 7 Aug 2023 11:19:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E35008D0003; Mon, 7 Aug 2023 11:19:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFC728D0001; Mon, 7 Aug 2023 11:19:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C19416B007B for ; Mon, 7 Aug 2023 11:19:34 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 809111A0B5B for ; Mon, 7 Aug 2023 15:19:34 +0000 (UTC) X-FDA: 81097667868.16.6A1EE2A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 50512180014 for ; Mon, 7 Aug 2023 15:19:32 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PTFPVxpI; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691421572; a=rsa-sha256; cv=none; b=ikRmWE/mFpzPsGrPktlAv3bO3HCQhlo5ly4dFk8/ObMlp7qKPNKQZSzZpIa3PKl8Pad0WI 2CEZMEMdmSeCBg7IPGkKEVWzq5bDUgTKj0I1ggkR2RrMMwlZhnX6eqxMd384GnTTVVy8nm T4qmGsIgYqirmkg47IH8Sjn4sZ4YxHA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PTFPVxpI; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691421572; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ILpAQ4IG6NfOMwaDkg0LmIfYykguYhFItNWjhBjizGQ=; b=11kYqYB11lfaVoYoek4QFH/1REVJtVY/eN77fiM2QV8EiZ3ViDnxhIueOe335RGDKSaWBp tKp4EinxED8rH7ems/rqDzkCSRRaRp6I3HAYv006bumpo416Kt2ULdcenkQywd+ztdF6tV wbx3wz9DXwYIV+7FdHA1g70hDscxvrw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691421571; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ILpAQ4IG6NfOMwaDkg0LmIfYykguYhFItNWjhBjizGQ=; b=PTFPVxpI6lopgcAWUHTywU630p+3Nzg1dvW2Ac182Olxyx06NnZrWeEBvNZ9gSNygYpl5e sZWFOI8LwRXT8DRHpwzgACOA5tbXE21UAArvxNwufXqP85fA0x2xMHJdNRRGJkp1v4Y4iZ M6R8twnxivo8+yzGPVhMC+Ptz6PqhFw= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-393-1aejIWVMNMu6V0BCaxfq2w-1; Mon, 07 Aug 2023 11:19:30 -0400 X-MC-Unique: 1aejIWVMNMu6V0BCaxfq2w-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fe1dadb5d2so24405985e9.1 for ; Mon, 07 Aug 2023 08:19:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691421569; x=1692026369; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ILpAQ4IG6NfOMwaDkg0LmIfYykguYhFItNWjhBjizGQ=; b=SJaK8imRpDKsTJyOQnRReq7eQt9bDxeMOlaTDs2d5x4UekbfTYbUeCP9dHsjDp/Pjv y507g10Vo2GRFq7LQdO/I3lf9cNN8te6CZetfW6l6N4S12ZTRNlyOWEOLmTeDg1FXGQa NOLpfBa1E5G1Kxx+tcFk11zA+ZKkYnyXO00Q80OtV/6r7wdT5z+LMxmxb6zdBTitw3SB BtB2IUsrqLhvXIpiJ1vJ3Tcuu/yaHs4kLCRSYRnZC+6Iytt90e+NK+B7S94aUiRXYJwz gL2e3Ui6zJioqIc2Jodurghrw0j/yn82mCmueNV/7uPN674gAlWdfEZ23qQjAFUI+22S z1TQ== X-Gm-Message-State: AOJu0YzGyW5Bzvi285hU4KAuh6bJ8SNa6M22oDv4TI9LTRCEEt3c2RLa sRknF463yLev4TJnnSkZe9Q1qPyIu265nyvBT4FJ2v7WfAACBaB7LKeLqTPnMIDN1/593FiFzXO XFcsFTTjiSYQ= X-Received: by 2002:a1c:4c12:0:b0:3fe:2140:f504 with SMTP id z18-20020a1c4c12000000b003fe2140f504mr6757642wmf.20.1691421569252; Mon, 07 Aug 2023 08:19:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF7ggpZe/EzpiqfSiQqM6rdrPghQn3o0/yNG55O9rd3ALXA4iz16n9j7++2smaGhgMx2Sq87g== X-Received: by 2002:a1c:4c12:0:b0:3fe:2140:f504 with SMTP id z18-20020a1c4c12000000b003fe2140f504mr6757629wmf.20.1691421568879; Mon, 07 Aug 2023 08:19:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c740:5d00:5143:1cd2:a300:ceff? (p200300cbc7405d0051431cd2a300ceff.dip0.t-ipconnect.de. [2003:cb:c740:5d00:5143:1cd2:a300:ceff]) by smtp.gmail.com with ESMTPSA id f10-20020a7bc8ca000000b003fe20533a1esm10986119wml.44.2023.08.07.08.19.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Aug 2023 08:19:28 -0700 (PDT) Message-ID: <5fbe62f8-11b6-6486-85c3-38f196cd1350@redhat.com> Date: Mon, 7 Aug 2023 17:19:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 4/7] mm/shmem.c: use helper macro K() To: Peng Zhang , linux-mm@kvack.org Cc: akpm@linux-foundation.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com References: <20230804012559.2617515-1-zhangpeng362@huawei.com> <20230804012559.2617515-5-zhangpeng362@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230804012559.2617515-5-zhangpeng362@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 50512180014 X-Stat-Signature: ze7mehai1aag4rxhrauas3rajhrb6gcd X-Rspam-User: X-HE-Tag: 1691421572-100703 X-HE-Meta: U2FsdGVkX18DnzWASVOko72294b7cJJju/PGQrXzcrObIMJ3xcFkjkcJZt5YjVCqnoP0KEsgiBTd8yu/xH3uPAI6cyqKy+wtYFhN1/fJ1SE+VJB/HwhHPHZTNGkdA8UDuLMsIDZxd92sKoPApKtPWdGNJ1tbUHoVczmf8xHppMzo2as2in/PsShloIqwby19lXAidzmhne0ju6k8NqCK22yw4MrAjHgmOfefk2WX57n3h3rQt3DmhvPDQFYvkv/4xeb/+NWxN3IrqbANbOFKZ9ckIzUaeT/PUtawKN7GESBYqMXp038slxKBCAiinGwUO34Gu1WTE1XyYvXxf2XY1ShQU7/nYGxkqzdBFN2BZbVbC9eKUgbZ/bt7xJ3F9pCp/ncfHZfxtLof1TViBkNnCIaCKFqr1uqRJbblKup5ArfbvaTKTHcXkbVsI/lDg+Jbix/M+/TyUsnt2dNigvuuh90fy3kWMVKPgjvWJuQd9OW4/XCpGVb/3kLbRgF03ePOudOEM3T5wHwIsIA8RMNd+DQhGqjjKgdbj8iO1W7AGx/ha8pS9quCbi7PaLx5FoCVZpBDO9kODYcvDsM8ZaEqLrv5pUJxyPTLpaGweTmfPlakxd/escfCu7BGjrCYd2EYoNwsqHR+277aefzWekfCoXgDAOHG/bMV/WAlXvopKHuwDQXqPNsc6pV6qlu6wyELQc+0yJ3VuoGuADyQVhjRBSGCRa1p4xO1hMpH3yDawEff1qLutzqoMtp254on5qrTGjh/xCVO+lY8k/mNgaHTdL5tsH4kcjlNv44bds4ZLwNtxlIGMtRLhdD3GI4p+ChifmUAyXBugnNyqkjjMs9GpGIXGinuCNr7n00oM40gq51qIV792kX6Q1MJgfHbV1TVVwkncmS6V7aYlQdLkDGUNUkt6CV4VY2MC8Ge5x46Qdf44tIFbO83lUBSFaje1QugVzwqkHWTFQF/lfdnUnC pkeEYtO1 FVV83OdqiVBdv+sqGNVwyq6w19RnrsZbHCDfoU3FQ2g9Y210zEKGqbMsO4SH5aQZyX43ofLfhD6W/YFotqIy3j8/FWFjQrtlIN1+3ntpaq3ZzTZfHksaVoSUYXE80PiznXLTzKGS+NqDBhg5XQJwtWc8ujajuQJwZ/DUdYUtTodNXyy4JIeOFtLsMflLkSkS1cA7/lz2OowTnkoIPhjru+bo4Yksscdt9sxTSgtlV7QGMDnAUudCfZOZwN7HDEDn7BWs2BeP1tUh62mWbPQ7Pmy9uWWsIwLa7qZa/LhtShVimKjVuTeZB/FHMa0UiA/LqJFwxepBZGWM1G0HYgQqG5gOZrIPCv6bOEqfaEhlizW2GeMOQ40CkZNO+HgvGk6flTyRhh/iVg/NR2E8PIpMS/K5CHefPb3tgxr3vK6AikLSuuiY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04.08.23 03:25, Peng Zhang wrote: > From: ZhangPeng > > Use helper macro K() to improve code readability. No functional > modification involved. > > Signed-off-by: ZhangPeng > --- > mm/shmem.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/shmem.c b/mm/shmem.c > index 30e96dcd71a2..7a0c1e19d9f8 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -3881,8 +3881,7 @@ static int shmem_show_options(struct seq_file *seq, struct dentry *root) > struct mempolicy *mpol; > > if (sbinfo->max_blocks != shmem_default_max_blocks()) > - seq_printf(seq, ",size=%luk", > - sbinfo->max_blocks << (PAGE_SHIFT - 10)); > + seq_printf(seq, ",size=%luk", K(sbinfo->max_blocks)); > if (sbinfo->max_inodes != shmem_default_max_inodes()) > seq_printf(seq, ",nr_inodes=%lu", sbinfo->max_inodes); > if (sbinfo->mode != (0777 | S_ISVTX)) Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb