From: David Hildenbrand <david@redhat.com>
To: Peng Zhang <zhangpeng362@huawei.com>, linux-mm@kvack.org
Cc: akpm@linux-foundation.org, wangkefeng.wang@huawei.com,
sunnanyong@huawei.com
Subject: Re: [PATCH 4/7] mm/shmem.c: use helper macro K()
Date: Mon, 7 Aug 2023 17:19:27 +0200 [thread overview]
Message-ID: <5fbe62f8-11b6-6486-85c3-38f196cd1350@redhat.com> (raw)
In-Reply-To: <20230804012559.2617515-5-zhangpeng362@huawei.com>
On 04.08.23 03:25, Peng Zhang wrote:
> From: ZhangPeng <zhangpeng362@huawei.com>
>
> Use helper macro K() to improve code readability. No functional
> modification involved.
>
> Signed-off-by: ZhangPeng <zhangpeng362@huawei.com>
> ---
> mm/shmem.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/shmem.c b/mm/shmem.c
> index 30e96dcd71a2..7a0c1e19d9f8 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -3881,8 +3881,7 @@ static int shmem_show_options(struct seq_file *seq, struct dentry *root)
> struct mempolicy *mpol;
>
> if (sbinfo->max_blocks != shmem_default_max_blocks())
> - seq_printf(seq, ",size=%luk",
> - sbinfo->max_blocks << (PAGE_SHIFT - 10));
> + seq_printf(seq, ",size=%luk", K(sbinfo->max_blocks));
> if (sbinfo->max_inodes != shmem_default_max_inodes())
> seq_printf(seq, ",nr_inodes=%lu", sbinfo->max_inodes);
> if (sbinfo->mode != (0777 | S_ISVTX))
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-08-07 15:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 1:25 [PATCH 0/7] cleanup with " Peng Zhang
2023-08-04 1:25 ` [PATCH 1/7] mm: remove redundant K() macro definition Peng Zhang
2023-08-07 8:31 ` Kefeng Wang
2023-08-07 15:20 ` David Hildenbrand
2023-08-08 10:44 ` zhangpeng (AS)
2023-08-04 1:25 ` [PATCH 2/7] mm/swapfile.c: use helper macro K() Peng Zhang
2023-08-07 15:18 ` David Hildenbrand
2023-08-04 1:25 ` [PATCH 3/7] mm/swap_state.c: " Peng Zhang
2023-08-07 15:19 ` David Hildenbrand
2023-08-04 1:25 ` [PATCH 4/7] mm/shmem.c: " Peng Zhang
2023-08-07 15:19 ` David Hildenbrand [this message]
2023-08-04 1:25 ` [PATCH 5/7] mm/nommu.c: " Peng Zhang
2023-08-07 15:19 ` David Hildenbrand
2023-08-04 1:25 ` [PATCH 6/7] mm/mmap.c: " Peng Zhang
2023-08-07 15:19 ` David Hildenbrand
2023-08-04 1:25 ` [PATCH 7/7] mm/hugetlb.c: " Peng Zhang
2023-08-07 15:20 ` David Hildenbrand
2023-08-04 3:39 ` [PATCH 0/7] cleanup with " Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fbe62f8-11b6-6486-85c3-38f196cd1350@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=sunnanyong@huawei.com \
--cc=wangkefeng.wang@huawei.com \
--cc=zhangpeng362@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox