From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC7D8C021A0 for ; Wed, 12 Feb 2025 01:52:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 699FD6B0083; Tue, 11 Feb 2025 20:52:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 648FE6B0088; Tue, 11 Feb 2025 20:52:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55F426B0089; Tue, 11 Feb 2025 20:52:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3A7686B0083 for ; Tue, 11 Feb 2025 20:52:09 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B1923812EF for ; Wed, 12 Feb 2025 01:52:08 +0000 (UTC) X-FDA: 83109617136.16.1E23605 Received: from out30-111.freemail.mail.aliyun.com (out30-111.freemail.mail.aliyun.com [115.124.30.111]) by imf25.hostedemail.com (Postfix) with ESMTP id A47D6A0004 for ; Wed, 12 Feb 2025 01:52:05 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=X1ThpAFV; spf=pass (imf25.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.111 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739325127; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KwxKW1SDDYgfgG2N6v3DrfWr2V+f8zrDXRD4+gXBJvU=; b=jKRxJW6gM8Fmt+kgq89Ip4Ix/6TUNdtP/y9NZZgN9QIn6Ad/VApFGlZambLDNSNkHpOAy7 OdzSik7MnjyqiLXad6rMWvtAlQ7UCwpf7vGE/dFbO4o9bTAvaHy/SDx/E9dUuSBnHny1R4 tL5zeS3m3eX1RHClThJGr2aVDOsftCE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=X1ThpAFV; spf=pass (imf25.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.111 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739325127; a=rsa-sha256; cv=none; b=vXVAMPoOzTBDt8YuiR5lliDGE50ou6Wt+V2Q4+Zw7xqCqw8Z6cqG/YdlADsKGFV9uKLMAx 3sSVmxI4hPJk+fATZgbODLgi1FDcKj9Jtg8/SsUklq5P3+Lnblml9aO4swlurzdd2jO6rv QhgiJW3pH2wbpZ+GfAaahaWW1F2oUfw= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1739325123; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=KwxKW1SDDYgfgG2N6v3DrfWr2V+f8zrDXRD4+gXBJvU=; b=X1ThpAFVCDXpDqQw4YKIia98lea9MH8ZD/V5f68IHJcXlN7Npfob6UbYZ3pLGqCS+mbfbKDBGSKoi0W1msd3tb8Ykzh4gZYvmGPl1cQo/ICXzgSW21NyTGthSG2l8CW0K5WkR7vzM5xGgPNts/hORc2LyxcCL78ko8unHs2RLmk= Received: from 30.246.161.128(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WPI8Bo9_1739325121 cluster:ay36) by smtp.aliyun-inc.com; Wed, 12 Feb 2025 09:52:02 +0800 Message-ID: <5fb57072-96a6-4ce9-8636-f1746693cfff@linux.alibaba.com> Date: Wed, 12 Feb 2025 09:51:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/4] x86/mce: Collect error message for severities below MCE_PANIC_SEVERITY To: "Luck, Tony" , "bp@alien8.de" , "nao.horiguchi@gmail.com" Cc: "tglx@linutronix.de" , "mingo@redhat.com" , "dave.hansen@linux.intel.com" , "x86@kernel.org" , "hpa@zytor.com" , "linmiaohe@huawei.com" , "akpm@linux-foundation.org" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "baolin.wang@linux.alibaba.com" , "tianruidong@linux.alibaba.com" References: <20250211060200.33845-1-xueshuai@linux.alibaba.com> <20250211060200.33845-2-xueshuai@linux.alibaba.com> From: Shuai Xue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: A47D6A0004 X-Stat-Signature: od9qkoboqifj1sb99ucs1jg49och1bta X-Rspamd-Server: rspam03 X-HE-Tag: 1739325125-930105 X-HE-Meta: U2FsdGVkX19d85gRdPOAkx4s3ucoRL6IDVmS3VLIv8kL6y9oK8IEaewIUIN3K5gEMCA7E7Md5MwjlGjumLfvT7QBPaPMbviQ6v3q0ZxqnCcVBzk8wyjqlH++fKu4FFsiH7GU+nOLXsCvC77VSxaTOTMGq3oNjm2blL/XJWrZiPXOEl7xfBiC02tX8UsXu7aKlt6pjkYRgrB/LpoSmNWdSyxnYfSrXxlq7dZuJe8kEoo9wMX40IwbJJhUiftIpY+zj1OU6KPSqta/03dP23nqhcOwJwfAsFKNGk0c0LNXa150/XNn+bKswHohJCozrRXOg7EFBjNA1SIGf72Hgy4BSr/O7Igm4PYf5Oq8KMMegBVH+YRNCGB6rrogldESKn8I8xO/9Q9q8rF9BRmmpRZks6EFpXL4smrR2xaJOyQu9Ph5HfVAYvY4B3zM7ahBcf7CVDleWxPvPHrQF8b3RMAW/6HxhEzthfD88FcYd33pmbap7RPc2wN1ROgEeY7gziZabUiGazVj/C5iVlkhFY2/apH7ykVJUPsc6FzmT7xxp7KVeFjFfkUwZl7m2IhdL3G/6moDXEGfzpt8PPgqIkJsBFJt3X2hYALmtBZ4UjrMZ6Sfh1HRkS1lcDo8OvmscTDd2LqpNsV1BgJT83nYgSTVJrar+ZUKcyFk6bKjBZPoj0Q9j5JjQ8f4MLQCsvKXGyNIikrLG1c1X/NMBO3eV9RoW+/8FdkwaXwshiUZfm438bGfjZsE6lA/74YH/Y+9Yx4/ukGU5iEO+6TNVYLlbzLT7TtIL273/3qsr5rGxLr+4gha28rd4jJIro/Vf43LP3XEl3q3yR7BgblQSBYOOKAuoPOSFezGNi7nfEPvDJ20hSrpO68n0CBkXiqDAyxL/DBNQYziGPkO0LXYzRcZwU8UI38l+DpTe9ks157cJVc9HfSe7TVBS0xB1/FGJZLXEgN9zgk8K6O0WAESL9vPnH6 gjtQYz43 vShpzhZPrhuntLydsPRyDwHGloAWfGOJQl6X7X9I6JhTiaCUoL+n+xZE8U0bShwXG87FroK6RrZCgXP0xN5H393VRfwvYRXi6ObTenMUzeAL7Ou5vR+/WOuaduheW3Q+siZW9WAaLxjvMtav2rKUo1RzYP7z954Rzh8OEjKnz/bbs7izggO0Q6KO9J+f6c7te7AJKsj6ghiw2tfSHOVaHrj95/8CjDrRU9uAezHybBRJUUISsNBFuKGCtFnV8YkER4WytpnempOHE30N3FMNGojlnW4BRAWeIxxkl+KcsaMz0sV6SITRFvG5tIo8TkCNputYnApL+eZI+O1mPVd5BkdKpyhN/+rDUgjAurWUYqeqR95N2XCXYcpo3n4T20SBQUUwGFCvSj7+5LFbn8zerlnOcM1Lw9m0xPY7n/ut5gehprXu6wt84Sy176Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.379051, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/2/12 00:51, Luck, Tony 写道: >> + char *tmp = *msg, cur_sev = MCE_NO_SEVERITY, sev; > > Should cur_sev and sev be of type "int" (since that's the type returned by mce_severity())? > > It doesn't matter today since the list of return value does fit into "char", but it is setting up > to fail if that should ever change. > > -Tony You are right, I previously only focused on the fact that the field 'sev' of struct severity is an unsigned char. Will fix it in next version. Thanks. Shuai