From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E27CFC4332F for ; Thu, 21 Oct 2021 08:04:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 72DDB60EB2 for ; Thu, 21 Oct 2021 08:04:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 72DDB60EB2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 128DC940007; Thu, 21 Oct 2021 04:04:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D7026B0073; Thu, 21 Oct 2021 04:04:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB8C4940007; Thu, 21 Oct 2021 04:04:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0225.hostedemail.com [216.40.44.225]) by kanga.kvack.org (Postfix) with ESMTP id DDEB16B0072 for ; Thu, 21 Oct 2021 04:04:13 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A778D29327 for ; Thu, 21 Oct 2021 08:04:13 +0000 (UTC) X-FDA: 78719706786.30.01D35BD Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf30.hostedemail.com (Postfix) with ESMTP id 9B28AE0016B0 for ; Thu, 21 Oct 2021 08:04:07 +0000 (UTC) Received: by mail-lf1-f41.google.com with SMTP id bq11so10412lfb.10 for ; Thu, 21 Oct 2021 01:04:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WVuVc/pTL60G1S+pyJWiP1YTmMHNb2+xE6ALYVAi/xw=; b=IEEro4gNH3DIejCXpe0LTEo03FXaRhBYkaROjLXCHDflecMHf3lv+ZnmPuKnlnT5Fy je52KNQ/4D9i2+nXYvvuP+an1Pnlw7PxN4XUfbxmSd1diABe1aysqs6pFnLw0TQalFe6 Vb0q1sKA7Q/KMsvD+g9kIlKuxrBAdqSDmOUHhclAI52k5RjWxo1RpFfwMIVTAUG5Tqpv lmd65eKglHQZDWRKqtpnDYnUPHiF9jt7Oq67BAwl1HYkwfS4SSPZ0vYVIhqMHhCaMpm+ eoPoiDcs2osNu6vsHNgwY4FzxNKjBkhWPi/d8z/Q37rh46hLiVx/SqVJlpmWiMrVxDsb 0gyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=WVuVc/pTL60G1S+pyJWiP1YTmMHNb2+xE6ALYVAi/xw=; b=S352YZCqpLzjfHJg789wGN0BVWzz47Ji0TDXzB2EzL5JJXb92RFD1Ptf/BoZrwIcfD B2HcNCGdKpdvPQTkbMMTSwmpKVY+kJC2Sw7wuToAgmYhvyyCJUt0yl01qYh4AqLsgVdS 19piNO7lNX6yymS24JasmC+T5HY3ZCuEJDkzC3Hw9mEJ770crGm4E9MRJzv8LUO0wGGU 7t1viiktME9rhiuRRx0f7puLRimeKh9nUH1qQ4gOw2yUQ78P+v0vt85OSxP98FvI/pyW D+3Lhw71y9LnDHeJZzZpXiPkhwOeejZdV/FcDuTKHID0XDI0eq43Zsi15PsB/k5/06j9 oEOw== X-Gm-Message-State: AOAM533hf/T4y83Yj5cb6ykFhpvmJUF0Hioyf2Ywy7uTU2pHMQmyYWWw 3d+NrwhK388gFKp0sNyjqbQvnQ== X-Google-Smtp-Source: ABdhPJwH6CfInm0R8kLy2CulWi4rcXhCTIo2C2PA9o2nT1Cjc31WnBrrJLTnA3vNKuAFp0LelU1v2w== X-Received: by 2002:a05:6512:3055:: with SMTP id b21mr4173674lfb.316.1634803451737; Thu, 21 Oct 2021 01:04:11 -0700 (PDT) Received: from [192.168.1.102] (62-248-207-242.elisa-laajakaista.fi. [62.248.207.242]) by smtp.gmail.com with ESMTPSA id u25sm391601lfr.279.2021.10.21.01.04.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Oct 2021 01:04:11 -0700 (PDT) Subject: Re: [PATCH v2 2/2] memblock: exclude MEMBLOCK_NOMAP regions from kmemleak To: Mike Rapoport , linux-mm@kvack.org Cc: Andrew Morton , Catalin Marinas , Linus Torvalds , Mike Rapoport , Qian Cai , linux-kernel@vger.kernel.org References: <20211021070929.23272-1-rppt@kernel.org> <20211021070929.23272-3-rppt@kernel.org> From: Vladimir Zapolskiy Message-ID: <5fb2f209-e048-f6f9-4ad3-96645d23fce8@linaro.org> Date: Thu, 21 Oct 2021 11:03:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20211021070929.23272-3-rppt@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9B28AE0016B0 X-Stat-Signature: krcmfh7z18ysn96b63qsx9bqno1rxuey Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=IEEro4gN; dmarc=pass (policy=none) header.from=linaro.org; spf=pass (imf30.hostedemail.com: domain of vladimir.zapolskiy@linaro.org designates 209.85.167.41 as permitted sender) smtp.mailfrom=vladimir.zapolskiy@linaro.org X-HE-Tag: 1634803447-120699 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mike, On 10/21/21 10:09 AM, Mike Rapoport wrote: > From: Mike Rapoport > > Vladimir Zapolskiy reports: > > commit a7259df76702 ("memblock: make memblock_find_in_range method private") > invokes a kernel panic while running kmemleak on OF platforms with nomaped > regions: > > Unable to handle kernel paging request at virtual address fff000021e00000 > [...] > scan_block+0x64/0x170 > scan_gray_list+0xe8/0x17c > kmemleak_scan+0x270/0x514 > kmemleak_write+0x34c/0x4ac > > The memory allocated from memblock is registered with kmemleak, but if it > is marked MEMBLOCK_NOMAP it won't have linear map entries so an attempt to > scan such areas will fault. > > Ideally, memblock_mark_nomap() would inform kmemleak to ignore > MEMBLOCK_NOMAP memory, but it can be called before kmemleak interfaces > operating on physical addresses can use __va() conversion. > > Make sure that functions that mark allocated memory as MEMBLOCK_NOMAP take > care of informing kmemleak to ignore such memory. > > Link: https://lore.kernel.org/all/8ade5174-b143-d621-8c8e-dc6a1898c6fb@linaro.org > Link: https://lore.kernel.org/all/c30ff0a2-d196-c50d-22f0-bd50696b1205@quicinc.com > Fixes: a7259df76702 ("memblock: make memblock_find_in_range method private") > Reported-by: Vladimir Zapolskiy > Signed-off-by: Mike Rapoport this change variant also solves the reported problem, thank you. Tested-by: Vladimir Zapolskiy -- Best wishes, Vladimir