From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7954CCD3427 for ; Mon, 2 Sep 2024 06:19:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A049E6B0319; Mon, 2 Sep 2024 02:19:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B2EC6B031B; Mon, 2 Sep 2024 02:19:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CA2C6B031A; Mon, 2 Sep 2024 02:19:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6D2E46B0114 for ; Mon, 2 Sep 2024 02:19:40 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BF96C1C69AD for ; Mon, 2 Sep 2024 06:19:39 +0000 (UTC) X-FDA: 82518796878.07.449FD3F Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by imf07.hostedemail.com (Postfix) with ESMTP id B296B40009 for ; Mon, 2 Sep 2024 06:19:36 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725257883; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HHgEOXh7sKDdLlkFOPXQwu8Qe2Jbr6SkQlE+sWd/XmQ=; b=Bqb8HdcRI6s89d3MpCHBW2kMTq6R6k+7UyWe6CrfCKLZ8m6PZ+H8KAjtzSD89k8ziA6L+t fkjXedlqMnAGJcFxjtpfo3uhjx3xldAePjvIaQpPS8fptIF3OU5KhBRo6tRu9g1t0IV1By oCvKUrm0+SaHUIoV6dTOv+h6ASH9ROc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725257883; a=rsa-sha256; cv=none; b=I0k/7iba+4FCFb66QJL5Xk0JoUwVcPx6IV2Jx8jOZawnUnMLilZLP4t++7O4wvzdpdz+Zg 4E4eiD6vNCn8OJ2RcuOvLmLm/XzKUQSRVBKSO4XPiO6/pEePSbF3j0Rv7T1Nvr4HMtKP5W zH0UMtXReZhP18Wl56YogkightvgWCE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of christophe.leroy@csgroup.eu designates 93.17.235.10 as permitted sender) smtp.mailfrom=christophe.leroy@csgroup.eu; dmarc=pass (policy=quarantine) header.from=csgroup.eu Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4Wxz9y3zggz9sSN; Mon, 2 Sep 2024 08:19:34 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oh9ReoBVOWjB; Mon, 2 Sep 2024 08:19:34 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4Wxz9y2zjLz9sSH; Mon, 2 Sep 2024 08:19:34 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 50A268B76C; Mon, 2 Sep 2024 08:19:34 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id gAfIussLeGez; Mon, 2 Sep 2024 08:19:34 +0200 (CEST) Received: from [192.168.234.158] (PO19952.IDSI0.si.c-s.fr [192.168.234.158]) by messagerie.si.c-s.fr (Postfix) with ESMTP id B2F1A8B763; Mon, 2 Sep 2024 08:19:33 +0200 (CEST) Message-ID: <5fa50d78-6764-4f99-87b3-7bd7edbeea5a@csgroup.eu> Date: Mon, 2 Sep 2024 08:19:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] mm: make copy_to_kernel_nofault() not fault on user addresses To: Omar Sandoval , linux-mm@kvack.org, Andrew Morton Cc: Christoph Hellwig , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-um@lists.infradead.org, kernel-team@fb.com References: Content-Language: fr-FR From: Christophe Leroy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: kukjz1ap4kwim9aiyjc1yb85ebhjsk1k X-Rspamd-Queue-Id: B296B40009 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725257976-536159 X-HE-Meta: U2FsdGVkX183ngTPznIaDden0AjesUcrJaQXwSiSW0NrOsDcB9nfSNE0x/yCvLNLB13twC7VHaRGQiQG9p1a+6wIR8tOrLxyqBWqWBBI9fxAECac4pxPwUlekr+iY4YVYeh/SBn1qOxvE1DLQ+TDKRwX2F+irlyX8IiL5/v5O3CKwDP5ARkVV5He4qu+7d2+N3RLZTGusF8rkRSjqVu3HDqvKOllzZEib2Vgjn62sPFJvH6BUvK4Z9+ud6bRdKpDd19/JemBSTtztUMCLHn3zCRXAkJSeQm+UG6jQzUGGlPn4N5M93guL20gprqXuNSbByI0k2fK/wqc386GQCqfOxgDLhzwMd/abvSG3/PrH6JWlI/zCt6kjzv9EvbqOvli12VXmhl6xSqiTR4UV1MxIMAXbx/1qsXRWUK1XGGO+sxT0SvIyjS6YC5Lp27U3ViFdJdcyCdHa7GEYrEh+lXUVv8gGsvdTb3iv9sBXBw3HGYbIVv+CQxQEe7hQbXA7TMfPFnBaDQ62DlnVehwwkROVYs7bKpaakdJNeuUoto0eX2D33ePXnibtYDNi3fGCr3lk3xpu/Xfj7QMY2WCCZqyYAJFjX0CS7W8e4u2I+UF6Y4JiZvS0zh4+h6D4wEsLThe4HOjI/NGsPiRstKYEpV3WGr1MWlI3y+994kWnMvvyyrPcf3rl39L/YUH2UhtimdJH3vqvALrzvgDu7eHzFI3SguLwb44Lxfn2TmorZpF0ccx1sH3bmek/2Sld9QzUJf6q1TOxyO+qNwVr7DwFzedGvbxv8IEB0F5xPOYQdmMP16kbGY70aVR3m6keAPSbSOe9+0fQGErdesGaof/+dU0CGs5E4eHlD6BJgyQX/yKBhqKqolAn2P9lTRdowFVVzoGSs4PBQG9CZ9V/y4OINeqs0Mc2BfAISLD8QhrJiBit0q5adRvk5qggE7buwzleXW8m376OVRMRatQhYFwc8z LLAXgQj2 +YaiyKnh8TxmCp59NzjCc24Ug6+4VkxBaoZ/3FFc35Om1TY30lxBWENtBONvWd/lIInCPT4DQZFVhs+5fA/TDhL8XH2fTXFwYx96emdZ8y6LRAZVSjH7j9jwCVVzkOerxnDFwKJR7VhOXn0lrm5RvS4wdCouKrhm6023BrMYAhuvfUwd/vwr8wxndDZqEOfDDCaP615nsAStjk9EkY/26JeUb7v3GyfLselKs9BvnkpSeRlDnz0DHuGl3wGRKD3iFVFiGSOFZlHqlWhjcbZZcMRQXlavHgTEVIl0JvNrKrDSnwTe9jFwsLCnvP9w2fDn1ar3j+YBq8LtWeRPzAKFw4fvn/vbcWjM2ZZyRWjF5f6oDHnuRQutliGRc+hJI20lPaRKyDa3D5tp3NV0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 02/09/2024 à 07:31, Omar Sandoval a écrit : > [Vous ne recevez pas souvent de courriers de osandov@osandov.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > From: Omar Sandoval > > Hi, > > I hit a case where copy_to_kernel_nofault() will fault (lol): if the > destination address is in userspace and x86 Supervisor Mode Access > Prevention is enabled. Patch 2 has the details and the fix. Patch 1 > renames a helper function so that its use in patch 2 makes more sense. > If the rename is too intrusive, I can drop it. The name of the function is "copy_to_kernel". If the destination is a user address, it is not a copy to kernel but a copy to user and you already have the function copy_to_user() for that. copy_to_user() properly handles SMAP. Christophe > > Thanks, > Omar > > Omar Sandoval (2): > mm: rename copy_from_kernel_nofault_allowed() to > copy_kernel_nofault_allowed() > mm: make copy_to_kernel_nofault() not fault on user addresses > > arch/arm/mm/fault.c | 2 +- > arch/loongarch/mm/maccess.c | 2 +- > arch/mips/mm/maccess.c | 2 +- > arch/parisc/lib/memcpy.c | 2 +- > arch/powerpc/mm/maccess.c | 2 +- > arch/um/kernel/maccess.c | 2 +- > arch/x86/mm/maccess.c | 4 ++-- > include/linux/uaccess.h | 2 +- > mm/maccess.c | 10 ++++++---- > 9 files changed, 15 insertions(+), 13 deletions(-) > > -- > 2.46.0 > >