From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6368CEEE265 for ; Thu, 12 Sep 2024 22:45:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB2246B0089; Thu, 12 Sep 2024 18:45:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3B536B008A; Thu, 12 Sep 2024 18:45:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B02EC6B008C; Thu, 12 Sep 2024 18:45:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 90FAA6B0089 for ; Thu, 12 Sep 2024 18:45:24 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3395C160B39 for ; Thu, 12 Sep 2024 22:45:24 +0000 (UTC) X-FDA: 82557568968.12.33E9C11 Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf29.hostedemail.com (Postfix) with ESMTP id 8D241120006 for ; Thu, 12 Sep 2024 22:45:21 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=DLDSueZI; spf=pass (imf29.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726181015; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=77ok5TgUdxkvklpoX29JaVNVSQrsyW3afANiB8lorG4=; b=xPcq/0+pL6Vm3r+ONeDOO5ueMnpmksn8/O07DB0AI2i0VMq9EAaWzEsxrq+jihkO89/g1f 9kW+Hd5yY16VW9NjiuIpYHCRlh2IhkkIMMvTZwXSi28MeH3y+1SfaYlIqirNVqG9a2Bi7W /U3SveuUoth5Accy2emHV522AqcKpUo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726181015; a=rsa-sha256; cv=none; b=u9TKL8YcFPd2vRMbJ2JmigJauQYLzhXtPhft5vGzu3QVIpZf/tzxk0+OKGR5kB08nLIoJ0 kHm3yoyEl4NyLB5SkKtmigLUjXcvhAFzMVhDl+rgA80ifp3CRxO9ekxyWwKfWPVSKRXZC9 1JLvY/I+l4QqUQ3tJnC8+26OOUfkjdc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=DLDSueZI; spf=pass (imf29.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.org; s=default; t=1726179662; bh=l78uYYUDdPq8NYE6gjoHUQJq/YK7wZojSJ0RQKOF0aw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=DLDSueZIc9xylIWaSQCWxbKxnRD/+z5nSSQhuanrh0lVcivSVWajubmOwVpR+qE3S ciT/0JUTH2P0byafBd9FRq0ke3OntwIkYLn4SSVp7Y4JM1o9Po3/wEpRRsl0507v3w jtXpwHVegSlGjJn4ujk/SAuokCuXLyarJVwuYEbw= Received: by gentwo.org (Postfix, from userid 1003) id 538E94027D; Thu, 12 Sep 2024 15:21:02 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 51A73401CB; Thu, 12 Sep 2024 15:21:02 -0700 (PDT) Date: Thu, 12 Sep 2024 15:21:02 -0700 (PDT) From: "Christoph Lameter (Ampere)" To: Matthew Wilcox cc: kernel test robot , Christoph Lameter via B4 Relay , Vlastimil Babka , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Yang Shi , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Huang Shijie Subject: Re: [PATCH v2] SLUB: Add support for per object memory policies In-Reply-To: Message-ID: <5f9e2cbd-a7a6-53c1-8272-6f91fb525571@gentwo.org> References: <20240906-strict_numa-v2-1-f104e6de6d1e@gentwo.org> <202409080304.haF25cFZ-lkp@intel.com> <2011fcea-b4f3-a7ec-e747-6ee0195452e1@gentwo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: g1p6g89y18tjozekkz8tww3q78iex9i3 X-Rspamd-Queue-Id: 8D241120006 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1726181121-842475 X-HE-Meta: U2FsdGVkX19BYltKbpXk2pJovM3Kzjz+73l/zEv+7TcoA51/Fgifi3nOnEc9r7CJazTo20TTfQjfGsFi81YecaJefCxHgS+a4cUtJsi1ecziSs+aenk8vrEPnalM3xVI4ZPDGtbF4sWVT1Q0tmwZFSin4YOkbPeL7f2RfcUSbMq9FZWu0qnXtvLAZA98fKeWJ4KYlVw3ZU3zoVLcXBTEemDh/yEfazeG0MgBnu+Gyx4dwi2Rqyj7MgW9PKwAwputziJIz499UFx+pug1NRL4om2hg2DtxPcc0oQBVeoqXqF1LQj/POY7A41iHBmvcLjIgHEuAS9x6UKFvPW6ocwC++yYhFYBVnMVu0G2jwSxczhexOPuRgdtQQElcWsDsqOKLE6FPGgwMNvz5zNXJPMeyvI1KTjNGb921C1SbMql4JMOCUAwsqDtpeDmQ/kIexoBi2zsGrzkpvkf3q8esMeacpss5GK/9AH8ixrQli0OkwgPjRIDvAgbLZe+NbpDE0r7IceVPS7y7dM1ei1thYSm8zXhRePUpdLVjDpfs1MtIeaQxm0qVsJpNEwOP5R1DpB11/EPZbiCXWP/nLansfItghBJrTuIzjEPD49Nrcu4x5OzZYL9CXgevzY/6pHWArnhLEPMZIRLB+Xc1lLybf+CSJZUzfwdkN9mwi7hiogn8NVODXeAk79sZIH3Iq04QndFeV1qPT6o1HnVRmC17T9CLgTVk7yJFM22X2Pmykr9mvPyVPJvFPoxwK9mNMiSL8k9DpX/WK80MySlLdWbxdBEHQD3A3AaOyzimfyNOoDgQsjdk8Xk8BN0RMeUGkim87LDz+AR9MOYC9wSsi46lGj9qyMeaTLE3B3oBX87/zsN1BXubW2MUszauSQKl0V96zwc1ASRFKxOhlbOGEyiZItvzz/ichfHMVQVwG+InuwDhoItLiGO6CvEhrATXTICz5eNZUP/dGpqqj0EdlY6WM3 8veazceS XV1LZDhtyK1aBpT4h00QCboB6Tn04thNfWEX1X6ZLLNz5HLwJE4j8QgD8iH7kQfESDSl6J8YIRn5ZZ1wIiHJhx+TScSvOPNI9Vb/Yp3k/n5LSuIran3reAUxNTKyzT07oBOC60rLNA8Q/aUSY6H6dbkO/bsYkrxhbiBCBsM7OUCozLw+S4v+xzAZEkPYnY3gTTFGYxoEkGgqt6kAE7aN9K9URJFF1hgkOi/Ao2Ka4astlSVECxuR5L18+I2ygGjsf9scFqzwXgSrbihHgtp4YLE6boUahym1kuyiyZbeFyKuG2xCNvDOECxECSSB9aJ6zBpMtz9dnqcPOAwWrdAgKLcEKQ5R7ZBFDI72FHAixQC+l6wiV70waHOmpsddCjYnhDdk5Sl9vKtbDUpREeQcAQVI9NA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 12 Sep 2024, Matthew Wilcox wrote: > On Thu, Sep 12, 2024 at 09:15:34AM -0700, Christoph Lameter (Ampere) wrote: > > > sparse warnings: (new ones prefixed by >>) > > > >> mm/slub.c:222:1: sparse: sparse: symbol 'strict_numa' was not declared. Should it be static? > > > > > > Ummm.. This code declares strict_numa. Whats wrong with sparc64 / sparse ? > > > > > vim +/strict_numa +222 mm/slub.c > > > > > > 220 > > > 221 #ifdef CONFIG_NUMA > > > > 222 DEFINE_STATIC_KEY_FALSE(strict_numa); > > maybe this should be: > > static DEFINE_STATIC_KEY_FALSE(strict_numa); Ah double staticity. Thanks. >From b239f4f26094845af74b091682f0bdcae56b5123 Mon Sep 17 00:00:00 2001 From: Christoph Lameter Date: Thu, 12 Sep 2024 15:15:07 -0700 Subject: [PATCH 3/3] [SLUB] Make strict_numa static strict_numa is only used in mm/slub.c so it can be static. Signed-off-by: Christoph Lameter --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index 2fa7c35e076a..56e320082c09 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -219,7 +219,7 @@ DEFINE_STATIC_KEY_FALSE(slub_debug_enabled); #endif /* CONFIG_SLUB_DEBUG */ #ifdef CONFIG_NUMA -DEFINE_STATIC_KEY_FALSE(strict_numa); +static DEFINE_STATIC_KEY_FALSE(strict_numa); #endif /* Structure holding parameters for get_partial() call chain */ -- 2.39.2