From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD5B3C678D4 for ; Mon, 6 Mar 2023 13:59:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E5B8280003; Mon, 6 Mar 2023 08:59:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 36F63280001; Mon, 6 Mar 2023 08:59:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EA6B280003; Mon, 6 Mar 2023 08:59:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 09BCD280001 for ; Mon, 6 Mar 2023 08:59:37 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D024116059F for ; Mon, 6 Mar 2023 13:59:36 +0000 (UTC) X-FDA: 80538631152.05.FEC2EAB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id A2E2E180016 for ; Mon, 6 Mar 2023 13:59:34 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SXUDk0tC; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678111174; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r/wVyxF7X8v5Rihnr47AJpuo/zEUiUXj51F4TpZ8Hk8=; b=7Od/rV3580HCYCAdm9AiqkLSPDUtFR7i98I/Qt3Mwdjp+V/EHlQ/IWybMpYADtyk906hQk RoRl5lVvECyMNF6NwvYjKyoR5hlw+njmDsr7QTgUeyX7aC4+k3v+fvL8vhnM+vDhoiHASe m3wbwhNNoBDzlCi5Hpqh5uBBYrqyMeQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SXUDk0tC; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678111174; a=rsa-sha256; cv=none; b=Js1Lzc6kOM0bH2WnVFoRpOnvgFd5AyIEvqgB9QPgAZOQHzgkvPcgBHFCD4HxwjeqF2JzBc f8aBCWGZG2aN3F07r5iy+sc3GWDNq264t9CFclwtMo76EW2NudCqU1WJyrhiLKLb+k6kN7 bnfxG/h7Az7YLvHBlXMmeWcIBqCxQfE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678111173; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r/wVyxF7X8v5Rihnr47AJpuo/zEUiUXj51F4TpZ8Hk8=; b=SXUDk0tCoGZgTXqRkJRpcl/ag3KZ5kY1jcM/UjKw+7hgXWxFGBWaHsLU2OhJlFJKjPPZVV Z90yStPFhXst7emgw+s2JwRMcy2D/JKY8tpadtD++8yUrlFbVhWlOaNC7aZcMgYpg0qbtk tFFAmarGglCYj8RyJCKQlz78ALRZbhc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-44-FpMmc1D3O_S-3h8PrthAdA-1; Mon, 06 Mar 2023 08:59:32 -0500 X-MC-Unique: FpMmc1D3O_S-3h8PrthAdA-1 Received: by mail-wm1-f69.google.com with SMTP id e22-20020a05600c219600b003e000facbb1so6771294wme.9 for ; Mon, 06 Mar 2023 05:59:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678111171; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r/wVyxF7X8v5Rihnr47AJpuo/zEUiUXj51F4TpZ8Hk8=; b=HHOw20eYPE4kSH4PgK79qvt8R4hphfEEBVxTXi9mucJHirGqHeC80mY5a4yDQwsgVN 5l0yr4s323beG7fHUY6WQlVI3SAtQemkatzXs/smHOIJXTgQS/yQFG7ONAuA1oc/g/M0 AX+ryJ52R1MRsxdiTTPzV6UD0hfM02lhyayRJ6h944i658pLU230MCpr4IKY6t1oGRkY 8SEUbslSZr8xB7/y2k2EwSIHT2KKcVNz+yg+JNIJOGE0Y5KYVPPji+E1oJsClw9a4KdA jMT/1lppy3oLTNp4lHFXrtVb1mirbbaaamHvNgx1SzSEz0QipL22v44200ipXYLiopJi 1tuQ== X-Gm-Message-State: AO0yUKVf02nIkJ1HC+S8fNYnG9ipYqgFd8/ZH2ZMIiU2oRp0Z1szTPax cqrhl2z+H4vETl42CXJNGYNIWN9F5RQVPdADbCU84ZrN1VCCepxAJda3MWX0BCHHoSZYLQqjZym mGAX29WGlzX8= X-Received: by 2002:a05:600c:4ecf:b0:3eb:399d:ab1a with SMTP id g15-20020a05600c4ecf00b003eb399dab1amr8875638wmq.21.1678111171450; Mon, 06 Mar 2023 05:59:31 -0800 (PST) X-Google-Smtp-Source: AK7set/rppROKlCDe1OMxkgmAULnb3zDPT283NgVkX5TfaUiRMqCs34bM9FlAufSTBytifeaefB1wg== X-Received: by 2002:a05:600c:4ecf:b0:3eb:399d:ab1a with SMTP id g15-20020a05600c4ecf00b003eb399dab1amr8875617wmq.21.1678111171096; Mon, 06 Mar 2023 05:59:31 -0800 (PST) Received: from ?IPV6:2003:cb:c704:3500:b8a3:191c:eae:cc05? (p200300cbc7043500b8a3191c0eaecc05.dip0.t-ipconnect.de. [2003:cb:c704:3500:b8a3:191c:eae:cc05]) by smtp.gmail.com with ESMTPSA id v28-20020a5d591c000000b002c6e8af1037sm9895953wrd.104.2023.03.06.05.59.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Mar 2023 05:59:30 -0800 (PST) Message-ID: <5f8a3f21-86cb-639e-66d8-9b40a218618c@redhat.com> Date: Mon, 6 Mar 2023 14:59:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/6] shmem: set shmem_writepage() variables early To: Luis Chamberlain , hughd@google.com, akpm@linux-foundation.org, willy@infradead.org, brauner@kernel.org Cc: linux-mm@kvack.org, p.raghav@samsung.com, da.gomez@samsung.com, a.manzanares@samsung.com, dave@stgolabs.net, yosryahmed@google.com, keescook@chromium.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org References: <20230302232758.888157-1-mcgrof@kernel.org> <20230302232758.888157-3-mcgrof@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230302232758.888157-3-mcgrof@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: A2E2E180016 X-Stat-Signature: 9om91bd3iw18if4e33xschg4rso13ykb X-HE-Tag: 1678111174-2163 X-HE-Meta: U2FsdGVkX1+wzrf4lNLb935duzQv+38imR11IpnOHsMfPuQHTYLe8OIka9oY9aMPSC9WkMbz8sEU3jK9SRtsCGpId5pIpD1fp9pJHwJhgWjYUnLFe9G+RxWhfi9PF3zJjyRlqHNQaOUZPEwyms3lRQNavT1wBVkxZ4EtjmjZEIotBmxEIAwab7whfAzaJAOhgYDPAQCZO7natQu6RCKH7wEJRWh8lf/iSmM3ytRhsEAjKkxFmBvb0lGCww15yJ1hl2JU6XSHbkoblRoIwA1lgeRD/yJLP5k7g+4rpdxbL0D1vJk+a6pKClhH0V41PPBNNXvTcruLkBRYA+u/ilnF0KgkCYW3l8BLoQ6vOR7lJpJ1zHYBFjp0k7K8GO7ofgAushpkAakCeqTiVnh/I7J51nFGMhPClKJLqOEDuCfr2ZhiYmTXYi04BBn6pDQEH3nI215XBrkG4DT567tz6CLBXN0AOtAyVYe4F93C/7hJzcLAi2Ow9bo6wl+2Ri/4fRa5RkRzGsGDSESmVrAvIdr3Y6NZMqSV53pQO+JQ+qv5HQj/PGcLOAyGzQTzFqvofgjjDVI6yOVWJM3hDXgVfa69+0v9A22dhWm7BYWKrwuFqUnReUnlfqL1QFbScAaUJPrnu6FAhFJEpLWcHjhHlrQm+hXxkq2H2rQMQynv5H+utdLWsthax8pZIevEtm70vY7nUoCXAMBBDpQdtGyxusfAP97Rxoi08GklCHJ7pIWkDWlDmnGNFxpa2tumA4v5dX8NRZ2SP76YaM7ktZOXk9yuzEFsMXzsN9KC76bFTNh26u6WMMoWW5cN/20sITp4IQXv0fQOT1OIZtTOC9QguM8LPgHn1M6Mrcwa2tKc2Y/zs/48U5E+HNuRaZF6gy5+Nglx34qb/1CO+yiPOvx7jOck2RxKZqJsdRzWH4QTJvsr00d7eJm0qfy4w7KA1deLzD4GO+jApccRnHmXwwa6rBc vJITlR9i 1icANa4EldkXqTvuWOd8RGvnwEjtQmG/vz+Mi1qrRhsSHDlSUWqIqBVSxUTJ/+kp/3U8LvPlEY5qlqI7Wa7vNJFj1JCa0qFffJkBP/0+hdADeXqd2ZgwiyGVBAZlaNnHLdBE5gQZV3fGjcdBiPNw0BRerFQkR2Ds3Q/H4W8M0U6aC13OIEOSdhCo8CIGcMXWk16alRf+4Xl7UodQdYIAMDW+REsAlJOkR1r3fl+XViaf+hKIojo8qKuyP4D3+PWMEg7C4Qn1Xt8sHBp430EwPstKyn0UWPoVLLND8Z6iCLTyUnacuN2lczNu4hIT5NUgE9fUxUfwoPB7YLTSxg5FzkRd3MZYJliHMnWMvi/uaOgzgS8NhGoJiXpF0yd1LI5Xo8OfUE/LvPlm9yY8bajEGhmxsTwgVKXt48aCzdKXdt0DZeesQOlD2loMS0g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03.03.23 00:27, Luis Chamberlain wrote: > shmem_writepage() sets up variables typically used *after* a possible > huge page split. However even if that does happen the address space > mapping should not change, and the inode does not change either. So it > should be safe to set that from the very beginning. > > This commit makes no functional changes. > > Signed-off-by: Luis Chamberlain > --- Acked-by: David Hildenbrand -- Thanks, David / dhildenb