From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFB1BC54EE9 for ; Wed, 7 Sep 2022 15:24:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 292C06B0072; Wed, 7 Sep 2022 11:24:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F52B8D0001; Wed, 7 Sep 2022 11:24:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0467C6B0074; Wed, 7 Sep 2022 11:24:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E3B476B0072 for ; Wed, 7 Sep 2022 11:24:14 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B9BAA161237 for ; Wed, 7 Sep 2022 15:24:14 +0000 (UTC) X-FDA: 79885660428.17.E1D4220 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf25.hostedemail.com (Postfix) with ESMTP id E2A37A007F for ; Wed, 7 Sep 2022 15:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1662564253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v4l5DNVkzArsZpK0R2MFCWt5K5AAMK992Cl+i+af9Zw=; b=Bi/QK+JjRcUAZ/iArtcxKdixKMoTNT5fY0+mQ+q9P2A8QZNRZgMqkOj+hDa8Bnh5zPGe/w 0+mGIdCoMiAuDc8DL/VVxQOjOqFGZuUnQ0+710BpCaQv9XPMkU2VIUzkW6XLB4UMGpOeav eA8CbSnJFJAQ4lkGziGIlomCCR6udHE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-342-4YIN9ir_MX6mm0MdFUaDIg-1; Wed, 07 Sep 2022 11:24:12 -0400 X-MC-Unique: 4YIN9ir_MX6mm0MdFUaDIg-1 Received: by mail-wm1-f72.google.com with SMTP id i67-20020a1c3b46000000b003a534ec2570so1218964wma.7 for ; Wed, 07 Sep 2022 08:24:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date; bh=v4l5DNVkzArsZpK0R2MFCWt5K5AAMK992Cl+i+af9Zw=; b=NQk1oD7/QqUdiy0grPL9UNXT9L0G6HSQ8rVUN+W1sYTrqnM/0tz7XcffkwFbo0hsnh QMR0AOPIXW99iCMlxt/wZDTSgFCugkPFrjMjGM/Mt9FVjW5B4p+pD+9/BmFvohFeX3wu ApBbjQ2tGUvayke9P7ypVN+m+Xoj7i0sAV0Wy6Tmy6V+eDekPzp2QQibM8bqKPXGlr/Z TRnn0pWPIam+9+uJDAnxYPzjU6xDvn75mOi5zrjqCgZpZNUkmKox8zyKrAvk8H3pD9Y4 aDu3z0pa9pm6yDNRMSwrnRqU8SNExYt2j0afgg997tmJYJDge8IRBDgStDMytsHNkBwl F+Ow== X-Gm-Message-State: ACgBeo0TgTrvCirWctYLHTbbz0OZcvTzmtpeef9piG8RIUDg9eYM7c+0 k2uZONC3uhWzTKAH3e0rANVpvrxFrP6HmA3yJpgs4C+a/YmJnlPr9033PCzwEdrcm7Aupi0MBg5 RyvJL34J77V8= X-Received: by 2002:adf:eb4c:0:b0:220:6aaf:ef5e with SMTP id u12-20020adfeb4c000000b002206aafef5emr2342063wrn.488.1662564246747; Wed, 07 Sep 2022 08:24:06 -0700 (PDT) X-Google-Smtp-Source: AA6agR7q59MkDqRdrR8Zk+P8doVY/5pZv2Hk7jquOShJm7zSA4dY0zMX3LJofvj/sz7wXMKgqT3uqw== X-Received: by 2002:adf:eb4c:0:b0:220:6aaf:ef5e with SMTP id u12-20020adfeb4c000000b002206aafef5emr2342050wrn.488.1662564246525; Wed, 07 Sep 2022 08:24:06 -0700 (PDT) Received: from ?IPV6:2003:d8:2f0d:ba00:c951:31d7:b2b0:8ba0? (p200300d82f0dba00c95131d7b2b08ba0.dip0.t-ipconnect.de. [2003:d8:2f0d:ba00:c951:31d7:b2b0:8ba0]) by smtp.gmail.com with ESMTPSA id o5-20020a05600c510500b003a31fd05e0fsm5905804wms.2.2022.09.07.08.24.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Sep 2022 08:24:05 -0700 (PDT) Message-ID: <5f89b54c-c1e8-04fe-890b-24d1daa865e8@redhat.com> Date: Wed, 7 Sep 2022 17:24:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v2 1/3] mm: reuse pageblock_start/end_pfn() macro To: Kefeng Wang , Andrew Morton , linux-mm@kvack.org Cc: Mike Rapoport , Oscar Salvador , linux-kernel@vger.kernel.org, Vlastimil Babka References: <20220907060844.126891-1-wangkefeng.wang@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220907060844.126891-1-wangkefeng.wang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662564254; a=rsa-sha256; cv=none; b=lQEL7xnT/e4v906xLiUX+0mQZySkWRqF/mEvu0hqC2eiFm9k6H+yrZnbCp5r/DptDFxxd2 UywaSWD/53R0TCk4FuKLL7wI51wx6oljwa6kRoU963NYPL4qlZXhA40ploI94R2FiGfhzr 6EWB8qqyii8VBLzYCEF2HqbIz7+q5fg= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Bi/QK+Jj"; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662564254; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v4l5DNVkzArsZpK0R2MFCWt5K5AAMK992Cl+i+af9Zw=; b=uZUtTaczGC2sqWCoHlNciPYW8X6NbCQHMGHU4EZXOY4E2kl8j5Gfof6AG2uLGbuQZeX4rx XetOpxR4fILcyGDlsAX0mpMgqDVcywtnVjSIGBWQVXg7ipml4aHam/6ERYqmApm48RhH8/ AtyvOZc7ZebSQxkH01XZttYIZdwivi0= X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Bi/QK+Jj"; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam04 X-Stat-Signature: dp5bm7u81nhostcw48wwqo8mic6tfy77 X-Rspamd-Queue-Id: E2A37A007F X-HE-Tag: 1662564253-809048 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07.09.22 08:08, Kefeng Wang wrote: > Move pageblock_start_pfn/pageblock_end_pfn() into pageblock-flags.h, > then they could be used somewhere else, not only in compaction, also > use ALIGN_DOWN() instead of round_down() to be pair with ALIGN(), which > should be same for pageblock usage. > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb