From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18D23C6FD19 for ; Fri, 10 Mar 2023 21:14:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A7C936B0078; Fri, 10 Mar 2023 16:14:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A056B6B007B; Fri, 10 Mar 2023 16:14:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87EFF8E0001; Fri, 10 Mar 2023 16:14:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 731B26B0078 for ; Fri, 10 Mar 2023 16:14:15 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 47DE640346 for ; Fri, 10 Mar 2023 21:14:15 +0000 (UTC) X-FDA: 80554241670.02.535A6FB Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by imf01.hostedemail.com (Postfix) with ESMTP id 2F39D40015 for ; Fri, 10 Mar 2023 21:14:11 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmx.de header.s=s31663417 header.b="Fs4lLH/b"; spf=pass (imf01.hostedemail.com: domain of deller@gmx.de designates 212.227.15.15 as permitted sender) smtp.mailfrom=deller@gmx.de; dmarc=pass (policy=none) header.from=gmx.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678482852; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t3LZ6Btzhs0mc0PNIn2+cSKqgg4zrZR7BYZah5aW8Q4=; b=u3l4gdNbatMkCjAWdM1l5O1fsk6O3xtdwSS0Ax0AMar1CS7bFZ+bRMElWJqfmG3mPmgNMV 5cp2JcmtXACyuZy3BOsn7eihfr49bUGUzxSqvLd+txYtRs7A23YFrunk4OqRzGdjwmOHBf BOHXcTMlpKnNnQl1rKRhX9Hm+Ijxa7Y= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmx.de header.s=s31663417 header.b="Fs4lLH/b"; spf=pass (imf01.hostedemail.com: domain of deller@gmx.de designates 212.227.15.15 as permitted sender) smtp.mailfrom=deller@gmx.de; dmarc=pass (policy=none) header.from=gmx.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678482852; a=rsa-sha256; cv=none; b=1i5f11t8eLOTuqQpIobbKAab8EPWBKKWnbjR+5t3r+gBV++/cR/0OWUAm4gi+C27tFeCZ+ T4FTGtsKqVJLRGnQZrgc1Co3bHtx15pCdhTda+QIjWa+iac0VXjn4mhy2NTss6YoN8f8JH 3ClRoTsZYMZYGgyGl7uCPI23GkJL4oM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1678482846; i=deller@gmx.de; bh=We4tVJ9aX8WWemGD0IA7ECCoCjcoMbMpuqwmPkvAqqQ=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=Fs4lLH/bAjI990hi6oAWHu3X3VrWy3tjXXuztt8y3REr7ICCFlamg5QYRmGvdM5Fu GHSdyxSyJiY888XV0gZzrBL+Ko5rb5YOLxATE1ZhCv2jOVEuRFWO909M3OGH7pZr75 k0x1rtJuDFogkmQlkVKFnxI/8XDlOeh3utjdYYwg90cukCxJmgql8lC5VeeReKk9QX fpFXPD5UFxkVgQKl7Ww4eBAG0ICrOSt7bZ1rAVEPfR7OotYtt2ULvJZvjm9MJVFWyF A/U4OnCaEf9lpDimlHnv1cYE6G8TPQ4rU04hN4/EYRVECsXbxTRryC4MsIRusiEKd9 mcYHsMUH8P6MA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.20.60] ([94.134.152.7]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MLi8g-1psPTK0gdc-00HffQ; Fri, 10 Mar 2023 22:14:06 +0100 Message-ID: <5f807b94-9169-3120-9329-611e4031c665@gmx.de> Date: Fri, 10 Mar 2023 22:14:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 3/4] arch/*/io.h: remove ioremap_uc in some architectures Content-Language: en-US To: Baoquan He , Thomas Bogendoerfer Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, mpe@ellerman.id.au, geert@linux-m68k.org, mcgrof@kernel.org, hch@infradead.org, linux-alpha@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org References: <20230308130710.368085-1-bhe@redhat.com> <20230308130710.368085-4-bhe@redhat.com> <20230309143621.GA12350@alpha.franken.de> From: Helge Deller In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:prdbfw0jkbpA2cD4PS8A/Q/bnmnu3OYgfeuy9CIfivml0OBah6B MGo7+iBseCwD1PVcU+5RG0jP1OD3CZxHtN3uIEBZi1dA22tJEq0pWnkq3La76NAmGwRayBS XciNoSO+Vo1DYUji/arGP4M8bHAlcRtDybpPn25b5aXw0gCZzJphAKo80pokJRNsnu3Acov Kgc55jhLjK07WSzPwizYQ== UI-OutboundReport: notjunk:1;M01:P0:GnB6wuRuGe8=;Hhtz914/IJ7nAaMT9Ty0LJE9nJ3 qsX6/pRaqe8JSsd8AX0qlvxgerripOr2OMvkR5AqBzN13ZBB0WbSVdMd0wRslRJhLPVk2NfHP ne08fK/1oClR0HB6P3x+0S5JVDyXfnFK9t/HMO1MyRvEKT0bxSZsgNzBtlnOZ6AhckHlp24i5 nwt5q+71jXG5JVP+J4zZHqgbVlUnbwuBSbnufn+NzNqGYqezWq5DgmihIjtMmcgkRsxmSIHNi VdBCFyNM9HPfHABBkNRRj3iIKHCI+mpcivp4IEbCO0UWpKkKYJluXWbUa5IDZIwxvqWxpoAy7 TiipvhxhzW2BorDhthOlGuhZ7nYBllk/JoCQMQiBTTlJQQGbl+CXSnF+66y0XzoV0MhVD+7Uy aHbxO1dajxVOJ0AfMDW5wtdd+wH/s7dS/eyeidfTAileP/wP/Wxm9bt39Wq4amDiQlhl+doB5 d7M3sNlxWIpyJJ412QUc0qvYN4M/iGsKJ6QmVZBaR7xZPtJ/mKYGf8Kn4W5WePzDY/TS74eeN myHgsVkxZieoPf6jz69JNCOs/ClaoN/bMxmVrtj6OeY6xBykhd3tpSArDi37WEgAkyu9YkGYS n+FlUHPOhs3W/Pr9cpydihcay7P9drt6ICYqYelTz1QbexPv/n7HeXvNTvSPYKMDBymqdIQaL cqnrhpZg7Yd45xlppdOdVQ83zuB1eF4kyC3UfmX6P/Csto0lwOzKDKFZoMbUz05B+UcVluR1i igya/wFC/IPhXB680mewg5DfSn7jCQ5CuSV3BxWu8pp9a5eV8F0C1cVKVecIAtzZSvLYpiBMc /Cf5EvHPb5GrTt2niJegozx3hwjdStg7lataEEStinQVZyD4n2SpvjRo1PRXtJ6C4G4gvomaa 2q1sYMfCsVv/UDyrsnqaEUKx7lI1dYWviSy0nvRw4B8HSZ//zhewIMUCNZgawtD/QEYY5Or4X qEXb3zwt3cWnfN7WclsZWX/U35U= X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2F39D40015 X-Rspam-User: X-Stat-Signature: ddsg5pmm65nrkmsgrwtspfz4omxsasu7 X-HE-Tag: 1678482851-656761 X-HE-Meta: U2FsdGVkX199jr/6MI9GPpnrJ8DbgThCgWMExJfCL/6QfW+peOd4SUaUZYKhBd9cLOSjK47V52FerZmk97wPjuBQNkCCkgTvTOIDD7801/pO4KA8ZNxUrAldNGiSZuegpFYcZ+dyLzVVHXV+BV79hDCmKa0plGE9pYEhyDgdKDitXNZcd3eNrwlGWNdIZN4znJtJcIrxKOJEEqeZBDgx+51bWbAX98JzMXkjqx7RbPa/CE7UyxEJvMwu49Ns01HU+qqDYkrk9MZntoji0CN6jJQ0DAylVcI7ra3Xbxa/1L35h40dIrDWjNT42p1zuPgRBE7rpTVG0yVNnyOI/z0uOqu5lOvak1bMTXgkcFkf/7d/GvUTn+ljDtmiDxyq8Oht2OE8kJMT6ONnE74cINl1mvPPK1K1wg72tKF4wDeFvXYNU2sYi0MXGnkb1wh0nOq6YjWwzIxak/M83lPK+YKwlGx9FoUgXi5ITP/V3+PGR60NqrqxliWULK//Nk2p92OIe2lNsbpqUJLDdMszd3UnAnmS2WSToRrD/VsA9Q5755YCtyK1mAI57QkG//KiTlATM+mF9bbj/p2RkmiBi8VYq8SGye7JE6JXU/xIg3yowV9tW7elRplhUioE/Sqym8nq1APip1CKlZTeRFkOs5MCVijFjIrf1MO59cW1A81sU31Q+vSMkaLiXqU+54pEqIVL9LSd1f6+xq2sU9G9h6x/zlP66n8xlkfXjfEUCaqGQOgJEALC/T0rtM4TK99GCziwxJRLH9Aa+/CH9lSQ5HZc7gAr58w1GmTso1RlUZRhKtJP9sSncd2iHHMf2CM4yEnP3acchnxtf0Pa9QArVrJKBPc6hlX5WlxfNnIRJtzClUlA0rbP8fBJbBel9zd3QziupoH5GUEfxicTB73ksK0STioIH2v4DM9ds5NGl3ZMRWxNZpizvviII/ogAv5XxRvEIcrs28faztfncIrFsDI xtq13NDf TD5z7ibnR8uw/zAsT6zp7qcIi/sDblshra8O6b4S/HTtdUb7ECa1A/WMsSUVljQ1vlamrDMER17g38LPQ3uRgLgice/0QWx3VapdIeERydVo5TxJyWW7J7NB4gUKu6QIh3CbhklB3uP9WHh+nAyed24xIG4ytyjqm4c4wUiMOT5htMYXN0xeoAxeFIMJlPriXJTxCJ5HO9ZUWM/Xvcz/tZLH8FbRI9LcsK6DWZtKKQ6ra143iwPJuT++GMhWLX7tGa65KuZ3DKHW7lCECfBvNLkk0weKMMXqCK0r6v8U21NhTYVuwTCJz+o/jtWKY//nhJSBt0hGHPqjOAI58ViCe0yJ60MS+ERtYZj0fFCbRbcy2H9UsxaSjEqAygbmzU5V8/i6Op3PI+GUwA41dKSqMfZZfh/Nbo0wJbYTv5wlCgAQYeU2Lv8pNEFWY7e2pqvPLi3zbyBA/n4JJ3mlZCPwQLz1SqsEkQGqry0v59lHrC8URyzAybB9UK8ihy5msFwx5KNXYHRTvey9+CfWFx+K6N+rCQnZi+NeMnfCPhpPO3XvSvWy5T1SxFcAVfo+IAdeBZh4WXrBBEA1LhnAZbKgrGL0Xa1zhAjLqtuXIZwrjJoeUCMzZcZ3K+g9JxpHdflkYsjKh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/10/23 02:45, Baoquan He wrote: > On 03/09/23 at 03:36pm, Thomas Bogendoerfer wrote: >> On Wed, Mar 08, 2023 at 09:07:09PM +0800, Baoquan He wrote: >>> ioremap_uc() is only meaningful on old x86-32 systems with the PAT >>> extension, and on ia64 with its slightly unconventional ioremap() >>> behavior. So remove the ioremap_uc() definition in architecutures >>> other than x86 and ia64. These architectures all have asm-generic/io.h >>> included and will have the default ioremap_uc() definition which >>> returns NULL. >>> >>> This changes the existing behaviour, while no need to worry about >>> any breakage because in the only callsite of ioremap_uc(), code >>> has been adjusted to eliminate the impact. Please see >>> atyfb_setup_generic() of drivers/video/fbdev/aty/atyfb_base.c. >>> >>> If any new invocation of ioremap_uc() need be added, please consider >>> using ioremap() intead or adding a ARCH specific version if necessary. >>> >>> Acked-by: Geert Uytterhoeven >>> Signed-off-by: Baoquan He >>> Cc: linux-alpha@vger.kernel.org >>> Cc: linux-hexagon@vger.kernel.org >>> Cc: linux-m68k@lists.linux-m68k.org >>> Cc: linux-mips@vger.kernel.org >>> Cc: linux-parisc@vger.kernel.org >>> Cc: linuxppc-dev@lists.ozlabs.org >>> Cc: linux-sh@vger.kernel.org >>> Cc: sparclinux@vger.kernel.org >>> --- >>> Documentation/driver-api/device-io.rst | 9 +++++---- >>> arch/alpha/include/asm/io.h | 1 - >>> arch/hexagon/include/asm/io.h | 3 --- >>> arch/m68k/include/asm/kmap.h | 1 - >>> arch/mips/include/asm/io.h | 1 - >>> arch/parisc/include/asm/io.h | 2 -- >>> arch/powerpc/include/asm/io.h | 1 - >>> arch/sh/include/asm/io.h | 2 -- >>> arch/sparc/include/asm/io_64.h | 1 - >>> 9 files changed, 5 insertions(+), 16 deletions(-) >> >> this doesn't apply to v6.3-rc1... what tree is this based on ? > > Sorry, I forgot mentioning this in cover letter. This series is > followup of below patchset, so it's on top of below patchset and based > on v6.3-rc1. > > https://lore.kernel.org/all/20230301034247.136007-1-bhe@redhat.com/T/#u > [PATCH v5 00/17] mm: ioremap: Convert architectures to take GENERIC_IOR= EMAP way I've applied both patch series on top of v6.3-rc1 and tested it with success on the parisc platform (32- and 64-bit kernel). You may add to both patch series: Acked-by: Helge Deller # parisc Thank you! Helge