From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C676C021AA for ; Tue, 18 Feb 2025 22:27:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D3FC2801A4; Tue, 18 Feb 2025 17:27:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 184AD28019B; Tue, 18 Feb 2025 17:27:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3FDD2801A4; Tue, 18 Feb 2025 17:27:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D1C4328019B for ; Tue, 18 Feb 2025 17:27:32 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 5029F80182 for ; Tue, 18 Feb 2025 22:27:32 +0000 (UTC) X-FDA: 83134503144.01.FA36B08 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by imf09.hostedemail.com (Postfix) with ESMTP id 5EFF414000B for ; Tue, 18 Feb 2025 22:27:29 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IyF6X87Y; spf=pass (imf09.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.8 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739917650; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dGyU5m7gAhGr643Mn0xH6uOEsrrOByUegNlHeskOZOg=; b=g8Y/IEwzc7qBEU8YIV54vURYBmdBJat1JepkrZ9Tia//Rl9EgKSoizcktOH/B9MY0E8yTv wzJfbTe4d2jZIUe4CQpSWmZlU0Uh+ILZ4cboSFVQr5TxaPs1boJd0gQPLzZVTxd/H8CbE4 kndyshuR0kQB3hTP+MK0WyOBaFyuZHc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IyF6X87Y; spf=pass (imf09.hostedemail.com: domain of dave.hansen@intel.com designates 192.198.163.8 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739917650; a=rsa-sha256; cv=none; b=giwLS02ypKhTdGJIVfyKa4YZrdIOOTIdm97GThRf1Hjtaf9DiUjemQlxcj40VRsBt70aCl n4NuK2n9wOJJc9LL4cmjhZEiecGWgnF4rnKO/iwSqSH2X8wEoRbut2qTdJOZ3PC1OVmqf3 H3y4WYA/Rotzr/oCpVl8ltiOb7BVygA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739917649; x=1771453649; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=R2Z+EiQfPTI1cTJRSIo5QQlqbt/tGC6vKcxiz+9+AJw=; b=IyF6X87Y04ttcNHk8/Xj2jGNPelFB031aXH23BRBpJWop1UAzax3XmzQ bAB0lD/j4bbR6UQ3sSCBeg8cfIk/VixLsApn37he1R38UkIdmA+PVBLON uvjb9ooLGXYiYI5/l/bpjJPkJmLflPmT2Kq6twy9JHz//9gKs/1z/8AOh R3YmKhH9TkS0YidZBIaZfJlCTmkkZGuiTJpV8YbS9JkxNtPeNuvkxVeSm KxZlzJvu6Uge87ECloqg9vVPJTYMPcB/3nFYFrgsN1ClwSfqg7zO0Dj8A N0m9ICVmd8Pbr9RsQ2r/LfAGy6nJBWIlZ6LugxR/lVc/5Onts//GLV4CZ w==; X-CSE-ConnectionGUID: xnV8kuPnRG2e7l5nZdPH+A== X-CSE-MsgGUID: bxZr5GwHQ+6ADNPMGwCMqg== X-IronPort-AV: E=McAfee;i="6700,10204,11348"; a="58174883" X-IronPort-AV: E=Sophos;i="6.13,296,1732608000"; d="scan'208";a="58174883" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2025 14:27:28 -0800 X-CSE-ConnectionGUID: H6MXhDhjR9qUAOs2t4/SgA== X-CSE-MsgGUID: 9u130mWdQsWiiYGxS7mGTQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="115006326" Received: from mgoodin-mobl2.amr.corp.intel.com (HELO [10.125.109.220]) ([10.125.109.220]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2025 14:27:27 -0800 Message-ID: <5f4d58fe-4fa1-4b59-81a7-e8c8d3030d0a@intel.com> Date: Tue, 18 Feb 2025 14:27:31 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 06/12] x86/mm: use INVLPGB for kernel TLB flushes To: Rik van Riel , Yosry Ahmed Cc: Peter Zijlstra , x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jackmanb@google.com, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla References: <20250213161423.449435-1-riel@surriel.com> <20250213161423.449435-7-riel@surriel.com> <20250214194013.GA2198@noisy.programming.kicks-ass.net> <3e26626aa1c01aaa5d1e7b42d3ffbd632c3264fb.camel@surriel.com> <724d17ce3fbe07d1d9404f8f32ba518071bcfa4a.camel@surriel.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <724d17ce3fbe07d1d9404f8f32ba518071bcfa4a.camel@surriel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5EFF414000B X-Stat-Signature: x944rhfro3wrihpred1oazxgyzg6iwih X-Rspam-User: X-HE-Tag: 1739917649-634136 X-HE-Meta: U2FsdGVkX1+seEpKug9Voj1dM6u1tSq7BiIy2YHYxB77FJXO1puQv7ahHEGRNi+CuAPcnpFG1W+1Sl7FBpvl0hf/IZ3rNBsgn14Ds78OeV2sEURcBkdHx2UAPBjTtcYpJLG+lpGGWm+G7kw5jhukm+sn5KAIyJ0KUmChahWwAi0RYon8DqoiXzT/7bjvLYrmLP54ZGiIUcCzI2/nBdY1jtbvhkv63SERqEamdfEklFL1KHQ5DL7qKsoX8h1YeS4rni99EZXY6n/26It1IvkfQR3JKPvodwYX1q04I4b6YD+sAVG5lJ18ixia9Y+TgcMKyK/OSq9ve8Y7Y5s3qeGMSbVjJLGBqjffIg6aBkgU1rxoy/nE93BVHS0ihiU5YIbzm+m6XnqLcvJzvZXwUh0ZBGn1hjOfbhfu1OJv3u8FBvw35ITqBKRBlK7TZiGHJQynE7xghpn/lxk6qM0pl3ICyc6NKvnLEWOHZ/0K1kcuN2rIscXqMAe+Orx4+KrbGjM9mIuqt6W6H5nmuoUaLYnbFv9ya+03t4frKcwpZ3iTNTiDbb6/9KGy4CQkjZTMpdVw3CQVVc4AQsXYSan3uQdO/CleimwwT1D2caDPKfFVrrc91lNhOseM4bX7BbWzt45vYx7S0jZ45HOeEmsxhuF+gICx7qwhfWXRQFTDkKY7PFM4HNGhrjDnwLpOgHLGCYCF7fo/LiIanh8Bx9HbCJz/4/yJwrj2c7zfEPTMyov+rz2X5MTfo05lUJvGLlOf4PAMQq0XtZx6QmiY06gKpmwRTQk/Xm5vLnYKTUWVs134i/V5oK3p3CudrhIMG6s4TURMWKyw/++6cH6AwwuLFWVMuRZ5WKUOTQGwJ25PiZprk4w3nDGbTYD1pdm/JSR8NXpHE8qKqALjmnbAQEaL8BJP7SVullPv+CYHkfGzQisREh/6cmPuvDFtyBkeBed3KPXe5RifrW1QaPH8FgqXY5v oK/SQCau xEWbBKt+hh1vtrc4ThH/BTTdsI5cQOjt1Guau8YFJJe7hdlpZw/h67OGzZU2q//gk/L9zHw7VOUpUla2gghopcrAunaVnqUtNN95uDovrGpCtH031q6OGARDoMsB/ylC0eikC+Owsh8PeJXLKgjnTKKGF5FWxf7Z7f5wXSXTf8WaAQ+pGTweA8dhRV5KWAudTz/XoIvVP6vVW+iojEOHCYYJnlA8FeW/7UHbMao+jZZXTWrcBOxmZTbPP0IekWrKFu15lc/lWS0Thb9RN4xoPUONVpA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/18/25 10:00, Rik van Riel wrote: > On Sat, 2025-02-15 at 02:08 +0000, Yosry Ahmed wrote: >> So I think what Dave wants (and I agree) is: >> if (!broadcast_kernel_range_flush(info)) >> ipi_kernel_range_flush(info) >> >> Where ipi_kernel_range_flush() contains old_thing1() and oldthing2(). That's OK-ish. But it still smells of hacking in the new concept without refactoring things properly. Let's logically inline the code that we've got. I think it actually ends up looking something like this: if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) { if (info->end == TLB_FLUSH_ALL) { invlpgb_flush_all(); } else { for_each(addr) invlpgb_flush_addr_nosync(addr, nr); } } else { if (info->end == TLB_FLUSH_ALL) on_each_cpu(do_flush_tlb_all, NULL, 1); else on_each_cpu(do_kernel_range_flush, info, 1); } Where we've got two inputs: 1. INVLPGB support (or not) 2. TLB_FLUSH_ALL (basically ranged or full flush) So I think we should group by *one* of those. The above groups by INVLPGB support and this groups by TLB_FLUSH_ALL: if (info->end == TLB_FLUSH_ALL) { if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) { invlpgb_flush_all(); } else { on_each_cpu(do_flush_tlb_all, NULL, 1); } } else { if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) for_each(addr) invlpgb_flush_addr_nosync(addr, nr); else on_each_cpu(do_kernel_range_flush, info, 1); } So, if we create some helpers that give some consistent naming: static tlb_flush_all_ipi(...) { on_each_cpu(do_flush_tlb_all, NULL, 1); } static tlb_flush_all(...) { if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) invlpgb_flush_all(...); else tlb_flush_all_ipi(...); } and then also create the ranged equivalents (which internally have the same cpu_feature_enabled() check): tlb_flush_range_ipi(...) invlpgb_flush_range(...) Then we can have the top-level code be: if (info->end == TLB_FLUSH_ALL) tlb_flush_all(info); else tlb_flush_range(info); That actually looks way nicer than what we have today. For bonus points, if a third way of flushing the TLB showed up, it would slot right in: static tlb_flush_all(...) { if (cpu_feature_enabled(X86_FEATURE_INVLPGB)) invlpgb_flush_all(...); + else if cpu_feature_enabled(X86_FEATURE_RAR)) + rar_flush_all(...); else tlb_flush_all_ipi(...); } That's *exactly* the way we want the code to read. At the higher level, it's deciding based on the generic thing that *everybody* cares about: ranged or full flush. Then, at the lower level, it's deciding how to implement that high-level flush concept.