From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07A7BC7115C for ; Wed, 25 Jun 2025 08:47:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 615426B00A2; Wed, 25 Jun 2025 04:47:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C57A6B00A3; Wed, 25 Jun 2025 04:47:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48E456B00A9; Wed, 25 Jun 2025 04:47:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 34DD56B00A2 for ; Wed, 25 Jun 2025 04:47:59 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9AB425FDB8 for ; Wed, 25 Jun 2025 08:47:58 +0000 (UTC) X-FDA: 83593295436.29.53D02C5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id E966B140003 for ; Wed, 25 Jun 2025 08:47:55 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K9OxsoaZ; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750841276; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1xd9WPpFgl5LHUWhMgoti0ghzp6p9niA9oyQicHDlpo=; b=oLhtw8JHReOU919riXWTFWLopsWCl29q6F381n/WthI9igWNTRCOs5r+hxWXWHmsL2l/d+ kmbAXS8+gOR4GuEGeQpdH9J6qD2T2KOe9C7AGPmriDtHQ199HLy+k1Qq8rdLm/aVrpZ0Vh zUlSe+9mobgphz2uIeFM6s+CuG4A17k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750841276; a=rsa-sha256; cv=none; b=ep4KRE6S5hH1pcvDH8R9QZFLPSycGfAmBnpQzX9/IN7uuAQLVsQLe2MGwWN97Ag9JpAOnd iyyCJsPy08O1ELu/DgrVh2gzWDwu975qHSHSSZ3x6xl+7chpccU1hCVvfxIhABNKzBBwCF jvj0NKQt4jFmBHMNsMQnBhpaZiPzS5M= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=K9OxsoaZ; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750841275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1xd9WPpFgl5LHUWhMgoti0ghzp6p9niA9oyQicHDlpo=; b=K9OxsoaZNyxVvUpdt/wBxAkx74fR3EHXZxNM0U7sfQXIRuqbdTZFLUDu8093GqoLptMgi4 R1+uynDLAxggkHhmXEBQ0BwmhitsGiQWKs3o6vZx+ZhUKkQADVbShwDOtF6qcS0O+jWOPE mQHu8CJivbsO1Zekjh6NcsyKlOdAidA= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-199-Y8YlrEEKOGWi_suUriycxQ-1; Wed, 25 Jun 2025 04:47:54 -0400 X-MC-Unique: Y8YlrEEKOGWi_suUriycxQ-1 X-Mimecast-MFC-AGG-ID: Y8YlrEEKOGWi_suUriycxQ_1750841273 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-450df53d461so46365735e9.1 for ; Wed, 25 Jun 2025 01:47:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750841273; x=1751446073; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=1xd9WPpFgl5LHUWhMgoti0ghzp6p9niA9oyQicHDlpo=; b=BtfGGyICGjun5U5k1kJo7TlCEaUN/osGyWINGJcu6qEA4RREj3qf8BBRtDm++wMkD2 0A1RpKHb8s7maCVqIuNCh2HFBFTxIWpjaLxly0R5fKs54OEWvlO9shdeRyVFcXSETXnh 6l8qH6lF86j+ODj1g6Qswe7YuNnMp1hjUSKtA7djbRbi2RhkVtBSPok1pwncmESVgtYN 11pl2V4Af0FyM0YxVpkKL8ETJNUfKPEHybBtGCuszsj3gH2MMzh/r/Tx85x8eEkDU1Z5 iuE6NkbhFBsrmp89+BC3U7orrL4Yjvf7eKGoz5P4wMe08ANabaJd547isGxpUzoSOUaJ dcLg== X-Forwarded-Encrypted: i=1; AJvYcCVhBgrYND/RqBN+dzdQAMALu6Ldrk4fi0wfYohYKcEPNJPaB6kM+crXv/fHVBSF+LET4qQdgs7ALw==@kvack.org X-Gm-Message-State: AOJu0YwaJRxaXLno7dbnKJTHYTe3UcQ32LrKu/RJaV04v5gPpjHahv/z ZNYTxwpUEkSd3NNWPDNhY/8R2cggnnbdZ7hNxQfHOlibM4Yu1uJdbfkcgw/KvgM0Qo/+8cmmBKy c0JZnp5hqa+7shJXi8J2n75w6Fv/VeKqK259j6WMfjQ4Cj3CD/aQj X-Gm-Gg: ASbGnctloDEh+7d9CN98F2sSDOxSBlnFJduYkcr6t4g8wcS/OjJ8G35P8Qk1ZsaYCsb +AeQWBt7wULaMMD05uMBMuuVU26gfZpmPpKIstb6vaWvTRDJtXOY3ChFyLD7fHgHra/TJMgSQH4 1Dk4Zg0i99npiQygDu6aMUXWcQ2SwsAL0alGE/NTGsi8BF03eQzcej+L/rELPkIIr9I/AQI01Ss idLd633Jt59KNg2QOKTgvRWYSZhXhbLgbp3H+xKB8qh3MOjTT7LZXfZ5NGqPLsIgo6qUaY8fewu Lr2RPjJt2B48pPCYZDTp47/B+PaYKSZv7PicEe+oXptwz3cG8dQ5DqN1A9PPIlhTkuEDwsXAy5Q PzxAy3gglrtFX2SXRd0MBgPILlQeaLyvsHSfJ2fD8hx7B X-Received: by 2002:a05:600c:154e:b0:44a:b478:1387 with SMTP id 5b1f17b1804b1-45381ae3576mr22313925e9.17.1750841272672; Wed, 25 Jun 2025 01:47:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFAYS0X8N7xEFzwTzklctg8lKH7oKBXzgFBqyrisxcav/ySIelpP/IwsIPf2LcVX8aOeVVltQ== X-Received: by 2002:a05:600c:154e:b0:44a:b478:1387 with SMTP id 5b1f17b1804b1-45381ae3576mr22313605e9.17.1750841272285; Wed, 25 Jun 2025 01:47:52 -0700 (PDT) Received: from ?IPV6:2003:d8:2f12:1b00:5d6b:db26:e2b7:12? (p200300d82f121b005d6bdb26e2b70012.dip0.t-ipconnect.de. [2003:d8:2f12:1b00:5d6b:db26:e2b7:12]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453823b913esm12703805e9.33.2025.06.25.01.47.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jun 2025 01:47:51 -0700 (PDT) Message-ID: <5f4c0a45-f219-4d95-b5d7-b4ca1bc9540b@redhat.com> Date: Wed, 25 Jun 2025 10:47:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 11/14] mm: remove "horrible special case to handle copy-on-write behaviour" To: linux-kernel@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Alistair Popple , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-12-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250617154345.2494405-12-david@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6o1xhp5uFQtgBFPbfkS-pZp_I2qeXw4LRl6hEkLyHl0_1750841273 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: E966B140003 X-Stat-Signature: tj5u8hftsk4rn3nxukugsteid7sqnkpo X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1750841275-106483 X-HE-Meta: U2FsdGVkX1/Jo02F95fDzXXfLcZvPDIrLWJqPcPAPGn0IiKuO/59P3iAIbL1qtqbXZLVmecaxNZ5KaPUh+bqbKLJB+de6cXhFktJt8PUF70U85K4Yvo9dSQL5ElhPNRlIOCk4v7+bHzI/itZqawZwEmuMdDnNFsjN8gRPzjDfESl7MAG1XM4QPGsLijqxISY1lCZPgeVzuZLFwSSs8Lm9Fjqugln2gFLQArZE2cZtEwSoY6OTki1N7YxlRrF1mrU3tDzXosc6/lXoMQB3YdtirnaBCax18l6h4sA9zchgMa6aScpK56+pTWehhrEJaGQoI6nrLUi/hzzSjicacYgNgq/uP6PJb+XNCw0PdXSsKTNfgN3wcVMGKkduYF9yiS8g28qCanxic4ZxB/s49c6jEpdhXhv56oDbVxMAo5Df/lXSTZQFTMJNIUFhV884LsyiB4bqFTP5zXr7dgf+g3eNvcfvopkhuvXaiy5+NZpwJMlvjMwHA0kugyKdeblkp+k2TJ/1XYdUxKHlMDIqdsnntuAtYaK4Lb2Jykixp5C0Cj7RVsL3901gu1BkeGvPQj2SpyAXZ3J3PEafg+kxEg7EWCCEWnSznjTiB/KsQeXNC4HBDlr1eMWOnFaUIwblyl2giYB5DqqQZJzN46UR8XOj0qU/CrQ3ZDUto3CRWbCwkvcCi67VAm7MxEDCx+jWH0ovCszdzHI2JnxjObqoOj047qbWHjutYLWsvnDBSHkqbJ2Fj7RBGsNmloeE48Sw/Fi+mPdM/iwGm4oJu6jrnKVQ4hZS/OoyMFBLtTBDk7j069pLQNq8ks77D8KK+jR6uvLbEYHi+gOIu9nu0sF89NIcmKM4SVPWDi71NRH5j/CAeHYkHrb8wwUz/bTjmOfxKAs88Pe4BdDdInvegTIxRqLhvXc/04pYBpsLYEZ8fd0SPQSyoymgZE9AsOtrUS8Wa0mF8Ay5xGlFniD6Pq8UMo 25ydMa9w w9WLOwD9SpBmY4pMfLymfGZv/G85YVbYlkyaCvtU0ptAi9ByyCKZ8uWNyH+RZtP5GFWuXV3B7Yd2vP8jkZsS0Wf3nAHDYy01xWo7M/LeC8I3qwOV8uhqflaEOd/mbY8yqkNdNH66MiuCpEM2rrAwPvOi0ou5UMoZxabD56LjWtoQtfkNB/A8AOJDrRknw3AietG/03D2KtZk2jU9N7Gn8+8E1WVWliPEso6hvyleuRjHpcAcLo9biRXD5g7OmD5TiNdnuUnSWutYIPt6NozgMF1ZWg0ZXCgRhI+tQP1qU3fKZjKoaRvIfes643wHG6nOP6ixqCmXdiaAzPaVYA+bRxvSiTcYLVLZyowFjWLNkOSO/OvplwlW9UDKK7SkW9NZLCXOS64Zf2MWB4y4H415G0s00Tu4NLow7VUXwVK9nLpkUu1A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 17.06.25 17:43, David Hildenbrand wrote: > Let's make the kernel a bit less horrible, by removing the > linearity requirement in CoW PFNMAP mappings with > !CONFIG_ARCH_HAS_PTE_SPECIAL. In particular, stop messing with > vma->vm_pgoff in weird ways. > > Simply lookup in applicable (i.e., CoW PFNMAP) mappings whether we > have an anon folio. > > Nobody should ever try mapping anon folios using PFNs, that just screams > for other possible issues. To be sure, let's sanity-check when inserting > PFNs. Are they really required? Probably not, but it's a good safety net > at least for now. > > The runtime overhead should be limited: there is nothing to do for !CoW > mappings (common case), and archs that care about performance > (i.e., GUP-fast) should be supporting CONFIG_ARCH_HAS_PTE_SPECIAL > either way. > > Likely the sanity checks added in mm/huge_memory.c are not required for > now, because that code is probably only wired up with > CONFIG_ARCH_HAS_PTE_SPECIAL, but this way is certainly cleaner and > more consistent -- and doesn't really cost us anything in the cases we > really care about. > > Signed-off-by: David Hildenbrand > --- I'm still thinking about this patch here, and will likely send out the other patches first as a v1, and come back to this one later. Really, someone mapping random memory using /dev/mem, and then getting anonymous memory in there is the (nasty) corner case I ignored. There are rather nasty ways of trying to detect if an anon folio really fits into a VMA, but I'd like to avoid that. What I am thinking about right now is that we could, for these special architectures, simply disallow CoW faults on /dev/mem. So we would still allow MAP_PRIVATE mappings (e.g., random app opening /dev/mem using MAP_PRIVATE but never actually writing to that memory), but the actual CoW faults would fail without pte_special(). Some more thinking to do ... -- Cheers, David / dhildenb