From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E64FC3ABDA for ; Thu, 15 May 2025 00:14:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62DF76B00EA; Wed, 14 May 2025 20:14:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E7296B00EB; Wed, 14 May 2025 20:14:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42BC86B00EC; Wed, 14 May 2025 20:14:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 235D76B00EA for ; Wed, 14 May 2025 20:14:37 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4CB7D5E0DC for ; Thu, 15 May 2025 00:14:37 +0000 (UTC) X-FDA: 83443220994.08.A0AACCC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf20.hostedemail.com (Postfix) with ESMTP id B741A1C000A for ; Thu, 15 May 2025 00:14:34 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ICIVapwT; spf=pass (imf20.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747268075; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kNzHUEUeO2dhjTSVzvgUR5Z+U81BlGK7DOEGqJYrY1c=; b=Gxr5RgZIDcN8yu8IGJXoI5xzCahV2lJ/7A3EgPOTyAz9hLXIfGbFM/wBzPBfE+OhL9IpWI 1HayxO0TJLHwtP5EIPg6lBQ9g/kN+/j1VcKshf7CiETDzrEsoJrqwt2LbqAZwQnkJ7A5VZ L4kIEoAxpa6IPsvKjeux9mmNMZZJP1c= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ICIVapwT; spf=pass (imf20.hostedemail.com: domain of llong@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=llong@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747268075; a=rsa-sha256; cv=none; b=F8tnC8atuS4ELMyW2kBgjTiIfspLhNQainDgK20mvMWKhs8ZCumPGJXuz6Y9xD4LltDVbH hU7aMlEwU/6rbOwB+uyWvYeNny13iqfw8JyqPW29Zfp3uBEwrfFJaDhevDBQrqFw4JMLre xZadnfCUZRYzOfvQmK8SvnhOZUAdZaM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747268074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kNzHUEUeO2dhjTSVzvgUR5Z+U81BlGK7DOEGqJYrY1c=; b=ICIVapwT+ltb/ndbQX4pHJikd3vnPZvfsaSJrlAUwZNwyBEIyFnMjwaJfuv4NtXrjUyn5N BlW7XCgIGshn3CQAA9JgAqtMxE1mdMrDLDnGsG0gc9iBCwryvsbIk5vi7jzPb+z7CgnG7d KLTqH0DxGlZcEneuCR95/+UAdaOW7pw= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-302-wzINZp7XPgqGT6x2uCSZ5w-1; Wed, 14 May 2025 20:14:33 -0400 X-MC-Unique: wzINZp7XPgqGT6x2uCSZ5w-1 X-Mimecast-MFC-AGG-ID: wzINZp7XPgqGT6x2uCSZ5w_1747268073 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-6f53913e2b6so6063896d6.2 for ; Wed, 14 May 2025 17:14:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747268073; x=1747872873; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:subject:user-agent:mime-version:date:message-id:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kNzHUEUeO2dhjTSVzvgUR5Z+U81BlGK7DOEGqJYrY1c=; b=qqCMVlDQa3J8XwIXn/v+x+LkTGbLmhNQ1q7kGB2bsUDqygqrJh4z4EdHZxu2+bJjnd yvGS58SoBa9Jk/HZPwJ6c0pPtlN4e2vQZ/NXCi/zsID4xuO+EkKT5NX/Vg3/YYN6f36m 8NhvxL5YELvOQDGJWzPNPb/s3zQikNpY7xmUtYVdZmy/17etJt5pu7tMxuwftugeaijd QGXExaU4mh7mrB/Vifl2aYGFqIabcXMDTqtPDy4bb74m3DE6dquRUMARC8pNgjVNGR3f bmFNMOf92QxGDJKN+zhfjaRINvoC9zQET7iT0RGiSaGhZR2kXL0g7ZKdzVmFI0ExKVWA 5BXQ== X-Forwarded-Encrypted: i=1; AJvYcCX93lNaWNJQOjQ/OdogQcEV0NJgbTDIWGbXeMfS7t8WpTkWnXhMfOtZiDFl344xlHY8P9rB3uFeGg==@kvack.org X-Gm-Message-State: AOJu0YxXFjJ4FgetSWGOmDL3OsiFFlfK3QN7MxABH1R6FN4V+SHLlJwo B9nrn7kfn0cSDsdTg+v3ELJYZ0WGUImVzbGNEEvvLungneIKiGqc49IidYhPekoJbBwJ1LIzJB5 BqwsryBoframB5eUj3URO/zjQT/RKiIzMl71zQEynJE2+5hDD X-Gm-Gg: ASbGnctuBcRWgkkAfl+/vo/Ae5agEaJYghEsWLM2HRCqJ1sRICTDzkKj/CoV/mgOVSh UnWHeFNkJvRjQy4ohxX98OObsO7Ky6MRQuamKtS0j9lMtabI4wZV9wxbHh6soCMzug+7FGl+UN4 daqaF7wG2EyZnSTP2/FetlQobRG0HedYrqb90gF0Bpfke1VRGxY0akKgqdcx3Fm/lERV1YE38Le Q4w7/0SzFCywBYUL6G1DU/ON0A72ATVQR4Ewl23ZNRdX2bidIfQhlZs6HzpMMCy1/mbvX2vDLLX HQrD9eXuH6BtS1yuNjqAOheb8yOF+/VHHGQ5jiPimNwqYxIaDXNMWS8Uqg== X-Received: by 2002:a05:6214:d0c:b0:6e8:fe16:4d44 with SMTP id 6a1803df08f44-6f896ea9057mr99475146d6.31.1747268072587; Wed, 14 May 2025 17:14:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHsr7IFrS3iOvG8LAJsmK3Z9rLV7eHpX1e12kq9yRd9jWKqc02gH6HkR1aDUM2ojcwgcm4bmg== X-Received: by 2002:a05:6214:d0c:b0:6e8:fe16:4d44 with SMTP id 6a1803df08f44-6f896ea9057mr99474556d6.31.1747268072185; Wed, 14 May 2025 17:14:32 -0700 (PDT) Received: from ?IPV6:2601:408:c101:1d00:6621:a07c:fed4:cbba? ([2601:408:c101:1d00:6621:a07c:fed4:cbba]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f6e39e0c8csm87119136d6.18.2025.05.14.17.14.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 May 2025 17:14:31 -0700 (PDT) From: Waiman Long X-Google-Original-From: Waiman Long Message-ID: <5f412ff9-c6a3-4eb1-9c02-44d7c493327d@redhat.com> Date: Wed, 14 May 2025 20:14:26 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v15 01/43] llist: move llist_{head,node} definition to types.h To: Byungchul Park , linux-kernel@vger.kernel.org Cc: kernel_team@skhynix.com, torvalds@linux-foundation.org, damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, will@kernel.org, tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org, sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu, willy@infradead.org, david@fromorbit.com, amir73il@gmail.com, gregkh@linuxfoundation.org, kernel-team@lge.com, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, sj@kernel.org, jglisse@redhat.com, dennis@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org, josef@toxicpanda.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, jlayton@kernel.org, dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org, dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com, harry.yoo@oracle.com, chris.p.wilson@intel.com, gwan-gyeong.mun@intel.com, max.byungchul.park@gmail.com, boqun.feng@gmail.com, yskelg@gmail.com, yunseong.kim@ericsson.com, yeoreum.yun@arm.com, netdev@vger.kernel.org, matthew.brost@intel.com, her0gyugyu@gmail.com References: <20250513100730.12664-1-byungchul@sk.com> <20250513100730.12664-2-byungchul@sk.com> In-Reply-To: <20250513100730.12664-2-byungchul@sk.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: IIt5Kqjmol-pr7a-vaNud8ZhikwcC1DAOdsUH7vrTDg_1747268073 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B741A1C000A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: o6xbcraa95zk4wccb4b3f1k4nyjtqk8f X-HE-Tag: 1747268074-588938 X-HE-Meta: U2FsdGVkX1/wlAH4/sDXxHsFG3VroeVjUwtjen1ohTML044eYdPaxMNt83oEdoxAUGam3lIucSHbwfGLw/c6Fny2YDKvx/nZlIvIwLVLWKRTdsU+bZel1I6B5ArUuZ9/DaNWJiAB+JG26ZEuqNyc5vEve0CIV+KkfkiqacxCGtDGyMs1+zoPSoErxLWGlOqeTQEFtQ+YsjbWoK05Q4ka6enyXY9gULjyfN4+7AWwVDCeNfsShtBCy8+TfwDPL9mbc6tUFMQM2vi31iHr6BacRQxRg8ADEQAT+DBPWhrwwFULblbV9PXsgtmMIfwsUfXopvnkKMNMX9vQwKyCoULihGVZKSYN5qkAAZIhMAKUk4NYf+kT90T339WWrj1IUvJhNbHTNyOpUGSZgT99ucS4P4JpD0XkK/xkZOy95UQYoTysYquBMsebQA159fP2RVnayfEcTIvhAyR4kPZUcPNdF51uO7q75HkxCYd8S/c8ixCjYkIn0vmBvNlnZOu0NsrhZsYCc6zDc6ewrB+3rZBSkS7zsONDzVr1tk/7C+YsX6WPsr9gJY6Bzc/OJBNzmL8AQ5eoD4WO84GvLV5/VjRMT43HDlT9EU/KFo4/mpp3KeRtnI1kxB9ImRaB/2A/nT5yXETw3z3Ke3wnKfvj0k7ln7j4lE43BzFxHurG2LdJAKpdxox+asbzzjvv67PzmjnyCIRs16yMMnO2zYj5tl6zmktS/w2RtG7pK2zUhwy6ofDQEYM3qeP4ab647hM6rFwqglxlL4dBFd8g9Fsu26k9Nhh4rWBMYKNGnjG7AxmkgjnmTSMr1rTvlykNxrtnCjDFWRUkJK4IdVE/SojjvYcy9So818Y9/++Fmk2XpGkTJIKESTv4AOo1We1OdbLTrNQzaMJwad/Nax7aQWkENr0D3ItzEgLOIP0xhT/ZZWeE3NRW4SOeaN/SOiRCIbF9KP0cqWbMOKZPkE0WbC7gFwb uzZn+emn ZOdLKfXSiRZ3zupwYA68zT6FfSimfX3K1ySAvC5463Uyy/q/+q2XcVxKGEieBnv27w2/xUeHVmGC/UMKtfMYS0U0MqPYxhBr3XvsrEso33VVyCHhcoCMdodZiYMP5yds6/gq1M8p7+mmwuIDkopy7Iv31Wrzwi+pnzQWoktpHMdmvutMMle5L8WpoxMXceA04d723RC9ulVwgvgbjFFTNgSHVZWQCO/B773sHV7vqn2x8LNBlOgTsqybRzFcjdxgUZKpjycedsPXEHXK2ETsZCNZ4vDChH4TVn/kRAvONboxlwD/anpBbcGvQaTwC1WBgQfudazehzp64x1A+xPARicBh+F+5NGxHPfSE6X9Ztb/5bdMBw2uO+arUr/8CgP7ogmt/qoPN6OiSxea2/Pb4cLf1d4mVWRFTlOxYU7LJp/gnKdmQkmz4HGFCV4aFZ1xp8Af1j0+Air1zdHtJRz8miJGwIGozb7GtQopsB/gyW0N5GJi4x6O0w0JM1221/8q8I7Bw+tNzLJIp7wpLJt1ZXPVq5PFcbq93/VF65V5tEkyEyrgr2ThrSV30PfsIdrXDN7NEv3dz9P8hXl3GHFIKZB2iBI9voXtyX9Q/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/13/25 6:06 AM, Byungchul Park wrote: > llist_head and llist_node can be used by very primitives. For example, I suppose you mean "every primitives". Right? However, the term "primitive" may sound strange. Maybe just saying that it is used by some other header files. Cheers, Longman > dept for tracking dependencies uses llist in its header. To avoid header > dependency, move those to types.h. > > Signed-off-by: Byungchul Park > --- > include/linux/llist.h | 8 -------- > include/linux/types.h | 8 ++++++++ > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/include/linux/llist.h b/include/linux/llist.h > index 2c982ff7475a..3ac071857612 100644 > --- a/include/linux/llist.h > +++ b/include/linux/llist.h > @@ -53,14 +53,6 @@ > #include > #include > > -struct llist_head { > - struct llist_node *first; > -}; > - > -struct llist_node { > - struct llist_node *next; > -}; > - > #define LLIST_HEAD_INIT(name) { NULL } > #define LLIST_HEAD(name) struct llist_head name = LLIST_HEAD_INIT(name) > > diff --git a/include/linux/types.h b/include/linux/types.h > index 49b79c8bb1a9..c727cc2249e8 100644 > --- a/include/linux/types.h > +++ b/include/linux/types.h > @@ -204,6 +204,14 @@ struct hlist_node { > struct hlist_node *next, **pprev; > }; > > +struct llist_head { > + struct llist_node *first; > +}; > + > +struct llist_node { > + struct llist_node *next; > +}; > + > struct ustat { > __kernel_daddr_t f_tfree; > #ifdef CONFIG_ARCH_32BIT_USTAT_F_TINODE