From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 907F0C77B7F for ; Thu, 11 May 2023 22:37:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F031A6B0074; Thu, 11 May 2023 18:37:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EB2B96B007D; Thu, 11 May 2023 18:37:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7A5E6B007E; Thu, 11 May 2023 18:37:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C85226B0074 for ; Thu, 11 May 2023 18:37:20 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 87449140936 for ; Thu, 11 May 2023 22:37:20 +0000 (UTC) X-FDA: 80779436640.23.5C0ED5C Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by imf27.hostedemail.com (Postfix) with ESMTP id B096840009 for ; Thu, 11 May 2023 22:37:18 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=rmLEbyJn; spf=pass (imf27.hostedemail.com: domain of hughd@google.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683844638; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y7hKTTTuYzAS0vkkDuN/hWvEkav8P49YQtcFz2W5wMI=; b=NhBVO+8v5Y8wqlx+1dJJ1I1tCXm/BYNpr47//44899875FdyVJlBoHospQCxVrhS+10KfF 7TW8St+TJhfNbpDM+C64dlh+XXQylm/IQBr4InTD4LAcxaBcda7S8vdDQFb83Z3cTs+9uU BVLhA/RXkXe9BW3FNKFGrvdolAuQPeI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683844638; a=rsa-sha256; cv=none; b=E7qlUaw4FHbsiGaasHsJQOt6a9ShpUPQBBQ2XmIs0OIm2Fo9ojJJZ+WE8LtzRuUBMfPc/1 ysAXjZMIbpJxFqQUMJwKEMZfzMdA+K7zUUaaF6SIU167onA1FgDf+ammbcBYe5SNlkPucY IktiE8GrTbajaEeByxSRD+2YYzTh5IY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=rmLEbyJn; spf=pass (imf27.hostedemail.com: domain of hughd@google.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-55a64f0053fso138501777b3.3 for ; Thu, 11 May 2023 15:37:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683844638; x=1686436638; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=Y7hKTTTuYzAS0vkkDuN/hWvEkav8P49YQtcFz2W5wMI=; b=rmLEbyJnqvOVZvyem/dx4EeE4Hb+y/Pt3sCMXOhUT4+WOSVgT9SrvJwpG8J8eccP0S We1xZ/4WGGdBDqfpqGsHnuZCSGFvQm2UYsHZAw4MXWcPX6YHx0oGna9RTg3sUR1c+U5C Qwyvr7FjQ97oYJtWz5JHamyFDaPkeLpJG2e+6gaYqq98OwH+CEZB9+6FFIMkzBivvFNq Exf4rCzbMu2F6AQ16mi9sKfKgnOSmIkugBLcrInFdkuq/2+/Qa9DzwgXelYXVXQSgV80 gGYHfGgjFLWgxh60yeQd+cZiSMa6GOyrUhuEAmZ1y1qkdwMFxFqrjaacIJIbHbu95RNV quZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683844638; x=1686436638; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y7hKTTTuYzAS0vkkDuN/hWvEkav8P49YQtcFz2W5wMI=; b=cKPuvBwmPcB40RaEX7H2JNCAAuAQQcKyTc4kXf0hozd4dnvkNSHVpweLq3KChX9fby FvRdU53slOuzSlCswHsFABK0/tB1an0nFpDmbjJ9ET9r+P7tCfHeCfG9yeUTpdkLnZY2 kzpGDqcnlKQso2NAgHdRbxmERKvR4+zmQorNGrPoAvzfSOiZvPChqdsqqubhi0RMccbk xkvJht6LMg/xOCZ8xzZVN/P/WslpZ+ypkq9VDn+qiXkAizzVI3qwn3P/qA3imJIuQ29v RRx/dl4YxmPUhxbUWUQ2DxYHTTVGoqsLK6/ls6Rm+vgR60TDHgphiAk+WyA5qRj6QP5l EZNw== X-Gm-Message-State: AC+VfDyXvveAGBvLJRLsqZt/LEx2b/C9miD6uRtDzVMRGoq8PnuzX81P +B25J9C02+qhhTYNmebrXh9Iqg== X-Google-Smtp-Source: ACHHUZ5ulkW3cY83+IL8attIxR7bTyRhvIioTTYSGrJhrY5IS/y6LwBFwFzMwChvIicQOTRvegivGA== X-Received: by 2002:a0d:d993:0:b0:559:d294:1c48 with SMTP id b141-20020a0dd993000000b00559d2941c48mr22473279ywe.24.1683844637583; Thu, 11 May 2023 15:37:17 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id k189-20020a0dfac6000000b0054fa5f6c0cdsm5262641ywf.53.2023.05.11.15.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 May 2023 15:37:17 -0700 (PDT) Date: Thu, 11 May 2023 15:37:06 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Matthew Wilcox cc: Hugh Dickins , Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Russell King , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Greg Ungerer , Michal Simek , Thomas Bogendoerfer , Helge Deller , John David Anglin , "Aneesh Kumar K.V" , Michael Ellerman , Alexandre Ghiti , Palmer Dabbelt , Heiko Carstens , Christian Borntraeger , Claudio Imbrenda , John Paul Adrian Glaubitz , "David S. Miller" , Chris Zankel , Max Filippov , Peter Zijlstra , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michel Lespinasse Subject: Re: [PATCH 00/23] arch: allow pte_offset_map[_lock]() to fail In-Reply-To: Message-ID: <5f1dd6f-1e75-8d98-3083-e1bd2163dcc6@google.com> References: <77a5d8c-406b-7068-4f17-23b7ac53bc83@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Stat-Signature: wddnw5ejw6a86fmqyanfmiwh4bjn3u3n X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B096840009 X-Rspam-User: X-HE-Tag: 1683844638-562951 X-HE-Meta: U2FsdGVkX1+joumt9trSYToljitHjuaNzvU+a8s/lUgFaa32DduAQsjVTsO8lrT5eC4HK7hKRHFz6PI31oW/zYeAAUBEfFQcIqi1IJnqpvrYcGvOnCyCJEX+7b/ywKiVmysFFjUCH5fKDz2T35u975P3s4Eb5+JrljzuLz5jwVVZ1q461fPVlNQDsIGCvYTksq+0S5+PpOXwtNAMwj3OKtYEp3tFANmLSWzoGnIJy0b4G9A2kXUCE8nNDKRAo6lVA4jR1xq6G0bqvBJ/92Do0PliwTV9pUJjH6oni/YeP3p00pI7QJUB8gqN52sLbcR4BgYW1cetcvPnrglq+LuFb8LnfUIOWZKMhpm9ZM/maDQC325Q5t37JlHQ3p2P1hLLViuDm2VHbxDlO65dbhOovzn+zyITqNeCl4zVDKwRN0pFXQs02PCRO+b1cQuTP8u2Vxy+H8pX6jkaiZ7ATBh+zx2tYoJerRy+860Bfuo2ZCRhz8PSqxk3vi1GOeDRXJohqeBKOq61luV1aHjEMSkIhgy+2klU1RAEtOr147UAX0dirO7Y2NVfdfunfDu7/kOJmX4ABgiC+T7W3N2NV4ueae2v5BNBYG2w0trYsUgpdOcqztX96mJUVdECr0SOpcc9Zx1n/QK0/uzIpHPIGjrNqHrhdjDYUVqpcY6kTtPb4Empmh3pRA9wEKemLexEFI3KmzAhsUc5K3fe1bLwayU/nCel7NYiEEBgJCZ6QYdRE9lN3FrGi2yymR5TW5nNOWCLD0jKb3E299X3FhwpbL8iyEMjStpxKLVxJkpOLX40glKLtURcEL1nJPITP6jFphzeve5i060bT+uPScoU1EKYZ+vaeu08JtHm9ehluyYAvJV9Jnh+YGcpgv+axFGzPvuwxZrrkEeGDz/6quVPeLHwQZw090hsBsAkdJZWyNOiqwOdbIWX54FhttpLm3losmNsx/xAEGOLbx+EcbcKLIx pP4Xst2Z 415k8sa7/o4cYd7KQdKpZoam6jF7FzVVRJ4Wi2ly2Knw6JRhmVgFAEIWAE/ZlXEtgNHRWU5jggshE0f1mPjrtbSPORfhcx0bUNSAfipdSTLV4lpzIh0AQQQfDpUMJv5pkzCQa9JeJI81J/o12qZRW/paNzM6ciHEByoXKdrBZ/5IcW0KKWhOitHELZxLlWHhM6cFLIbZCneClFafgnqLaGAoHeyTZnfwzCZw4H85Uu4h6+fre1slEFv3AY+hWlZmTAVrwz6pMTc9369r4zcUz9Kfkojqp8onnLQGiVW4yDTNMXli/mC8k5a0W5uHHWV3C6J+ZCWGyJ6CrnGmVGaoJM/kqATG/iW5fYYUN+4Lfk2LRutaYND129EWxf1RFY6GU2IEz2P1dZSmFYSd909IuzfosTtYpWZ2LiHSB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 11 May 2023, Matthew Wilcox wrote: > > I was thinking that removing CONFIG_HIGHPTE might simplify the page > fault handling path a little, but now I've looked at it some more, and > I'm not sure there's any simplification to be had. It should probably > use kmap_local instead of kmap_atomic(), though. Re kmap_local, yes, one of the patches in the next series does make that change. > > I infer that what you need is a pte_access_start() and a > pte_access_end() which look like they can be plausibly rcu_read_lock() > and rcu_read_unlock(), but might need to be local_irq_save() and > local_irq_restore() in some configurations? Yes, except that the local_irq_restore() in PAE-like configurations (if we need it at all) is not delayed until the pte_access_end() or pte_unmap() - it's internal to the pte_access_start() or pte_offset_map(): interrupts only disabled across the getting of a consistent pmd entry. Over-generalizing a little, any user of pte_offset_map() (as opposed to pte_offset_map_lock()) has to be prepared for the ptes to change under them: but we do need to give them something that is or was recently the relevant page table, rather than a random page mishmashed from mismatched pmd_low and pmd_high. > > We also talked about moving x86 to always RCU-free page tables in > order to make accessing /proc/$pid/smaps lockless. I believe Michel > is going to take a swing at this project. (And /proc/$pid/numa_maps, I hope: that's even worse in some way, IIRC.) That might be orthogonal to what I'm doing: many non-x86 architectures already do RCU-freeing of page tables via the TLB route, but that doesn't cover a pte_free() from retract_page_tables() or collapse_and_free_pmd(). Hugh