From: Miaohe Lin <linmiaohe@huawei.com>
To: Michal Hocko <mhocko@suse.com>
Cc: <hannes@cmpxchg.org>, <roman.gushchin@linux.dev>,
<shakeelb@google.com>, <akpm@linux-foundation.org>,
<muchun.song@linux.dev>, <cgroups@vger.kernel.org>,
<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memcg: remove unneeded header files
Date: Mon, 19 Jun 2023 15:42:32 +0800 [thread overview]
Message-ID: <5f1d08ea-72af-f287-9ec5-3c485c1e4f0c@huawei.com> (raw)
In-Reply-To: <ZJABkaSdZP+K6dOh@dhcp22.suse.cz>
On 2023/6/19 15:19, Michal Hocko wrote:
> On Sat 17-06-23 15:26:58, Miaohe Lin wrote:
>> Remove some unneeded header files. No functional change intended.
>
> Header inclusion cleanups are certainly welcome but it would be much
> more preferred to explain why those are not needed. As build test follow
> ups show this is much more subtle than it seems.
Will make it clear in v2. Thanks for comment.
prev parent reply other threads:[~2023-06-19 7:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-17 7:26 Miaohe Lin
2023-06-17 9:12 ` kernel test robot
2023-06-19 1:38 ` Miaohe Lin
2023-06-17 9:24 ` kernel test robot
2023-06-17 10:58 ` kernel test robot
2023-06-19 7:19 ` Michal Hocko
2023-06-19 7:42 ` Miaohe Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f1d08ea-72af-f287-9ec5-3c485c1e4f0c@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox