From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E745C0015E for ; Thu, 27 Jul 2023 09:20:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3AE1D6B0072; Thu, 27 Jul 2023 05:20:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 338076B0074; Thu, 27 Jul 2023 05:20:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B1278D0001; Thu, 27 Jul 2023 05:20:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0A3D76B0072 for ; Thu, 27 Jul 2023 05:20:07 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BDF841A0541 for ; Thu, 27 Jul 2023 09:20:06 +0000 (UTC) X-FDA: 81056845212.21.8D8FB68 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by imf29.hostedemail.com (Postfix) with ESMTP id BDB53120028 for ; Thu, 27 Jul 2023 09:20:04 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=YCWSTu9U; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf29.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690449604; a=rsa-sha256; cv=none; b=SgGPDrLISL5pUGQGQPDjSdhQX/46qmgZ5sdn8C1EONNzVk43v/dVJNKTM8N6oit+XHl1yW BFSyjcnaSx7P6f5P2y5lsTOjdhCjy9UcSyG5QeXJ4S6amon6Xwzty7qpORM6C3DJuJivgf tzG0uedrs4AhcFsTffIdDan5FKUKxTA= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=YCWSTu9U; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf29.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.173 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690449604; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cb79b5va6gFfSJneJi5lY4rGeRwgOukMupryAUVW6kI=; b=a0CJA2NcjvpuC70/5uiPBuZ3wWvRcHmauBKXYUD3lL5ly4hUAzhgBBYTYIPfCfV/YcY2FL HuHDhZb3+kQ0sr2tKEHGpdaPNUoThOWaHJzMnQwptOaNO/AVVFgD1OSDpDS6Y+AUjYRdcD 5O1NxGNn68XEt5JErkTrwQjro8Wbw14= Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-682ae5d4184so182993b3a.1 for ; Thu, 27 Jul 2023 02:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690449603; x=1691054403; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cb79b5va6gFfSJneJi5lY4rGeRwgOukMupryAUVW6kI=; b=YCWSTu9U7oWMIxlz666y2QG523oA3QX5qQv7ZytrRVu6fJw8dRHyUfgDIT1gU69FG8 THUguZfsi1KeJApNPmw0jxmv7f8KFlV4UTxlH9XbeulHxoa/ldWA269gxLsqPd7fsDUL 3wrs7fjkTjLEvVIuFKVgIWoEr+OE7ZGV4f2QptD03saCT0x1g+4lQFRHQ9ruqft2Rhft lQsKff8YPeqYMpcr6auHVhvyZ4A0b6O2v3t87pxn8FkR9lCy8v/ntqGuUNKm9Zf3rtD1 Pt/WGCyBPHzJX+fw7G8Ac9jWyGkR4LQhg8QoLvoZwbFMr8CqGaDCh/cUGTEJkXif0gLU NqYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690449603; x=1691054403; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cb79b5va6gFfSJneJi5lY4rGeRwgOukMupryAUVW6kI=; b=NIabhtthUZZhWAoWfv2KT3qmMyTi2WfR0n8mFPiKsR8rYHVVRGh4xwe/EWREQ5Tgx1 5L4aX0E9GFdB3UpxlLnx3+gkyf/nU4c83xd8MvlCOO+zXLC5ylKuX3iYZNnzJZs1jMZ/ EF1bWkAZkIBwXwKWcM2We6F+j/ZAih91NL4bMh6EtMhyz5NDWnJwqXHuRLYbX+Y2j99P MnrezeU4GezkYfvrDmZ02/CUA7rmOt/B3sfSvyFeOHhNxTDCwegE1NFsALaPsa2Mz2MC nHuc/qdceIl6Y+eL6e98M6Kkar/51Tm+LEF39PIY1HGSeHxp1lAH72pWOKBRLQ/lB12C FPvg== X-Gm-Message-State: ABy/qLaUYAO4i2TQTrW2G4gMpDshZQ0hxSOXSduprBGqOMO14DXcaz2F MBcce2bHOZGgexj6wAWLkI8R/oJipluwdZSuR9I= X-Google-Smtp-Source: APBJJlH+dm0mCsob/js+yZXnXAfwEH4KDToex0aS0MQ56gbjyJxo+xxDZzOa2lZ9gy3mjvwdmWQa2g== X-Received: by 2002:a17:902:da82:b0:1b8:811:b079 with SMTP id j2-20020a170902da8200b001b80811b079mr5785873plx.0.1690449602958; Thu, 27 Jul 2023 02:20:02 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id 5-20020a170902c24500b001bbb7d8fff2sm1109046plg.116.2023.07.27.02.19.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jul 2023 02:20:02 -0700 (PDT) Message-ID: <5f1b85b8-3655-1700-4d16-fa056b31ceeb@bytedance.com> Date: Thu, 27 Jul 2023 17:19:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 40/49] xfs: dynamically allocate the xfs-qm shrinker Content-Language: en-US To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Muchun Song References: <20230727080502.77895-1-zhengqi.arch@bytedance.com> <20230727080502.77895-41-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: <20230727080502.77895-41-zhengqi.arch@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: BDB53120028 X-Stat-Signature: amwb19qftstm6p51nrbmigdwhh4wya8a X-HE-Tag: 1690449604-687334 X-HE-Meta: U2FsdGVkX193PMb4xgjllCNlvNI9sFXgyUdYw+rfJU7Aji/b23llWVHX0DizpaaZ5CDfEndI92nRJNC5OXGJ/0DRlaCiuIpAb2EH6qnght7XYQBPjMlvP9I6qMcnlqbnZ1EP0ySuFoT98TqSyxX1MmuhDplATC2MQ65KNfmVL+vcOvGRUnn0f5dTE+pDRYr3TQLWdRSSKBozfaxIwTRVALqh5XMtjIPfKszAynn5fTC5jbOYJN/98zSYy2hpOaBNFUbwd45i4A+Bfbz2YnLl4Ym3EMP1X9G7gsjT8aVPnHrUh2sxRmTgo4S4DZZtDLqg1FFP602Vv4Rm0Pih0tp+d6aS8U97J5IzuyJLaI4UlW7DJYwRtpXv4GTR2826KmT80RSgziui4xzwbEHSG4rsGpwSfnoyDMLuUEBaxf6VEI6NJpQzvvdPPG5gKH985hUFslXY9qICiB8pM8JpswwSvPD/dYCQvZfAR81cJoaGUekTyE/bwB5n/+P0osL4vJ4C3KnDbd2Lj3jPsAtJ5OBVpsxQDv2PwqgiEz3i+f/ZnBYayVN2wAyJhfPa1XQyDJrx3WnWpSnso3kOoWyaqyBwPwb+bBx7MutrbJeykqNJeueaKb2UgksFMTME9S6EIsqvVE+wzwkP2d7wxAlo8Ckja/x2idYiV7hTvMe00uVkfFBcrpOxjzc0CG/fHbMiuDmG5E2D6nIIyc1ZHzt/ZBu7lgVWrbcIwB0RfvpLbFqLoEI4R+/1DqV3EGKQt8WSRCA+HyN67WR/01O0ZWSM3AUu0k8uODUOm0Z0Xe1BlInBOPP0bqB+L17Sp1HPzQp1vkEJwqRhtyVlHeysE+ANq2Z+3DcbMT/Kv4ZyBKmgytNFzTSpzUS8XRLFeISzN7Gz8+w5sUF2sWCJsmxitq8HAscP8kSnhKVuq8vVLWM+O/kPD8KgxrOYeWthHmMRMJE3iB7CganKX/Mx2H0yl0ZUuSQ 8krgckXK wOcWxN5ux0EpAhdP8fBfHvQ9/bpHVk6W/j3M/v1Gjv2cNst+tSPkpohox0uaDy1aB+PkfvkDFWfAiwbtkUlMY+9fcC5Eq0CXt5P04S/Nc9BvkjUYbD7i29SwDmAQ+n1uKd8gtx/zqtrgxmpS2/+UoV3C8q2KNdz0dbNjiGuan8cw4gebIBXRjCOeMTSN6m24VBENxdoM3YkOFWhCqKTl1DQ64quQIGPtazW2ybYQULpGSlGZRDPkVmDr5ntAokoK9BZSlFdBgODKu5nWA2Ux4YgnONDaiU7hUDWXBHqAbHemV8OsYseCpmer/fOKU6MkmCYtXpvBwenRI7fnPeKMwYakSCaztlt4GTjiLsDe9fXNVWI0xAVFtkGD8sOHl4khUJyBtLCo/bV0CdbO/9f0NPo/dPiGRqKeoPCaOlFVlrdv2nwE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/27 16:04, Qi Zheng wrote: > In preparation for implementing lockless slab shrink, use new APIs to > dynamically allocate the xfs-qm shrinker, so that it can be freed > asynchronously using kfree_rcu(). Then it doesn't need to wait for RCU > read-side critical section when releasing the struct xfs_quotainfo. > > Signed-off-by: Qi Zheng > Reviewed-by: Muchun Song > --- > fs/xfs/xfs_qm.c | 26 +++++++++++++------------- > fs/xfs/xfs_qm.h | 2 +- > 2 files changed, 14 insertions(+), 14 deletions(-) > > diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c > index 6abcc34fafd8..032f0a208bd2 100644 > --- a/fs/xfs/xfs_qm.c > +++ b/fs/xfs/xfs_qm.c > @@ -504,8 +504,7 @@ xfs_qm_shrink_scan( > struct shrinker *shrink, > struct shrink_control *sc) > { > - struct xfs_quotainfo *qi = container_of(shrink, > - struct xfs_quotainfo, qi_shrinker); > + struct xfs_quotainfo *qi = shrink->private_data; > struct xfs_qm_isolate isol; > unsigned long freed; > int error; > @@ -539,8 +538,7 @@ xfs_qm_shrink_count( > struct shrinker *shrink, > struct shrink_control *sc) > { > - struct xfs_quotainfo *qi = container_of(shrink, > - struct xfs_quotainfo, qi_shrinker); > + struct xfs_quotainfo *qi = shrink->private_data; > > return list_lru_shrink_count(&qi->qi_lru, sc); > } > @@ -680,16 +678,18 @@ xfs_qm_init_quotainfo( > if (XFS_IS_PQUOTA_ON(mp)) > xfs_qm_set_defquota(mp, XFS_DQTYPE_PROJ, qinf); > > - qinf->qi_shrinker.count_objects = xfs_qm_shrink_count; > - qinf->qi_shrinker.scan_objects = xfs_qm_shrink_scan; > - qinf->qi_shrinker.seeks = DEFAULT_SEEKS; > - qinf->qi_shrinker.flags = SHRINKER_NUMA_AWARE; > - > - error = register_shrinker(&qinf->qi_shrinker, "xfs-qm:%s", > - mp->m_super->s_id); > - if (error) > + qinf->qi_shrinker = shrinker_alloc(SHRINKER_NUMA_AWARE, "xfs-qm:%s", > + mp->m_super->s_id); > + if (!qinf->qi_shrinker) Here should set error to -ENOMEM, will fix. > goto out_free_inos; > > + qinf->qi_shrinker->count_objects = xfs_qm_shrink_count; > + qinf->qi_shrinker->scan_objects = xfs_qm_shrink_scan; > + qinf->qi_shrinker->seeks = DEFAULT_SEEKS; > + qinf->qi_shrinker->private_data = qinf; > + > + shrinker_register(qinf->qi_shrinker); > + > return 0; > > out_free_inos: > @@ -718,7 +718,7 @@ xfs_qm_destroy_quotainfo( > qi = mp->m_quotainfo; > ASSERT(qi != NULL); > > - unregister_shrinker(&qi->qi_shrinker); > + shrinker_free(qi->qi_shrinker); > list_lru_destroy(&qi->qi_lru); > xfs_qm_destroy_quotainos(qi); > mutex_destroy(&qi->qi_tree_lock); > diff --git a/fs/xfs/xfs_qm.h b/fs/xfs/xfs_qm.h > index 9683f0457d19..d5c9fc4ba591 100644 > --- a/fs/xfs/xfs_qm.h > +++ b/fs/xfs/xfs_qm.h > @@ -63,7 +63,7 @@ struct xfs_quotainfo { > struct xfs_def_quota qi_usr_default; > struct xfs_def_quota qi_grp_default; > struct xfs_def_quota qi_prj_default; > - struct shrinker qi_shrinker; > + struct shrinker *qi_shrinker; > > /* Minimum and maximum quota expiration timestamp values. */ > time64_t qi_expiry_min;