From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5519C83F1B for ; Mon, 14 Jul 2025 14:27:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73B858D0007; Mon, 14 Jul 2025 10:27:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EBBA8D0001; Mon, 14 Jul 2025 10:27:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DB128D0007; Mon, 14 Jul 2025 10:27:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4E3FD8D0001 for ; Mon, 14 Jul 2025 10:27:39 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 19D2D12AFD8 for ; Mon, 14 Jul 2025 14:27:39 +0000 (UTC) X-FDA: 83663098638.22.852BF5D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id CBB77140006 for ; Mon, 14 Jul 2025 14:27:36 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A7VjbXuC; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752503256; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SLif49jv+ZvfHqLndwovPsHsTBrasj5ntlXYHSvszjo=; b=AAIjMVNRDbgpFUOtG0b5Ljo3sBjeBIFOwQd4rjuhkD9N1b+9Vqt9Yvqryw/DVBvyOHI229 l/vsatNSPsD+/WZq+D0QpOyj/hbkw0KpWr3CiLHNEdMt+5ydubOk9VdAzJDnQ043aVyVLq /iffEklJq1Yji8IkSXqpJxEbXksvmY8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752503256; a=rsa-sha256; cv=none; b=wpb10D1tqegb5E1w9EpD7JVwqLK0sNckcXwpSYFjV4VN0dSKcgLaF0LHBBztw5zUWoQ36L j74G3DgHcnbqpfUeQFr59mwp84B3eNRqnMvsKnngCFKgMtek1mBMHAXwJcZkZKyhvNozko agc0t7U4A5HP9uDuHPEEE6F+QUslfno= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A7VjbXuC; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752503256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=SLif49jv+ZvfHqLndwovPsHsTBrasj5ntlXYHSvszjo=; b=A7VjbXuC3yMOR4ou1sjymgNFDc8uarN0Rv1DiCPcs2m1qeO4VVXLtn0SM9Mxov/trrCyTR VTjzXUab9od8oHKyxcIlbCQKxk9oFTpx3UwSxeX3B+hxnIjhWIvqVEFDGvi7M45c7eNj0L 4tZM5w0n5q3jYw5GQUiKgmNxrz8ZvJ4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-QnHaVQMgNomGBnPyKoKGPQ-1; Mon, 14 Jul 2025 10:27:33 -0400 X-MC-Unique: QnHaVQMgNomGBnPyKoKGPQ-1 X-Mimecast-MFC-AGG-ID: QnHaVQMgNomGBnPyKoKGPQ_1752503252 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a4f8192e2cso2505863f8f.3 for ; Mon, 14 Jul 2025 07:27:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752503252; x=1753108052; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=SLif49jv+ZvfHqLndwovPsHsTBrasj5ntlXYHSvszjo=; b=qeq7zYkhCtWjmVsJ6wvExodtjsYF4P0jRQnkR0wsQjKgzhRC7FkQbEXBt4yomanlTm XmKyaLIvEZJHTDSpggsP8q5drpKVs0Mf+01XjBAbvnn6x4XgO7QR163mdk2KVDaSSpe5 IMuLg8nBh0Q+82W1D+6vpFy/Q6MIISPSacHpHlUbCti1LCAxsuck2w52Ay6hOBrmfJh4 ZjyUx16kGXGsMLifT7/5aYc/L+StqON8iskA/V+HrL/zRmchI0jZXRfWzcFxMKCxyMYG Gn5Wl8QpJfPuDpL1flRDQ7eDa7M2K/Eq1hxBbyEfHSFC79AwUmoevzz6QNEjdG3qbD1K 21jw== X-Forwarded-Encrypted: i=1; AJvYcCW1xPoiuJJ9MrT2BmMacXycwtyvod2DOiClOm2BHZBOFUh/S800f9VWv64G0uHggaK7Fva47NtX0A==@kvack.org X-Gm-Message-State: AOJu0YzonqnV0N84qSs5j4OCdnWYtVQ3rxfCzJE1vQ0b+5sRchfhggTF +W1TZD5ajvHWDhYkJG4zW7HfTrpnDc9F9nb3TokyYHmuhA50ChRcUEVCqthI7XWPqXklVls5OtE yGpZJvunTPASkwwhOcaXtpqNKBiuAhZ/cDOHs0v3MlxkKvd9geHqR X-Gm-Gg: ASbGncv/hD0LTMUWITeIgpfTpJSkdNxlZ2YrSXmm3BlHcnvvNXQOTE9MMaoxnfD+PKq Tk0aK7htClpqWkzh61f/klr4p5aV0wrm0GC8BydjGDtXKwPgoFNEvjzd3aFLsgYmZSnbZwssLet +I+/3eCH+ZQj1muZQ/3BGH4zi2CTSD8jnyoYlCRmOqNFTKmop+7mt/SA8X8pDz4ZCvlu97Qyqkd aaY0EI3F8Ut9Rent2a6gT7zoeNYdUTqSJUf6D4U/Tu1P3sfoZs1fV+OVsFo4dUtraDxqoFNhPy2 qLOJzZqCqVMNOL/6GkdqgaqZ2UIMjHz2/prvKFzzD/fPEWUs02yJqzdSaQO73MU0p3szY77pTvx 0KCt+cct1QhQhUyKDtF7maBMzbhmfYPx/W/XZTPm+oEE9LFn/Q+ae9X/rL4RuxMSd X-Received: by 2002:a05:6000:1882:b0:3a3:6595:9209 with SMTP id ffacd0b85a97d-3b5f2dfdfdfmr10757391f8f.36.1752503251867; Mon, 14 Jul 2025 07:27:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHb9yPQGfUemoQ/ftwZvJKjzlbImo6TEw+6kXEcwvLRV1cThxuF77rhGdAIcuPD1v8QuJos0g== X-Received: by 2002:a05:6000:1882:b0:3a3:6595:9209 with SMTP id ffacd0b85a97d-3b5f2dfdfdfmr10757378f8f.36.1752503251480; Mon, 14 Jul 2025 07:27:31 -0700 (PDT) Received: from ?IPV6:2003:d8:2f38:ca00:ca3a:83da:653e:234? (p200300d82f38ca00ca3a83da653e0234.dip0.t-ipconnect.de. [2003:d8:2f38:ca00:ca3a:83da:653e:234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4560f22cd29sm63831485e9.34.2025.07.14.07.27.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jul 2025 07:27:30 -0700 (PDT) Message-ID: <5f1598d0-3645-4553-a3a4-4b458190ef53@redhat.com> Date: Mon, 14 Jul 2025 16:27:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/vma: refactor vma_modify_flags_name() to vma_modify_name() To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250714135839.178032-1-lorenzo.stoakes@oracle.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 90vbFnJSWr5x-Yg7rA3kgMhJiv-_AO1T31G8RRChMQ0_1752503252 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CBB77140006 X-Stat-Signature: yhedj5fwoykg4gurshk4fepukc7yubbi X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1752503256-994103 X-HE-Meta: U2FsdGVkX18u6K6+gpkDahFEtrbBbBHd4i84B98fz9aTnrFHP6s1GsX1DYt5NVGwLYIkAiOlX2J8sFtU+4FZz1pOqGo6e6HSxzUDmsyXZF760R2BIe/QaXg7sEtGOZ7UZhB0eu7v93iyd6GOMAUIftiN4DI9180RT97nvQgBKteigf6+rf+I72/2CCW0jI/u3/i3rIeSPA4z9tyWfgC1SW1Bcz9O2FqHHSBVizi3zmI8TCpQ9WwPOXOxF0Bbw+vwago3scRQgGOiuDXTpFT93a2pLeR3XAWzoLE73txh9pT64LaU5476/VlwMFXf77TWbQEI6JGuPTiWDPWHhT5vq89worSBuZRbmRY3UWG1WjHMZ/tuwtn9tOqsaUFKiCenWm5NPQJvssp+V+0j4hzQFifDIc2kwD9XmVCJWZrm7i3Mezu5OaAW5WawJNOpX18nJmhrJ8AFXJ7ifWUrqoupnoypDzZzB0fn2gKalcuJJFAWvn/6ONAWXenRXLL6sTw5u9mYEhrfdl/JfdH1IhO9uBGOW8H0VoZLyLFJCQVjYLsTfkqNV5vTJDI4HY6JR5zKDA2R8YrpVq2VWUOPpLsce+LI5rp5ML3WSGraS+Q/Qj4gvbcEGeDJTracBd6+MTp7ewJnXPbvcDZlJzxWHXwxsHWEew8ubiYYGKxSCVQr6CkUTrE5XSbUx2QPkGlx4m7ltNvnDC7/J42dDeSI1lfX8VnlHDmtlkN0JynSPE/HqESIT+behTdz+2dn0ZtePRMil/kd2LNkyLEPIHwmfygT+QY+kntIawW43yzESo73vuvwhRPNWaJ5ddUt65WegEX2tlgjfI0CoPDrEI52n0DHcfpdk6kyqXuOtmNwZoKWITQamZikwWxYXs1YGU6w7JgwuF6/y0YrGaNWHWL69VY4Lyz13/sjVVUnXpLuFH/1MXo/KUcFrEyssl9w68Sf7Q3ExdBzb9pnCUl2RhfEfAm v9kmIeAO 9Sn7TaBu0VQDLN1yfJw/MvhHPmCNBH2Y3U1sRgsxfevqCmN4UFIKbAynQOG30mkGGgGIUjteagOKWRz4g4GVLj8+ptA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.07.25 16:24, Lorenzo Stoakes wrote: > On Mon, Jul 14, 2025 at 04:18:13PM +0200, David Hildenbrand wrote: >> On 14.07.25 15:58, Lorenzo Stoakes wrote: >>> The single instance in which we use this function doesn't actually need to >>> change VMA flags, so remove this parameter and update the caller >>> accordingly. >>> >>> Signed-off-by: Lorenzo Stoakes >>> --- >>> mm/madvise.c | 4 ++-- >>> mm/vma.c | 4 +--- >>> mm/vma.h | 15 +++++++-------- >>> 3 files changed, 10 insertions(+), 13 deletions(-) >>> >>> diff --git a/mm/madvise.c b/mm/madvise.c >>> index 9de9b7c797c6..afa9e4db2adb 100644 >>> --- a/mm/madvise.c >>> +++ b/mm/madvise.c >>> @@ -162,8 +162,8 @@ static int madvise_update_vma(vm_flags_t new_flags, >>> return 0; >>> if (set_new_anon_name) >>> - vma = vma_modify_flags_name(&vmi, madv_behavior->prev, vma, >>> - range->start, range->end, new_flags, anon_name); >>> + vma = vma_modify_name(&vmi, madv_behavior->prev, vma, >>> + range->start, range->end, anon_name); >>> else >> >> The doc of madvise_update_vma() is a bit misleading: >> >> "Update the vm_flags and/or anon_name" >> >> I assume it's xor? Do we want to sanity check that this will hold true? > > Yeah should be xor, this is just a remnant of a past age :P > > No need for sanity check I'd say, as the only code path that does this is very > specific - with behaviour of __MADV_SET_ANON_VMA_NAME and new_flags not updated > from vma->vm_flags. > > I can send a fix-patch to update the comment for madvise_update_vma(). With that Acked-by: David Hildenbrand Cheers buddy! -- Cheers, David / dhildenb