From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECAEDC282DE for ; Fri, 14 Mar 2025 01:11:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E6501280002; Thu, 13 Mar 2025 21:11:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E1443280001; Thu, 13 Mar 2025 21:11:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0345280002; Thu, 13 Mar 2025 21:11:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B0E0E280001 for ; Thu, 13 Mar 2025 21:11:39 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A5633551A1 for ; Fri, 14 Mar 2025 01:11:39 +0000 (UTC) X-FDA: 83218379118.18.6D08709 Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) by imf18.hostedemail.com (Postfix) with ESMTP id D12511C000D for ; Fri, 14 Mar 2025 01:11:37 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=bYdPbeyA; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf18.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741914698; a=rsa-sha256; cv=none; b=S8HOYCEVlgcJFAZjw/NtBDbvPqRBzPpoQOzjJuU7oqaVDzcPzMGLpgaa3bl2v0WK3A4BvC 6+pm5+tCaxTCzR5YUABBi2PvK3ILYyNNgbJu/qN5x6uo85KzWKqj3FM03Qpg4DEu5ChtcX yNdq1+QrTF1xljtO/sgvj6lOX6jIjo0= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=bYdPbeyA; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf18.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741914698; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=gbFfShayNoWAtYukk49ekwawgSMf4yXiMpSRNzuZTH8=; b=FswJgZ3/nJUEdWV0ZqBnxbXzDpbYtYjAbhO3qEzh6HBmJSlc0GmPrftjuPrPyP28Ah7kC9 uhD3yIP390xJPEWSeFRWZsZWckL7DECHuvlPLOj8XFoIQ8tDa+UjuZewhJhaIA+cjKIkSW y+FpxZq8w3I5ac8sWkmobX2kY0SOuuA= Date: Thu, 13 Mar 2025 18:11:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741914696; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=gbFfShayNoWAtYukk49ekwawgSMf4yXiMpSRNzuZTH8=; b=bYdPbeyARqk9eoq6FDufIEQDdiFXLWkFpb2BM7Ea3a7p8TkxZ9VDYsQ+Hd+C4IdLgJQC1/ GJi+E/rCvGO5RvbuTo/XpZ514emHjT1zwoAm542rmK6k0CQtOCOeUUG+r+gxvC44UIH1NT X/vpO3Jd0VRNEqIfSMPtB4WcmlrDZTg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt To: Sebastian Andrzej Siewior Cc: linux-mm@kvack.org Subject: question on memcg_stats_[un]lock in memcg code Message-ID: <5eqyqywhpgtpulqgnqyvpjivwfasbytgfrmum75ikvmsyhsjzu@xudzfvenzhzl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam07 X-Rspam-User: X-Stat-Signature: 7pwupn7ih84733ecf31odmca7d7ee8ff X-Rspamd-Queue-Id: D12511C000D X-HE-Tag: 1741914697-100501 X-HE-Meta: U2FsdGVkX1/I3YzP1Lndj7usBVWdTmtL1GyxU6QmVGQg7WNooZoPdTIg4Cf83Tn890oa2TUfJjHfyz1ZOAKI+n6CqAMpFgZCY4p7aSM4z0k/jr9GFvfEXDk3qhiFgPwh0AZMYmASwRs2rtr2y+hwvkFTfGQnLKi3cmMB6azcI6Ik0/SAov7Voek/7eRh1teWaO+fcsmuQquECePU7IX6mVPhRmo4QH6U8+MmrbDCp1CiRsTO3Y6jJYci9Eb7SD2keJQ+YoanLchxdGWH2uDdKAt9I5me1V4OkGgbjGz+E7XK20PQXep66YhH2yds5HeS7NN1LPeQjygoSnw2jKW/YN7nAFfoQbszv4kydbsHDT+I5lq4eIh/75Z9ygcH/CUbz2GOtzmYY0tsrcfOnDpLPgcgTum7q3mesh9w+T5zfRMQJF3XfsLX3PJwqqkiyqmBkZxr7eSVdqbbRa4tdhUR1gIuoFoU+VWGLD7+l87AzPd3Zx6hYA47bvTLUarHYbHVOk0mYP492D32NXtdUk4NLFVwK1p/YYc/Npk9sDH6qfqvzMhkcpTuac0EqU3eQRfezx4AW83LJTC2u+pQDPHd8csi8dW0C3WEG4opChI98CQVkvRaQymrAw+JhViE9Jr3BSeZrnj5Ahl/XNJTWO/BQSdiwm3kyrgy/qIucJ1HoeaaXQtlbXL1lPtvITaTOkVcfNOsAnh3z+F0T63bP51F+IHYl2dmROesjAjrnMift19iqQC6XlUwQjTnMJXic3hX1iyV3ByVGVebPtw5uKmADLVBVmRDUg6xV5nUFELMgJeyb2n3a1H4+WPUw2Be6ePY6z8dMd4Fog8Ix45ROo/0i6174rXV9sphdm8dCgPrzc16JlxYUO35Ta69Kbd1f1Nwv8fu6FzaaV5XP9XYuCiPSirQOgHmg048A/6bU9Kf6IkbHdeFpMHXhklLHL6Oxa3AWwvWQl4w4pxf8r6/aCb HBY1n90v uI4p6k6ALifVrb+xTQzpyDyVRO1LYpLGj0oLTR4g6VpbSBW6g1paob2DY4OoJ/36xnLRsag7VR8mnaxjY44qEcl/qkwsZmHF59e9zv4yOG3DExSWk/xKOykVX0Hp11UEaRQ3lpok+lBR38qh6+f2toKs9FHB/NTmO2ixz7vwlcsdFSxuaqEe8+mCSB3oJV54g20mZ/eH5B8Yb30YxQTuyW18ojDgPmNW0tbnj X-Bogosity: Ham, tests=bogofilter, spamicity=0.035553, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Sebastian, The commit be3e67b54b43 ("mm/memcg: protect per-CPU counter by disabling preemption on PREEMPT_RT where needed.") added memcg_stats_lock() and other variants in memcontrol.c. There usage were added in __mod_memcg_lruvec_state, __count_memcg_events and mem_cgroup_swapout. I am wondering why __mod_memcg_state was excluded? thanks, Shakeel