From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4534DC001DB for ; Mon, 7 Aug 2023 15:17:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D710B6B0071; Mon, 7 Aug 2023 11:17:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF9518D0003; Mon, 7 Aug 2023 11:17:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BC1F08D0001; Mon, 7 Aug 2023 11:17:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A8C8A6B0071 for ; Mon, 7 Aug 2023 11:17:07 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6BF0880AEA for ; Mon, 7 Aug 2023 15:17:07 +0000 (UTC) X-FDA: 81097661694.21.6C37832 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 1BBB518001E for ; Mon, 7 Aug 2023 15:17:04 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fnz8HT9C; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691421425; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eYywqks2v0/0vFQzXb/j/mZ2T5ErMgHmjkmLPArYOCg=; b=J0H0HPMtrpJDXwL9GkKJ80kqfVJqT8InmAe5oB7gvQ6/H1TB1o+d1piLuCSGdnsJa7Ys7H wnJR7rcuJKSYn+FqSCNGbiyMdIecY9rCUZ83qTYeeIXiq4UfJRp6CO+k/qOUAXnzlytCCL tFmE7C6cMAjuodJBtAYkwXccMU1XBaE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fnz8HT9C; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691421425; a=rsa-sha256; cv=none; b=ydth4OnpGVt/cCnul+wxobIEf4OBGt3iSzsyJ0h62uSXIEl6HO/WFulu4Xm5J8EalbK2uV ccsvgJ6Ns1Sfw8A/nYFH7OCNpm0AspSShgvjtWjZApkgngnUXgtmYJmJvK0EpT7bTFtNWB dpMOCfvFYsW5S8yBDi6op8qWigkr/LI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691421424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eYywqks2v0/0vFQzXb/j/mZ2T5ErMgHmjkmLPArYOCg=; b=fnz8HT9CJuGD+WdRGS/erXpXJIqvSIjFgTWLyd0HIw9448H2/AL15v4gI+K/zhhJu+Oi3S pVZUgntrqIzXv4qlP1y7ceE7pRO1OPShbc5RE/vq+SSZprhfUe0KjR29Obh9WYDg4atX2V Y/pM3EdKjvyUAcftjwH0Q2KYWLDqY38= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-356-MEOqwux2PyGUB03BM4kvSA-1; Mon, 07 Aug 2023 11:17:03 -0400 X-MC-Unique: MEOqwux2PyGUB03BM4kvSA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-3fe25f8c4bfso28780485e9.2 for ; Mon, 07 Aug 2023 08:17:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691421422; x=1692026222; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eYywqks2v0/0vFQzXb/j/mZ2T5ErMgHmjkmLPArYOCg=; b=M6aTFhMIn1yDUpkriHvqYZvNTnE5u/NDh0bm3XLWJM+7ApSq1xS7PR0PFPGFaUTWa1 ap5sKRSqa3RhjPkFyRnE4v8MttInFy/CugVYpe//3mXIz4Chz7i/dNvRvgPbc3cH4GWx HnDydyHm+m3EHPVbJ56NmkI25EpVPuAeHVAoEfcRrKzAjU/erJRThaJuQIGe43nU1cUj QD3lXXMwiHWLy8JHNREXX234drSt8xGnhcwJMeFdasx0enqskMjBQHw5m3meHvLFyjaC KY4E/NZNDrFL0XJoGRYWW0aeCo8LuyGfZVR56WImHoLb0K0lDTfjOqhso9BTckhm+eIr G9aQ== X-Gm-Message-State: AOJu0Yy6yp1PCZPwinJAN/k5m5AE1PEJFAMl02n1AsT+gbkYa+9Qt4rf cyrs1hUJR/Bg7w47jxCGdwU1v7v1a0c8V4NtNCdZg/tyofKi9iX9cBqHZWcEKJdGSfsVLb68K9B yokjXHWIWxkw= X-Received: by 2002:a7b:cc99:0:b0:3fe:1f98:deb7 with SMTP id p25-20020a7bcc99000000b003fe1f98deb7mr6896143wma.35.1691421421816; Mon, 07 Aug 2023 08:17:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEQweb6a8gTL7eOuQoZpcVgMLeKmYM/RCYzQjmSC1LPdgup0SqS6gADC7LdfWp+Qv4bdcyehw== X-Received: by 2002:a7b:cc99:0:b0:3fe:1f98:deb7 with SMTP id p25-20020a7bcc99000000b003fe1f98deb7mr6896128wma.35.1691421421354; Mon, 07 Aug 2023 08:17:01 -0700 (PDT) Received: from ?IPV6:2003:cb:c740:5d00:5143:1cd2:a300:ceff? (p200300cbc7405d0051431cd2a300ceff.dip0.t-ipconnect.de. [2003:cb:c740:5d00:5143:1cd2:a300:ceff]) by smtp.gmail.com with ESMTPSA id q9-20020a1ce909000000b003fc04d13242sm15467140wmc.0.2023.08.07.08.17.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Aug 2023 08:17:00 -0700 (PDT) Message-ID: <5ef201cd-dd30-45c7-9f49-c5e6301e8652@redhat.com> Date: Mon, 7 Aug 2023 17:17:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 2/4] mm/hugeltb: clean up hstate::max_huge_pages To: Xueshi Hu , mike.kravetz@oracle.com, muchun.song@linux.dev, corbet@lwn.net, akpm@linux-foundation.org, n-horiguchi@ah.jp.nec.com, osalvador@suse.de Cc: linux-mm@kvack.org References: <20230806074853.317203-1-xueshi.hu@smartx.com> <20230806074853.317203-3-xueshi.hu@smartx.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230806074853.317203-3-xueshi.hu@smartx.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1BBB518001E X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 95mej1r9psamruf4rohsttfemohtyptz X-HE-Tag: 1691421424-809653 X-HE-Meta: U2FsdGVkX19j1C8liBTKKs5V37Yz5KN9zqhCuzHc+idf84GoX4h6UCOKoekADWMvA8YpJLoAlg1papHFKBK/+/wkBiCpSkcgdHsTwxmonDNqVW92HAgKubOCx5VOBMJ4I4hsp1CkKwS89quMGJ/rZPsjCiYJVeAPFUpIWmEoJaKQEsOmv4ufjBC/TK8Kyg81mrFxqcM6ys2FFMemCeJXLseAo2ZtViPwywXdfzTsC/rURq9RNy12aYgQczCn5FyCGJ1P/8Gy5IZT0EEKnm5yNmp5Gow95xmE6rIi7A2vHGuI2JPtqF2NHAv6yMglHzGUxgASa6WFCdoyu3FvZbZn9L8jUHp3BBxAJ7aq+w/0m43MozSyRczgEEyL02SqnddzK8AyyymukwKDwdrmN66tPDmMqyTvR++2+tV12H5T4plKoG5PqfwNAuexFowsdv7h45xwM6NcRDfwdfDkttBbMjVSEp46RF4Wxst0ZRGPejmBeQZJRxx5+h5HAcHTg3v6ORUhEtXrAgn+wjW2v/GHj2NRHXcMTqwn0+9GXnFZsISsokMyOR9bqmPV9LuBkFdBOjbpyZacJoU4s2eLu64jPwd2OtDaBcPQh3SDDQ0Rom3scyne1UjwfpN0dIX6iUe5mHTyj8b+3m9WlAXVXJ1pV1wJnEF01Ihuhsovj6Cbz0yHBi/lJAxMSSEZZlavoZen4uNRci4XYU1GryID7wQ8X8M4DCcOnpBUMwgmMA01cogC8FxwePChlpDW2nfLPe8ngcxB8bfs561HuQStC/S0c06Aj6drfIZehfh1EqsaxtlnV7knSE3BlGx3yPcM7i37THLguBV5PUr9R5IkUxb/NI3RppKTxKdjphlidPhe4AGMAV91yZGTPDTb8VriwL0QBZa6fiLnxKTTLkoRcP9jQkOfi4IWe9jEetlrm3VUzRkvB/Ono2U5NNpEwbe5G9PZpNPF5ENZ508xuge48VO s9LUiKSd T6GMYfY9y9ruAkcawsv+Xds6VxduuDtNpeyp3WIHkw0NHT+loqZsH17eQ7U+oehJIMCAfR2UmOSi8Pcq0HSBmAB1uwwfuKTBZVnN3I6hR6YZoGOLFCY/kTzTpacoaUTB3XyCSTVfH1q45TtxBF1bmpXmQAMyCG6CzZwY28IGVVoLaP/JLj9WCTMWhqEEvm6awUUD/L0T5UsW37WXXglvDtxxNXXz/ZZoxTI3ghX6jeL1HY/cGwEERv51vwUy8LTOS+UbVVjEh1MYVdvvDOiI1ooSkvueO/O3VTn+xr/Ll9nwhw5mig5wxSHk7+uM6LbfKyib0u+VNbgOHFw+H322Abzz/4AV2shY2E0AAvXmxYRthw/2tX5R7oVzEQEHvXsu1qgSvrsJLs1K9KaDBP8oGXLH58f3CuYCyuXnZ0SEs9d3GQZ0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06.08.23 09:48, Xueshi Hu wrote: > Presently, the sole use case of hstate::max_huge_pages is confined to > hugetlb_sysctl_handler_common() and hugetlbfs_size_to_hpages(). > The former has been replaced with hstate::nr_huge_pages, while the latter Most probably that conversion is wrong as it changes documented behavior, and therefore, this patch is not applicable. -- Cheers, David / dhildenb