From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E812CA0EFF for ; Wed, 27 Aug 2025 12:01:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E4706B027C; Wed, 27 Aug 2025 08:01:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 494BA6B027E; Wed, 27 Aug 2025 08:01:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3AA756B0281; Wed, 27 Aug 2025 08:01:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 279AE6B027C for ; Wed, 27 Aug 2025 08:01:10 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DDA59C05CA for ; Wed, 27 Aug 2025 12:01:09 +0000 (UTC) X-FDA: 83822396658.19.4B243A9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 4D55C1A0011 for ; Wed, 27 Aug 2025 12:01:07 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=guo1O427; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1756296067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NWINZR72AGUB423TkOc4D8qtFil+Ep+hQK7BWdIPlw0=; b=FNTUlw3sbRhCZP5807YM6W9FOXvsQky5nk/CItgt628AqllA22WyzHEifye8iQHxGp3QkI 1oOkLjzjI6KtnS7ggaepKxIynElVjhcj6/5wRml2XoeNutFVZDFZWW5IA7vUlG1rTffLM/ r6HAhtR9ymUyxPOq3URq6YeT2AsRrCU= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=guo1O427; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1756296067; a=rsa-sha256; cv=none; b=64cD38Y2dZHxv7QfQbh50DZmfsyN+emvIH6hYEv0lLfPC+n+9WKeLdHjDMyQlY6MT9s6Vk jGjTPOUIK5qkhxcSr9rbZDicdTyqZ4xDiXTAayD1PC4JISp49f1z6Nht83Qf0WSz47f/1v K0ekAaxPdEDg2oAcnget8lkLuBCQ9fA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756296066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=NWINZR72AGUB423TkOc4D8qtFil+Ep+hQK7BWdIPlw0=; b=guo1O427cS/RBm2+8htHSbrfu4OVoxLlPBNLCV9XSRBPbNV6vkITZ+uB6oRBKgQs3xRzQn ScEiPN90d/u99iXTym9fA/nHFU28jp6vpCWWrxOCdr2o1PwBkUiGcYPDm0Z6mAGQ21Tb7u 2kT+LVlykCm3hJY9VZdfKixzaAtRywA= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-581-mnivf2cVN_SWh1F86UyCMw-1; Wed, 27 Aug 2025 08:01:05 -0400 X-MC-Unique: mnivf2cVN_SWh1F86UyCMw-1 X-Mimecast-MFC-AGG-ID: mnivf2cVN_SWh1F86UyCMw_1756296065 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-70d903d0cbaso18825266d6.0 for ; Wed, 27 Aug 2025 05:01:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756296065; x=1756900865; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NWINZR72AGUB423TkOc4D8qtFil+Ep+hQK7BWdIPlw0=; b=iXgfph7YwkGDFbZlCDmTAVXizNMDY+HTDr1vUBPqzR8f5yggbMsygnki3W2YpuNqf7 7XvoywS/BZ1BTdrjAyGf1DR11kbcikr4RwrVj5xZyK7SaPpdYO0OKw1fQUfrD4EwkLcF OvRTlvUtITW+7oUsjq2YvfDO0vGhyryFFLuU5bWLk1FK3AxpuHDttaRDMAw0jMTyMR/A clMBBBBiXGNPhxkAL0+ysSQ1PQ3Ilj3zy7uFD4ZkWYMbMjHvCUjXhOPY36HA5UzfhG6o N9GI8XLqG/7ZB+s68NQ8XDsxQjX09Jr5pKpOop49iWMlIYvijcn00nbv1Tk6B0xLVl9g J8/Q== X-Forwarded-Encrypted: i=1; AJvYcCXYFIB4JW2bpD4R+hNGDDuQmLOk1670r/ZjsR8l4J7y6xpfn84yf3lmUQopwQ1x4BiFiwd+QZyo2w==@kvack.org X-Gm-Message-State: AOJu0YyQ4HoLLIDgly/1mAeTiEzeR3ZeNJCZETXDMIKBu1bogHLVfiX/ vt1qWmm98bViMw/sMz2OdRjH9pI5hkoWADeFDiN6VP85NbRr5Vpyy2o9UKpuYkd9FZFFBZA6KuB n6uSjlhX/y5XuKnz+ucyipLKLdNFFTJV1GKJ2FuXiHh289YFOqUjz X-Gm-Gg: ASbGncvWBE6pWNO9fowurhckWFLAxGn1zi+tzidB0pHLyaTuGYn0UgVGAGOWhCKBP3E QJLuec3XvF9ugAiQqKVquklZ2kSXdCpmDoGv5I7AhDB+6FaNoPOH8rcrvwKV6FUoTHbBSgvSOEl KFFqCjl88F8n8Q6J5/KK+Zq5Bx05P0RJNPgDm7slnlEumBUuk2et0vGDl4fbS+fyYB3uSedreLA iIBIDwFUqf+M9RoZipM9sNvOB5Ib6oe/73iOnN+lDRNCY0wzELuduNxxvw/W8wyxhkdO3csBQZt m//EspHjt2OdsOyq0LuLf5AOArHv5BJq/qrf4c7wryuORAQk+DG3Od8t/AHdog== X-Received: by 2002:a05:6214:212e:b0:70d:c9bc:6281 with SMTP id 6a1803df08f44-70dd59c076fmr59734506d6.34.1756296064474; Wed, 27 Aug 2025 05:01:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFcADX4G7Pyj6o8x+T3ZNqZCUs7nd2m7BaU5rckVG8ObCg+LGLJBVDHW/Z4oABiPM4EWrPqHw== X-Received: by 2002:a05:6214:212e:b0:70d:c9bc:6281 with SMTP id 6a1803df08f44-70dd59c076fmr59733836d6.34.1756296063956; Wed, 27 Aug 2025 05:01:03 -0700 (PDT) Received: from [10.32.64.156] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-70da714cb55sm81940206d6.16.2025.08.27.05.01.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Aug 2025 05:01:03 -0700 (PDT) Message-ID: <5ee2b684-94d9-40be-b01c-b0538ced33bc@redhat.com> Date: Wed, 27 Aug 2025 14:01:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/7] virtio_balloon: Stop calling page_address() in free_pages() To: "Vishal Moola (Oracle)" , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Michael S. Tsirkin" References: <20250826205617.1032945-1-vishal.moola@gmail.com> <20250826205617.1032945-8-vishal.moola@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20250826205617.1032945-8-vishal.moola@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JqiCriU4gwzJy0yI4SweKeca83FIb0hENCj27HA1shk_1756296065 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 4D55C1A0011 X-Stat-Signature: tqm85ggwupkkjd3bbhr3rbwfy7w4kbri X-Rspam-User: X-HE-Tag: 1756296067-127330 X-HE-Meta: U2FsdGVkX18POfQvkIxGbqi7FwbTzKYcQ4YDz49k5BOOCf/yOayleTlFDeQ7hmwdrsUMnumKQfsdShzcmaVSqgDRMcCMY0bm+e2G4UCX4G9BpIKicQWDYV2jwCeszVLXkHjMW5gWYv40VPQa7bhuRunl/aBUHQj6euVJdQ25t65krxjLi19jLQ6PNpv8gknOPo3aGSwKeYktgFVc8qC+k2VH0Mf0D4QYIbBeQiOZGBny9xKKrOMrx0xqdny3p/PjzVFnMM3RSodSzuBF5cmDtTbGyPo6N+/ZNXM9fAo5jaHP1V10UV6NUT1ylZ8Pc4htxSzXWhyjGae884cqgMeY7yJsZGzY4pneVX1gX3Tq1LotcRqzsqbI7WoFVTUIqlm6i1gkwU8jLOVLERCSUOh9KSaKsH9qO1nOHyXHjcsUjRS7XxkHOgRzRLoyua58pLhe2fc7c9/aej0OchMBHM4u1KXSRYh0MYe8a5ta3aBjOqMHLcGnarKhjjEqtf4AyqmgatcOyqkh0LQcr/ClGSd705NjrbtpaHZfA0rKgFwl/A+6PLvayQYUJm/KnSojcaoscsTIfGX+yyI8zEk/EylbkyUxrQrj9IAZlTVqbcMbHONTFYZTvVpy8vsfWedvnq3yLN9VXsSOMbC/qzrmcQdgIIEXg+HXPcX2sqPwhP4Ps68qRWuFM2WXH0UoKAE9Wq2JdUo0V+d7NlGmVkDYeOPn4xu9h37IURMG2Wt+mxIUFBjBiGlQeqnmYY/TTkdYkBhJbq6NVLhPZg8WtKexGimuhmDMzaqTRSF1b5Q6+2yZPRC0U9S/c/3y5B+NYu7mY37ajIznG6plfbhTe2hckwIIlxeSkuWmD1WBmvT3bk6B5GV+xS9GbWPI8dN6JTYyho8sbvg/yofG9De3N8AZzmv8EykZg+mhmWc8XXpmJKEsrONSNgQbi2h1wVVDzf5jiNbaTh/vkit96tnnCw++nbh /8Jo1gCb Xx9+kXTssPUuwspl3NqjtmWY69bV6V3ZW/VPnjopzs14UKubBGcQ2omNOvUPcSSdG4txcGlA7YNGmz9adGbTgi4LuPU0fDy2DqS8KIj2gZlzZDlnWw+w4bp3B6YkYNp1bLF6slZKBcq04aCqhafGfqH1QWD3dpvba94UNlxaUdsceP6joP22hRtWl/Swx8OWdZUFKOMnnI7fWJq+fPkUN5BKXl5yIES0/1e/JDLeHbjYNtmCbIbAv4NSy6gEsamDp5qgt1Jg/KNoQpX0IIuHzXEZiGBWYrtlgMc3s1iwLPtm6w/7bP94oJEIVosxVvXwFbz17ZXv85Okm8E+TI38We89lBX/vSggC9zkPft8Jx+SgByekaap6HgDYjjzKDCdFFDwrj4i+2EQXMJ654X6AgBrb4OLmk11HmgkDEcnKQ3qpYbqJsw7ZX+2tj1+4WiBBIY/GELjDUt3y+O8Mi7Jc8btbm8rKZjwqdzzOzHgCO5qDb7ZYR7sF90bRjHvVsswXBnpbG1wI50vVKyBOx9JSeCRZxj4pFKpPWczMpz+KW+yeOP8hyWIrSHBA7OpW3qKgxDBQrgYWAvdfrGu4D1fJA0Y7xWNQ2StZOPjwLugcJtahCcg2fvGdflNQvMuF8nccfyztX2X9TiS/txg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.08.25 22:56, Vishal Moola (Oracle) wrote: > free_pages() should be used when we only have a virtual address. We > should call __free_pages() directly on our page instead. > > Signed-off-by: Vishal Moola (Oracle) > --- > drivers/virtio/virtio_balloon.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > index eae65136cdfb..d4e6865ce355 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c > @@ -488,8 +488,7 @@ static unsigned long return_free_pages_to_mm(struct virtio_balloon *vb, > page = balloon_page_pop(&vb->free_page_list); > if (!page) > break; > - free_pages((unsigned long)page_address(page), > - VIRTIO_BALLOON_HINT_BLOCK_ORDER); > + __free_pages(page, VIRTIO_BALLOON_HINT_BLOCK_ORDER); > } > vb->num_free_page_blocks -= num_returned; > spin_unlock_irq(&vb->free_page_list_lock); I think you missed another nastiness of similar kind in get_free_page_and_send() where we do p = page_address(page); Just to call free_pages((unsigned long)p, VIRTIO_BALLOON_HINT_BLOCK_ORDER); -- Cheers David / dhildenb