From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71040C64ED6 for ; Wed, 1 Mar 2023 14:07:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A040A6B0073; Wed, 1 Mar 2023 09:07:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B4A06B0074; Wed, 1 Mar 2023 09:07:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 87C0F6B0075; Wed, 1 Mar 2023 09:07:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 78D3F6B0073 for ; Wed, 1 Mar 2023 09:07:22 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3F02C80147 for ; Wed, 1 Mar 2023 14:07:22 +0000 (UTC) X-FDA: 80520506724.02.A27B16C Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by imf09.hostedemail.com (Postfix) with ESMTP id D959C140011 for ; Wed, 1 Mar 2023 14:07:19 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=NY6zRLj9; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=PAmVBsQn; dmarc=none; spf=pass (imf09.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.28 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677679640; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5m3HfYKwmwBaOjWZWUy6qvDlncIvme0bGcT9RvLhnCs=; b=RKITIFL0MQdhEH5Y3q9P6g6RX4f30YPT5C5PIK95/XhboeHcAnn80lBE+fLLmqIUYBd/XC bIfHRh09ocotlpD7WhQysVxgOINuPFbVM/eN/GhOf35u03/ntExPzuDLCeomj0LoI8Qm72 p0NleEQCZvXjB43bKYvdMb1vE/XTUq4= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=NY6zRLj9; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=PAmVBsQn; dmarc=none; spf=pass (imf09.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.28 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677679640; a=rsa-sha256; cv=none; b=2lnJ4N3J9iIX5E7mesqJpL99QDJQYYQRI2X5Jxr1J9PrOoERWcDCm6Wce8S9nHmmYbPA4L FnyCTO7Rsm5+BonkFJCc66ZccV+wpT5g/JNLsZ+FUgydsX/uTumbvyiJE6srSrcDYUVQyC nGef2rm/Xc5tNL5m1ziclhEIzWLuEJo= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 52EA25C00E2; Wed, 1 Mar 2023 09:07:19 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Wed, 01 Mar 2023 09:07:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1677679639; x=1677766039; bh=5m3HfYKwmw BaOjWZWUy6qvDlncIvme0bGcT9RvLhnCs=; b=NY6zRLj9LNQXp1PiMPVL+Sr2oM 7BYgON/qWAtNrM7M8WK2lJjFXaTtPW4TtKYCcqbe47p//ahHMaHQLwWFuIFATzjk KeqqWMXthvgK6HbJf2swGC57Xh3eXlECzJiL0gb5jDESuRLq6HNxOCT1146Xgx55 ijgcnmQaLTV3bBWWFboOhI4iAcpadeSB6l4B3KOZMqN+I+1aMsLrcmMZq3WgDZCb v1+MXnjnnCKnOUAmqlHIHwnIHo18eTxn17OueOcnYbiy0ISVe2dEvnICjwgTDT0y ix2Ubj7mtVdljq1Qt9nDwyFDEBOLeZ58cjofqrckolUcunsiEIuE2k7lbWiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1677679639; x=1677766039; bh=5m3HfYKwmwBaOjWZWUy6qvDlncIv me0bGcT9RvLhnCs=; b=PAmVBsQn04eoXV7tafopSDqW1GPJUefcqlmXK9zwvsJo uuXz52sQwkE8j/aIiAR8OtC3BOTi2V1EhCRZqi9sw5Tl5ruA+b0iI4ip2AXvLh3C oh/shkGAA8TP3P3irDX9SBcugi1Q6yYpnUw4EkBrQRAkOCCPnnIP9iR23uFGqXAw q6wNgyzecjaVQSGPlMDd9d+hJAF2SOiWmXB0HS7hG+/vchOIuyAiu67MO/E1fZcj AS7BdrOkWre003ihJhlHjCarbJEfKLuJm6mBas3w0m7mnJjqCso8FGoYTqVgDoIT NpakBSvosoXDk/GmDa9DaQokJmngemfbheJzVwvIDw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudelhedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 75B41B60089; Wed, 1 Mar 2023 09:07:18 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-183-gbf7d00f500-fm-20230220.001-gbf7d00f5 Mime-Version: 1.0 Message-Id: <5edd5304-ef11-4607-9189-a07613ecfee2@app.fastmail.com> In-Reply-To: <20230301102208.148490-2-bhe@redhat.com> References: <20230301102208.148490-1-bhe@redhat.com> <20230301102208.148490-2-bhe@redhat.com> Date: Wed, 01 Mar 2023 15:06:57 +0100 From: "Arnd Bergmann" To: "Baoquan He" , linux-kernel@vger.kernel.org Cc: Linux-Arch , linux-mm@kvack.org, "Geert Uytterhoeven" , "Christoph Hellwig" , "Luis Chamberlain" , "Thomas Bogendoerfer" , "Huacai Chen" , "Jiaxun Yang" , linux-mips@vger.kernel.org Subject: Re: [PATCH v2 1/2] mips: add including Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D959C140011 X-Stat-Signature: 3o6fgdyuq45h9otufdpda7mc3mabzx7z X-HE-Tag: 1677679639-856485 X-HE-Meta: U2FsdGVkX1/uCr/rLK6Mnu+eGSchJJDylObJHNqg/ulxGlQoW2hl6W6nSZfDBFGO2efBiZfmB8avWQa5mycCygaozA9RIyQEW/biZABTymG8R4BRSjKsSp/FwzVG4V96+dfn66WANrP54fNcDG+C5lKM5VL75bndigYoBZ1od5aOBD96KrPL6DxuaYEYBkhyeACz2addsU5exdRsfE6ii/xnzUDNVn1+b5mMNbecxkewZElI1TgLfBmtu/9IH07INWQgy0xOZvXJUgm5fJQthd1I6neP6deOwWg+oT6zmVZtBbwDA4FOAWytrOqmms37zKSlbhyyfXw4+LAAwjfGe83L0DxYGy6XoerNf3iQI4iYr0IEP+oOvR0FkQHzsMI85749oAPTPyLvc1Jto4//4Zx/yJxZOZ2Tpz1+wDWNZqDSCNvh4QDdHqfLL+YU0bvuILNdPPaHJSEt2XZuTHNNTUI5nswxu4yPzTix7uOyHFdP+x4YAuBsyRgKGU5bv358WAhAgBFRjurtkm85TeFrrxl6DH/9t3RJxWJZikX9QC7CMDgtsaziP66cLwcscR1OfdCBDfLBVrK+Uo/mOLhcrjsxdziwdE7iBl+2BmdbY90/xo1e+20KyYmcO0IGfLUCJ+/K2d5a/wrO8F8844cCXezG74ocJ25CypWpxuLwhAaSAfW/OqK8CWHmj1g/WBayU2M6GJgFrmw6nUngbiG0vghiNXoMruJ/piCf97848yVp4GrAZKmpePQ8LBBBzHGmh5rDAmRkjm9bcFc7GM62l9BT1BEiA2Hj4yleIuL9VmAKkD1mXdjs9292zEJTKSp5vckvNlJUXxWDqwgXhH9D82kkAORfVnPDYgPWCBcXhGLjOwqSz0Hp3ebFfrNbEQQQshvtwT1CdkJsIcpXCGPGE727kBIctTNC+jCisESL+qbj7bPZD2iez2PXj0pdERpv+WNoSZ6dHAYnCXXLBpb 9MQqkSEo c1nWotAQlS/EyqYXvcMt8F7rhUp1KdtQtBMkOSbV1JtkIKY86+V9siR/wVxlKZ4gInU3n+ITw0Q2D++yVmNl/Hs5HIC0oKRwBMBiYd2OvduUIqGy7nveydTAC2xuJdbFs+ffmFkQtPHOaJZLH8KUFc7tTyJK7vcvA8v7Qu+ALdmR+8YDw4ToNPLK2XzuGuAgNQzulX2oQ0zsZRsUTg8BTAFD7ufC0NBiS9+u2tfi5c39DRjM4xjRw5LcJu/AgNuwGSjq3xAEYrSYAYGgJmdFTnVvbld8CdcSFZcTJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 1, 2023, at 11:22, Baoquan He wrote: > With the adding, some default ioremap_xx methods defined in > asm-generic/io.h can be used. E.g the default ioremap_uc() returning > NULL. > > Here, remove the including in asm/mmiowb.h, otherwise nested > including will cause compiling error. > > Signed-off-by: Baoquan He > Cc: Thomas Bogendoerfer > Cc: Huacai Chen > Cc: Jiaxun Yang > Cc: linux-mips@vger.kernel.org This looks good to me, Reviewed-by: Arnd Bergmann but it obviously needs to be properly reviewed by the MIPS maintainers as well. I think others have tried to do this in the past but did not make it in. > @@ -548,6 +552,46 @@ extern void (*_dma_cache_inv)(unsigned long start, > unsigned long size); > #define csr_out32(v, a) (*(volatile u32 *)((unsigned long)(a) + > __CSR_32_ADJUST) = (v)) > #define csr_in32(a) (*(volatile u32 *)((unsigned long)(a) + > __CSR_32_ADJUST)) > > + > +#define inb_p inb_p > +#define inw_p inw_p > +#define inl_p inl_p > +#define insb insb > +#define insw insw > +#define insl insl I would prefer to put the #defines next to the function declarations, even when they come from macros. > > -#include > - > #define mmiowb() iobarrier_w() > I think this only works as long as asm/spinlock.h also includes asm/io.h, otherwise linux/spinlock.h will be missing the iobarrier_w definition. Most likely this is implicitly included from somewhere else below linux/spinlock.h, but it would be better not to rely on that, and instead define mmiowb() to wmb() directly. Arnd