From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8E48C3DA49 for ; Tue, 30 Jul 2024 11:38:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 352CF6B0085; Tue, 30 Jul 2024 07:38:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 301A76B0088; Tue, 30 Jul 2024 07:38:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F0B66B0089; Tue, 30 Jul 2024 07:38:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F24606B0085 for ; Tue, 30 Jul 2024 07:38:48 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9BD8F140267 for ; Tue, 30 Jul 2024 11:38:48 +0000 (UTC) X-FDA: 82396221936.17.A21EF48 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf01.hostedemail.com (Postfix) with ESMTP id B0E934000F for ; Tue, 30 Jul 2024 11:38:46 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UJsPexcQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of seakeel@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722339486; a=rsa-sha256; cv=none; b=l/g7MeSjq0Qi5YAWHyefFNl1OFA+jRjRCjY3phzDD3eoXgz4xBiOBfpM/swEPOdXSF2ldM qQHhytPfKtLlLs4rKTi8gJLSqLDm3DHD1zTcH7K46LMPrzHfcwXFWwL5cdUqoPZibu/gYg XHTwSM8nHffwTg2t/FSmeXs0c0FDAxU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UJsPexcQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of seakeel@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=seakeel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722339486; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8MFqGZ8807+PNXQ8BnyhmtNVvHRUHtuiqEf4+LLnxW4=; b=pT8fZMclPv/oN44KOB7fm46kEp+443EulUDP700Tip65uYcy4H4YRuoSekxYV9b4OmrFYa duDp1V6zhZnzN9YSTZ9pf4/5xC3iTcpmSPwzR0hZU3m1QWtGDeXs3dsaW9oY9RX9seWEPI ITMW8KIbdaOgOiY4U7d3MBHYQ+QZ4to= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1fd69e44596so28289315ad.1 for ; Tue, 30 Jul 2024 04:38:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722339525; x=1722944325; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8MFqGZ8807+PNXQ8BnyhmtNVvHRUHtuiqEf4+LLnxW4=; b=UJsPexcQhgHoNtBsssrxU4UVYzRgm73/MrRuxuSLYpmV2R56bUCSRPkOFTELkcdhrR nH0mw/X0vaLdVGk8LOSu4kBCsuswA3lGRnOImRL4V2Q0LjbIWTJPoBSKXm8k3j0aYjNY LcW0zltyMSW/685/kH34CCmDDNJBB6JmSc3O9DMTaDF3X0h/Nrg7AxrnyXobmN8BY3gJ k+ORdUqVkkkhWuBGskXri3n9dtHIvBD4tQKDEi+/nfmg4+d2RUMUjN4QwkslMyYQpxQ7 ou8fjxLO7roX+QF0/tO3eB6MaaHoJW0Dj8ckTB4upSm7j8PiWU5bu8ERY24Cus8n+A3J qBEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722339525; x=1722944325; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8MFqGZ8807+PNXQ8BnyhmtNVvHRUHtuiqEf4+LLnxW4=; b=QBWks3c29R0XcYH5DZNlzPt3y4cqFEYt3xmJs/g346rD8qB4f23KjBkf0F6+N3E6fo 2TnyW/w1OeqeXBlOOh32ObLjzsbyQHzhreMRGOjSS45pN88W/kY6Kqo4RjSQlsBBoym4 O31ZaIqoP9QZnF0/AtbaYQF+UwjlG+tRLubIzPXGDFyhTFZhMS4xo+A8JspPmLre88vE 2n+0F5kcIZrP6MAM+TiC2owkW/n4r038ICVdYGPz/Zz9RipzO1P5ud92Je52kv64kgJt qyDp/z2vVUImWhpyCxP/IeEKfMODv+4j2sW66+gsQQuPsiq8DuHu3VdZ9PLLwyYBQxty 2fDA== X-Forwarded-Encrypted: i=1; AJvYcCXT6P90cVLQxivB3mgMyLY+82pl2sA0DgBn88/fOJpSwtouzdubewxcnMjHPcRoWnspQc/eL02iYIqQsXZYU5P7G+I= X-Gm-Message-State: AOJu0YyMwN/mdi5HITGGTEnurOzYuvMnoiEy62VmGd2GEjqjjrxjIvdf OGgDCOUNtzLcGec21aj7aRKA7czdzB8aoaf6auJtDFBGPlbIjBmm X-Google-Smtp-Source: AGHT+IEBBOHnFCkjS4erYNgJjiprwps8xwQLgMn5LY7rnBhZttmUOgpWuMTyJ9yoYQq+SzqmMUcUrQ== X-Received: by 2002:a17:902:e850:b0:1fb:4f57:6a65 with SMTP id d9443c01a7336-1ff37c3167fmr25480215ad.30.1722339525125; Tue, 30 Jul 2024 04:38:45 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.21]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fed7f1ac12sm99336475ad.186.2024.07.30.04.38.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jul 2024 04:38:44 -0700 (PDT) Message-ID: <5ed6a7fa-31e0-4516-8cbf-8a725377aa32@gmail.com> Date: Tue, 30 Jul 2024 19:38:40 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 18/22] mm/zsmalloc: introduce __zpdesc_clear_movable To: Sergey Senozhatsky , alexs@kernel.org Cc: Vitaly Wool , Miaohe Lin , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, minchan@kernel.org, willy@infradead.org, david@redhat.com, 42.hyeyoo@gmail.com, Yosry Ahmed , nphamcs@gmail.com References: <20240729112534.3416707-1-alexs@kernel.org> <20240729112534.3416707-19-alexs@kernel.org> <20240730093419.GA16599@google.com> Content-Language: en-US From: Alex Shi In-Reply-To: <20240730093419.GA16599@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B0E934000F X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: np65cregik8pdgyupaa8wjnef1bynfyh X-HE-Tag: 1722339526-704280 X-HE-Meta: U2FsdGVkX18w95zFnK7s8I9uuVJkiySIR0OMgF4u0DWDWXTa6JG1+sPS9HQadJsQCYhtdVSN1Kw+mJ+mehIls2gN1ptCbcAMeZwBEeoge7+xLq+xYHdnJOmwltc+i9J4fli7v/jvEYZQYn6xaGvwd9m6RJINADyEUzybIcDoP9l29Rj3x+I2x0JgLS0GdP7JcvMcypQxzijQ/WBLEUoieLlunrcDRpDOfCoETp9cFlow8zAAlwioa0K63irmDL1DvfqrLYQJsu42zvN/gYh16QB3aJvg/nPyqecPyuw0xZSefCE3FOJ/vpi/C6C/PbhBSAmfSqdz+VOVaFTXPYrmS14Wn4cz06tF63RR/NBzp3VfGkdRXbp049htLx4XclEhpsITQcAQSlnqDAzoXb7ey3kOgRAZ1ONjwd6k9OK1Ia59F+7xjRIe0u4neWUU0XfTiiutKXxrZMAdyGcfJI/5iUZ2q78egAw0I+r7EPklvgaZorl3tj5I4oVVAJB6Iu5iNNM0esPDpLAvS0BliMWn/09O0hz9Gd9p6FOjMy5gEoxVceTL1fMMdxV+BSsH+wVMYpZSod6A7tjkDSMGXf3ZHmkyqU67Xapo64//7yxoFbJ+PozlMgNAZFqCDeDpxGiWBEGOzBqG7lw4zT6tESIOE4rEpnsRRbU0mqVf8JytM5QmvVWyUsiX4L5umfw9pgimgr0NwqXDehHIwaNdKZTlpfhjd7MWQTXOibNGESZRjk/l/r99NcAc9D7eoKNiFXgto+UdiEi7yde2fjmXzvtxhHi/HYXhHpf+LOUFTDnvPw0+JIUohF7i4arLG7EYDfyb2qfbeCiTXy4EysQ3BwwkeBqWJ1YpGrlFIhHEAjWJrsqynH/zmJ8HUI0pVO0MtfB1jkwH1OkW27frQAywen8DTSagakDqu3eHVNeIx+RBkNwTDh2A0opwRSVh3WmIf5gtlxjPT7WOpLhrumWzax5 mNAAlGAv 0O+a4hF0+pzU1U0gS2ZTwJwYPicMlao2gA+gtIQRjRKvGW7mVMDTYXHevCqMF5PPVDK4tJbatiB98a0feRZhjK8pJF75rhumxAgRUitk3BfxHMaXNweLpbjuBnaXQUIlm5rdibnTiNLmfs9NdS8HFG8/l7vafN7D8zZTDCW8RehU9fZTjgDIflKgSnDGORAQdMCmTOEFs7D3bpUaQFI6H5bKrRnqemoBGffxi1iXtMZxyhA5sx8rDyYepaoz9+Vttzx8z4LMPpFvzshKEWfrYQjATxYz4tVTTP8wubb45bPZfovpA/sfeaDhiYBpMC0HPokCn0+qdR4AoIlyJNY2cdBZZMcSwrK9GjbV4W/VQeFWPL48FEabddXriiA6pE8lq9cE2bt1/l5geN/lpP1q5VmYjSA8W2RAim5RmOoKjsElTTh19UGDLVvEbj5RpwpnfBaYS6IBByd3mWvObmMoHGgSkDRWnv1NujX4gwK7z8/vJVLMtLsxl4/xt8Xj2tPqbFWnm5IJd1D4uzQZzzRq4ktVKBBSMzpQLwWej8oib8nLMR3A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/30/24 5:34 PM, Sergey Senozhatsky wrote: > On (24/07/29 19:25), alexs@kernel.org wrote: > [..] >> +static inline void __zpdesc_clear_movable(struct zpdesc *zpdesc) >> +{ >> + __ClearPageMovable(zpdesc_page(zpdesc)); >> +} > > [..] > >> @@ -846,7 +846,7 @@ static void reset_zpdesc(struct zpdesc *zpdesc) >> { >> struct page *page = zpdesc_page(zpdesc); >> >> - __ClearPageMovable(page); >> + __zpdesc_clear_movable(zpdesc); >> ClearPagePrivate(page); > > Just a quick question, I see that you wrote wrappers for pretty > much everything, including SetPagePrivate(), but not for > ClearPagePrivate()? Hi Sergey, Thanks for comment! Yes, it's better to have one for clear, I'll sent a patch soon. Alex