From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D835DC19F2D for ; Tue, 9 Aug 2022 23:56:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E1768E0002; Tue, 9 Aug 2022 19:56:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2914A8E0001; Tue, 9 Aug 2022 19:56:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E4148E0002; Tue, 9 Aug 2022 19:56:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F34808E0001 for ; Tue, 9 Aug 2022 19:56:12 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A19968048D for ; Tue, 9 Aug 2022 23:56:12 +0000 (UTC) X-FDA: 79781715384.22.BE304CE Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by imf24.hostedemail.com (Postfix) with ESMTP id 4B1A7180062 for ; Tue, 9 Aug 2022 23:56:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660089371; x=1691625371; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=fO8/MXYpjCjUIPuE89CWSCz+/zVwiHe90QFhm9Svruw=; b=PnHlrc+Cm2gVtfnKvBAUr2mHdKdjCjIN9eKAcziQT3bzio26zRyocstQ K00YjdZaB+cZTdosRJIRF9Oi37tDK18JWY+bXoLXtcP0seuMMPbtshdY2 oljs2l0TkiXe5qFpLrMfiWdVslvCJhRy5Jo9Ukx2nqloNF+3fAH8tY1bh /80ZOTqgxpSErj53+0o3x3Ah4pIDe4haGPjgJrdxOxzLHV3/gjsd0FsTt GuhL8pDW2fo7oBuBLBwn4bdYkn03EYvU/u74cVYdyNFRZjvYKE8EMtADl szNnbBT1OUAAaKd+kPSWK1KomeORSRkTRtft6h9+H2SO6W3FBRC7FUSMv Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10434"; a="288525202" X-IronPort-AV: E=Sophos;i="5.93,225,1654585200"; d="scan'208";a="288525202" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2022 16:56:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,225,1654585200"; d="scan'208";a="604938892" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 09 Aug 2022 16:56:09 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 9 Aug 2022 16:56:09 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Tue, 9 Aug 2022 16:56:09 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Tue, 9 Aug 2022 16:56:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OiDZRR7SOhCNY66Ta8+FIKm0Smbr74Z1c80Yg1kt2qlRxgrTfeZYZF4jKV3x6vdWGsalwTHViu1Cb8A/nGLceCsAK7OaLMVnXFaoNycnmFHnKqIYazYZHuvrVs2RvqS1FpYkgFVOIh3xA9FNLNobjdz9j8NTi5rKsSji9x0ZeOtagmuBPtXf7S+bO3uvhtBHPCphurjXZIZLZ9Zv4DrpKBajurR+AYionYIp6vQPjLQeTGX9DfqweVf7t5vU+XETlOpk2nlylBOfRFV+o8nzc8iZ3nG1VZArsUzCds6VCmfYsBWv43HmM9HSuHf7qailq+ggrBHoMF3oDRCwmDEwyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iW3WrDI7Gqz58767+VSxpQjbGuhqP8/2B34C/p4Xl3Q=; b=TwLBFqWrOIb5rHXjQ/Mzjcx4mRWXjlVSB/P7ZuiIjq1Ca+QvpqM90q07Z8V5U+jgKUsrQOosRM0gj79DI1Gizg66SmjUSOcJUjZNvE+/j9jeOBVr4FAFJj8asrvkykJpmhz4+rGEMH8JMoDQJPHvNRPmEAg1zuDTq+aNRTvy4UeSKW30zRQrmMgIjiEJ0RkI0wb4MqYNOyChXmPRvMMr3cg6S96Zuqu/8Ibq5lJZNglcWisVV8k+HZFIruW/PaDpfATvmSZs02Fefzh25ncx5nTLwEpLPdms8c338BOkaS5fi/RN5UvOn5iJI+wD6NEiAYenrW5kUMoQQdr70z20eA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by BN6PR1101MB2145.namprd11.prod.outlook.com (2603:10b6:405:51::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.10; Tue, 9 Aug 2022 23:56:07 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::552f:2392:56f8:ca32]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::552f:2392:56f8:ca32%3]) with mapi id 15.20.5504.020; Tue, 9 Aug 2022 23:56:07 +0000 Message-ID: <5ecb424a-a407-b08b-bbc7-6a8668b3dd78@intel.com> Date: Wed, 10 Aug 2022 07:55:50 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] mm: release private data before split THP Content-Language: en-US To: Yang Shi , Aaron Lu CC: , , , , , References: <20220805062844.439152-1-fengwei.yin@intel.com> <9c16b712-b5e7-df79-e7de-0259086bb3a9@intel.com> From: Yin Fengwei In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR02CA0134.apcprd02.prod.outlook.com (2603:1096:4:188::14) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1bc98f93-966a-4199-9ba1-08da7a62b9aa X-MS-TrafficTypeDiagnostic: BN6PR1101MB2145:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FY/NPsD7/fJ7Z+O9/OnnYHIIArbL74A2Aot0eFEjcgaJUApDY0hR2Cgrb3R9eu+lH14Zc8hCdhWlYb7S/agtNprRvkJ1x3RlvtCUWZO9SlD7L+LAkdvH1gBsEMga29ewb0xHqKfblTGTxVPH8d0cH9CEVIEPkzkeqIz1l6YbsiuRmEiaJGxUnQ3fp94OJ5SaVqHbSgIagJPpmrIYBqE71LaxvTWm/N7xMm5evJw4R34HbrkhSl8yFDo4OLY78eSjyS0TFiE+WQrZKneeFMCk8THJ5hQBUyvB3a62eVC24ZnbkPJtMsGuzucWCNtwZ1NcBeDNiHgGvXCN5aF+0y1A3xFrOF3PftPgf2lwjtpjYO1esdbFcwudDWbedCaaV4fqyT4cwVprcJRrXlDK+NsTXLuQs2kYpg+ihB/ASZ6N2FNQvQfRBn3V4/8JqGIe33eiWMhvY+/uy9Cn2QE+ohu1ROGhG1owWlXNeTExhdC9Uu7v35oF7RHMgOKCsyuSrnq9hP5aWXBSXWV1QfsH8BQMSIbYs9LD+C3alWajgw8O4WOa6oodw3y7YA/GexohUepw/4fFdD4DyL4mzzA/hJjlhZwo5tfAPJhADh69xgNyHsgpuInIQhaoD0CHGzTBdVFLLgTOhsD95ijqul0Z0jDO/YWkVf1In5+G9B23WqWI9wiAiYxrsBVrLF9ykDjffsDezgyI8THrxDFOP0MvTBfgPd4vA0c2wBgcCg8lIcSQKRxb4MqxDBSfHSWkkhbjI/F3vygMIMF/13YkWCcQuXIS68F1t2zg4Zcz4Y6/MC08etCbiOldfHz2WaISV7h4O7RKPnuKQsKbCecNpFjFuRTBGQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(366004)(136003)(396003)(39860400002)(8676002)(66476007)(66946007)(478600001)(36756003)(8936002)(31686004)(66556008)(38100700002)(4326008)(110136005)(316002)(6666004)(6636002)(5660300002)(2906002)(41300700001)(6486002)(107886003)(186003)(2616005)(6506007)(26005)(6512007)(83380400001)(86362001)(82960400001)(53546011)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmZWK09hR2Q2SVpPZWhSdm1Jd1NzQm5GSjlZa2JZN2psdXRWT3pnNEtRc0Nz?= =?utf-8?B?QjdKWWJaZGM3a1h6UGZ2OTBiTXZvTEdjT0xhdW02K1dQdi9ZT2w5amp3V1JM?= =?utf-8?B?RFBmSkdwZ0ZHUnR6NVhHaXZTTFVEYlJndVZaQTdJamFWb1Q4WXUvU3Q3ZURB?= =?utf-8?B?NTcyeGduQ2RkaCt3b0x3WmhVR2JRR25UMFBqLzhQbjQ2T24veTh0c1BRbU9s?= =?utf-8?B?bVZiMGdNTmZFZllJVGlkTHczQ3UvUUNuaFdUaWhQMG5sWjBHdzZCa1RZU0Zv?= =?utf-8?B?THl1VTZQZ0VIbzhCcTVFRmdaM3NPQkVhQnBXOUdrdUhwMVc1dS8rdUVGejBU?= =?utf-8?B?Vit6cG5XSkk1dDhMeExFZFhGenNhbk50K2NpU00zQ0tycW1QSDhmV2hZVlJp?= =?utf-8?B?TkpTUUYwK1Y5cTErQS9MeWFsY0xLSkJEWmpVZUJ2UXU2bVBzUzJadm9FcXN2?= =?utf-8?B?S0UxTkVBV25Rdmc3a0l3RFFuS1Z4SjUxWUlOSUFScGJhS0NaUTN0YmpOVStj?= =?utf-8?B?WjZYRHorQjRKUmV2ZjJBTFZLVWJMZzhaSmlqN0c3cXducXdoSnJGZkN6OVRJ?= =?utf-8?B?NnVNZE45TklMa3VCWUpPUnJkUmM4d2FaMXEzdDVzVmhPRlphTXZ6Z2FiOUo5?= =?utf-8?B?MTRPVUtXeEhreXB6UThHUTJ3RlVTdWhSSHRPU0NoN3JyUlM5RFRlcTZtUm1o?= =?utf-8?B?NVdhcDh0LzhrU2IzcWFLWlRXN05ra1dibzh5amlvMVQzQVBRekpVNnA3M0tC?= =?utf-8?B?KzBYZmVCTSs5cC9PNWY0cDJUL1ptZGhQK1ZkNGNNcWYzamZlRDhERXJpNEhs?= =?utf-8?B?bDBCOGdxVDhCVTNtZlNhRlRVUjYzTktuMTFZWVoyTjJvZHJaaTRUNVp5aGlN?= =?utf-8?B?elFjRVovOWRPSldpVUxOY1g2WFZkK0RkemdNRkNQRlJabmZ0NzJIWHB1V2s2?= =?utf-8?B?T3lwWTRrUmpGbnZpRHRXMUFKMFhlVHFmaEsrUzdnU00xZzhNQ21uRk9pbXVR?= =?utf-8?B?bDZpWDRldnhRUEFzaHp6a1VqRm50M2kwQzJPMHBxUFl3SjYwZXdsNnFhY29Q?= =?utf-8?B?QkgvbVRKVUhGVzZzcU9ZNENPRUNwY3dNU0R4UVJPT1lEdnY0Z21acXRQbHZy?= =?utf-8?B?UTJVU0FEQTAzdkNZZWxuaTZzWFY3WkF5Z1hibGVvQ3IycXNvbHFGYkJKNTN0?= =?utf-8?B?M3lSSWl3dXZnVldMYjFobU03dXZvVWx0M0ExclF0WDhuMVlIQ1E3SEtUQ1Nh?= =?utf-8?B?UXpkaHdSRlpPbDNnWGlsa3VNZ21kc2J2d3dLZ0pkNDBjdXJTMUxyMEZaU3hX?= =?utf-8?B?aFl5S2RHbzZFcGtyNFR1K24xWlkrdjg1ZzZOT3RHYmlwbkxJVUFXV3BiVG9V?= =?utf-8?B?Rmp0K0tieCt2VDVNM3pPUFV0UlFGRUFyTm5PN0VhVTYvTGhhclh1WVlGTjEv?= =?utf-8?B?NEVDeU40ZGNnREpEdHJMbXUwTGR0eGk5OWVQdlI5WXRnN0VscmZYakdBSVlP?= =?utf-8?B?UnZJQTRtN3RDajludW5EZDliU0FLdk1FeDZERmo5QWs3VGQ0Zkx3UjBtTHZV?= =?utf-8?B?b3hsbGV2OGpESkVNN0dDaSt3YktOZU1KYSs4UkFjUm1SL0RrdTR6aFI0Y1Na?= =?utf-8?B?TnFsWWNYZ3IvMUF6eDBqVHZSOWZEUmFtQmM2UkVMTXdJNFpHbFEwNW9kSGh1?= =?utf-8?B?NXk5QTBBejgwY2lKZU1POUNWa0s2Q056T0lhanNPRW9ENUM1R3pZMU5kVVlw?= =?utf-8?B?ZS8wQVJsM05ubWR3MDAycmNIV1Ayb3Nwb2ljZjdMRXJMZ3B2UDdtcXpOaVp0?= =?utf-8?B?dEFmTFVXSzNMSzd0TG5OOXpqZ2dLYWZJWWVQa2MvU21kTGJmQjRDNGd4UXBJ?= =?utf-8?B?WDdLclZxRytCM2lpalJCVVRRQTJUb2RHVXBoU2NlK2c2N003d3F6aERQY09q?= =?utf-8?B?bUwrZHNHVnpyS3Q0ekc5M1l2RzRtbGVWZGtOMzlieW50SFF4cVVxSzgwMzN4?= =?utf-8?B?ZXBkR1dJTnYyemtwQW0wdEJxTHF6WElxaVJQcGxnbkNpNTBSOUdONUM0MHlK?= =?utf-8?B?aTNsd0VUMnZFWHVEdVNjblJXQndYZUNUalNpWjV0SVpFdjBVb1FpL1ZBMGQr?= =?utf-8?Q?SEEqTwR3qotbOEy5hPUgKFzMO?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1bc98f93-966a-4199-9ba1-08da7a62b9aa X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2022 23:56:06.9508 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3583PmhmSqZ0Vml3j9eqJNlK6Y3rYpcfD5g5EQQaCREFXZBkAfJNPKm08mSZ7k/Ib5lUylURJVr4dQrl4Xa7fQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2145 X-OriginatorOrg: intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1660089372; a=rsa-sha256; cv=fail; b=hzopYzPOBcSD+aK8zjWjtk55GMiqmUBxJ32Cschg42VDwnNJO1sJu2N+BvCxrd/hAqlnyB 87+IC3QzpnztWOkCfNCLRw+n8isPof+cIs6jkifGbZpJo8L5dRW5wO6MDhVZEanfYWX8+e Wk4HK/tSt+td4rEzRcKmzkpF0T+7MCM= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=PnHlrc+C; spf=pass (imf24.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660089372; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iW3WrDI7Gqz58767+VSxpQjbGuhqP8/2B34C/p4Xl3Q=; b=rnGvZZvi5K4n40/Feul45IRWCtlsHPzv6wfvsUWwrhMuLIrXn5nbDqHm3PgkMzOfmOholn KdpVeTp2Eiyh3oL7xhQSsg9Z50MoSii+YhQTnjqsr9vKg3tfLbof/R95QCdRrwMrP2Vx2s P39PYKN79s22n3Y/JCkmDtOppzde+Vc= X-Stat-Signature: 3eerpizu4633at8eupzmoepti7jkwxys X-Rspamd-Queue-Id: 4B1A7180062 Authentication-Results: imf24.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=PnHlrc+C; spf=pass (imf24.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1660089371-167592 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/8/10 00:45, Yang Shi wrote: > On Tue, Aug 9, 2022 at 2:08 AM Aaron Lu wrote: >> >> On Tue, Aug 09, 2022 at 09:12:57AM +0800, Yin Fengwei wrote: >>> Hi Yang, >>> >>> On 2022/8/9 01:49, Yang Shi wrote: >>>> The GFP_KERNEL is fine for most THP split callsites except for the >>>> memory reclaim path since it might not allow certain flags to avoid >>>> recursion, for example, nested reclaim, issue I/O, etc. The most >>>> filesystems clear __GFP_FS. However it should not be a real life >>>> problem now since AFAIK just xfs supports large folios for now and xfs >>>> uses iomap release_folio() method which actually ignores gfp flags. >>> Thanks a lot for the valuable comments. >>> >>> >>>> >>>> So it sounds safer to follow the gfp convention used by >>>> xas_split_alloc() in the below. The best way is to pass in the gfp >>>> flag from the reclaimer IMO, but it seems overkilling at the moment. >>> >>> It's possible that the gfp used by xas_split_alloc has __GFP_FS/IO set. >>> What about to use current_gfp_context(gfp_as_xas_split_alloc)? >>> >> >> Sounds reasonable to me. >> >> Also, the gfp used by xas_split_alloc() should also be modified to: >> current_gfp_context(mapping_gfp_mask(mapping) & GFP_RECLAIM_MASK)? >> Since they are in the same context. > > Good point, fine to me. Thanks both of your a lot for the comments. I will update the patch. Regards Yin, Fengwei