From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22255C001DB for ; Mon, 7 Aug 2023 19:47:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADC7C6B0075; Mon, 7 Aug 2023 15:47:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A8D416B0078; Mon, 7 Aug 2023 15:47:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92E806B007B; Mon, 7 Aug 2023 15:47:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 83E706B0075 for ; Mon, 7 Aug 2023 15:47:22 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5331040481 for ; Mon, 7 Aug 2023 19:47:22 +0000 (UTC) X-FDA: 81098342724.01.CDFE292 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by imf11.hostedemail.com (Postfix) with ESMTP id 40C0940002 for ; Mon, 7 Aug 2023 19:47:20 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=rasmusvillemoes.dk header.s=google header.b=ACLAwZ5Q; spf=pass (imf11.hostedemail.com: domain of linux@rasmusvillemoes.dk designates 209.85.218.46 as permitted sender) smtp.mailfrom=linux@rasmusvillemoes.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691437640; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9w+dD7oBoo3Er0Bu1CBuXGCJGgEYD7GFzLamH3ZCcr8=; b=WSnUtOgQ+7P5uqF9IsWwSO/84wkFubeifLofKXKlJ3Xu0KTWrkIG0JQCl16btVm4UFAQCK kDkaJvkRksdn2vrVFhiDgyhU7HxtwPBT1/sw5skSUfD9eaPoHganm/hNDB03uAinJwUOSW QDh+qJaBV04o3jLNndS2W2b7RULVi2U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691437640; a=rsa-sha256; cv=none; b=up0Uo8ibK2hKwF4IZyADFq5MXv45jfLDH4RD7Kv1njZ5jA5kylVetpxGW67i8kuesFrMEy ltxXqdat1GbF0ZUFn9ktse0X1o3tQIJ8976eeLqeSBhe+MaUWVk4jS0kcaatno+ztecoxe momuaF9I0+Ggtx7i9DYgtyLGpIZi/mc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=rasmusvillemoes.dk header.s=google header.b=ACLAwZ5Q; spf=pass (imf11.hostedemail.com: domain of linux@rasmusvillemoes.dk designates 209.85.218.46 as permitted sender) smtp.mailfrom=linux@rasmusvillemoes.dk; dmarc=none Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-99c136ee106so720992466b.1 for ; Mon, 07 Aug 2023 12:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; t=1691437638; x=1692042438; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9w+dD7oBoo3Er0Bu1CBuXGCJGgEYD7GFzLamH3ZCcr8=; b=ACLAwZ5Q1QYlglJh/cTJUTTmgmubDo2WtPMVNFJIP6B/9pz+vkZY90O9pNMAVM293k GF3F2dxluChNVCpjeSG4B9Pfrr58vGW25dKtDK2rwQReKirZt0ep5Y2ANyw63fKb6DPE c218tSgxg3HjoEfH1taAVjczofcd5uuOx8ZMo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691437638; x=1692042438; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9w+dD7oBoo3Er0Bu1CBuXGCJGgEYD7GFzLamH3ZCcr8=; b=ixALp7u1o+vqsNoRarinLkoUXXjGsZrUogss2BgJffje6ZISlhGTyZSrnzlrV3cUim tr5GpR+8oEzv8HBZZhaWSLEPSIVqs97nFMLYFzn4Wi2tvF4iRQfuTwsFLv5mEZCJkpNO rXrxeKc5pUlYOAmgKvuhYED/pSpMWP98odXejYk+yCU0ZQvdMpplO+KQK1AYW0Ew8+bl zJ9tSCr2boHavZolHUykTZcz8VpYRLRTERNRscTX66QDQFijKaNfqFm9lXOvtpP3sg6D i4y94GEbrxtmpkGIlsrHN/NF4wr2Z5XqvJZUe6qZJGX/bSYfiai2w+Vhfa4w4+DjJfJ9 OzPg== X-Gm-Message-State: AOJu0YyxEfuJChfl6UcFUxnJR9vrpwnEqO0G90eETtIz5nELebd+j+4w zhy4jTMS8slUyET2p2BD1jTXtg== X-Google-Smtp-Source: AGHT+IG+HQvpo71rtv3OpKs0t9vFLDYnAM2od1lnPHOPbGnZQjr2+hSnY38MLF+pnk5+t/FTuQVvig== X-Received: by 2002:a17:906:1db:b0:993:f2c2:7512 with SMTP id 27-20020a17090601db00b00993f2c27512mr10894304ejj.33.1691437638444; Mon, 07 Aug 2023 12:47:18 -0700 (PDT) Received: from [192.168.1.128] (77.33.185.10.dhcp.fibianet.dk. [77.33.185.10]) by smtp.gmail.com with ESMTPSA id x13-20020a1709064bcd00b00992b3ea1ee4sm5701924ejv.149.2023.08.07.12.47.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Aug 2023 12:47:17 -0700 (PDT) Message-ID: <5eca0ab5-84be-2d8f-e0b3-c9fdfa961826@rasmusvillemoes.dk> Date: Mon, 7 Aug 2023 21:47:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 1/3] lib/vsprintf: Sort headers alphabetically Content-Language: en-US, da To: Andy Shevchenko , Petr Mladek Cc: Marco Elver , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, Steven Rostedt , Sergey Senozhatsky , Alexander Potapenko , Dmitry Vyukov , Andrew Morton References: <20230805175027.50029-1-andriy.shevchenko@linux.intel.com> <20230805175027.50029-2-andriy.shevchenko@linux.intel.com> From: Rasmus Villemoes In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 40C0940002 X-Rspam-User: X-Stat-Signature: xxm73q5gx3gkg9uuttu44cntmz3y7zmo X-Rspamd-Server: rspam03 X-HE-Tag: 1691437640-677398 X-HE-Meta: U2FsdGVkX1/V0HL0RBg7k+MeJy81PhvJR778ztTbpiHz7KpHpMtbu5sq9IvcV4mJnKDN/6pK7ABuaGeBzZEQiCIuyzbgNosC2r9QjLgCG/h4rMa9ZcwtI0OIGwauS3JhKQNUsnyQcBu7TCX+G+FadIIE0OhJ8c+sVll7lXqD2Q7Lqp7R0nc6nvlVurZ5hr4MU+oNNTWD7Aph/FK2L8GCfEunzU88r3OPxEp+EwHkK4AHOYbPfE1iscNenPn3dBWtBk3SAaQhG6f3s7Pn5zwUDbMEXNIls0RpRU25ijQRdjha14e7cmKS+s4W6TzzKonOL5DrJdGgtb/+D0tv882ZJPe2Rr8mGsQLewwS3zXcfO2bvLA1AeUTEUDNDD4J4bk2+7GqLuQNJO22nWKR1qePlviM4gTfzLtJuVd9Xycbf6VeT8KDWpwZjARLhSzXhueLK1fRm9xviCw229qWJS5dvmFVnMzSJZeqZ4HgMPqlCW4Zts28zkkQ9yTado0zruM8K411Pfdi7mfD/6raGpZMbcMYt97gjVoRqWqxRvVOiyt312h7d9WOdcUFphSHcx6qmy9XYW9rqy5gVGGaDB8lv9VbODPPsOWng14MSiGKa/yR/4A+dIP9FHktt65Gbgwwkx2Y29dptpkKo/0RM9iqimpMpWEIZNrN2prrRByi5OLeItWiJDDHP02j4OVslzjnfrYU9V0dlkoVdzO8U601ySPnUlri3n45W62VvHUd2gFr3Kf7rMbmxmHGgjPCkuPmO3w0XbHUPBacymGjqTl8QUAkYMKXlN7AN/E1uCM3wleTyPKdjl1/wpZLWW17dzR+32oi9NPfZBqvalIy8y15NJEDs29t4ue82XElcrrNpvZf1ze+m9Lu+CtZ01M9JnytQP3zmkYi5l5tYKcAzwrr4+aGDcFMJxj2RUdNtfzrBEKXDlzDvBZIoMTNuiK9JbzrvcpMUeioJTPCG1zbHVt OchOeDGJ JhKbiVMctnAvZeop5u2wP0XWbO68kiByb8GhArbxJUMX0tUiu6aCNZaFDp2eiL2LrIYv+MGmUQQjnYLGmbGKYpg6K7YNOZyqKfMZkaR73Gyy8fsfzynjkbdcftPt5wdoO8PY+maVdxtm/LZ29qC/uj2N88GEWsLo6c4Z8TT+uD2ORoOFDKMEucY1rZHlBgR3FDIyU5smXGXrYpAXq4EVZ57rTh66ajeQSbHnNbbF9Hzl9S89eSVtFLE82yzBAC6NvIer3ANtHp/tXqpyBVNjJsqgfR2WF3RjzwJt8OWtLXWbrJSFPHTJTWGdqFQJVrbsQ2vv44K1fiNodWkA50ZTgC9kszibdu1AEK8iWxm/ZQLTy9Iw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.003224, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 07/08/2023 16.58, Andy Shevchenko wrote: > On Mon, Aug 07, 2023 at 04:31:37PM +0200, Petr Mladek wrote: >> On Sat 2023-08-05 20:50:25, Andy Shevchenko wrote: >>> Sorting headers alphabetically helps locating duplicates, and >>> make it easier to figure out where to insert new headers. >> >> I agree that includes become a mess after some time. But I am >> not persuaded that sorting them alphabetically in random source >> files help anything. >> >> Is this part of some grand plan for the entire kernel, please? >> Is this outcome from some particular discussion? >> Will this become a well know rule checked by checkpatch.pl? >> >> I am personally not going to reject patches because of wrongly >> sorted headers unless there is some real plan behind it. >> >> I agree that it might look better. An inverse Christmas' tree >> also looks better. But it does not mean that it makes the life >> easier. > > It does from my point of view as maintainability is increased. > >> The important things are still hidden in the details >> (every single line). >> >> From my POV, this patch would just create a mess in the git >> history and complicate backporting. >> >> I am sorry but I will not accept this patch unless there >> is a wide consensus that this makes sense. > > Your choice, of course, But I see in practice dup headers being > added, or some unrelated ones left untouched because header list > mess, and in those cases sorting can help (a bit) in my opinion. I agree with Andy on this one. There doesn't need to be some grand master plan to apply this to the entire kernel, but doing it to individual files bit by bit does increase the maintainability. And I really don't buy the backporting argument. Sure, backporting some patch across the release that does the sorting is harder - but then, backporting the sorting patch itself is entirely trivial (maybe not the textual part, but redoing the semantics of it is). _However_, backporting a patch from release z to release y, both of which being later than the release x that did the sorting, is going to be _easier_. It also reduces merge conflicts - that's also why lots of Makefiles are kept sorted. It's of course entirely unrelated to moving the declarations of the provided functions to a separate header file, but IMO both are worth doing. Rasmus