From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A392C25B78 for ; Tue, 4 Jun 2024 14:27:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 855616B0088; Tue, 4 Jun 2024 10:27:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 805996B008A; Tue, 4 Jun 2024 10:27:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CC9E6B008C; Tue, 4 Jun 2024 10:27:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 4DDDB6B0088 for ; Tue, 4 Jun 2024 10:27:03 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B679F1C182C for ; Tue, 4 Jun 2024 14:27:02 +0000 (UTC) X-FDA: 82193433084.16.59AF1B8 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf29.hostedemail.com (Postfix) with ESMTP id 6094312000E for ; Tue, 4 Jun 2024 14:26:59 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf29.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717511220; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XsJNYTk3MvYT1hMxVDCXlySERKcdS/IXOZcaXPSS7zo=; b=tTxBGNooDU48qIcAGoAGMDCdmU4Zwmk4n4WYuRCm7Hg58KFOqeyhPYdTT8Bz6HiYHzCoVt 6nJIYviGBofozW0o6QXMEt9pxwtvw9ttx3RC0nSkllHad6Fc7O8/3IsrAeV8kQ1HfHk9EE oE6BJI3sfNKvhdm3OQRCtiMZmmPV3fg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf29.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717511220; a=rsa-sha256; cv=none; b=eH8Q5dmmZbfMGw8Dkg+GEW4vPWPc9cjPd5xYruLn+uyqSKlnexusaaOCLhuBrjnNKTqzPE C0C5MEy/Rz8NGmGWUCV76/H95kE5vo0hF9Y24XoKR7nImRoxygQvzURi0qCSDjhh72zExd cBIRkhfRrnJEmV7OBA7cwSlJxACc4ks= Received: from mail.maildlp.com (unknown [172.19.163.48]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4Vtt9H6nxnzxRTv; Tue, 4 Jun 2024 22:22:59 +0800 (CST) Received: from dggpemm100001.china.huawei.com (unknown [7.185.36.93]) by mail.maildlp.com (Postfix) with ESMTPS id C6246180060; Tue, 4 Jun 2024 22:26:55 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm100001.china.huawei.com (7.185.36.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 4 Jun 2024 22:26:55 +0800 Message-ID: <5ec7f8b0-777c-44d2-874f-9332432129b4@huawei.com> Date: Tue, 4 Jun 2024 22:26:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] fs/proc/task_mmu: use folio API in pte_is_pinned() Content-Language: en-US To: David Hildenbrand , Andrew Morton CC: Helge Deller , Daniel Vetter , Matthew Wilcox , , Jonathan Corbet References: <20240604114822.2089819-1-wangkefeng.wang@huawei.com> <20240604114822.2089819-2-wangkefeng.wang@huawei.com> <70ce5e9a-ddd7-4e21-9ca9-cd0e72e1df60@redhat.com> From: Kefeng Wang In-Reply-To: <70ce5e9a-ddd7-4e21-9ca9-cd0e72e1df60@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm100001.china.huawei.com (7.185.36.93) X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6094312000E X-Stat-Signature: qhk1ch1c5shp8qkor5hmsgzo4aigscsy X-HE-Tag: 1717511219-21190 X-HE-Meta: U2FsdGVkX1/c9xBSJ4YYnevIJrUnDEFCks7egy5K9Mgwujvl3KBvLGg0JuMOmqmdZG+67UKsnFvoDUi6+ABMW2M4o2ikmzbWmMAM575WtCD46xD3ZdMfNaYaz4kxzJyr3QzPzfhPCONkeRKnHpH86Z0AUEYPLNn8BAhQTXYbyvgiu9bxWbpJy31DT3tuDedaXrQfmAcQL2V3vQq+ZDfusHJflMjcfOawWbgUWcDl5ZcsKQDfqTgahCN3ZlwBdBdpXR+hYU3qRU8vZoNbJsKge6w7s9h5QwPFenGjo+RQ1DO1TPFzZr/ZcKSkU8jVD2iUaW0khjprgbk51/ImetvWcZLavxa6siHOIM8tvozBkM06kiTeWA+2vsf2nWTHYaavWegfykPRyjzX5bK6WlWZWfXVzhXbgIeHaq2kRwVyf9/YaDS5zIJ7Yyiy+l3hhIff5Tgyw21897uFMeD39qex/OLerAXCCriDqY30GfJ4ZcX4GcyWxbTUG/cIGdyi71X3ZhKrN/JLeoqI0vvwoUImmRnuHdWGl4bS+jYRG4XMdb4xsPeGQBJzVk3hHX34m/MrBHbaX1x3ZrYc0hBbFiBngR/ws3HMyo2D04ibZu0MiTx5bfmRpEQxKhHhpsFkyi2vGy2gBT8oNVkmDJzJYjOIzPatay07gUpa9UkpPSJcanQ+m2E1IpxPcNV3nKdr8+4W7SEbeCoqZIcmOIrXgyok59NPnfwdjQneoqY04VTE37DQbfp708YD3yUylI11qm/5erIPxSuHLxXL92N1q1tadMgB0ZpGZ60W2WYXwOVBWc2YrmBBiYWFS0dDFRz5lEjNJekX8VQY7ZBHG+ElWmawxUWE9ZY6dWh0mlYZ5aMYmCbXwmr5OCIep6YrnNm4G6EJsaFZMaSyjD6Gk9iE5NZQX7ou9U4Ipzq8TmWuR5qZxxwsiNxgCwdGCbXlHUUm36N1DqHTa7SQrRJM5Y7dprA lx0znfUD LmcXIuIq+Dkuhfjp+/gBcMV689rsj6dl4E3btzVkmx96r2/EGT8tohbvHidSO7wsZ71D7/Xt9TJRVl6A9qASgdno9NqM7K/tgHQtRLCBtIEJnn04sN26JDfkdai8aRgLkIdUf74S5A4IuoHlv/i1exWLqsJZv8Ozd0KBnJCRnYnbSNAhPcbWLIDkRjTIu01beGCTtMun4l1Wdc8+0RTvWFmH5DGANwHlq8LGRrLTj+gM83aHBxx3dYQGTg0liooB9GhbtSTDntrf0rL8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/4 19:51, David Hildenbrand wrote: > On 04.06.24 13:48, Kefeng Wang wrote: >> Convert to use vm_normal_folio() and folio_maybe_dma_pinned() API, >> which helps to remove page_maybe_dma_pinned() in the subsequent change. >> >> Signed-off-by: Kefeng Wang >> --- >>   fs/proc/task_mmu.c | 8 ++++---- >>   1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c >> index f8d35f993fe5..5aceb3db7565 100644 >> --- a/fs/proc/task_mmu.c >> +++ b/fs/proc/task_mmu.c >> @@ -1088,7 +1088,7 @@ struct clear_refs_private { >>   static inline bool pte_is_pinned(struct vm_area_struct *vma, >> unsigned long addr, pte_t pte) >>   { >> -    struct page *page; >> +    struct folio *folio; >>       if (!pte_write(pte)) >>           return false; >> @@ -1096,10 +1096,10 @@ static inline bool pte_is_pinned(struct >> vm_area_struct *vma, unsigned long addr, >>           return false; >>       if (likely(!test_bit(MMF_HAS_PINNED, &vma->vm_mm->flags))) >>           return false; >> -    page = vm_normal_page(vma, addr, pte); >> -    if (!page) >> +    folio = vm_normal_folio(vma, addr, pte); >> +    if (!folio) >>           return false; >> -    return page_maybe_dma_pinned(page); >> +    return folio_maybe_dma_pinned(folio); >>   } >>   static inline void clear_soft_dirty(struct vm_area_struct *vma, > > Likely we should just get rid of the pte_is_pinned() check completely > now. We don't perform the same for PMDs, we don't sync against GUP-fast, Yes, no handle for clear PMDs. > and the original COW vs. GUP issue was resolved. Agree, but I'm not sure about removing it, from the commit 9348b73c2e1bf, "The whole "track page soft dirty" state doesn't work with pinned pages anyway, since the page might be dirtied by the pinning entity without ever being noticed in the page tables." The issue is between the pin mechanism and "track page soft dirty", if the page is pinned, the pining entiry(DMA?) could change the page but the pte dirty won't be set, so maybe we still need it, even add some similar thing for PMD? Correct me if I'm wrong, thanks.